<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>239699</bug_id>
          
          <creation_ts>2022-04-23 23:40:34 -0700</creation_ts>
          <short_desc>[Wasm] Remove confusing isFuncref and isExternref</short_desc>
          <delta_ts>2022-04-24 23:38:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebAssembly</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dmitry">dbezhetskov</reporter>
          <assigned_to name="Dmitry">dbezhetskov</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1863951</commentid>
    <comment_count>0</comment_count>
    <who name="Dmitry">dbezhetskov</who>
    <bug_when>2022-04-23 23:40:34 -0700</bug_when>
    <thetext>[Wasm] Remove confusing isFuncref and isExternref</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1863952</commentid>
    <comment_count>1</comment_count>
      <attachid>458229</attachid>
    <who name="Dmitry">dbezhetskov</who>
    <bug_when>2022-04-23 23:47:14 -0700</bug_when>
    <thetext>Created attachment 458229
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1864025</commentid>
    <comment_count>2</comment_count>
      <attachid>458229</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2022-04-24 23:27:45 -0700</bug_when>
    <thetext>Comment on attachment 458229
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1864029</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-04-24 23:37:18 -0700</bug_when>
    <thetext>Committed r293314 (249937@main): &lt;https://commits.webkit.org/249937@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458229.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1864030</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-04-24 23:38:14 -0700</bug_when>
    <thetext>&lt;rdar://problem/92251458&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>458229</attachid>
            <date>2022-04-23 23:47:14 -0700</date>
            <delta_ts>2022-04-24 23:37:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-239699-20220424134713.patch</filename>
            <type>text/plain</type>
            <size>3408</size>
            <attacher name="Dmitry">dbezhetskov</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0
YzFmM2VmOWY1Y2E4MTNmMjNiYTJhMDc1YWU0M2UxZTViZTRhYjYyLi44NmM4NDkxMjQyMTI2MDZj
MzRlNTI3YTAwY2YyMDhjMDZiZGJlN2Y0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyNCBAQAorMjAyMi0wNC0yMyAgRG1pdHJ5IEJlemhldHNrb3YgIDxkYmV6aGV0c2tvdkBp
Z2FsaWEuY29tPgorCisgICAgICAgIFtXYXNtXSBSZW1vdmUgY29uZnVzaW5nIGlzRnVuY3JlZiBh
bmQgaXNFeHRlcm5yZWYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIzOTY5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFRoZXJlIGFyZSB0d28gZnVuY3Rpb25zIHdpdGggdGhlIHNhbWUgbmFtZSBXYXNtOjpU
eXBlOjppc0Z1bmNyZWYgYW5kCisgICAgICAgIFdhc206OmlzRnVuY3JlZiBidXQgd2l0aCBkaWZm
ZXJlbnQgYmVoYXZpb3VyLCBhbmQgc28sCisgICAgICAgIHRoaXMgYnJpbmdzIGNvbmZ1c2lvbiBp
bnRvIHRoZSBjb2RlYmFzZS4KKyAgICAgICAgVGhlIGZpcnN0IGZ1bmN0aW9uIGNoZWNrcyB0aGF0
IC5raW5kID09IGZ1bmNyZWYgYW5kIHRoZSBzZWNvbmQgb25lIGNoZWNrcworICAgICAgICBmb3Ig
dGhlIHNhbWUgYnV0IHdpdGggcmVzcGVjdCB0byB0eXBlZCBmdW5jdGlvbiByZWZlcmVuY2VzIHBy
b3Bvc2FsLgorICAgICAgICBUaGUgc2Vjb25kIG9uZSBzaG91bGQgYmUgdXNlZCB3aGVuIHdlIHdh
bnQgdG8gY2hlY2sgdGhhdCB0eXBlIGlzIGZ1bmNyZWYsIAorICAgICAgICBzbyB0aGUgZmlyc3Qg
b25lIGlzIG5vdCBuZWVkZWQgYW5kIGFjdHVhbGx5IG5vdCB1c2VkLCBzbyB0aGlzIHBhdGNoIHJl
bW92ZXMgaXQuCisKKyAgICAgICAgVGhlIHNhbWUgc2l0dWF0aW9uIGlzIGZvciBpc0V4dGVybnJl
Zi4KKworICAgICAgICAqIHdhc20vZ2VuZXJhdGVXYXNtT3BzSGVhZGVyLnB5OgorICAgICAgICAo
dHlwZU1hY3JvaXplcik6CisgICAgICAgICh0eXBlTWFjcm9pemVyRmlsdGVyZWQpOgorCiAyMDIy
LTA0LTIyICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAg
VW5yZXZpZXdlZCwgbm9uLXVuaWZpZWQgYnVpbGQgZml4ZXMgYWZ0ZXIgcjI5MzIwMwpkaWZmIC0t
Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vZ2VuZXJhdGVXYXNtT3BzSGVhZGVyLnB5
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vZ2VuZXJhdGVXYXNtT3BzSGVhZGVyLnB5Cmlu
ZGV4IDg2YTVjYmZlN2MzMzMxYmExYzk1MzE3NGY2YzU4YWJlZWI4YzdhZDkuLjI4YTM1ZDc3OGEy
NjgwOWM4YzBmYTQwM2NiMWZjMWQ3YjU2ODNmZTggMTAwNzU1Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny
aXB0Q29yZS93YXNtL2dlbmVyYXRlV2FzbU9wc0hlYWRlci5weQorKysgYi9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvd2FzbS9nZW5lcmF0ZVdhc21PcHNIZWFkZXIucHkKQEAgLTU2LDEwICs1NiwyMCBA
QCBkZWYgdHlwZU1hY3JvaXplcigpOgogICAgICAgICB5aWVsZCBjcHBNYWNybyh0eSwgd2FzbS50
eXBlc1t0eV1bInZhbHVlIl0sIHdhc20udHlwZXNbdHldWyJiM3R5cGUiXSwgaW5jLCB0eSkKICAg
ICAgICAgaW5jICs9IDEKIAorCitkZWYgdHlwZU1hY3JvaXplckZpbHRlcmVkKGZpbHRlcik6Cisg
ICAgZm9yIHQgaW4gdHlwZU1hY3JvaXplcigpOgorICAgICAgICBpZiBub3QgZmlsdGVyKHQpOgor
ICAgICAgICAgICAgeWllbGQgdAorCiB0eXBlX2RlZmluaXRpb25zID0gWyIjZGVmaW5lIEZPUl9F
QUNIX1dBU01fVFlQRShtYWNybykiXQogdHlwZV9kZWZpbml0aW9ucy5leHRlbmQoW3QgZm9yIHQg
aW4gdHlwZU1hY3JvaXplcigpXSkKIHR5cGVfZGVmaW5pdGlvbnMgPSAiIi5qb2luKHR5cGVfZGVm
aW5pdGlvbnMpCiAKK3R5cGVfZGVmaW5pdGlvbnNfZXhjZXB0X2Z1bmNyZWZfZXh0ZXJucmVmID0g
WyIjZGVmaW5lIEZPUl9FQUNIX1dBU01fVFlQRV9FWENFUFRfRlVOQ1JFRl9BTkRfRVhURVJOUkVG
KG1hY3JvKSJdCit0eXBlX2RlZmluaXRpb25zX2V4Y2VwdF9mdW5jcmVmX2V4dGVybnJlZi5leHRl
bmQoW3QgZm9yIHQgaW4gdHlwZU1hY3JvaXplckZpbHRlcmVkKGxhbWJkYSB4OiB4ID09ICJmdW5j
cmVmIiBvciB4ID09ICJleHRlcm5yZWYiKV0pCit0eXBlX2RlZmluaXRpb25zX2V4Y2VwdF9mdW5j
cmVmX2V4dGVybnJlZiA9ICIiLmpvaW4odHlwZV9kZWZpbml0aW9uc19leGNlcHRfZnVuY3JlZl9l
eHRlcm5yZWYpCisKIAogZGVmIG9wY29kZU1hY3JvaXplcihmaWx0ZXIsIG9wY29kZUZpZWxkPSJ2
YWx1ZSIsIG1vZGlmaWVyPU5vbmUpOgogICAgIGluYyA9IDAKQEAgLTIwNiw3ICsyMTYsOCBAQCBz
dGF0aWMgY29uc3RleHByIHVuc2lnbmVkIGV4cGVjdGVkVmVyc2lvbk51bWJlciA9ICIiIiArIHdh
c20uZXhwZWN0ZWRWZXJzaW9uTnVtYgogCiBzdGF0aWMgY29uc3RleHByIHVuc2lnbmVkIG51bVR5
cGVzID0gIiIiICsgc3RyKGxlbih0eXBlcykpICsgIiIiOwogCi0iIiIgKyB0eXBlX2RlZmluaXRp
b25zICsgIiIiCisiIiIgKyB0eXBlX2RlZmluaXRpb25zICsgIlxuIiArICIiIgorIiIiICsgdHlw
ZV9kZWZpbml0aW9uc19leGNlcHRfZnVuY3JlZl9leHRlcm5yZWYgKyAiIiIKICNkZWZpbmUgQ1JF
QVRFX0VOVU1fVkFMVUUobmFtZSwgaWQsIC4uLikgbmFtZSA9IGlkLAogZW51bSBjbGFzcyBUeXBl
S2luZCA6IGludDhfdCB7CiAgICAgRk9SX0VBQ0hfV0FTTV9UWVBFKENSRUFURV9FTlVNX1ZBTFVF
KQpAQCAtMjQwLDggKzI1MSwxMCBAQCBzdHJ1Y3QgVHlwZSB7CiAgICAgICAgIHJldHVybiBzdGF0
aWNfY2FzdDxib29sPihudWxsYWJsZSk7CiAgICAgfQogCisgICAgLy8gVXNlIFdhc206OmlzRnVu
Y3JlZiBhbmQgV2FzbTo6aXNFeHRlcm5yZWYgaW5zdGVhZCBiZWNhdXNlIHRoZXkgY2hlY2sgYWdh
aW50cyBhbGwga2luZCBvZiByZXByZXNlbnRhdGlvbnMgb2YgZnVuY3Rpb24gcmVmZXJlbmVzIGFu
ZCBleHRlcm5hbCByZWZlcmVuY2VzLgorCiAgICAgI2RlZmluZSBDUkVBVEVfUFJFRElDQVRFKG5h
bWUsIC4uLikgYm9vbCBpcyAjIyBuYW1lKCkgY29uc3QgeyByZXR1cm4ga2luZCA9PSBUeXBlS2lu
ZDo6bmFtZTsgfQotICAgIEZPUl9FQUNIX1dBU01fVFlQRShDUkVBVEVfUFJFRElDQVRFKQorICAg
IEZPUl9FQUNIX1dBU01fVFlQRV9FWENFUFRfRlVOQ1JFRl9BTkRfRVhURVJOUkVGKENSRUFURV9Q
UkVESUNBVEUpCiAgICAgI3VuZGVmIENSRUFURV9QUkVESUNBVEUKIH07CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>