239681 2022-04-22 18:09:46 -0700 [Xcode] Compute PGO profdata paths instead of searching for them at build time 2022-05-31 14:19:30 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 239795 241065 1 emw emw commit-queue webkit-bug-importer oldest_to_newest 1863831 0 emw 2022-04-22 18:09:46 -0700 Currently, the "Copy Profiling Data" script phases find profdata to use by checking BUILT_PRODUCTS_DIR, then the SDK, and finally falling back to the default profdata stub in SRCROOT. This can cause problems if stale profdata is present in BUILT_PRODUCTS_DIR and a production build is updating SDK content. It also confuses XCBuild's dependency validation on open-source builds, because the build system expects the SDK and WebKitAdditions paths to always exist. Instead of this dynamic approach, we can compute the expected path in xcconfigs, based on the active build settings. 1863833 1 emw 2022-04-22 18:23:19 -0700 Pull request: https://github.com/WebKit/WebKit/pull/367 1863835 2 webkit-bug-importer 2022-04-22 18:30:04 -0700 <rdar://problem/92200351> 1863918 3 emw 2022-04-23 13:34:56 -0700 Pull request: https://github.com/WebKit/WebKit/pull/369 1864565 4 ews-feeder 2022-04-26 12:21:12 -0700 Committed r293442 (249997@main): <https://commits.webkit.org/249997@main> Reviewed commits have been landed. Closing PR #367 and removing active labels. 1864673 5 commit-queue 2022-04-26 16:37:23 -0700 Re-opened since this is blocked by bug 239795 1871889 6 emw 2022-05-25 16:26:00 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1031 1872428 7 ews-feeder 2022-05-27 14:11:36 -0700 Committed r294952 (251060@main): <https://commits.webkit.org/251060@main> Reviewed commits have been landed. Closing PR #1031 and removing active labels. 1872865 8 ap 2022-05-30 19:13:47 -0700 This patch was reverted in https://commits.webkit.org/251100@main 1872879 9 emw 2022-05-30 20:09:05 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1171 1873134 10 ews-feeder 2022-05-31 14:19:29 -0700 Committed r295065 (251160@main): <https://commits.webkit.org/251160@main> Reviewed commits have been landed. Closing PR #1171 and removing active labels.