239679 2022-04-22 17:43:00 -0700 Fix build error caused by LTO + Unified Sources 2022-04-23 14:49:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 justin_michaud justin_michaud achristensen dino ews-watchlist kondapallykalyan mark.lam webkit-bug-importer oldest_to_newest 1863824 0 justin_michaud 2022-04-22 17:43:00 -0700 Fix build error caused by LTO + Unified Sources 1863825 1 458189 justin_michaud 2022-04-22 17:44:31 -0700 Created attachment 458189 Patch 1863827 2 458189 mark.lam 2022-04-22 17:49:50 -0700 Comment on attachment 458189 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458189&action=review rs=me ... too > Source/WebCore/ChangeLog:3 > + Fix build error caused by LTO + Unified Sources nit: We'll typically say something like "Speculative fix for build error caused by LTO + Unified Sources" so that reviewers will know that the fix is of a speculative nature. 1863912 3 justin_michaud 2022-04-23 12:23:16 -0700 I confirmed that this fixes the build error. I'll give Mac-debug another shot to run and then merge. 1863921 4 justin_michaud 2022-04-23 14:39:38 -0700 Mac-debug timing out appears to be a known issue, landing. 1863927 5 ews-feeder 2022-04-23 14:48:07 -0700 Committed r293295 (249920@main): <https://commits.webkit.org/249920@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458189. 1863929 6 webkit-bug-importer 2022-04-23 14:49:14 -0700 <rdar://problem/92221251> 458189 2022-04-22 17:44:31 -0700 2022-04-23 14:48:09 -0700 Patch bug-239679-20220422174430.patch text/plain 2026 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY2Mjg5Y2RlYWU3YmM0 YjJmZDYyYjUxZjZhMjVhYzkxZWMzYjI3Ny4uOTg3OGE5MjRhZmRjZDE4ZjlmYzNiODMwMDExNDA1 MzZiMjVlNjVmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTA0LTIyICBKdXN0 aW4gTWljaGF1ZCAgPGp1c3Rpbl9taWNoYXVkQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYnVp bGQgZXJyb3IgY2F1c2VkIGJ5IExUTyArIFVuaWZpZWQgU291cmNlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5Njc5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBob3BlZnVsbHkgZml4ZXMgdGhl IGZvbGxvd2luZyBidWlsZCBlcnJvcjoKKyAgICAgICAgVW5kZWZpbmVkIHN5bWJvbHMgZm9yIGFy Y2hpdGVjdHVyZSB4ODZfNjQ6CisgICAgICAgICAgIkpTQzo6R2VuZXJpY1R5cGVkQXJyYXlWaWV3 PEpTQzo6VWludDhDbGFtcGVkQWRhcHRvcj46OnRyeUNyZWF0ZVVuaW5pdGlhbGl6ZWQodW5zaWdu ZWQgbG9uZykiLCByZWZlcmVuY2VkIGZyb206CisgICAgICAgICAgICAgIFdlYkNvcmU6OkZFR2F1 c3NpYW5CbHVyU29mdHdhcmVBcHBsaWVyOjphcHBseShXZWJDb3JlOjpGaWx0ZXIgY29uc3QmLCBX VEY6OlZlY3RvcjxXVEY6OlJlZjxXZWJDb3JlOjpGaWx0ZXJJbWFnZSwgV1RGOjpSYXdQdHJUcmFp dHM8V2ViQ29yZTo6RmlsdGVySW1hZ2U+ID4sIDB1bCwgV1RGOjpDcmFzaE9uT3ZlcmZsb3csIDE2 dWwsIFdURjo6RmFzdE1hbGxvYz4gY29uc3QmLCBXZWJDb3JlOjpGaWx0ZXJJbWFnZSYpIGNvbnN0 IGluIGx0by5vCisgICAgICAgIGxkOiBzeW1ib2wocykgbm90IGZvdW5kIGZvciBhcmNoaXRlY3R1 cmUgeDg2XzY0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL3NvZnR3YXJl L0ZFR2F1c3NpYW5CbHVyU29mdHdhcmVBcHBsaWVyLmNwcDoKKwogMjAyMi0wNC0yMiAgQWxhbiBC dWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25dIEFk ZCBibGFuayBMYXlvdXRJbnRlZ3JhdGlvbjo6RmxleExheW91dApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9zb2Z0d2FyZS9GRUdhdXNzaWFuQmx1 clNvZnR3YXJlQXBwbGllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9m aWx0ZXJzL3NvZnR3YXJlL0ZFR2F1c3NpYW5CbHVyU29mdHdhcmVBcHBsaWVyLmNwcAppbmRleCBk ZWUwNDgwMWEzZmYyYzFlNmFmNGM0ODEwMGU5N2RlMmRmYTVmY2MxLi5hODZhOWZkMGFlYTUyZTZk MDg2YWQxMDNhNjZmMjBiYmM1MmJkNWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9maWx0ZXJzL3NvZnR3YXJlL0ZFR2F1c3NpYW5CbHVyU29mdHdhcmVBcHBs aWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL3Nv ZnR3YXJlL0ZFR2F1c3NpYW5CbHVyU29mdHdhcmVBcHBsaWVyLmNwcApAQCAtMzMsMTIgKzMzLDEy IEBACiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiSW1hZ2VCdWZmZXIu aCIKICNpbmNsdWRlICJQaXhlbEJ1ZmZlci5oIgorI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL1R5 cGVkQXJyYXlJbmxpbmVzLmg+CiAjaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KIAogI2lmIFVT RShBQ0NFTEVSQVRFKQogI2luY2x1ZGUgPEFjY2VsZXJhdGUvQWNjZWxlcmF0ZS5oPgogI2Vsc2UK LSNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9UeXBlZEFycmF5SW5saW5lcy5oPgogI2luY2x1ZGUg PHd0Zi9QYXJhbGxlbEpvYnMuaD4KICNlbmRpZgogCg==