239676 2022-04-22 16:44:07 -0700 Web Inspector: response overrides with an error status code should indicate that somewhere 2022-04-25 12:56:13 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi ews-watchlist hi inspector-bugzilla-changes pangle webkit-bug-importer oldest_to_newest 1863814 0 hi 2022-04-22 16:44:07 -0700 it's odd that the local override shows as regular "text" when resources loaded from it have error (i.e. red) "text" 1863815 1 458187 hi 2022-04-22 16:47:40 -0700 Created attachment 458187 Patch 1863823 2 458187 pangle 2022-04-22 17:03:46 -0700 Comment on attachment 458187 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458187&action=review r=me > Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js:111 > // Do nothing. Do not allow ResourceTreeElement / SourceCodeTreeElement to modify our status element. I think the "Do nothing" part of this is contradicted now 😅. (As an aside, I had to read this comment a few times before I realized it was trying to explain why we don't let `super` be called.) 1864147 3 458284 hi 2022-04-25 11:08:08 -0700 Created attachment 458284 Patch 1864193 4 ews-feeder 2022-04-25 12:55:21 -0700 Committed r293338 (249959@main): <https://commits.webkit.org/249959@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458284. 1864195 5 webkit-bug-importer 2022-04-25 12:56:13 -0700 <rdar://problem/92288790> 458187 2022-04-22 16:47:40 -0700 2022-04-25 11:08:08 -0700 Patch bug-239676-20220422174739.patch text/plain 1978 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdhNjUwYmE5NWQwZTRjMWNlZGUzOWEzYTAwOWJh NTQ4YzkzNmQ2NjQuLjQ0MGM5YjRiMTFlYWU0YjNkMzc2MGRmZGIwNTc2OGJiMzk2ZTM1MDAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTA0LTIyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBy ZXNwb25zZSBvdmVycmlkZXMgd2l0aCBhbiBlcnJvciBzdGF0dXMgY29kZSBzaG91bGQgaW5kaWNh dGUgdGhhdCBzb21ld2hlcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzOTY3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Mb2NhbFJlc291cmNlT3ZlcnJpZGVUcmVl RWxlbWVudC5qczoKKyAgICAgICAgKFdJLkxvY2FsUmVzb3VyY2VPdmVycmlkZVRyZWVFbGVtZW50 LnByb3RvdHlwZS51cGRhdGVTdGF0dXMpOgorICAgICAgICBBbHNvIGhhdmUgdGhlIGBXSS5Mb2Nh bFJlc291cmNlT3ZlcnJpZGVUcmVlRWxlbWVudGAgYWRkL3JlbW92ZSB0aGUgYCJlcnJvciJgIENT UyBjbGFzcworICAgICAgICBkZXBlbmluZyBvbiB0aGUgc3RhdGUgb2YgdGhlIHJlbGF0ZWQgYFdJ LkxvY2FsUmVzb3VyY2VgICh3aGljaCBpcyB3aGF0J3MgZG9uZSBmb3IgInJlZ3VsYXIiCisgICAg ICAgIGBXSS5SZXNvdXJjZVRyZWVFbGVtZW50YCBhbmQgYFdJLlJlc291cmNlYCkuCisKIDIwMjIt MDQtMjEgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IEVsZW1lbnRzOiBMYXlvdXQ6IGhvdmVyaW5nIG92ZXIgYSBub2RlIHNob3VsZCBo aWdobGlnaHQgaXQgaW4gdGhlIHBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvY2FsUmVzb3VyY2VPdmVycmlkZVRyZWVFbGVtZW50Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9jYWxSZXNvdXJj ZU92ZXJyaWRlVHJlZUVsZW1lbnQuanMKaW5kZXggZDg0ZDRjZjVhYmQ2NzhkMWViOTY5YzQxYjk3 YmU1M2FjODA4MjRhZi4uZmMwNGM4Nzk5ZTViYjBkYjdjN2I0NmM2ZjJiNzEzNjZkMjYzMjNmMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9j YWxSZXNvdXJjZU92ZXJyaWRlVHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9jYWxSZXNvdXJjZU92ZXJyaWRlVHJlZUVsZW1lbnQu anMKQEAgLTEwOSw2ICsxMDksMTEgQEAgV0kuTG9jYWxSZXNvdXJjZU92ZXJyaWRlVHJlZUVsZW1l bnQgPSBjbGFzcyBMb2NhbFJlc291cmNlT3ZlcnJpZGVUcmVlRWxlbWVudCBleHQKICAgICB1cGRh dGVTdGF0dXMoKQogICAgIHsKICAgICAgICAgLy8gRG8gbm90aGluZy4gRG8gbm90IGFsbG93IFJl c291cmNlVHJlZUVsZW1lbnQgLyBTb3VyY2VDb2RlVHJlZUVsZW1lbnQgdG8gbW9kaWZ5IG91ciBz dGF0dXMgZWxlbWVudC4KKworICAgICAgICBpZiAodGhpcy5yZXNvdXJjZS5oYWRMb2FkaW5nRXJy b3IoKSkKKyAgICAgICAgICAgIHRoaXMuYWRkQ2xhc3NOYW1lKFdJLlJlc291cmNlVHJlZUVsZW1l bnQuRmFpbGVkU3R5bGVDbGFzc05hbWUpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB0aGlz LnJlbW92ZUNsYXNzTmFtZShXSS5SZXNvdXJjZVRyZWVFbGVtZW50LkZhaWxlZFN0eWxlQ2xhc3NO YW1lKTsKICAgICB9CiAKICAgICAvLyBQb3BvdmVyIGRlbGVnYXRlCg== 458284 2022-04-25 11:08:08 -0700 2022-04-25 12:55:22 -0700 Patch 239676.diff text/plain 2006 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdhNjUwYmE5NWQwZS4uYzkzMmUwNTMxNjhiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMi0wNC0yMiAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog cmVzcG9uc2Ugb3ZlcnJpZGVzIHdpdGggYW4gZXJyb3Igc3RhdHVzIGNvZGUgc2hvdWxkIGluZGlj YXRlIHRoYXQgc29tZXdoZXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMzk2NzYKKworICAgICAgICBSZXZpZXdlZCBieSBQYXRyaWNrIEFuZ2xlLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Mb2NhbFJlc291cmNlT3ZlcnJpZGVUcmVl RWxlbWVudC5qczoKKyAgICAgICAgKFdJLkxvY2FsUmVzb3VyY2VPdmVycmlkZVRyZWVFbGVtZW50 LnByb3RvdHlwZS51cGRhdGVTdGF0dXMpOgorICAgICAgICBBbHNvIGhhdmUgdGhlIGBXSS5Mb2Nh bFJlc291cmNlT3ZlcnJpZGVUcmVlRWxlbWVudGAgYWRkL3JlbW92ZSB0aGUgYCJlcnJvciJgIENT UyBjbGFzcworICAgICAgICBkZXBlbmluZyBvbiB0aGUgc3RhdGUgb2YgdGhlIHJlbGF0ZWQgYFdJ LkxvY2FsUmVzb3VyY2VgICh3aGljaCBpcyB3aGF0J3MgZG9uZSBmb3IgInJlZ3VsYXIiCisgICAg ICAgIGBXSS5SZXNvdXJjZVRyZWVFbGVtZW50YCBhbmQgYFdJLlJlc291cmNlYCkuCisKIDIwMjIt MDQtMjEgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IEVsZW1lbnRzOiBMYXlvdXQ6IGhvdmVyaW5nIG92ZXIgYSBub2RlIHNob3VsZCBo aWdobGlnaHQgaXQgaW4gdGhlIHBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvY2FsUmVzb3VyY2VPdmVycmlkZVRyZWVFbGVtZW50Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9jYWxSZXNvdXJj ZU92ZXJyaWRlVHJlZUVsZW1lbnQuanMKaW5kZXggZDg0ZDRjZjVhYmQ2Li5kMzQ4MjM2ZTk1OTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xv Y2FsUmVzb3VyY2VPdmVycmlkZVRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvY2FsUmVzb3VyY2VPdmVycmlkZVRyZWVFbGVtZW50 LmpzCkBAIC0xMDgsNyArMTA4LDEyIEBAIFdJLkxvY2FsUmVzb3VyY2VPdmVycmlkZVRyZWVFbGVt ZW50ID0gY2xhc3MgTG9jYWxSZXNvdXJjZU92ZXJyaWRlVHJlZUVsZW1lbnQgZXh0CiAKICAgICB1 cGRhdGVTdGF0dXMoKQogICAgIHsKLSAgICAgICAgLy8gRG8gbm90aGluZy4gRG8gbm90IGFsbG93 IFJlc291cmNlVHJlZUVsZW1lbnQgLyBTb3VyY2VDb2RlVHJlZUVsZW1lbnQgdG8gbW9kaWZ5IG91 ciBzdGF0dXMgZWxlbWVudC4KKyAgICAgICAgLy8gRG9uJ3QgY2FsbCBgc3VwZXJgIGFzIHdlIGRv bid0IHdhbnQgYFdJLlJlc291cmNlVHJlZUVsZW1lbnRgIC8gYFdJLlNvdXJjZUNvZGVUcmVlRWxl bWVudGAgLyBldGMuIHRvIG1vZGlmeSBvdXIgc3RhdHVzIGVsZW1lbnQuCisKKyAgICAgICAgaWYg KHRoaXMucmVzb3VyY2UuaGFkTG9hZGluZ0Vycm9yKCkpCisgICAgICAgICAgICB0aGlzLmFkZENs YXNzTmFtZShXSS5SZXNvdXJjZVRyZWVFbGVtZW50LkZhaWxlZFN0eWxlQ2xhc3NOYW1lKTsKKyAg ICAgICAgZWxzZQorICAgICAgICAgICAgdGhpcy5yZW1vdmVDbGFzc05hbWUoV0kuUmVzb3VyY2VU cmVlRWxlbWVudC5GYWlsZWRTdHlsZUNsYXNzTmFtZSk7CiAgICAgfQogCiAgICAgLy8gUG9wb3Zl ciBkZWxlZ2F0ZQo=