239648 2022-04-22 03:09:02 -0700 [Refactoring] Reduce number of const and reinterpret casts 2022-04-22 16:23:14 -0700 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbezhetskov dbezhetskov ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1863597 0 dbezhetskov 2022-04-22 03:09:02 -0700 [Refactoring] Reduce number of const and reinterpret casts 1863600 1 458129 dbezhetskov 2022-04-22 03:12:37 -0700 Created attachment 458129 Patch 1863805 2 ews-feeder 2022-04-22 16:22:49 -0700 Committed r293265 (249906@main): <https://commits.webkit.org/249906@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458129. 1863806 3 webkit-bug-importer 2022-04-22 16:23:14 -0700 <rdar://problem/92195529> 458129 2022-04-22 03:12:37 -0700 2022-04-22 16:22:51 -0700 Patch bug-239648-20220422171236.patch text/plain 4623 dbezhetskov U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MWFhNjZiMTE5Zjg3OWEyMGY4OWRhOTljNTFjN2U0ZWQ5ZDhjZDIyLi5iNTgxYjE3MzhhNGJmYjY3 MWQ4MjAwNjFmMjk4MGE0YTlkNmI5ZDRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAyMi0wNC0yMiAgRG1pdHJ5IEJlemhldHNrb3YgIDxkYmV6aGV0c2tvdkBp Z2FsaWEuY29tPgorCisgICAgICAgIFtSZWZhY3RvcmluZ10gUmVkdWNlIG51bWJlciBvZiBjb25z dCBhbmQgcmVpbnRlcnByZXQgY2FzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzOTY0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorICAgICAgICAKKyAgICAgICAgVGhlIHN0YXRlbWVudAorICAgICAgICAicmVpbnRlcnBy ZXRfY2FzdDxUeXBlRGVmaW5pdGlvbio+KGNvbnN0X2Nhc3Q8Y2hhcio+KGZ1bmN0aW9uVHlwZS5t X3BheWxvYWQpCisgICAgICAgIC0gc2l6ZW9mKFR5cGVEZWZpbml0aW9uKSkiCisgICAgICAgIGlz IGRhbmdlcm91cyBhbmQgaXQgcHJvZHVjZXMgd2FybmluZyBvbiBzb21lIHBsYXRmcm9tcy4KKyAg ICAgICAgVGhlcmUgaXMgd2F5IHRvIGF2b2lkIGl0IGFuZCB0aGlzIHBhdGNoIGlzIGRvaW50IHRo YXQuCisKKyAgICAgICAgKiB3YXNtL1dhc21TbG93UGF0aHMuY3BwOgorICAgICAgICAoSlNDOjpM TEludDo6ZG9XYXNtQ2FsbEluZGlyZWN0KToKKyAgICAgICAgKEpTQzo6TExJbnQ6OmRvV2FzbUNh bGxSZWYpOgorICAgICAgICAqIHdhc20vV2FzbVR5cGVEZWZpbml0aW9uLmg6CisgICAgICAgIChK U0M6Oldhc206OkZ1bmN0aW9uU2lnbmF0dXJlOjpvcGVyYXRvcj09IGNvbnN0KToKKyAgICAgICAg KiB3YXNtL1dhc21UeXBlRGVmaW5pdGlvbklubGluZXMuaDoKKwogMjAyMi0wNC0yMSAgWXVzdWtl IFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIFByb3BlcnR5VGFi bGUgc2hvdWxkIGhhdmUgY29tcGFjdCBtb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd2FzbS9XYXNtU2xvd1BhdGhzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNt L1dhc21TbG93UGF0aHMuY3BwCmluZGV4IGNiNjhiNDljZjcyNDk4YWI0MjFkNDdmMzc3ZGU4ODM2 MTU0NjhjYzkuLjFjZTk4ZDBiMGE3MjM5YTI2NzE5NGUwODU4YWFkMDEzYTc0MDM1ZDMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21TbG93UGF0aHMuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21TbG93UGF0aHMuY3BwCkBAIC01MDAsNyAr NTAwLDcgQEAgaW5saW5lIFNsb3dQYXRoUmV0dXJuVHlwZSBkb1dhc21DYWxsSW5kaXJlY3QoQ2Fs bEZyYW1lKiBjYWxsRnJhbWUsIFdhc206Okluc3RhbmMKICAgICAgICAgV0FTTV9USFJPVyhXYXNt OjpFeGNlcHRpb25UeXBlOjpOdWxsVGFibGVFbnRyeSk7CiAKICAgICBjb25zdCBhdXRvJiBjYWxs U2lnbmF0dXJlID0gQ0FMTEVFKCktPnNpZ25hdHVyZSh0eXBlSW5kZXgpOwotICAgIGlmIChmdW5j dGlvbi50eXBlSW5kZXggIT0gV2FzbTo6VHlwZUluZm9ybWF0aW9uOjpnZXQoY2FsbFNpZ25hdHVy ZSkpCisgICAgaWYgKGNhbGxTaWduYXR1cmUgIT0gV2FzbTo6VHlwZUluZm9ybWF0aW9uOjpnZXRG dW5jdGlvblNpZ25hdHVyZShmdW5jdGlvbi50eXBlSW5kZXgpKQogICAgICAgICBXQVNNX1RIUk9X KFdhc206OkV4Y2VwdGlvblR5cGU6OkJhZFNpZ25hdHVyZSk7CiAKICAgICBpZiAodGFyZ2V0SW5z dGFuY2UgIT0gaW5zdGFuY2UpCkBAIC01NDEsNyArNTQxLDcgQEAgaW5saW5lIFNsb3dQYXRoUmV0 dXJuVHlwZSBkb1dhc21DYWxsUmVmKENhbGxGcmFtZSogY2FsbEZyYW1lLCBXYXNtOjpJbnN0YW5j ZSogY2EKICAgICBpZiAoY2FsbGVlSW5zdGFuY2UgIT0gY2FsbGVySW5zdGFuY2UpCiAgICAgICAg IGNhbGxlZUluc3RhbmNlLT5zZXRDYWNoZWRTdGFja0xpbWl0KGNhbGxlckluc3RhbmNlLT5jYWNo ZWRTdGFja0xpbWl0KCkpOwogCi0gICAgQVNTRVJUKGZ1bmN0aW9uLnR5cGVJbmRleCA9PSBXYXNt OjpUeXBlSW5mb3JtYXRpb246OmdldChDQUxMRUUoKS0+c2lnbmF0dXJlKHR5cGVJbmRleCkpKTsK KyAgICBBU1NFUlQoV2FzbTo6VHlwZUluZm9ybWF0aW9uOjpnZXRGdW5jdGlvblNpZ25hdHVyZShm dW5jdGlvbi50eXBlSW5kZXgpID09IENBTExFRSgpLT5zaWduYXR1cmUodHlwZUluZGV4KSk7CiAg ICAgVU5VU0VEX1BBUkFNKHR5cGVJbmRleCk7CiAgICAgV0FTTV9DQUxMX1JFVFVSTihjYWxsZWVJ bnN0YW5jZSwgZnVuY3Rpb24uZW50cnlwb2ludExvYWRMb2NhdGlvbi0+ZXhlY3V0YWJsZUFkZHJl c3MoKSwgV2FzbUVudHJ5UHRyVGFnKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93YXNtL1dhc21UeXBlRGVmaW5pdGlvbi5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dh c20vV2FzbVR5cGVEZWZpbml0aW9uLmgKaW5kZXggMmFmMzljODYxYjMzYWFjNjc1NTY1N2RkMGNm MThmNzNjYTZiMTUxMC4uOTU5ZDg1Mzg1ZjNjMzE3ZTU5OWNlNjg0Zjk2MWU0YWNmMDU1NWVjOSAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbVR5cGVEZWZpbml0aW9u LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbVR5cGVEZWZpbml0aW9uLmgK QEAgLTYwLDYgKzYwLDE0IEBAIHB1YmxpYzoKICAgICBib29sIHJldHVybnNWb2lkKCkgY29uc3Qg eyByZXR1cm4gIXJldHVybkNvdW50KCk7IH0KICAgICBUeXBlIGFyZ3VtZW50VHlwZShGdW5jdGlv bkFyZ0NvdW50IGkpIGNvbnN0IHsgcmV0dXJuIGNvbnN0X2Nhc3Q8RnVuY3Rpb25TaWduYXR1cmUq Pih0aGlzKS0+Z2V0QXJndW1lbnRUeXBlKGkpOyB9CiAKKyAgICBib29sIG9wZXJhdG9yPT0oY29u c3QgRnVuY3Rpb25TaWduYXR1cmUmIG90aGVyKSBjb25zdAorICAgIHsKKyAgICAgICAgLy8gRnVu Y3Rpb24gc2lnbmF0dXJlcyBhcmUgdW5pcXVlIGJlY2F1c2UgaXQgaXMganVzdCBhbiB2aWV3IGNs YXNzIG92ZXIgVHlwZURlZmluaXRpb24gYW5kCisgICAgICAgIC8vIHNvLCB3ZSBjYW4gY29tcGFy ZSB0d28gc2lnbmF0dXJlcyB3aXRoIGp1c3QgcGF5bG9hZCBwb2ludGVycyBjb21wYXJpc2lvbi4K KyAgICAgICAgLy8gT3RoZXIgY2hlY2tzIHByb2JhYmx5IGFyZW4ndCBuZWNlc3NhcnkgYnV0IGl0 J3MgZ29vZCB0byBiZSBwYXJhbm9pZC4KKyAgICAgICAgcmV0dXJuIG1fcGF5bG9hZCA9PSBvdGhl ci5tX3BheWxvYWQgJiYgbV9hcmdDb3VudCA9PSBvdGhlci5tX2FyZ0NvdW50ICYmIG1fcmV0Q291 bnQgPT0gb3RoZXIubV9yZXRDb3VudDsKKyAgICB9CisKICAgICBXVEY6OlN0cmluZyB0b1N0cmlu ZygpIGNvbnN0OwogICAgIHZvaWQgZHVtcChXVEY6OlByaW50U3RyZWFtJiBvdXQpIGNvbnN0Owog CkBAIC0yMTcsNyArMjI1LDYgQEAgcHVibGljOgogICAgIHN0YXRpYyBjb25zdCBUeXBlRGVmaW5p dGlvbiYgZ2V0KFR5cGVJbmRleCk7CiAgICAgc3RhdGljIFR5cGVJbmRleCBnZXQoY29uc3QgVHlw ZURlZmluaXRpb24mKTsKIAotICAgIHN0YXRpYyBUeXBlSW5kZXggZ2V0KGNvbnN0IEZ1bmN0aW9u U2lnbmF0dXJlJik7CiAgICAgc3RhdGljIGNvbnN0IEZ1bmN0aW9uU2lnbmF0dXJlJiBnZXRGdW5j dGlvblNpZ25hdHVyZShUeXBlSW5kZXgpOwogCiAgICAgc3RhdGljIHZvaWQgdHJ5Q2xlYW51cCgp OwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbVR5cGVEZWZpbml0 aW9uSW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbVR5cGVEZWZpbml0 aW9uSW5saW5lcy5oCmluZGV4IDkwZTc2YTRkMWVlYWI3NjYxMjE0MGY5NjdhOGNmYTFhMjBlZjRj YjQuLmEzNTYzNjlkNDA2YjhjN2IxYTJjNDgzMWYxNTA4ZTAwNTY1OWJkYjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21UeXBlRGVmaW5pdGlvbklubGluZXMuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtVHlwZURlZmluaXRpb25JbmxpbmVz LmgKQEAgLTY0LDExICs2NCw2IEBAIGlubGluZSBUeXBlSW5kZXggVHlwZUluZm9ybWF0aW9uOjpn ZXQoY29uc3QgVHlwZURlZmluaXRpb24mIHR5cGUpCiAgICAgcmV0dXJuIGJpdHdpc2VfY2FzdDxU eXBlSW5kZXg+KCZ0eXBlKTsKIH0KIAotaW5saW5lIFR5cGVJbmRleCBUeXBlSW5mb3JtYXRpb246 OmdldChjb25zdCBGdW5jdGlvblNpZ25hdHVyZSYgZnVuY3Rpb25UeXBlKQotewotICAgIHJldHVy biBnZXQoKnJlaW50ZXJwcmV0X2Nhc3Q8VHlwZURlZmluaXRpb24qPihjb25zdF9jYXN0PGNoYXIq PihmdW5jdGlvblR5cGUubV9wYXlsb2FkKSAtIHNpemVvZihUeXBlRGVmaW5pdGlvbikpKTsKLX0K LQogfSB9IC8vIG5hbWVzcGFjZSBKU0M6Oldhc20KIAogI2VuZGlmIC8vIEVOQUJMRShXRUJBU1NF TUJMWSkK