239646 2022-04-22 02:55:33 -0700 Remove adjustPathForRecentRenamings from VCSUtils.pm, they are not recent anymore 2022-08-02 00:12:32 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=243447 InRadar P2 Normal --- 1 kkinnunen kkinnunen darin gsnedders jbedard webkit-bug-importer oldest_to_newest 1863589 0 kkinnunen 2022-04-22 02:55:33 -0700 Remove adjustPathForRecentRenamings from VCSUtils.pm, they are not recent anymore 1863594 1 458127 kkinnunen 2022-04-22 02:58:59 -0700 Created attachment 458127 Patch 1864368 2 458334 kkinnunen 2022-04-26 00:11:32 -0700 Created attachment 458334 Patch 1864727 3 ews-feeder 2022-04-26 22:41:39 -0700 Committed r293498 (250031@main): <https://commits.webkit.org/250031@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458334. 1864728 4 webkit-bug-importer 2022-04-26 22:42:12 -0700 <rdar://problem/92378815> 1864935 5 458334 darin 2022-04-27 14:21:03 -0700 Comment on attachment 458334 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458334&action=review > Tools/Scripts/VCSUtils.pm:-856 > - # The first and second paths can differ in the case of copies > - # and renames. We use the second file path because it is the > - # destination path. Just noticed this comment. Was there a reason to remove it? 1865106 6 458334 kkinnunen 2022-04-28 03:58:15 -0700 Comment on attachment 458334 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458334&action=review >> Tools/Scripts/VCSUtils.pm:-856 >> - # destination path. > > Just noticed this comment. Was there a reason to remove it? It's a stale comment from the era when the logic of parseGitDiffStartLine was inline in this function, and the regex extracted both the first path and second path from the match. There's no "first path" nor "second path" in this context anymore. parseGitDiffStartLine documents that it returns the destination file for each file diff section in a git patch. bug 38628 458127 2022-04-22 02:58:59 -0700 2022-04-26 00:11:25 -0700 Patch bug-239646-20220422125857.patch text/plain 2186 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMjEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzIwYmQ2YjZiMzVmOTc0ZmQ0NTgzNGY1YzNmNWY3N2M3 ODBjNDk1NC4uOWM4NmY4YzhiNDg4OTE5MmNiNzhhMzkxMDc5M2YzNjA1YjRlODZiMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIyLTA0LTIyICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIGFkanVzdFBhdGhGb3JSZWNlbnRSZW5hbWluZ3MgZnJvbSBWQ1NVdGls cy5wbSwgdGhleSBhcmUgbm90IHJlY2VudCBhbnltb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk2NDYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVzZSB3ZXJlIHVzZWQgdG8gYWRqdXN0IHBhdGNo ZXMgMTAgeWVhcnMgYWdvLgorICAgICAgICBUaGUgZnVuY3Rpb25hbGl0eSByZW5hbWVzICpfdGVz dF9leHBlY3RhdGlvbnMudHh0IGluIEFOR0xFIGltcG9ydHMsIHdoaWNoIGNhdXNlcyBzdXJwcmlz ZXMKKyAgICAgICAgYW5kIGhhcmQgdG8gdHJhY2sgcmVkdW5kYW50IHNlY3Rpb25zIHdoaWxlIGlu c3BlY3RpbmcgZG93bnN0cmVhbSBkaWZmZXJlbmNlcyB0byB1cHN0cmVhbS4KKworICAgICAgICAq IFNjcmlwdHMvVkNTVXRpbHMucG06CisgICAgICAgIChwYXJzZUdpdERpZmZIZWFkZXIpOgorCiAy MDIyLTA0LTE5ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAg ICAgSVBDIHRlc3RpbmcgQVBJIHNob3VsZCBoYXZlIHRoZSBhYmlsaXR5IHRvIHRlc3QgSVBDOjpD b25uZWN0aW9uIHNlbmQgYW5kIHJlY2VpdmUgdGhyb3VnaCBJUEM6OkNvbm5lY3Rpb24KZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0gYi9Ub29scy9TY3JpcHRzL1ZDU1V0aWxz LnBtCmluZGV4IGRmOGI1NWZlMjQ5YTkwZjE2YzhlNDUxYzNkMDI4NzY3ZTAxNTM3NzEuLjNiMWY3 N2NjYTFhZmZjMDgwNjQxODI5YTdiMDA0MGRjZjExMTAxN2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvVkNTVXRpbHMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQpAQCAtNTkz LDE3ICs1OTMsNiBAQCBzdWIgcG9zc2libHlDb2xvcmVkKCQkKQogICAgIH0KIH0KIAotc3ViIGFk anVzdFBhdGhGb3JSZWNlbnRSZW5hbWluZ3MoJCkgCi17IAotICAgIG15ICgkZnVsbFBhdGgpID0g QF87IAotIAotICAgICRmdWxsUGF0aCA9fiBzfFdlYkNvcmUvd2ViYXVkaW98V2ViQ29yZS9Nb2R1 bGVzL3dlYmF1ZGlvfGc7Ci0gICAgJGZ1bGxQYXRoID1+IHN8SmF2YVNjcmlwdENvcmUvd3RmfFdU Ri93dGZ8ZzsKLSAgICAkZnVsbFBhdGggPX4gc3x0ZXN0X2V4cGVjdGF0aW9ucy50eHR8VGVzdEV4 cGVjdGF0aW9uc3xnOwotCi0gICAgcmV0dXJuICRmdWxsUGF0aDsgCi19IAotCiBzdWIgY2Fub25p Y2FsaXplUGF0aCgkKQogewogICAgIG15ICgkZmlsZSkgPSBAXzsKQEAgLTg1MCwxMiArODM5LDcg QEAgc3ViIHBhcnNlR2l0RGlmZkhlYWRlcigkJCkKICAgICBpZiAoLyRnaXREaWZmU3RhcnRSZWdF eC8pIHsKICAgICAgICAgIyBVc2UgJFBPU1RNQVRDSCB0byBwcmVzZXJ2ZSB0aGUgZW5kLW9mLWxp bmUgY2hhcmFjdGVyLgogICAgICAgICBteSAkZW9sID0gJFBPU1RNQVRDSDsKLQotICAgICAgICAj IFRoZSBmaXJzdCBhbmQgc2Vjb25kIHBhdGhzIGNhbiBkaWZmZXIgaW4gdGhlIGNhc2Ugb2YgY29w aWVzCi0gICAgICAgICMgYW5kIHJlbmFtZXMuICBXZSB1c2UgdGhlIHNlY29uZCBmaWxlIHBhdGgg YmVjYXVzZSBpdCBpcyB0aGUKLSAgICAgICAgIyBkZXN0aW5hdGlvbiBwYXRoLgotICAgICAgICAk aW5kZXhQYXRoID0gYWRqdXN0UGF0aEZvclJlY2VudFJlbmFtaW5ncyhwYXJzZUdpdERpZmZTdGFy dExpbmUoJF8pKTsKLQorICAgICAgICAkaW5kZXhQYXRoID0gJF87CiAgICAgICAgICRfID0gIklu ZGV4OiAkaW5kZXhQYXRoJGVvbCI7ICMgQ29udmVydCB0byBTVk4gZm9ybWF0LgogICAgIH0gZWxz ZSB7CiAgICAgICAgIGRpZSgiQ291bGQgbm90IHBhcnNlIGxlYWRpbmcgXCJkaWZmIC0tZ2l0XCIg bGluZTogXCIkbGluZVwiLiIpOwo= 458334 2022-04-26 00:11:32 -0700 2022-04-26 22:41:40 -0700 Patch bug-239646-20220426101129.patch text/plain 2441 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNDEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGJiOTg5ZTgzN2M0YWFiOWIzZGViMmRhMjlkYzU5N2M0 MmIzNWI3ZS4uYzRlM2EyZDE1YjNiMWM4MGMyZDkwNTNlMDUyZWJjOTEyZDNlYzdiZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIyLTA0LTI2ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIGFkanVzdFBhdGhGb3JSZWNlbnRSZW5hbWluZ3MgZnJvbSBWQ1NVdGls cy5wbSwgdGhleSBhcmUgbm90IHJlY2VudCBhbnltb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk2NDYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVzZSB3ZXJlIHVzZWQgdG8gYWRqdXN0IHBhdGNo ZXMgMTAgeWVhcnMgYWdvLgorICAgICAgICBUaGUgZnVuY3Rpb25hbGl0eSByZW5hbWVzICpfdGVz dF9leHBlY3RhdGlvbnMudHh0IGluIEFOR0xFIGltcG9ydHMsIHdoaWNoIGNhdXNlcyBzdXJwcmlz ZXMKKyAgICAgICAgYW5kIGhhcmQgdG8gdHJhY2sgcmVkdW5kYW50IHNlY3Rpb25zIHdoaWxlIGlu c3BlY3RpbmcgZG93bnN0cmVhbSBkaWZmZXJlbmNlcyB0byB1cHN0cmVhbS4KKworICAgICAgICAq IFNjcmlwdHMvVkNTVXRpbHMucG06CisgICAgICAgIChwYXJzZUdpdERpZmZIZWFkZXIpOgorCiAy MDIyLTA0LTI1ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAgICAg ICBbaU9TXSBBZGQgTlNDb2Rpbmcgc3VwcG9ydCBmb3IgZmluZEludGVyYWN0aW9uRW5hYmxlZApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbSBiL1Rvb2xzL1NjcmlwdHMvVkNT VXRpbHMucG0KaW5kZXggZGY4YjU1ZmUyNDlhOTBmMTZjOGU0NTFjM2QwMjg3NjdlMDE1Mzc3MS4u ZDE5NDIzNmM5OTcyOGU3YzU0YTI2MzQyMGE5NDY2NzAyNDE5MzVhNCAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy9WQ1NVdGlscy5wbQorKysgYi9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCkBA IC01OTMsMTcgKzU5Myw2IEBAIHN1YiBwb3NzaWJseUNvbG9yZWQoJCQpCiAgICAgfQogfQogCi1z dWIgYWRqdXN0UGF0aEZvclJlY2VudFJlbmFtaW5ncygkKSAKLXsgCi0gICAgbXkgKCRmdWxsUGF0 aCkgPSBAXzsgCi0gCi0gICAgJGZ1bGxQYXRoID1+IHN8V2ViQ29yZS93ZWJhdWRpb3xXZWJDb3Jl L01vZHVsZXMvd2ViYXVkaW98ZzsKLSAgICAkZnVsbFBhdGggPX4gc3xKYXZhU2NyaXB0Q29yZS93 dGZ8V1RGL3d0ZnxnOwotICAgICRmdWxsUGF0aCA9fiBzfHRlc3RfZXhwZWN0YXRpb25zLnR4dHxU ZXN0RXhwZWN0YXRpb25zfGc7Ci0KLSAgICByZXR1cm4gJGZ1bGxQYXRoOyAKLX0gCi0KIHN1YiBj YW5vbmljYWxpemVQYXRoKCQpCiB7CiAgICAgbXkgKCRmaWxlKSA9IEBfOwpAQCAtODUwLDEyICs4 MzksNyBAQCBzdWIgcGFyc2VHaXREaWZmSGVhZGVyKCQkKQogICAgIGlmICgvJGdpdERpZmZTdGFy dFJlZ0V4LykgewogICAgICAgICAjIFVzZSAkUE9TVE1BVENIIHRvIHByZXNlcnZlIHRoZSBlbmQt b2YtbGluZSBjaGFyYWN0ZXIuCiAgICAgICAgIG15ICRlb2wgPSAkUE9TVE1BVENIOwotCi0gICAg ICAgICMgVGhlIGZpcnN0IGFuZCBzZWNvbmQgcGF0aHMgY2FuIGRpZmZlciBpbiB0aGUgY2FzZSBv ZiBjb3BpZXMKLSAgICAgICAgIyBhbmQgcmVuYW1lcy4gIFdlIHVzZSB0aGUgc2Vjb25kIGZpbGUg cGF0aCBiZWNhdXNlIGl0IGlzIHRoZQotICAgICAgICAjIGRlc3RpbmF0aW9uIHBhdGguCi0gICAg ICAgICRpbmRleFBhdGggPSBhZGp1c3RQYXRoRm9yUmVjZW50UmVuYW1pbmdzKHBhcnNlR2l0RGlm ZlN0YXJ0TGluZSgkXykpOwotCisgICAgICAgICRpbmRleFBhdGggPSBwYXJzZUdpdERpZmZTdGFy dExpbmUoJF8pOwogICAgICAgICAkXyA9ICJJbmRleDogJGluZGV4UGF0aCRlb2wiOyAjIENvbnZl cnQgdG8gU1ZOIGZvcm1hdC4KICAgICB9IGVsc2UgewogICAgICAgICBkaWUoIkNvdWxkIG5vdCBw YXJzZSBsZWFkaW5nIFwiZGlmZiAtLWdpdFwiIGxpbmU6IFwiJGxpbmVcIi4iKTsKQEAgLTk3OCw3 ICs5NjIsNyBAQCBzdWIgcGFyc2VTdm5EaWZmSGVhZGVyKCQkKQogCiAgICAgbXkgJGluZGV4UGF0 aDsKICAgICBpZiAoLyRzdm5EaWZmU3RhcnRSZWdFeC8pIHsKLSAgICAgICAgJGluZGV4UGF0aCA9 IGFkanVzdFBhdGhGb3JSZWNlbnRSZW5hbWluZ3MoJDEpOworICAgICAgICAkaW5kZXhQYXRoID0g JDE7CiAgICAgfSBlbHNlIHsKICAgICAgICAgZGllKCJGaXJzdCBsaW5lIG9mIFNWTiBkaWZmIGRv ZXMgbm90IGJlZ2luIHdpdGggXCJJbmRleCBcIjogXCIkX1wiIik7CiAgICAgfQo=