239641 2022-04-22 01:21:15 -0700 Bail out from text decoration computation if none is requested 2022-04-22 05:04:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto koivisto bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan ntim pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1863570 0 koivisto 2022-04-22 01:21:15 -0700 We look for them unnecessarily. 1863573 1 458120 koivisto 2022-04-22 01:26:37 -0700 Created attachment 458120 Patch 1863598 2 458120 ntim 2022-04-22 03:09:42 -0700 Comment on attachment 458120 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458120&action=review > Source/WebCore/rendering/TextDecorationPainter.cpp:413 > + if (requestedDecorations.isEmpty()) > + return { }; Can we use the same more strict check like above? or does that cause issues? Fwiw, blink isn't supported, and none should do nothing. 1863613 3 458134 koivisto 2022-04-22 03:54:01 -0700 Created attachment 458134 Patch for landing 1863615 4 koivisto 2022-04-22 03:55:14 -0700 > Can we use the same more strict check like above? or does that cause issues? > Fwiw, blink isn't supported, and none should do nothing. Good point, though I went to other directions by just using isEmpty(). I also removed the unused None value. 1863628 5 ews-feeder 2022-04-22 05:03:27 -0700 Committed r293217 (249886@main): <https://commits.webkit.org/249886@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458134. 1863631 6 webkit-bug-importer 2022-04-22 05:04:14 -0700 <rdar://problem/92157483> 458120 2022-04-22 01:26:37 -0700 2022-04-22 03:53:56 -0700 Patch bug-239641-20220422112636.patch text/plain 2704 koivisto U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTBiNmUxZTQyODFiY2Nm ZWY4ZDBmNjAxMzE3N2U1MTk1MGZjNDJlOC4uM2QwNGQ1NTQ5NDk5ZTAzMjZkMWFkMDE1MjkyNmJm NTYxMDdhMjY2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTA0LTIyICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBCYWlsIG91dCBmcm9tIHRl eHQgZGVjb3JhdGlvbiBjb21wdXRhdGlvbiBpZiBub25lIGlzIHJlcXVlc3RlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5NjQxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvVGV4dERl Y29yYXRpb25QYWludGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNvbGxlY3RTdHlsZXNGb3JS ZW5kZXJlcik6CisKKyAgICAgICAgQWxzbyBhdm9pZCByZXNvbHZpbmcgY29sb3JzIHVubmVjZXNz YXJpbHkuCisKKyAgICAgICAgKFdlYkNvcmU6OlRleHREZWNvcmF0aW9uUGFpbnRlcjo6c3R5bGVz Rm9yUmVuZGVyZXIpOgorCiAyMDIyLTA0LTIyICBUeWxlciBXaWxjb2NrICA8dHlsZXJfd0BhcHBs ZS5jb20+CiAKICAgICAgICAgQVg6IFRoZSBpc29sYXRlZCB0cmVlIGlzIG5vdCB1cGRhdGVkIGFm dGVyIHJvbGUgY2hhbmdlcyBpbiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojp1cGRhdGVSb2xl QWZ0ZXJDaGlsZHJlbkNyZWF0aW9uKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9UZXh0RGVjb3JhdGlvblBhaW50ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1RleHREZWNvcmF0aW9uUGFpbnRlci5jcHAKaW5kZXggZWQyMjllOTg2NzgxOTIzMzEwNzk4Y2U5 NjVhNTU5ZDk0ZDJhZjhjNC4uOTY5OWVhMWE4NzA4M2NlYzBiYTY5ZWUxODI0MTJlOWJlZGJjNDgy MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHREZWNvcmF0aW9uUGFp bnRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHREZWNvcmF0aW9uUGFp bnRlci5jcHAKQEAgLTMzNiw2ICszMzYsOSBAQCB2b2lkIFRleHREZWNvcmF0aW9uUGFpbnRlcjo6 cGFpbnRMaW5lVGhyb3VnaChjb25zdCBDb2xvciYgY29sb3IsIGZsb2F0IHRoaWNrbmVzcwogc3Rh dGljIHZvaWQgY29sbGVjdFN0eWxlc0ZvclJlbmRlcmVyKFRleHREZWNvcmF0aW9uUGFpbnRlcjo6 U3R5bGVzJiByZXN1bHQsIGNvbnN0IFJlbmRlck9iamVjdCYgcmVuZGVyZXIsIE9wdGlvblNldDxU ZXh0RGVjb3JhdGlvbkxpbmU+IHJlbWFpbmluZ0RlY29yYXRpb25zLCBib29sIGZpcnN0TGluZVN0 eWxlLCBQc2V1ZG9JZCBwc2V1ZG9JZCkKIHsKICAgICBhdXRvIGV4dHJhY3REZWNvcmF0aW9ucyA9 IFsmXSAoY29uc3QgUmVuZGVyU3R5bGUmIHN0eWxlLCBPcHRpb25TZXQ8VGV4dERlY29yYXRpb25M aW5lPiBkZWNvcmF0aW9ucykgeworICAgICAgICBpZiAoIWRlY29yYXRpb25zLmNvbnRhaW5zQW55 KHsgVGV4dERlY29yYXRpb25MaW5lOjpVbmRlcmxpbmUsIFRleHREZWNvcmF0aW9uTGluZTo6T3Zl cmxpbmUsIFRleHREZWNvcmF0aW9uTGluZTo6TGluZVRocm91Z2ggfSkpCisgICAgICAgICAgICBy ZXR1cm47CisKICAgICAgICAgYXV0byBjb2xvciA9IFRleHREZWNvcmF0aW9uUGFpbnRlcjo6ZGVj b3JhdGlvbkNvbG9yKHN0eWxlKTsKICAgICAgICAgYXV0byBkZWNvcmF0aW9uU3R5bGUgPSBzdHls ZS50ZXh0RGVjb3JhdGlvblN0eWxlKCk7CiAKQEAgLTM1NCw3ICszNTcsNiBAQCBzdGF0aWMgdm9p ZCBjb2xsZWN0U3R5bGVzRm9yUmVuZGVyZXIoVGV4dERlY29yYXRpb25QYWludGVyOjpTdHlsZXMm IHJlc3VsdCwgY29ucwogICAgICAgICAgICAgcmVzdWx0LmxpbmV0aHJvdWdoQ29sb3IgPSBjb2xv cjsKICAgICAgICAgICAgIHJlc3VsdC5saW5ldGhyb3VnaFN0eWxlID0gZGVjb3JhdGlvblN0eWxl OwogICAgICAgICB9Ci0KICAgICB9OwogCiAgICAgYXV0byBzdHlsZUZvclJlbmRlcmVyID0gWyZd IChjb25zdCBSZW5kZXJPYmplY3QmIHJlbmRlcmVyKSAtPiBjb25zdCBSZW5kZXJTdHlsZSYgewpA QCAtNDA3LDYgKzQwOSw5IEBAIE9wdGlvblNldDxUZXh0RGVjb3JhdGlvbkxpbmU+IFRleHREZWNv cmF0aW9uUGFpbnRlcjo6dGV4dERlY29yYXRpb25zSW5FZmZlY3RGb3JTCiAKIGF1dG8gVGV4dERl Y29yYXRpb25QYWludGVyOjpzdHlsZXNGb3JSZW5kZXJlcihjb25zdCBSZW5kZXJPYmplY3QmIHJl bmRlcmVyLCBPcHRpb25TZXQ8VGV4dERlY29yYXRpb25MaW5lPiByZXF1ZXN0ZWREZWNvcmF0aW9u cywgYm9vbCBmaXJzdExpbmVTdHlsZSwgUHNldWRvSWQgcHNldWRvSWQpIC0+IFN0eWxlcwogewor ICAgIGlmIChyZXF1ZXN0ZWREZWNvcmF0aW9ucy5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiB7 IH07CisKICAgICBTdHlsZXMgcmVzdWx0OwogICAgIGNvbGxlY3RTdHlsZXNGb3JSZW5kZXJlcihy ZXN1bHQsIHJlbmRlcmVyLCByZXF1ZXN0ZWREZWNvcmF0aW9ucywgZmFsc2UsIHBzZXVkb0lkKTsK ICAgICBpZiAoZmlyc3RMaW5lU3R5bGUpCg== 458134 2022-04-22 03:54:01 -0700 2022-04-22 05:03:28 -0700 Patch for landing bug-239641-20220422135359.patch text/plain 4158 koivisto U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTBiNmUxZTQyODFiY2Nm ZWY4ZDBmNjAxMzE3N2U1MTk1MGZjNDJlOC4uMDE2ODIyMTg3OGUyN2Y3YjE3OGU2MzRjMGRjMDBi ZWY0N2M1YTY3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIyLTA0LTIyICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBCYWlsIG91dCBmcm9tIHRl eHQgZGVjb3JhdGlvbiBjb21wdXRhdGlvbiBpZiBub25lIGlzIHJlcXVlc3RlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5NjQxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgVGltIE5ndXllbi4KKworICAgICAgICAqIHJlbmRlcmluZy9UZXh0RGVjb3Jh dGlvblBhaW50ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29sbGVjdFN0eWxlc0ZvclJlbmRl cmVyKToKKworICAgICAgICBBbHNvIGF2b2lkIHJlc29sdmluZyBjb2xvcnMgdW5uZWNlc3Nhcmls eS4KKworICAgICAgICAoV2ViQ29yZTo6VGV4dERlY29yYXRpb25QYWludGVyOjpzdHlsZXNGb3JS ZW5kZXJlcik6CisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRz LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om9wZXJhdG9yPDwpOgorICAgICAgICAqIHJlbmRlcmlu Zy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50cy5oOgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQg J05vbmUnIHZhbHVlLgorCiAyMDIyLTA0LTIyICBUeWxlciBXaWxjb2NrICA8dHlsZXJfd0BhcHBs ZS5jb20+CiAKICAgICAgICAgQVg6IFRoZSBpc29sYXRlZCB0cmVlIGlzIG5vdCB1cGRhdGVkIGFm dGVyIHJvbGUgY2hhbmdlcyBpbiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojp1cGRhdGVSb2xl QWZ0ZXJDaGlsZHJlbkNyZWF0aW9uKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9UZXh0RGVjb3JhdGlvblBhaW50ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1RleHREZWNvcmF0aW9uUGFpbnRlci5jcHAKaW5kZXggZWQyMjllOTg2NzgxOTIzMzEwNzk4Y2U5 NjVhNTU5ZDk0ZDJhZjhjNC4uY2NlZGZmYTk5OTdhMTcyZmI3ZTZjM2U1ODQyMDMyM2I3NGIxYTVi NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHREZWNvcmF0aW9uUGFp bnRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHREZWNvcmF0aW9uUGFp bnRlci5jcHAKQEAgLTMzNiw2ICszMzYsOSBAQCB2b2lkIFRleHREZWNvcmF0aW9uUGFpbnRlcjo6 cGFpbnRMaW5lVGhyb3VnaChjb25zdCBDb2xvciYgY29sb3IsIGZsb2F0IHRoaWNrbmVzcwogc3Rh dGljIHZvaWQgY29sbGVjdFN0eWxlc0ZvclJlbmRlcmVyKFRleHREZWNvcmF0aW9uUGFpbnRlcjo6 U3R5bGVzJiByZXN1bHQsIGNvbnN0IFJlbmRlck9iamVjdCYgcmVuZGVyZXIsIE9wdGlvblNldDxU ZXh0RGVjb3JhdGlvbkxpbmU+IHJlbWFpbmluZ0RlY29yYXRpb25zLCBib29sIGZpcnN0TGluZVN0 eWxlLCBQc2V1ZG9JZCBwc2V1ZG9JZCkKIHsKICAgICBhdXRvIGV4dHJhY3REZWNvcmF0aW9ucyA9 IFsmXSAoY29uc3QgUmVuZGVyU3R5bGUmIHN0eWxlLCBPcHRpb25TZXQ8VGV4dERlY29yYXRpb25M aW5lPiBkZWNvcmF0aW9ucykgeworICAgICAgICBpZiAoZGVjb3JhdGlvbnMuaXNFbXB0eSgpKQor ICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIGF1dG8gY29sb3IgPSBUZXh0RGVjb3JhdGlv blBhaW50ZXI6OmRlY29yYXRpb25Db2xvcihzdHlsZSk7CiAgICAgICAgIGF1dG8gZGVjb3JhdGlv blN0eWxlID0gc3R5bGUudGV4dERlY29yYXRpb25TdHlsZSgpOwogCkBAIC0zNTQsNyArMzU3LDYg QEAgc3RhdGljIHZvaWQgY29sbGVjdFN0eWxlc0ZvclJlbmRlcmVyKFRleHREZWNvcmF0aW9uUGFp bnRlcjo6U3R5bGVzJiByZXN1bHQsIGNvbnMKICAgICAgICAgICAgIHJlc3VsdC5saW5ldGhyb3Vn aENvbG9yID0gY29sb3I7CiAgICAgICAgICAgICByZXN1bHQubGluZXRocm91Z2hTdHlsZSA9IGRl Y29yYXRpb25TdHlsZTsKICAgICAgICAgfQotCiAgICAgfTsKIAogICAgIGF1dG8gc3R5bGVGb3JS ZW5kZXJlciA9IFsmXSAoY29uc3QgUmVuZGVyT2JqZWN0JiByZW5kZXJlcikgLT4gY29uc3QgUmVu ZGVyU3R5bGUmIHsKQEAgLTQwNyw2ICs0MDksOSBAQCBPcHRpb25TZXQ8VGV4dERlY29yYXRpb25M aW5lPiBUZXh0RGVjb3JhdGlvblBhaW50ZXI6OnRleHREZWNvcmF0aW9uc0luRWZmZWN0Rm9yUwog CiBhdXRvIFRleHREZWNvcmF0aW9uUGFpbnRlcjo6c3R5bGVzRm9yUmVuZGVyZXIoY29uc3QgUmVu ZGVyT2JqZWN0JiByZW5kZXJlciwgT3B0aW9uU2V0PFRleHREZWNvcmF0aW9uTGluZT4gcmVxdWVz dGVkRGVjb3JhdGlvbnMsIGJvb2wgZmlyc3RMaW5lU3R5bGUsIFBzZXVkb0lkIHBzZXVkb0lkKSAt PiBTdHlsZXMKIHsKKyAgICBpZiAocmVxdWVzdGVkRGVjb3JhdGlvbnMuaXNFbXB0eSgpKQorICAg ICAgICByZXR1cm4geyB9OworCiAgICAgU3R5bGVzIHJlc3VsdDsKICAgICBjb2xsZWN0U3R5bGVz Rm9yUmVuZGVyZXIocmVzdWx0LCByZW5kZXJlciwgcmVxdWVzdGVkRGVjb3JhdGlvbnMsIGZhbHNl LCBwc2V1ZG9JZCk7CiAgICAgaWYgKGZpcnN0TGluZVN0eWxlKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50cy5jcHAKaW5kZXgg NTdlNmNhNzkyOTNhMTc1N2U0MWEyMWIwNjQ2MDNmMzUyNTkwMDNmYS4uNDk1ODk5M2EyYTc3ZTU4 OTcxM2FhNTg1OTE5YmJmYTM5ZGNlMzE4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGVDb25zdGFudHMuY3BwCkBAIC0xMDA2LDcgKzEw MDYsNiBAQCBUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFRleHRTdHJlYW0mIHRzLCBUZXh0Q29tYmlu ZSB0ZXh0Q29tYmluZSkKIFRleHRTdHJlYW0mIG9wZXJhdG9yPDwoVGV4dFN0cmVhbSYgdHMsIFRl eHREZWNvcmF0aW9uTGluZSBsaW5lKQogewogICAgIHN3aXRjaCAobGluZSkgewotICAgIGNhc2Ug VGV4dERlY29yYXRpb25MaW5lOjpOb25lOiB0cyA8PCAibm9uZSI7IGJyZWFrOwogICAgIGNhc2Ug VGV4dERlY29yYXRpb25MaW5lOjpVbmRlcmxpbmU6IHRzIDw8ICJ1bmRlcmxpbmUiOyBicmVhazsK ICAgICBjYXNlIFRleHREZWNvcmF0aW9uTGluZTo6T3ZlcmxpbmU6IHRzIDw8ICJvdmVybGluZSI7 IGJyZWFrOwogICAgIGNhc2UgVGV4dERlY29yYXRpb25MaW5lOjpMaW5lVGhyb3VnaDogdHMgPDwg ImxpbmUtdGhyb3VnaCI7IGJyZWFrOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvc3R5bGUvUmVuZGVyU3R5bGVDb25zdGFudHMuaAppbmRleCA2ZmFhYzczM2ZkODViMmNiZDYz NjgwMzA5YzU3YjE3NTg3Mjk0YzljLi5kZGI5MzhkZWQ2OGYzNGJmMTlmNTlhNTIxZmY2Mjc5MjBl YmY5ZjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVy U3R5bGVDb25zdGFudHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVu ZGVyU3R5bGVDb25zdGFudHMuaApAQCAtNzM4LDcgKzczOCw2IEBAIGVudW0gY2xhc3MgVGV4dFRy YW5zZm9ybSA6IHVpbnQ4X3QgewogCiBzdGF0aWMgY29uc3Qgc2l6ZV90IFRleHREZWNvcmF0aW9u TGluZUJpdHMgPSA0OwogZW51bSBjbGFzcyBUZXh0RGVjb3JhdGlvbkxpbmUgOiB1aW50OF90IHsK LSAgICBOb25lICAgICAgICAgID0gMCwKICAgICBVbmRlcmxpbmUgICAgID0gMSA8PCAwLAogICAg IE92ZXJsaW5lICAgICAgPSAxIDw8IDEsCiAgICAgTGluZVRocm91Z2ggICA9IDEgPDwgMiwK