239620 2022-04-21 13:39:57 -0700 Simplify FrameSelection::textWasReplaced() and callers 2022-04-21 17:03:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin esprehn+autocc ews-watchlist ggaren kangil.han mifenton sam webkit-bug-importer wenson_hsieh oldest_to_newest 1863390 0 cdumez 2022-04-21 13:39:57 -0700 Simplify FrameSelection::textWasReplaced() and callers. 1863395 1 458090 cdumez 2022-04-21 13:46:45 -0700 Created attachment 458090 Patch 1863461 2 458090 ggaren 2022-04-21 16:23:22 -0700 Comment on attachment 458090 Patch r=me 1863474 3 ews-feeder 2022-04-21 17:02:33 -0700 Committed r293197 (249871@main): <https://commits.webkit.org/249871@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458090. 1863475 4 webkit-bug-importer 2022-04-21 17:03:14 -0700 <rdar://problem/92130777> 458090 2022-04-21 13:46:45 -0700 2022-04-21 17:02:35 -0700 Patch bug-239620-20220421134645.patch text/plain 6999 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNiZWU0YjlhMjE5NWFk N2M5MTUzZDI4MDIzMzNjNjQyOTQ2NDdlMS4uZGRiMGYyYjM1MGFkYzFiZmRjNDkwYzdlMjg1OWVm Nzc0YWYyNjc1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM4IEBACisyMDIyLTA0LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgRnJhbWVTZWxl Y3Rpb246OnRleHRXYXNSZXBsYWNlZCgpIGFuZCBjYWxsZXJzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk2MjAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9DaGFyYWN0ZXJEYXRhLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNoYXJhY3RlckRhdGE6OnNldERhdGEpOgorICAgICAgICAtIENhY2hl IGRvY3VtZW50KCkuZnJhbWUoKQorICAgICAgICAtIENhbGwgdGV4dFdhc1JlcGxhY2VkKCkgd2l0 aCAqdGhpcyBpbnN0ZWFkIG9mIHRoaXMKKyAgICAgICAgLSBVc2UgbW9kZXJuIHRlbXBsYXRlIGRl ZHVjdGlvbiBmb3IgUmVmPD4uCisKKyAgICAgICAgKFdlYkNvcmU6OkNoYXJhY3RlckRhdGE6OnNl dERhdGFBbmRVcGRhdGUpOgorICAgICAgICAtIFVzZSBXVEZNb3ZlKCkgZm9yIG1fZGF0YSB0byBh dm9pZCByZWYtY291bnRpbmcgY2h1cm4uIFdlJ3JlIGFib3V0IHRvIG92ZXJ3cml0ZQorICAgICAg ICAgIG1fZGF0YSBhbnl3YXkuCisgICAgICAgIC0gVXNlIGBlbHNlIGlmYCBmb3IgdGhlIFByb2Nl c3NpbmdJbnN0cnVjdGlvbiBicmFuY2ggaW5zdGVhZCBvZiBgaWZgIHRvIGF2b2lkIHRoaXMKKyAg ICAgICAgICBjaGVjayBpbiB0aGUgY29tbW9uIGNhc2Ugd2hlcmUgfHRoaXN8IGlzIGEgVGV4dCBu b2RlLiBBIFRleHQgbm9kZSBjYW5ub3QgYmUgYQorICAgICAgICAgIFByb2Nlc3NpbmdJbnN0cnVj dGlvbiBub2RlLgorICAgICAgICAtIENhY2hlIGRvY3VtZW50KCkuZnJhbWUoKQorICAgICAgICAt IENhbGwgdGV4dFdhc1JlcGxhY2VkKCkgd2l0aCAqdGhpcyBpbnN0ZWFkIG9mIHRoaXMKKworICAg ICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6dXBk YXRlUG9zaXRpb25BZnRlckFkb3B0aW5nVGV4dFJlcGxhY2VtZW50KToKKyAgICAgICAgLSBQYXNz IG5vZGUgYnkgcmVmZXJlbmNlIG5vdyB0aGF0IHRoZSBjYWxsZXIgbm93IGhhcyBhIHJlZmVyZW5j ZSBpbnN0ZWFkIG9mIGEgcG9pbnRlcgorICAgICAgICAtIERyb3AgIXBvc2l0aW9uLmFuY2hvck5v ZGUoKSBjaGVjay4gSXQgaXMgbm90IG5lY2Vzc2FyeSBhcyB0aGUgcG9zaXRpb24uYW5jaG9yTm9k ZSgpICE9ICZub2RlCisgICAgICAgICAgY2hlY2sgd291bGQgYWxyZWFkeSBiZSB0cnVlIGlmIHRo ZSBhbmNob3JOb2RlIHdlcmUgbnVsbC4KKworICAgICAgICAoV2ViQ29yZTo6RnJhbWVTZWxlY3Rp b246OnRleHRXYXNSZXBsYWNlZCk6CisgICAgICAgIC0gRHJvcCBvdXRkYXRlZCBjb21tZW50IGFi b3V0IGEgZnJhZ21lbnQgY2hlY2sgc2luY2UgdGhlcmUgaXMgbm8gc3VjaCBjaGVjayBhbnltb3Jl CisgICAgICAgIC0gUGFzcyBub2RlIGJ5IHJlZmVyZW5jZSBpbnN0ZWFkIG9mIHBvaW50ZXIgYXMg YWxsIGNhbGwgc2l0ZXMgaGF2ZSBhIG5vbi1udWxsIHBvaW50ZXIKKyAgICAgICAgLSBEcm9wIG51 bGwgY2hlY2sgZm9yIG5vZGUgdGhhdCBpcyBubyBsb25nZXIgbmVjZXNzYXJ5CisKKyAgICAgICAg KiBlZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmg6CisKIDIwMjItMDQtMjAgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBZG9wdCBSb2Jpbkhvb2RIYXNoTWFwIC8gUm9i aW5Ib29kSGFzaFNldCBtb3JlIGJyb2FkbHkgaW4gV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL0NoYXJhY3RlckRhdGEuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0NoYXJh Y3RlckRhdGEuY3BwCmluZGV4IDI1YzBjNzg3MWExNmNiOWU2ZGU3OGYyOTUwN2E3ZjQ3YTYyMmI3 MWUuLjMwYjdhMWNhYjRjMTdhZGM1MmIwNTExYmMzMGE5MTczY2Y1NzY5MjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9DaGFyYWN0ZXJEYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vQ2hhcmFjdGVyRGF0YS5jcHAKQEAgLTU2LDEzICs1NiwxMiBAQCB2b2lkIENoYXJhY3Rl ckRhdGE6OnNldERhdGEoY29uc3QgU3RyaW5nJiBkYXRhKQogCiAgICAgaWYgKG1fZGF0YSA9PSBu b25OdWxsRGF0YSAmJiBjYW5Vc2VTZXREYXRhT3B0aW1pemF0aW9uKCp0aGlzKSkgewogICAgICAg ICBkb2N1bWVudCgpLnRleHRSZW1vdmVkKCp0aGlzLCAwLCBvbGRMZW5ndGgpOwotICAgICAgICBp ZiAoZG9jdW1lbnQoKS5mcmFtZSgpKQotICAgICAgICAgICAgZG9jdW1lbnQoKS5mcmFtZSgpLT5z ZWxlY3Rpb24oKS50ZXh0V2FzUmVwbGFjZWQodGhpcywgMCwgb2xkTGVuZ3RoLCBvbGRMZW5ndGgp OworICAgICAgICBpZiAoYXV0byogZnJhbWUgPSBkb2N1bWVudCgpLmZyYW1lKCkpCisgICAgICAg ICAgICBmcmFtZS0+c2VsZWN0aW9uKCkudGV4dFdhc1JlcGxhY2VkKCp0aGlzLCAwLCBvbGRMZW5n dGgsIG9sZExlbmd0aCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBSZWY8Q2hhcmFj dGVyRGF0YT4gcHJvdGVjdGVkVGhpcygqdGhpcyk7Ci0KKyAgICBSZWYgcHJvdGVjdGVkVGhpcyB7 ICp0aGlzIH07CiAgICAgc2V0RGF0YUFuZFVwZGF0ZShub25OdWxsRGF0YSwgMCwgb2xkTGVuZ3Ro LCBub25OdWxsRGF0YS5sZW5ndGgoKSk7CiB9CiAKQEAgLTE4Niw3ICsxODUsNyBAQCB2b2lkIENo YXJhY3RlckRhdGE6OnNldERhdGFBbmRVcGRhdGUoY29uc3QgU3RyaW5nJiBuZXdEYXRhLCB1bnNp Z25lZCBvZmZzZXRPZlJlcAogewogICAgIGF1dG8gY2hpbGRDaGFuZ2UgPSBtYWtlQ2hpbGRDaGFu Z2UoKnRoaXMsIENvbnRhaW5lck5vZGU6OkNoaWxkQ2hhbmdlOjpTb3VyY2U6OkFQSSk7CiAKLSAg ICBTdHJpbmcgb2xkRGF0YSA9IG1fZGF0YTsKKyAgICBTdHJpbmcgb2xkRGF0YSA9IFdURk1vdmUo bV9kYXRhKTsKICAgICB7CiAgICAgICAgIHN0ZDo6b3B0aW9uYWw8U3R5bGU6OkNoaWxkQ2hhbmdl SW52YWxpZGF0aW9uPiBzdHlsZUludmFsaWRhdGlvbjsKICAgICAgICAgaWYgKGF1dG8qIHBhcmVu dCA9IHBhcmVudE5vZGUoKSkKQEAgLTIwMywxMiArMjAyLDExIEBAIHZvaWQgQ2hhcmFjdGVyRGF0 YTo6c2V0RGF0YUFuZFVwZGF0ZShjb25zdCBTdHJpbmcmIG5ld0RhdGEsIHVuc2lnbmVkIG9mZnNl dE9mUmVwCiAgICAgQVNTRVJUKCFyZW5kZXJlcigpIHx8IGlzPFRleHQ+KCp0aGlzKSk7CiAgICAg aWYgKGF1dG8gdGV4dCA9IGR5bmFtaWNEb3duY2FzdDxUZXh0PigqdGhpcykpCiAgICAgICAgIHRl eHQtPnVwZGF0ZVJlbmRlcmVyQWZ0ZXJDb250ZW50Q2hhbmdlKG9mZnNldE9mUmVwbGFjZWREYXRh LCBvbGRMZW5ndGgpOwotCi0gICAgaWYgKGF1dG8gcHJvY2Vzc2luZ0ludHJ1Y3Rpb24gPSBkeW5h bWljRG93bmNhc3Q8UHJvY2Vzc2luZ0luc3RydWN0aW9uPigqdGhpcykpCisgICAgZWxzZSBpZiAo YXV0byBwcm9jZXNzaW5nSW50cnVjdGlvbiA9IGR5bmFtaWNEb3duY2FzdDxQcm9jZXNzaW5nSW5z dHJ1Y3Rpb24+KCp0aGlzKSkKICAgICAgICAgcHJvY2Vzc2luZ0ludHJ1Y3Rpb24tPmNoZWNrU3R5 bGVTaGVldCgpOwogCi0gICAgaWYgKGRvY3VtZW50KCkuZnJhbWUoKSkKLSAgICAgICAgZG9jdW1l bnQoKS5mcmFtZSgpLT5zZWxlY3Rpb24oKS50ZXh0V2FzUmVwbGFjZWQodGhpcywgb2Zmc2V0T2ZS ZXBsYWNlZERhdGEsIG9sZExlbmd0aCwgbmV3TGVuZ3RoKTsKKyAgICBpZiAoYXV0byogZnJhbWUg PSBkb2N1bWVudCgpLmZyYW1lKCkpCisgICAgICAgIGZyYW1lLT5zZWxlY3Rpb24oKS50ZXh0V2Fz UmVwbGFjZWQoKnRoaXMsIG9mZnNldE9mUmVwbGFjZWREYXRhLCBvbGRMZW5ndGgsIG5ld0xlbmd0 aCk7CiAKICAgICBub3RpZnlQYXJlbnRBZnRlckNoYW5nZShjaGlsZENoYW5nZSk7CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKaW5kZXggMjFlMDJlYTgwYjg2M2Jj MjJiYzRhZDliOTlkNGVhNDAxMzA5MTcyNC4uNDNlYWE2YzI4YWNjZjRlN2MwMmRmNTBhYWI0NjY2 NTI4MzUxNmRjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVj dGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAK QEAgLTYzMSw5ICs2MzEsOSBAQCB2b2lkIEZyYW1lU2VsZWN0aW9uOjpyZXNwb25kVG9Ob2RlTW9k aWZpY2F0aW9uKE5vZGUmIG5vZGUsIGJvb2wgYW5jaG9yUmVtb3ZlZCwgYgogICAgICAgICBzZXRT ZWxlY3Rpb24oVmlzaWJsZVNlbGVjdGlvbigpLCBEb05vdFNldEZvY3VzKTsKIH0KIAotc3RhdGlj IHZvaWQgdXBkYXRlUG9zaXRpb25BZnRlckFkb3B0aW5nVGV4dFJlcGxhY2VtZW50KFBvc2l0aW9u JiBwb3NpdGlvbiwgQ2hhcmFjdGVyRGF0YSogbm9kZSwgdW5zaWduZWQgb2Zmc2V0LCB1bnNpZ25l ZCBvbGRMZW5ndGgsIHVuc2lnbmVkIG5ld0xlbmd0aCkKK3N0YXRpYyB2b2lkIHVwZGF0ZVBvc2l0 aW9uQWZ0ZXJBZG9wdGluZ1RleHRSZXBsYWNlbWVudChQb3NpdGlvbiYgcG9zaXRpb24sIENoYXJh Y3RlckRhdGEmIG5vZGUsIHVuc2lnbmVkIG9mZnNldCwgdW5zaWduZWQgb2xkTGVuZ3RoLCB1bnNp Z25lZCBuZXdMZW5ndGgpCiB7Ci0gICAgaWYgKCFwb3NpdGlvbi5hbmNob3JOb2RlKCkgfHwgcG9z aXRpb24uYW5jaG9yTm9kZSgpICE9IG5vZGUgfHwgcG9zaXRpb24uYW5jaG9yVHlwZSgpICE9IFBv c2l0aW9uOjpQb3NpdGlvbklzT2Zmc2V0SW5BbmNob3IpCisgICAgaWYgKHBvc2l0aW9uLmFuY2hv ck5vZGUoKSAhPSAmbm9kZSB8fCBwb3NpdGlvbi5hbmNob3JUeXBlKCkgIT0gUG9zaXRpb246OlBv c2l0aW9uSXNPZmZzZXRJbkFuY2hvcikKICAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gU2VlOiBo dHRwOi8vd3d3LnczLm9yZy9UUi9ET00tTGV2ZWwtMi1UcmF2ZXJzYWwtUmFuZ2UvcmFuZ2VzLmh0 bWwjTGV2ZWwtMi1SYW5nZS1NdXRhdGlvbgpAQCAtNjQ4LDEzICs2NDgsMTIgQEAgc3RhdGljIHZv aWQgdXBkYXRlUG9zaXRpb25BZnRlckFkb3B0aW5nVGV4dFJlcGxhY2VtZW50KFBvc2l0aW9uJiBw b3NpdGlvbiwgQ2hhcmEKICAgICBpZiAocG9zaXRpb25PZmZzZXQgPiBvZmZzZXQgKyBvbGRMZW5n dGgpCiAgICAgICAgIHBvc2l0aW9uLm1vdmVUb09mZnNldChwb3NpdGlvbk9mZnNldCAtIG9sZExl bmd0aCArIG5ld0xlbmd0aCk7CiAKLSAgICBBU1NFUlQoc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHBv c2l0aW9uLm9mZnNldEluQ29udGFpbmVyTm9kZSgpKSA8PSBub2RlLT5sZW5ndGgoKSk7CisgICAg QVNTRVJUKHN0YXRpY19jYXN0PHVuc2lnbmVkPihwb3NpdGlvbi5vZmZzZXRJbkNvbnRhaW5lck5v ZGUoKSkgPD0gbm9kZS5sZW5ndGgoKSk7CiB9CiAKLXZvaWQgRnJhbWVTZWxlY3Rpb246OnRleHRX YXNSZXBsYWNlZChDaGFyYWN0ZXJEYXRhKiBub2RlLCB1bnNpZ25lZCBvZmZzZXQsIHVuc2lnbmVk IG9sZExlbmd0aCwgdW5zaWduZWQgbmV3TGVuZ3RoKQordm9pZCBGcmFtZVNlbGVjdGlvbjo6dGV4 dFdhc1JlcGxhY2VkKENoYXJhY3RlckRhdGEmIG5vZGUsIHVuc2lnbmVkIG9mZnNldCwgdW5zaWdu ZWQgb2xkTGVuZ3RoLCB1bnNpZ25lZCBuZXdMZW5ndGgpCiB7Ci0gICAgLy8gVGhlIGZyYWdtZW50 IGNoZWNrIGlzIGEgcGVyZm9ybWFuY2Ugb3B0aW1pemF0aW9uLiBTZWUgaHR0cDovL3RyYWMud2Vi a2l0Lm9yZy9jaGFuZ2VzZXQvMzAwNjIuCi0gICAgaWYgKGlzTm9uZSgpIHx8ICFub2RlIHx8ICFu b2RlLT5pc0Nvbm5lY3RlZCgpKQorICAgIGlmIChpc05vbmUoKSB8fCAhbm9kZS5pc0Nvbm5lY3Rl ZCgpKQogICAgICAgICByZXR1cm47CiAKICAgICBQb3NpdGlvbiBiYXNlID0gbV9zZWxlY3Rpb24u YmFzZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlv bi5oIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oCmluZGV4IGE5YWE2 MjllMzA5ODgyNmFjMjYxZDAxMjM1NTMxMTc4OWZjMjI5ZDAuLmEzZDc0MzRjYTVkOTRlMzJjYWRi ZWQ4N2U3NzFlZjEyY2FiODhjYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv RnJhbWVTZWxlY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0 aW9uLmgKQEAgLTE5MSw3ICsxOTEsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBkZWJ1Z1JlbmRlcmVy KFJlbmRlck9iamVjdCosIGJvb2wgc2VsZWN0ZWQpIGNvbnN0OwogCiAgICAgdm9pZCBub2RlV2ls bEJlUmVtb3ZlZChOb2RlJik7Ci0gICAgdm9pZCB0ZXh0V2FzUmVwbGFjZWQoQ2hhcmFjdGVyRGF0 YSosIHVuc2lnbmVkIG9mZnNldCwgdW5zaWduZWQgb2xkTGVuZ3RoLCB1bnNpZ25lZCBuZXdMZW5n dGgpOworICAgIHZvaWQgdGV4dFdhc1JlcGxhY2VkKENoYXJhY3RlckRhdGEmLCB1bnNpZ25lZCBv ZmZzZXQsIHVuc2lnbmVkIG9sZExlbmd0aCwgdW5zaWduZWQgbmV3TGVuZ3RoKTsKIAogICAgIHZv aWQgc2V0Q2FyZXRWaXNpYmxlKGJvb2wgY2FyZXRJc1Zpc2libGUpIHsgc2V0Q2FyZXRWaXNpYmls aXR5KGNhcmV0SXNWaXNpYmxlID8gVmlzaWJsZSA6IEhpZGRlbiwgU2hvdWxkVXBkYXRlQXBwZWFy YW5jZTo6WWVzKTsgfQogICAgIHZvaWQgcGFpbnRDYXJldChHcmFwaGljc0NvbnRleHQmLCBjb25z dCBMYXlvdXRQb2ludCYsIGNvbnN0IExheW91dFJlY3QmIGNsaXBSZWN0KTsK