23960 2009-02-13 17:32:53 -0800 WTF::isMainThread relies on initializeThreading incorrectly 2009-02-13 17:53:48 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 manyoso webkit-unassigned hausmann staikos zimmermann oldest_to_newest 109763 0 manyoso 2009-02-13 17:32:53 -0800 Here is the stack trace of a crash I received with Arora using ToT: #0 WTF::isMainThread () at ../../../../JavaScriptCore/wtf/ThreadingQt.cpp:194 #1 0xb68d9cc8 in buildBaseTextCodecMaps () at ../../../../WebCore/platform/text/TextEncodingRegistry.cpp:172 #2 0xb68da235 in WebCore::atomicCanonicalTextEncodingName (name=0xb717d552 "UTF-8") at ../../../../WebCore/platform/text/TextEncodingRegistry.cpp:227 #3 0xb68d7563 in TextEncoding (this=0xb7ee0158, name=0xb717d552 "UTF-8") at ../../../../WebCore/platform/text/TextEncoding.cpp:61 #4 0xb68d7678 in WebCore::UTF8Encoding () at ../../../../WebCore/platform/text/TextEncoding.cpp:231 #5 0xb6a83000 in KURL (this=0xbfe674a8, url=@0xbfe675c0) at ../../../../WebCore/platform/qt/KURLQt.cpp:40 #6 0xb6abb70a in QWebSettings::iconForUrl (url=@0xbfe675c0) at ../../../../WebKit/qt/Api/qwebsettings.cpp:487 #7 0x0807e0df in BrowserApplication::icon (url=@0xbfe675c0) at browserapplication.cpp:492 #8 0x080a6a63 in LocationBarSiteIcon::webViewSiteIconChanged (this=0x8341d68) at locationbar.cpp:57 #9 0x080a6bbc in LocationBarSiteIcon (this=0x8341d68, parent=0x8342a90) at locationbar.cpp:40 #10 0x080a6c94 in LocationBar (this=0x8342a90, parent=0x0) at locationbar.cpp:94 #11 0x080c74c9 in TabWidget::makeNewTab (this=0x81d7260, makeCurrent=true) at tabwidget.cpp:440 #12 0x080c7ef5 in TabWidget::newTab (this=0x81d7260) at tabwidget.cpp:417 #13 0x0808bdd4 in BrowserMainWindow (this=0x81ca830, parent=0x0, flags=@0xbfe678b8) at browsermainwindow.cpp:218 #14 0x0807e59c in BrowserApplication::newMainWindow (this=0xbfe678f8) at browserapplication.cpp:432 #15 0x080eda82 in main (argc=2, argv=0xbfe679b4) at main.cpp:36 The problem is that Arora calls QWebSettings::iconForUrl() before it constructs a QWebPage. The QWebSettings::iconForUrl() call eventually causes an 'ASSERT(isMainThread())' deep within WebCore. The patch attached fixes this crash by making 'isMainThread()' not rely upon 'initializeThreading' being called first. Cheers, Adam 109764 1 27678 manyoso 2009-02-13 17:33:35 -0800 Created attachment 27678 Fix for the crash 109765 2 manyoso 2009-02-13 17:51:21 -0800 Fixed with r41013 and reviewed by George Staikos over skype. 109766 3 27678 darin 2009-02-13 17:53:48 -0800 Comment on attachment 27678 Fix for the crash Makes sense, r=me 27678 2009-02-13 17:33:35 -0800 2009-02-13 17:53:48 -0800 Fix for the crash isMainThread.patch text/plain 1295 manyoso ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAzOGExNmI5Li5iN2Y1NDk2IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMDktMDItMTMgIEFkYW0gVHJlYXQgIDxhZGFtLnRyZWF0QHRvcmNobW9iaWxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBk ZXBlbmQgb24gJ2luaXRpYWxpemVUaHJlYWRpbmcoKScgdG8gY29tZSBiZWZvcmUgYSBjYWxsIHRv ICdpc01haW5UaHJlYWQoKScKKyAgICAgICAgYXMgUXRXZWJLaXQgb25seSBjYWxscyAnaW5pdGlh bGl6ZVRocmVhZGluZygpJyBkdXJpbmcgUVdlYlBhZ2UgY29uc3RydWN0aW9uLgorCisgICAgICAg IEEgY2xpZW50IGFwcCBtYXkgd2VsbCBtYWtlIGEgY2FsbCB0byBRV2ViU2V0dGluZ3M6Omljb25G b3JVcmwoKSBmb3IgaW5zdGFuY2UKKyAgICAgICAgYmVmb3JlIGNyZWF0aW5nIGEgUVdlYlBhZ2Ug YW5kIHRoYXQgY2FsbCB0byBRV2ViU2V0dGluZ3MgdHJpZ2dlcnMgYW4KKyAgICAgICAgQVNTRVJU KGlzTWFpblRocmVhZCgpKSBkZWVwIHdpdGhpbiBXZWJDb3JlLgorCisgICAgICAgICogd3RmL1Ro cmVhZGluZ1F0LmNwcDoKKyAgICAgICAgKFdURjo6aXNNYWluVGhyZWFkKToKKwogMjAwOS0wMi0x MyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgKiBDb25maWd1cmF0 aW9ucy9KYXZhU2NyaXB0Q29yZS54Y2NvbmZpZzogVW5kbyBhY2NpZGVudGFsIGNvbW1pdCBvZiB0 aGlzIGZpbGUuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUXQuY3Bw IGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1F0LmNwcAppbmRleCA1NWE0NzliLi4zNDFl NGI3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUXQuY3BwCisrKyBi L0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdRdC5jcHAKQEAgLTE5MSw3ICsxOTEsNyBAQCBU aHJlYWRJZGVudGlmaWVyIGN1cnJlbnRUaHJlYWQoKQogCiBib29sIGlzTWFpblRocmVhZCgpCiB7 Ci0gICAgcmV0dXJuIGN1cnJlbnRUaHJlYWQoKSA9PSBtYWluVGhyZWFkSWRlbnRpZmllcjsKKyAg ICByZXR1cm4gUVRocmVhZDo6Y3VycmVudFRocmVhZCgpID09IFFDb3JlQXBwbGljYXRpb246Omlu c3RhbmNlKCktPnRocmVhZCgpOwogfQogCiBNdXRleDo6TXV0ZXgoKQo=