23959 2009-02-13 17:29:04 -0800 LayoutTests/fast/dom/navigator-detached-no-crash.html fails with other JS engines 2009-02-19 14:20:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jcampan webkit-unassigned ap oldest_to_newest 109761 0 jcampan 2009-02-13 17:29:04 -0800 The layout test fast/dom/navigator-detached-no-crash.html fails with V8 as it iterates the properties and methods of the navigator object and log them as they are reported. JSC and V8 report these properties in different order (which is OK by JS specs I believe) causing the test to fail with Chromium. The test should probably sort these props before logging them so the order would always be the same. 109762 1 27677 jcampan 2009-02-13 17:30:49 -0800 Created attachment 27677 Changes the test so it sorts the properties and functions before logging them 109775 2 ap 2009-02-14 02:40:46 -0800 Do IE and Firefox sort these properties in the same order as WebKit? 109944 3 27677 ap 2009-02-17 02:17:24 -0800 Comment on attachment 27677 Changes the test so it sorts the properties and functions before logging them Ok, Firefox sorts differently, so r=me. But this patch includes a wrong ChangeLog, which must be fixed. 110014 4 27739 jcampan 2009-02-17 15:01:40 -0800 Created attachment 27739 New patch with ChangeLog fixed. ChangeLog fixed in new attachment (sorry, forgot to run prepare-changelog previously) 110298 5 dimich 2009-02-19 14:20:44 -0800 Landed in http://trac.webkit.org/changeset/41087 The ChangeLog usually includes a link to the bug in Bugzilla and a short description of changes. I've fixed it up and landed. 27677 2009-02-13 17:30:49 -0800 2009-02-17 15:01:40 -0800 Changes the test so it sorts the properties and functions before logging them layout_test_patch text/plain 3944 jcampan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDk5MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMDktMDEtMjkgIEpheSBDYW1wYW4gIDxqY2FtcGFuQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0FS TklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBwbGF0Zm9y bS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjopOgor ICAgICAgICAoV2ViQ29yZTo6UG9wdXBMaXN0Qm94OjpQb3B1cExpc3RCb3gpOgorICAgICAgICAo V2ViQ29yZTo6UG9wdXBDb250YWluZXI6OmNyZWF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpQb3B1 cENvbnRhaW5lcjo6UG9wdXBDb250YWluZXIpOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBDb250 YWluZXI6OnNob3dQb3B1cCk6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cExpc3RCb3g6OmhhbmRs ZUtleUV2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlzdEJveDo6aXNTZWxlY3RhYmxl SXRlbSk6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cExpc3RCb3g6OnNlbGVjdE5leHRSb3cpOgor ICAgICAgICAoV2ViQ29yZTo6UG9wdXBMaXN0Qm94OjpzZWxlY3RQcmV2aW91c1Jvdyk6CisgICAg ICAgIChXZWJDb3JlOjpQb3B1cE1lbnU6OnNob3cpOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL1BvcHVwTWVudUNocm9taXVtLmg6CisKIDIwMDktMDItMTMgIEFkYW0gVHJlYXQgIDxhZGFt LnRyZWF0QHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBDYXVnaHQgYnkgRGFyaW4gQWRsZXIu CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9uYXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jhc2gt ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL25hdmlnYXRv ci1kZXRhY2hlZC1uby1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDQwOTkzKQorKysgTGF5 b3V0VGVzdHMvZmFzdC9kb20vbmF2aWdhdG9yLWRldGFjaGVkLW5vLWNyYXNoLWV4cGVjdGVkLnR4 dAkod29ya2luZyBjb3B5KQpAQCAtMSwzMyArMSwzMyBAQAogVGhpcyB0ZXN0cyB0aGF0IHRoZSBu YXZpZ2F0b3Igb2JqZWN0IG9mIGEgZGVsZXRlZCBmcmFtZSBpcyBkaXNjb25uZWN0ZWQgcHJvcGVy bHkuIEFjY2Vzc2luZyBmaWVsZHMgb3IgbWV0aG9kcyBzaG91bGRuJ3QgY3Jhc2ggdGhlIGJyb3dz ZXIuIAogIENoZWNrIE5hdmlnYXRvcgotbmF2aWdhdG9yLnByb2R1Y3RTdWIgaXMgT0sKLW5hdmln YXRvci5wcm9kdWN0IGlzIE9LCiBuYXZpZ2F0b3IuYXBwQ29kZU5hbWUgaXMgT0sKLW5hdmlnYXRv ci52ZW5kb3IgaXMgT0sKLW5hdmlnYXRvci5wbGF0Zm9ybSBpcyBPSwotbmF2aWdhdG9yLm1pbWVU eXBlcyBpcyBPSworbmF2aWdhdG9yLmFwcE5hbWUgaXMgT0sKK25hdmlnYXRvci5hcHBWZXJzaW9u IGlzIE9LCituYXZpZ2F0b3IuY29va2llRW5hYmxlZCBpcyBPSworbmF2aWdhdG9yLmphdmFFbmFi bGVkKCkgaXMgT0sKIG5hdmlnYXRvci5sYW5ndWFnZSBpcyBPSworbmF2aWdhdG9yLm1pbWVUeXBl cyBpcyBPSworbmF2aWdhdG9yLm9uTGluZSBpcyBPSworbmF2aWdhdG9yLnBsYXRmb3JtIGlzIE9L CiBuYXZpZ2F0b3IucGx1Z2lucyBpcyBPSworbmF2aWdhdG9yLnByb2R1Y3QgaXMgT0sKK25hdmln YXRvci5wcm9kdWN0U3ViIGlzIE9LCiBuYXZpZ2F0b3IudXNlckFnZW50IGlzIE9LCi1uYXZpZ2F0 b3IuY29va2llRW5hYmxlZCBpcyBPSwotbmF2aWdhdG9yLmFwcFZlcnNpb24gaXMgT0sKK25hdmln YXRvci52ZW5kb3IgaXMgT0sKIG5hdmlnYXRvci52ZW5kb3JTdWIgaXMgT0sKLW5hdmlnYXRvci5v bkxpbmUgaXMgT0sKK25hdmlnYXRvci5hcHBDb2RlTmFtZSBpcyBPSwogbmF2aWdhdG9yLmFwcE5h bWUgaXMgT0sKK25hdmlnYXRvci5hcHBWZXJzaW9uIGlzIE9LCituYXZpZ2F0b3IuY29va2llRW5h YmxlZCBpcyBPSwogbmF2aWdhdG9yLmphdmFFbmFibGVkKCkgaXMgT0sKLW5hdmlnYXRvci5wcm9k dWN0U3ViIGlzIE9LCi1uYXZpZ2F0b3IucHJvZHVjdCBpcyBPSwotbmF2aWdhdG9yLmFwcENvZGVO YW1lIGlzIE9LCi1uYXZpZ2F0b3IudmVuZG9yIGlzIE9LCi1uYXZpZ2F0b3IucGxhdGZvcm0gaXMg T0sKLW5hdmlnYXRvci5taW1lVHlwZXMgaXMgT0sKIG5hdmlnYXRvci5sYW5ndWFnZSBpcyBPSwor bmF2aWdhdG9yLm1pbWVUeXBlcyBpcyBPSworbmF2aWdhdG9yLm9uTGluZSBpcyBPSworbmF2aWdh dG9yLnBsYXRmb3JtIGlzIE9LCiBuYXZpZ2F0b3IucGx1Z2lucyBpcyBPSworbmF2aWdhdG9yLnBy b2R1Y3QgaXMgT0sKK25hdmlnYXRvci5wcm9kdWN0U3ViIGlzIE9LCiBuYXZpZ2F0b3IudXNlckFn ZW50IGlzIE9LCi1uYXZpZ2F0b3IuY29va2llRW5hYmxlZCBpcyBPSwotbmF2aWdhdG9yLmFwcFZl cnNpb24gaXMgT0sKK25hdmlnYXRvci52ZW5kb3IgaXMgT0sKIG5hdmlnYXRvci52ZW5kb3JTdWIg aXMgT0sKLW5hdmlnYXRvci5vbkxpbmUgaXMgT0sKLW5hdmlnYXRvci5hcHBOYW1lIGlzIE9LCi1u YXZpZ2F0b3IuamF2YUVuYWJsZWQoKSBpcyBPSwogCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9uYXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jhc2guaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9uYXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jhc2guaHRtbAkocmV2aXNpb24g NDA5OTMpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9uYXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jh c2guaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNSw4ICs1LDExIEBAIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpIHsKICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgp OwogfQogCi1mdW5jdGlvbiBsb2cobXNnKSB7Ci0gIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdy ZXN1bHQnKS5pbm5lckhUTUwgKz0gbXNnICsgJzxicj4nOworZnVuY3Rpb24gbG9nKHN0cmluZ3Mp IHsKKyAgdmFyIG5vZGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0Jyk7CisgIGZv ciAodmFyIGkgaW4gc3RyaW5ncykgeworICAgIG5vZGUuaW5uZXJIVE1MICs9IHN0cmluZ3NbaV0g KyAnPGJyPic7CisgIH0KIH0KIAogZnVuY3Rpb24gZ2MoKQpAQCAtNDcsMTcgKzUwLDIwIEBAIGZ1 bmN0aW9uIGNoZWNrX25hdmlnYXRvcl9hbmRfZG9uZSgpIHsKIH0KIAogZnVuY3Rpb24gY2hlY2tf bmF2aWdhdG9yKCkgeworICB2YXIgc3RyaW5ncyA9IFsgXTsKICAgZm9yIChwIGluIG9sZF9uYXYp IHsKICAgICBpZiAodHlwZW9mIG9sZF9uYXZbcF0gPT0gJ2Z1bmN0aW9uJykgewogICAgICAgdmFy IHYgPSBvbGRfbmF2W3BdKCk7CiAgICAgICAvLyBubyBjcmFzaCwgaXQgaXMgb2sKLSAgICAgIGxv ZygibmF2aWdhdG9yLiIrcCsiKCkgaXMgT0siKTsKKyAgICAgIHN0cmluZ3MucHVzaCgibmF2aWdh dG9yLiIrcCsiKCkgaXMgT0siKTsKICAgICB9IGVsc2UgewogICAgICAgdmFyIHYgPSBvbGRfbmF2 W3BdOwogICAgICAgLy8gbm8gY3Jhc2gsIGl0IGlzIG9rLgotICAgICAgbG9nKCJuYXZpZ2F0b3Iu IitwKyIgaXMgT0siKTsKKyAgICAgIHN0cmluZ3MucHVzaCgibmF2aWdhdG9yLiIrcCsiIGlzIE9L Iik7CiAgICAgfQogICB9CisgIHN0cmluZ3Muc29ydCgpOworICBsb2coc3RyaW5ncyk7CiB9CiAK IDwvc2NyaXB0Pgo= 27739 2009-02-17 15:01:40 -0800 2009-02-17 15:01:40 -0800 New patch with ChangeLog fixed. layout_test_patch text/plain 3456 jcampan SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQxMDQzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDktMDItMTcgIEpheSBDYW1wYW4gIDxqY2Ft cGFuQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBmYXN0L2RvbS9uYXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jhc2gtZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIGZhc3QvZG9tL25hdmlnYXRvci1kZXRhY2hlZC1uby1jcmFzaC5odG1s OgorCiAyMDA5LTAyLTE3ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vbmF2 aWdhdG9yLWRldGFjaGVkLW5vLWNyYXNoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2RvbS9uYXZpZ2F0b3ItZGV0YWNoZWQtbm8tY3Jhc2gtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiA0MDk5MykKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL25hdmlnYXRvci1kZXRh Y2hlZC1uby1jcmFzaC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsMzMgKzEsMzMg QEAKIFRoaXMgdGVzdHMgdGhhdCB0aGUgbmF2aWdhdG9yIG9iamVjdCBvZiBhIGRlbGV0ZWQgZnJh bWUgaXMgZGlzY29ubmVjdGVkIHByb3Blcmx5LiBBY2Nlc3NpbmcgZmllbGRzIG9yIG1ldGhvZHMg c2hvdWxkbid0IGNyYXNoIHRoZSBicm93c2VyLiAKICBDaGVjayBOYXZpZ2F0b3IKLW5hdmlnYXRv ci5wcm9kdWN0U3ViIGlzIE9LCi1uYXZpZ2F0b3IucHJvZHVjdCBpcyBPSwogbmF2aWdhdG9yLmFw cENvZGVOYW1lIGlzIE9LCi1uYXZpZ2F0b3IudmVuZG9yIGlzIE9LCi1uYXZpZ2F0b3IucGxhdGZv cm0gaXMgT0sKLW5hdmlnYXRvci5taW1lVHlwZXMgaXMgT0sKK25hdmlnYXRvci5hcHBOYW1lIGlz IE9LCituYXZpZ2F0b3IuYXBwVmVyc2lvbiBpcyBPSworbmF2aWdhdG9yLmNvb2tpZUVuYWJsZWQg aXMgT0sKK25hdmlnYXRvci5qYXZhRW5hYmxlZCgpIGlzIE9LCiBuYXZpZ2F0b3IubGFuZ3VhZ2Ug aXMgT0sKK25hdmlnYXRvci5taW1lVHlwZXMgaXMgT0sKK25hdmlnYXRvci5vbkxpbmUgaXMgT0sK K25hdmlnYXRvci5wbGF0Zm9ybSBpcyBPSwogbmF2aWdhdG9yLnBsdWdpbnMgaXMgT0sKK25hdmln YXRvci5wcm9kdWN0IGlzIE9LCituYXZpZ2F0b3IucHJvZHVjdFN1YiBpcyBPSwogbmF2aWdhdG9y LnVzZXJBZ2VudCBpcyBPSwotbmF2aWdhdG9yLmNvb2tpZUVuYWJsZWQgaXMgT0sKLW5hdmlnYXRv ci5hcHBWZXJzaW9uIGlzIE9LCituYXZpZ2F0b3IudmVuZG9yIGlzIE9LCiBuYXZpZ2F0b3IudmVu ZG9yU3ViIGlzIE9LCi1uYXZpZ2F0b3Iub25MaW5lIGlzIE9LCituYXZpZ2F0b3IuYXBwQ29kZU5h bWUgaXMgT0sKIG5hdmlnYXRvci5hcHBOYW1lIGlzIE9LCituYXZpZ2F0b3IuYXBwVmVyc2lvbiBp cyBPSworbmF2aWdhdG9yLmNvb2tpZUVuYWJsZWQgaXMgT0sKIG5hdmlnYXRvci5qYXZhRW5hYmxl ZCgpIGlzIE9LCi1uYXZpZ2F0b3IucHJvZHVjdFN1YiBpcyBPSwotbmF2aWdhdG9yLnByb2R1Y3Qg aXMgT0sKLW5hdmlnYXRvci5hcHBDb2RlTmFtZSBpcyBPSwotbmF2aWdhdG9yLnZlbmRvciBpcyBP SwotbmF2aWdhdG9yLnBsYXRmb3JtIGlzIE9LCi1uYXZpZ2F0b3IubWltZVR5cGVzIGlzIE9LCiBu YXZpZ2F0b3IubGFuZ3VhZ2UgaXMgT0sKK25hdmlnYXRvci5taW1lVHlwZXMgaXMgT0sKK25hdmln YXRvci5vbkxpbmUgaXMgT0sKK25hdmlnYXRvci5wbGF0Zm9ybSBpcyBPSwogbmF2aWdhdG9yLnBs dWdpbnMgaXMgT0sKK25hdmlnYXRvci5wcm9kdWN0IGlzIE9LCituYXZpZ2F0b3IucHJvZHVjdFN1 YiBpcyBPSwogbmF2aWdhdG9yLnVzZXJBZ2VudCBpcyBPSwotbmF2aWdhdG9yLmNvb2tpZUVuYWJs ZWQgaXMgT0sKLW5hdmlnYXRvci5hcHBWZXJzaW9uIGlzIE9LCituYXZpZ2F0b3IudmVuZG9yIGlz IE9LCiBuYXZpZ2F0b3IudmVuZG9yU3ViIGlzIE9LCi1uYXZpZ2F0b3Iub25MaW5lIGlzIE9LCi1u YXZpZ2F0b3IuYXBwTmFtZSBpcyBPSwotbmF2aWdhdG9yLmphdmFFbmFibGVkKCkgaXMgT0sKIApJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vbmF2aWdhdG9yLWRldGFjaGVkLW5vLWNyYXNoLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vbmF2aWdhdG9yLWRldGFjaGVk LW5vLWNyYXNoLmh0bWwJKHJldmlzaW9uIDQwOTkzKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20v bmF2aWdhdG9yLWRldGFjaGVkLW5vLWNyYXNoLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTUsOCAr NSwxMSBAQCBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAgIGxheW91dFRlc3RD b250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKIH0KIAotZnVuY3Rpb24gbG9nKG1zZykgewotICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MICs9IG1zZyArICc8YnI+ JzsKK2Z1bmN0aW9uIGxvZyhzdHJpbmdzKSB7CisgIHZhciBub2RlID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ3Jlc3VsdCcpOworICBmb3IgKHZhciBpIGluIHN0cmluZ3MpIHsKKyAgICBub2Rl LmlubmVySFRNTCArPSBzdHJpbmdzW2ldICsgJzxicj4nOworICB9CiB9CiAKIGZ1bmN0aW9uIGdj KCkKQEAgLTQ3LDE3ICs1MCwyMCBAQCBmdW5jdGlvbiBjaGVja19uYXZpZ2F0b3JfYW5kX2RvbmUo KSB7CiB9CiAKIGZ1bmN0aW9uIGNoZWNrX25hdmlnYXRvcigpIHsKKyAgdmFyIHN0cmluZ3MgPSBb IF07CiAgIGZvciAocCBpbiBvbGRfbmF2KSB7CiAgICAgaWYgKHR5cGVvZiBvbGRfbmF2W3BdID09 ICdmdW5jdGlvbicpIHsKICAgICAgIHZhciB2ID0gb2xkX25hdltwXSgpOwogICAgICAgLy8gbm8g Y3Jhc2gsIGl0IGlzIG9rCi0gICAgICBsb2coIm5hdmlnYXRvci4iK3ArIigpIGlzIE9LIik7Cisg ICAgICBzdHJpbmdzLnB1c2goIm5hdmlnYXRvci4iK3ArIigpIGlzIE9LIik7CiAgICAgfSBlbHNl IHsKICAgICAgIHZhciB2ID0gb2xkX25hdltwXTsKICAgICAgIC8vIG5vIGNyYXNoLCBpdCBpcyBv ay4KLSAgICAgIGxvZygibmF2aWdhdG9yLiIrcCsiIGlzIE9LIik7CisgICAgICBzdHJpbmdzLnB1 c2goIm5hdmlnYXRvci4iK3ArIiBpcyBPSyIpOwogICAgIH0KICAgfQorICBzdHJpbmdzLnNvcnQo KTsKKyAgbG9nKHN0cmluZ3MpOwogfQogCiA8L3NjcmlwdD4K