239559 2022-04-20 11:48:50 -0700 Simplify type checking / casting in JSEventListener::handleEvent() 2022-04-21 17:10:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren sam webkit-bug-importer youennf oldest_to_newest 1863009 0 cdumez 2022-04-20 11:48:50 -0700 Simplify type checking / casting in JSEventListener::handleEvent(). 1863010 1 458000 cdumez 2022-04-20 11:49:38 -0700 Created attachment 458000 Patch 1863089 2 ews-feeder 2022-04-20 15:22:21 -0700 Committed r293124 (249827@main): <https://commits.webkit.org/249827@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458000. 1863482 3 ryanhaddad 2022-04-21 17:10:10 -0700 rdar://92055251 458000 2022-04-20 11:49:38 -0700 2022-04-20 15:22:23 -0700 Patch bug-239559-20220420114937.patch text/plain 2646 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWI2Njc3YTAzNDA3NGNh YzM0MDIxNDZmNzczODMwMTY4Y2RhODNmYS4uODljYTJhMGMzOTAyYWVhOWIzNjNkNGNlNzU4Njhh YmNkOWIzMzlkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIyLTA0LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgdHlwZSBjaGVj a2luZyAvIGNhc3RpbmcgaW4gSlNFdmVudExpc3RlbmVyOjpoYW5kbGVFdmVudCgpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk1NTkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pT RXZlbnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0V2ZW50TGlzdGVuZXI6Omhh bmRsZUV2ZW50KToKKwogMjAyMi0wNC0yMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBTb21lIEF1dG9zY3JvbGxDb250cm9sbGVyIGNsZWFudXAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRXZlbnRMaXN0ZW5lci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2ZW50TGlzdGVuZXIuY3BwCmluZGV4IGQ0 NDE1N2UwMWU0OWIyYmYxMmI3MTNkMjJlZWI1YjY5NDIxNTllODYuLmYwNmU1NTUwODhhMGVmZTQz NGRlNTEwNTRkMDk5ZmNiZjc0NjAwYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTRXZlbnRMaXN0ZW5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNFdmVudExpc3RlbmVyLmNwcApAQCAtMTM4LDI1ICsxMzgsMjUgQEAgdm9pZCBKU0V2ZW50 TGlzdGVuZXI6OmhhbmRsZUV2ZW50KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmIHNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQKICAgICAvLyAiSWYgdGhpcyB0aHJvd3MgYW4gZXhjZXB0aW9uLCByZXBvcnQg dGhlIGV4Y2VwdGlvbi4iIEl0IHNob3VsZCBub3QgcHJvcGFnYXRlIHRoZQogICAgIC8vIGV4Y2Vw dGlvbi4KIAotICAgIEpTT2JqZWN0KiBqc0Z1bmN0aW9uID0gZW5zdXJlSlNGdW5jdGlvbihzY3Jp cHRFeGVjdXRpb25Db250ZXh0KTsKKyAgICBhdXRvKiBqc0Z1bmN0aW9uID0gZW5zdXJlSlNGdW5j dGlvbihzY3JpcHRFeGVjdXRpb25Db250ZXh0KTsKICAgICBpZiAoIWpzRnVuY3Rpb24pCiAgICAg ICAgIHJldHVybjsKIAotICAgIEpTRE9NR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QgPSB0b0pT RE9NR2xvYmFsT2JqZWN0KHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsIG1faXNvbGF0ZWRXb3JsZCk7 CisgICAgYXV0byogZ2xvYmFsT2JqZWN0ID0gdG9KU0RPTUdsb2JhbE9iamVjdChzY3JpcHRFeGVj dXRpb25Db250ZXh0LCBtX2lzb2xhdGVkV29ybGQpOwogICAgIGlmICghZ2xvYmFsT2JqZWN0KQog ICAgICAgICByZXR1cm47CiAKICAgICBpZiAoc2NyaXB0RXhlY3V0aW9uQ29udGV4dC5pc0RvY3Vt ZW50KCkpIHsKLSAgICAgICAgSlNET01XaW5kb3cqIHdpbmRvdyA9IGpzQ2FzdDxKU0RPTVdpbmRv dyo+KGdsb2JhbE9iamVjdCk7CisgICAgICAgIGF1dG8qIHdpbmRvdyA9IGpzQ2FzdDxKU0RPTVdp bmRvdyo+KGdsb2JhbE9iamVjdCk7CiAgICAgICAgIGlmICghd2luZG93LT53cmFwcGVkKCkuaXND dXJyZW50bHlEaXNwbGF5ZWRJbkZyYW1lKCkpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAg IGlmICh3YXNDcmVhdGVkRnJvbU1hcmt1cCgpKSB7Ci0gICAgICAgICAgICBFbGVtZW50KiBlbGVt ZW50ID0gZXZlbnQudGFyZ2V0KCktPmlzTm9kZSgpICYmICFkb3duY2FzdDxOb2RlPigqZXZlbnQu dGFyZ2V0KCkpLmlzRG9jdW1lbnROb2RlKCkgPyBkeW5hbWljRG93bmNhc3Q8RWxlbWVudD4oKmV2 ZW50LnRhcmdldCgpKSA6IG51bGxwdHI7CisgICAgICAgICAgICBhdXRvKiBlbGVtZW50ID0gZHlu YW1pY0Rvd25jYXN0PEVsZW1lbnQ+KCpldmVudC50YXJnZXQoKSk7CiAgICAgICAgICAgICBpZiAo IXNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuY29udGVudFNlY3VyaXR5UG9saWN5KCktPmFsbG93SW5s aW5lRXZlbnRIYW5kbGVycyhzb3VyY2VVUkwoKS5zdHJpbmcoKSwgc291cmNlUG9zaXRpb24oKS5t X2xpbmUsIGNvZGUoKSwgZWxlbWVudCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAg ICB9CiAgICAgICAgIC8vIEZJWE1FOiBJcyB0aGlzIGNoZWNrIG5lZWRlZCBmb3Igb3RoZXIgY29u dGV4dHM/Ci0gICAgICAgIFNjcmlwdENvbnRyb2xsZXImIHNjcmlwdCA9IHdpbmRvdy0+d3JhcHBl ZCgpLmZyYW1lKCktPnNjcmlwdCgpOworICAgICAgICBhdXRvJiBzY3JpcHQgPSB3aW5kb3ctPndy YXBwZWQoKS5mcmFtZSgpLT5zY3JpcHQoKTsKICAgICAgICAgaWYgKCFzY3JpcHQuY2FuRXhlY3V0 ZVNjcmlwdHMoQWJvdXRUb0V4ZWN1dGVTY3JpcHQpIHx8IHNjcmlwdC5pc1BhdXNlZCgpKQogICAg ICAgICAgICAgcmV0dXJuOwogICAgIH0K