23955 2009-02-13 13:47:38 -0800 V8HTMLPlugInCustom returns undefined, which fools interceptors. 2009-02-18 10:47:47 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov oldest_to_newest 109728 0 dglazkov 2009-02-13 13:47:38 -0800 V8 interceptors need a truly empty value, rather than undefined. Sad. 109730 1 27668 dglazkov 2009-02-13 13:50:27 -0800 Created attachment 27668 V8HTMLPlugInCustom returns undefined, which fools interceptors, v1 WebCore/ChangeLog | 13 +++++++++++++ .../v8/custom/V8HTMLPlugInElementCustom.cpp | 16 ++++++++-------- 2 files changed, 21 insertions(+), 8 deletions(-) 109731 2 27668 eric 2009-02-13 14:01:28 -0800 Comment on attachment 27668 V8HTMLPlugInCustom returns undefined, which fools interceptors, v1 We're talking about something prettier, and involving more pink ponies and less scary undocumented subtitles in #webkit. No biscuit for this patch! 109754 3 27674 dglazkov 2009-02-13 16:04:19 -0800 Created attachment 27674 V8HTMLPlugInCustom returns undefined, which fools interceptors, v2 WebCore/ChangeLog | 13 +++++++++++++ .../v8/custom/V8HTMLPlugInElementCustom.cpp | 16 ++++++++-------- 2 files changed, 21 insertions(+), 8 deletions(-) 109769 4 27674 eric 2009-02-13 21:05:50 -0800 Comment on attachment 27674 V8HTMLPlugInCustom returns undefined, which fools interceptors, v2 LGTM. 110092 5 dglazkov 2009-02-18 10:47:47 -0800 Landed as http://trac.webkit.org/changeset/41017. 27668 2009-02-13 13:50:27 -0800 2009-02-13 14:01:28 -0800 V8HTMLPlugInCustom returns undefined, which fools interceptors, v1 V8HTMLPlugInCustom-returns-undefined-which-fools-interceptors-v1.patch text/plain 3317 dglazkov YzdiNDY4ZmI1ODliMTFhNTg1MTVlMjFiMzUwZWIzMzU1ZWIzZjhiNgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkYWMzNDA5Li44Y2M2NTg1 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDA5LTAyLTEzICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTU1CisgICAg ICAgIFY4SFRNTFBsdWdJbkN1c3RvbSByZXR1cm5zIHVuZGVmaW5lZCwgd2hpY2ggZm9vbHMgaW50 ZXJjZXB0b3JzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTFBsdWdJbkVs ZW1lbnRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TkFNRURfUFJPUEVSVFlfR0VUVEVS KTogUmV0dXJuCisgICAgICAgIChXZWJDb3JlOjpOQU1FRF9QUk9QRVJUWV9TRVRURVIpOgorICAg ICAgICAoV2ViQ29yZTo6SU5ERVhFRF9QUk9QRVJUWV9HRVRURVIpOgorICAgICAgICAoV2ViQ29y ZTo6SU5ERVhFRF9QUk9QRVJUWV9TRVRURVIpOgorCiAyMDA5LTAyLTEzICBBbnR0aSBLb2l2aXN0 byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0Lgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MUGx1Z0luRWxlbWVu dEN1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxQbHVnSW5FbGVt ZW50Q3VzdG9tLmNwcAppbmRleCA5MDY0YjI5Li40ZGYyMjYzIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxQbHVnSW5FbGVtZW50Q3VzdG9tLmNwcAorKysgYi9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxQbHVnSW5FbGVtZW50Q3VzdG9tLmNwcApA QCAtNDgsMTEgKzQ4LDExIEBAIE5BTUVEX1BST1BFUlRZX0dFVFRFUihIVE1MUGx1Z0luRWxlbWVu dCkKICAgICBIVE1MUGx1Z0luRWxlbWVudCogaW1wID0gVjhQcm94eTo6RE9NV3JhcHBlclRvTm9k ZTxIVE1MUGx1Z0luRWxlbWVudD4oaW5mby5Ib2xkZXIoKSk7CiAgICAgU2NyaXB0SW5zdGFuY2Ug c2NyaXB0SW5zdGFuY2UgPSBpbXAtPmdldEluc3RhbmNlKCk7CiAgICAgaWYgKCFzY3JpcHRJbnN0 YW5jZSkKLSAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKKyAgICAgICAgcmV0dXJuIHY4 OjpMb2NhbDx2ODo6T2JqZWN0PigpOwogCiAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGluc3Rh bmNlID0gdjg6OkxvY2FsPHY4OjpPYmplY3Q+OjpOZXcoc2NyaXB0SW5zdGFuY2UtPmluc3RhbmNl KCkpOwogICAgIGlmIChpbnN0YW5jZS5Jc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiB2ODo6VW5k ZWZpbmVkKCk7CisgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD4oKTsKIAogICAg IHJldHVybiBOUE9iamVjdEdldE5hbWVkUHJvcGVydHkoaW5zdGFuY2UsIG5hbWUpOwogfQpAQCAt NjMsMTEgKzYzLDExIEBAIE5BTUVEX1BST1BFUlRZX1NFVFRFUihIVE1MUGx1Z0luRWxlbWVudCkK ICAgICBIVE1MUGx1Z0luRWxlbWVudCogaW1wID0gVjhQcm94eTo6RE9NV3JhcHBlclRvTm9kZTxI VE1MUGx1Z0luRWxlbWVudD4oaW5mby5Ib2xkZXIoKSk7CiAgICAgU2NyaXB0SW5zdGFuY2Ugc2Ny aXB0SW5zdGFuY2UgPSBpbXAtPmdldEluc3RhbmNlKCk7CiAgICAgaWYgKCFzY3JpcHRJbnN0YW5j ZSkKLSAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKKyAgICAgICAgcmV0dXJuIHY4OjpM b2NhbDx2ODo6T2JqZWN0PigpOwogCiAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGluc3RhbmNl ID0gdjg6OkxvY2FsPHY4OjpPYmplY3Q+OjpOZXcoc2NyaXB0SW5zdGFuY2UtPmluc3RhbmNlKCkp OwogICAgIGlmIChpbnN0YW5jZS5Jc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiB2ODo6VW5kZWZp bmVkKCk7CisgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD4oKTsKIAogICAgIHJl dHVybiBOUE9iamVjdFNldE5hbWVkUHJvcGVydHkoaW5zdGFuY2UsIG5hbWUsIHZhbHVlKTsKIH0K QEAgLTg0LDExICs4NCwxMSBAQCBJTkRFWEVEX1BST1BFUlRZX0dFVFRFUihIVE1MUGx1Z0luRWxl bWVudCkKICAgICBIVE1MUGx1Z0luRWxlbWVudCogaW1wID0gVjhQcm94eTo6RE9NV3JhcHBlclRv Tm9kZTxIVE1MUGx1Z0luRWxlbWVudD4oaW5mby5Ib2xkZXIoKSk7CiAgICAgU2NyaXB0SW5zdGFu Y2Ugc2NyaXB0SW5zdGFuY2UgPSBpbXAtPmdldEluc3RhbmNlKCk7CiAgICAgaWYgKCFzY3JpcHRJ bnN0YW5jZSkKLSAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKKyAgICAgICAgcmV0dXJu IHY4OjpMb2NhbDx2ODo6T2JqZWN0PigpOwogCiAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGlu c3RhbmNlID0gdjg6OkxvY2FsPHY4OjpPYmplY3Q+OjpOZXcoc2NyaXB0SW5zdGFuY2UtPmluc3Rh bmNlKCkpOwogICAgIGlmIChpbnN0YW5jZS5Jc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiB2ODo6 VW5kZWZpbmVkKCk7CisgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD4oKTsKIAog ICAgIHJldHVybiBOUE9iamVjdEdldEluZGV4ZWRQcm9wZXJ0eShpbnN0YW5jZSwgaW5kZXgpOwog fQpAQCAtOTksMTEgKzk5LDExIEBAIElOREVYRURfUFJPUEVSVFlfU0VUVEVSKEhUTUxQbHVnSW5F bGVtZW50KQogICAgIEhUTUxQbHVnSW5FbGVtZW50KiBpbXAgPSBWOFByb3h5OjpET01XcmFwcGVy VG9Ob2RlPEhUTUxQbHVnSW5FbGVtZW50PihpbmZvLkhvbGRlcigpKTsKICAgICBTY3JpcHRJbnN0 YW5jZSBzY3JpcHRJbnN0YW5jZSA9IGltcC0+Z2V0SW5zdGFuY2UoKTsKICAgICBpZiAoIXNjcmlw dEluc3RhbmNlKQotICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOworICAgICAgICByZXR1 cm4gdjg6OkxvY2FsPHY4OjpPYmplY3Q+KCk7CiAKICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4g aW5zdGFuY2UgPSB2ODo6TG9jYWw8djg6Ok9iamVjdD46Ok5ldyhzY3JpcHRJbnN0YW5jZS0+aW5z dGFuY2UoKSk7CiAgICAgaWYgKGluc3RhbmNlLklzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIHY4 OjpVbmRlZmluZWQoKTsKKyAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6T2JqZWN0PigpOwog CiAgICAgcmV0dXJuIE5QT2JqZWN0U2V0SW5kZXhlZFByb3BlcnR5KGluc3RhbmNlLCBpbmRleCwg dmFsdWUpOwogfQo= 27674 2009-02-13 16:04:19 -0800 2009-02-13 21:05:50 -0800 V8HTMLPlugInCustom returns undefined, which fools interceptors, v2 V8HTMLPlugInCustom-returns-undefined-which-fools-interceptors-v2.patch text/plain 3293 dglazkov NDE1YjRlZjBmZDc4M2E4NWM0YTRmYjM4Y2QzNzAzMzhhMTdiODczOQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkYWMzNDA5Li44Y2M2NTg1 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDA5LTAyLTEzICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTU1CisgICAg ICAgIFY4SFRNTFBsdWdJbkN1c3RvbSByZXR1cm5zIHVuZGVmaW5lZCwgd2hpY2ggZm9vbHMgaW50 ZXJjZXB0b3JzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTFBsdWdJbkVs ZW1lbnRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TkFNRURfUFJPUEVSVFlfR0VUVEVS KTogUmV0dXJuCisgICAgICAgIChXZWJDb3JlOjpOQU1FRF9QUk9QRVJUWV9TRVRURVIpOgorICAg ICAgICAoV2ViQ29yZTo6SU5ERVhFRF9QUk9QRVJUWV9HRVRURVIpOgorICAgICAgICAoV2ViQ29y ZTo6SU5ERVhFRF9QUk9QRVJUWV9TRVRURVIpOgorCiAyMDA5LTAyLTEzICBBbnR0aSBLb2l2aXN0 byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0Lgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MUGx1Z0luRWxlbWVu dEN1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxQbHVnSW5FbGVt ZW50Q3VzdG9tLmNwcAppbmRleCA5MDY0YjI5Li40Y2QxOWQyIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxQbHVnSW5FbGVtZW50Q3VzdG9tLmNwcAorKysgYi9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxQbHVnSW5FbGVtZW50Q3VzdG9tLmNwcApA QCAtNDgsMTEgKzQ4LDExIEBAIE5BTUVEX1BST1BFUlRZX0dFVFRFUihIVE1MUGx1Z0luRWxlbWVu dCkKICAgICBIVE1MUGx1Z0luRWxlbWVudCogaW1wID0gVjhQcm94eTo6RE9NV3JhcHBlclRvTm9k ZTxIVE1MUGx1Z0luRWxlbWVudD4oaW5mby5Ib2xkZXIoKSk7CiAgICAgU2NyaXB0SW5zdGFuY2Ug c2NyaXB0SW5zdGFuY2UgPSBpbXAtPmdldEluc3RhbmNlKCk7CiAgICAgaWYgKCFzY3JpcHRJbnN0 YW5jZSkKLSAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKKyAgICAgICAgcmV0dXJuIGRl ZmVyVG9JbnRlcmNlcHRvcigpOwogCiAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGluc3RhbmNl ID0gdjg6OkxvY2FsPHY4OjpPYmplY3Q+OjpOZXcoc2NyaXB0SW5zdGFuY2UtPmluc3RhbmNlKCkp OwogICAgIGlmIChpbnN0YW5jZS5Jc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiB2ODo6VW5kZWZp bmVkKCk7CisgICAgICAgIHJldHVybiBkZWZlclRvSW50ZXJjZXB0b3IoKTsKIAogICAgIHJldHVy biBOUE9iamVjdEdldE5hbWVkUHJvcGVydHkoaW5zdGFuY2UsIG5hbWUpOwogfQpAQCAtNjMsMTEg KzYzLDExIEBAIE5BTUVEX1BST1BFUlRZX1NFVFRFUihIVE1MUGx1Z0luRWxlbWVudCkKICAgICBI VE1MUGx1Z0luRWxlbWVudCogaW1wID0gVjhQcm94eTo6RE9NV3JhcHBlclRvTm9kZTxIVE1MUGx1 Z0luRWxlbWVudD4oaW5mby5Ib2xkZXIoKSk7CiAgICAgU2NyaXB0SW5zdGFuY2Ugc2NyaXB0SW5z dGFuY2UgPSBpbXAtPmdldEluc3RhbmNlKCk7CiAgICAgaWYgKCFzY3JpcHRJbnN0YW5jZSkKLSAg ICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKKyAgICAgICAgcmV0dXJuIGRlZmVyVG9JbnRl cmNlcHRvcigpOwogCiAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGluc3RhbmNlID0gdjg6Okxv Y2FsPHY4OjpPYmplY3Q+OjpOZXcoc2NyaXB0SW5zdGFuY2UtPmluc3RhbmNlKCkpOwogICAgIGlm IChpbnN0YW5jZS5Jc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7Cisg ICAgICAgIHJldHVybiBkZWZlclRvSW50ZXJjZXB0b3IoKTsKIAogICAgIHJldHVybiBOUE9iamVj dFNldE5hbWVkUHJvcGVydHkoaW5zdGFuY2UsIG5hbWUsIHZhbHVlKTsKIH0KQEAgLTg0LDExICs4 NCwxMSBAQCBJTkRFWEVEX1BST1BFUlRZX0dFVFRFUihIVE1MUGx1Z0luRWxlbWVudCkKICAgICBI VE1MUGx1Z0luRWxlbWVudCogaW1wID0gVjhQcm94eTo6RE9NV3JhcHBlclRvTm9kZTxIVE1MUGx1 Z0luRWxlbWVudD4oaW5mby5Ib2xkZXIoKSk7CiAgICAgU2NyaXB0SW5zdGFuY2Ugc2NyaXB0SW5z dGFuY2UgPSBpbXAtPmdldEluc3RhbmNlKCk7CiAgICAgaWYgKCFzY3JpcHRJbnN0YW5jZSkKLSAg ICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKKyAgICAgICAgcmV0dXJuIGRlZmVyVG9JbnRl cmNlcHRvcigpOwogCiAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGluc3RhbmNlID0gdjg6Okxv Y2FsPHY4OjpPYmplY3Q+OjpOZXcoc2NyaXB0SW5zdGFuY2UtPmluc3RhbmNlKCkpOwogICAgIGlm IChpbnN0YW5jZS5Jc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7Cisg ICAgICAgIHJldHVybiBkZWZlclRvSW50ZXJjZXB0b3IoKTsKIAogICAgIHJldHVybiBOUE9iamVj dEdldEluZGV4ZWRQcm9wZXJ0eShpbnN0YW5jZSwgaW5kZXgpOwogfQpAQCAtOTksMTEgKzk5LDEx IEBAIElOREVYRURfUFJPUEVSVFlfU0VUVEVSKEhUTUxQbHVnSW5FbGVtZW50KQogICAgIEhUTUxQ bHVnSW5FbGVtZW50KiBpbXAgPSBWOFByb3h5OjpET01XcmFwcGVyVG9Ob2RlPEhUTUxQbHVnSW5F bGVtZW50PihpbmZvLkhvbGRlcigpKTsKICAgICBTY3JpcHRJbnN0YW5jZSBzY3JpcHRJbnN0YW5j ZSA9IGltcC0+Z2V0SW5zdGFuY2UoKTsKICAgICBpZiAoIXNjcmlwdEluc3RhbmNlKQotICAgICAg ICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOworICAgICAgICByZXR1cm4gZGVmZXJUb0ludGVyY2Vw dG9yKCk7CiAKICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4gaW5zdGFuY2UgPSB2ODo6TG9jYWw8 djg6Ok9iamVjdD46Ok5ldyhzY3JpcHRJbnN0YW5jZS0+aW5zdGFuY2UoKSk7CiAgICAgaWYgKGlu c3RhbmNlLklzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKKyAgICAg ICAgcmV0dXJuIGRlZmVyVG9JbnRlcmNlcHRvcigpOwogCiAgICAgcmV0dXJuIE5QT2JqZWN0U2V0 SW5kZXhlZFByb3BlcnR5KGluc3RhbmNlLCBpbmRleCwgdmFsdWUpOwogfQo=