23954 2009-02-13 12:33:19 -0800 Add V8 custom bindings for CanvasRenderingContext2D 2009-02-13 19:28:36 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov oldest_to_newest 109723 0 dglazkov 2009-02-13 12:33:19 -0800 Little by little. 109724 1 27667 dglazkov 2009-02-13 12:35:22 -0800 Created attachment 27667 Add V8 custom bindings for CanvasRenderingContext2D, v1 WebCore/ChangeLog | 13 +++ .../v8/custom/V8CanvasRenderingContext2DCustom.cpp | 95 ++++++++++++++++++++ 2 files changed, 108 insertions(+), 0 deletions(-) 109759 2 27667 eric 2009-02-13 17:13:44 -0800 Comment on attachment 27667 Add V8 custom bindings for CanvasRenderingContext2D, v1 LGTM. 109767 3 dglazkov 2009-02-13 19:28:36 -0800 Landed as http://trac.webkit.org/changeset/41016. 27667 2009-02-13 12:35:22 -0800 2009-02-13 17:13:44 -0800 Add V8 custom bindings for CanvasRenderingContext2D, v1 Add-V8-custom-bindings-for-CanvasRenderingContext2D-v1.patch text/plain 4575 dglazkov OGNkZGRiYWI5ZGMxNmMyNWY5MjMwYmJlYTlmODdjOWMzODVmZGE5OApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlZjYzNTg4Li5mNzM2Y2Vk IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDA5LTAyLTEzICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTU0CisgICAg ICAgIEFkZCBWOCBjdXN0b20gYmluZGluZ3MgZm9yIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC4K KworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOENhbnZhc1JlbmRlcmluZ0NvbnRleHQy REN1c3RvbS5jcHA6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6dG9WOCk6CisgICAgICAgIChX ZWJDb3JlOjp0b0NhbnZhc1N0eWxlKToKKyAgICAgICAgKFdlYkNvcmU6OkFDQ0VTU09SX0dFVFRF Uik6CisgICAgICAgIChXZWJDb3JlOjpBQ0NFU1NPUl9TRVRURVIpOgorCiAyMDA5LTAyLTEzICBE YXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmlj IFNlaWRlbApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDYW52YXNS ZW5kZXJpbmdDb250ZXh0MkRDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v VjhDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRDdXN0b20uY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLjA1NzBlMGUKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOENhbnZhc1JlbmRlcmluZ0NvbnRleHQyREN1c3RvbS5jcHAKQEAgLTAs MCArMSw5NSBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgorICogCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBl cm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1l dDoKKyAqIAorICogICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0 YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqICAgICAqIFJlZGlzdHJpYnV0aW9u cyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyAqIGNvcHlyaWdodCBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIKKyAqIGluIHRoZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlk ZWQgd2l0aCB0aGUKKyAqIGRpc3RyaWJ1dGlvbi4KKyAqICAgICAqIE5laXRoZXIgdGhlIG5hbWUg b2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBpdHMKKyAqIGNvbnRyaWJ1dG9ycyBtYXkg YmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisgKiB0 aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgor ICogCisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVS UyBBTkQgQ09OVFJJQlVUT1JTCisgKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVE IFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgVEhFIElNUExJ RUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisgKiBBIFBB UlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENP UFlSSUdIVAorICogT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVD VCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCisgKiBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNF UVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBQUk9D VVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyAq IERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVT RUQgQU5EIE9OIEFOWQorICogVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFD VCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9S IE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElT IFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFN QUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJDYW52YXNSZW5kZXJp bmdDb250ZXh0MkQuaCIKKworI2luY2x1ZGUgIkNhbnZhc0dyYWRpZW50LmgiCisjaW5jbHVkZSAi Q2FudmFzUGF0dGVybi5oIgorI2luY2x1ZGUgIkNhbnZhc1N0eWxlLmgiCisKKyNpbmNsdWRlICJW OEJpbmRpbmcuaCIKKyNpbmNsdWRlICJWOENhbnZhc0dyYWRpZW50LmgiCisjaW5jbHVkZSAiVjhD YW52YXNQYXR0ZXJuLmgiCisjaW5jbHVkZSAiVjhDdXN0b21CaW5kaW5nLmgiCisjaW5jbHVkZSAi VjhQcm94eS5oIgorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK3N0YXRpYyB2ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gdG9WOChDYW52YXNTdHlsZSogc3R5bGUpCit7CisgICAgaWYgKHN0eWxlLT5jYW52 YXNHcmFkaWVudCgpKQorICAgICAgICByZXR1cm4gVjhQcm94eTo6VG9WOE9iamVjdChWOENsYXNz SW5kZXg6OkNBTlZBU0dSQURJRU5ULCBzdHlsZS0+Y2FudmFzR3JhZGllbnQoKSk7CisKKyAgICBp ZiAoc3R5bGUtPmNhbnZhc1BhdHRlcm4oKSkKKyAgICAgICAgcmV0dXJuIFY4UHJveHk6OlRvVjhP YmplY3QoVjhDbGFzc0luZGV4OjpDQU5WQVNQQVRURVJOLCBzdHlsZS0+Y2FudmFzUGF0dGVybigp KTsKKworICAgIHJldHVybiB2OFN0cmluZyhzdHlsZS0+Y29sb3IoKSk7Cit9CisKK3N0YXRpYyBQ YXNzUmVmUHRyPENhbnZhc1N0eWxlPiB0b0NhbnZhc1N0eWxlKHY4OjpIYW5kbGU8djg6OlZhbHVl PiB2YWx1ZSkKK3sKKyAgICBpZiAodmFsdWUtPklzU3RyaW5nKCkpCisgICAgICAgIHJldHVybiBD YW52YXNTdHlsZTo6Y3JlYXRlKHRvV2ViQ29yZVN0cmluZyh2YWx1ZSkpOworCisgICAgaWYgKFY4 Q2FudmFzR3JhZGllbnQ6Okhhc0luc3RhbmNlKHZhbHVlKSkKKyAgICAgICAgcmV0dXJuIENhbnZh c1N0eWxlOjpjcmVhdGUoVjhQcm94eTo6RE9NV3JhcHBlclRvTmF0aXZlPENhbnZhc0dyYWRpZW50 Pih2YWx1ZSkpOworCisgICAgaWYgKFY4Q2FudmFzUGF0dGVybjo6SGFzSW5zdGFuY2UodmFsdWUp KQorICAgICAgICByZXR1cm4gQ2FudmFzU3R5bGU6OmNyZWF0ZShWOFByb3h5OjpET01XcmFwcGVy VG9OYXRpdmU8Q2FudmFzUGF0dGVybj4odmFsdWUpKTsKKworICAgIHJldHVybiAwOworfQorCitB Q0NFU1NPUl9HRVRURVIoQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEU3Ryb2tlU3R5bGUpCit7Cisg ICAgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEKiBpbXBsID0gVjhQcm94eTo6RE9NV3JhcHBlclRv TmF0aXZlPENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRD4oaW5mby5Ib2xkZXIoKSk7CisgICAgcmV0 dXJuIHRvVjgoaW1wbC0+c3Ryb2tlU3R5bGUoKSk7Cit9CisKK0FDQ0VTU09SX1NFVFRFUihDYW52 YXNSZW5kZXJpbmdDb250ZXh0MkRTdHJva2VTdHlsZSkKK3sKKyAgICBDYW52YXNSZW5kZXJpbmdD b250ZXh0MkQqIGltcGwgPSBWOFByb3h5OjpET01XcmFwcGVyVG9OYXRpdmU8Q2FudmFzUmVuZGVy aW5nQ29udGV4dDJEPihpbmZvLkhvbGRlcigpKTsKKyAgICBpbXBsLT5zZXRTdHJva2VTdHlsZSh0 b0NhbnZhc1N0eWxlKHZhbHVlKSk7Cit9CisKK0FDQ0VTU09SX0dFVFRFUihDYW52YXNSZW5kZXJp bmdDb250ZXh0MkRGaWxsU3R5bGUpCit7CisgICAgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEKiBp bXBsID0gVjhQcm94eTo6RE9NV3JhcHBlclRvTmF0aXZlPENhbnZhc1JlbmRlcmluZ0NvbnRleHQy RD4oaW5mby5Ib2xkZXIoKSk7CisgICAgcmV0dXJuIHRvVjgoaW1wbC0+ZmlsbFN0eWxlKCkpOwor fQorCitBQ0NFU1NPUl9TRVRURVIoQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJERmlsbFN0eWxlKQor eworICAgIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRCogaW1wbCA9IFY4UHJveHk6OkRPTVdyYXBw ZXJUb05hdGl2ZTxDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ+KGluZm8uSG9sZGVyKCkpOworICAg IGltcGwtPnNldEZpbGxTdHlsZSh0b0NhbnZhc1N0eWxlKHZhbHVlKSk7Cit9CisKK30gLy8gbmFt ZXNwYWNlIFdlYkNvcmUK