239529 2022-04-19 20:15:18 -0700 Remove unnecessary String allocations in CSSPrimitiveValue::unitTypeString 2022-04-19 22:33:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=239483 InRadar P2 Normal --- 1 achristensen achristensen cdumez esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard webkit-bug-importer oldest_to_newest 1862809 0 achristensen 2022-04-19 20:15:18 -0700 Remove unnecessary String allocations in CSSPrimitiveValue::unitTypeString 1862812 1 457954 achristensen 2022-04-19 20:16:04 -0700 Created attachment 457954 Patch 1862815 2 457954 cdumez 2022-04-19 20:54:09 -0700 Comment on attachment 457954 Patch r=me 1862826 3 ews-feeder 2022-04-19 22:32:43 -0700 Committed r293062 (249793@main): <https://commits.webkit.org/249793@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457954. 1862827 4 webkit-bug-importer 2022-04-19 22:33:13 -0700 <rdar://problem/92007015> 457954 2022-04-19 20:16:04 -0700 2022-04-19 22:32:44 -0700 Patch bug-239529-20220419201603.patch text/plain 4472 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzMDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2FmYTJiOGIwMDczYzUw ZjlmZDFlMDYxNjVkNWYyY2M2OGZhZDNkMS4uZjEzODYzNmFkM2YwMzRlNjczMjFlZDY4ZWU2NDUx MDJhOWZmNGY4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTA0LTE5ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3Zl IHVubmVjZXNzYXJ5IFN0cmluZyBhbGxvY2F0aW9ucyBpbiBDU1NQcmltaXRpdmVWYWx1ZTo6dW5p dFR5cGVTdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzOTUyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1By aW1pdGl2ZVZhbHVlOjp1bml0VHlwZVN0cmluZyk6CisgICAgICAgICogY3NzL0NTU1ByaW1pdGl2 ZVZhbHVlLmg6CisgICAgICAgICogY3NzL3R5cGVkb20vQ1NTVW5pdFZhbHVlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNTU1VuaXRWYWx1ZTo6dW5pdCBjb25zdCk6CisgICAgICAgIChXZWJDb3Jl OjpDU1NVbml0VmFsdWU6OnVuaXRTZXJpYWxpemF0aW9uIGNvbnN0KToKKyAgICAgICAgKiBjc3Mv dHlwZWRvbS9DU1NVbml0VmFsdWUuaDoKKwogMjAyMi0wNC0xOSAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlcGxhY2UgU3RyaW5nOjpyZXBsYWNlV2l0aExpdGVy YWwoKSB3aXRoIGEgU3RyaW5nOjpyZXBsYWNlKCkgb3ZlcmxvYWQgdGhhdCB0YWtlcyBpbiBhbiBB U0NJSUxpdGVyYWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVW YWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCmluZGV4 IGExZjQ4MjM5YmE4MGJiYjQxMGU3OGRhNmZhMTc2NjZkMDQ1MWFmNjEuLjIzZjIzNDYyMDRmZjgz ZjhlN2YyYTFhOWNmODYwZWY0ZWMwYTk4N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1p dGl2ZVZhbHVlLmNwcApAQCAtMTIzOSw4ICsxMjM5LDcgQEAgTkVWRVJfSU5MSU5FIFN0cmluZyBD U1NQcmltaXRpdmVWYWx1ZTo6Zm9ybWF0SW50ZWdlclZhbHVlKFN0cmluZ1ZpZXcgc3VmZml4KSBj b24KICAgICByZXR1cm4gbWFrZVN0cmluZyhtX3ZhbHVlLm51bSwgc3VmZml4KTsKIH0KIAotLy8g RklYTUU6IFNob3VsZCByZXR1cm4gY29uc3QgY2hhciouCi1TdHJpbmcgQ1NTUHJpbWl0aXZlVmFs dWU6OnVuaXRUeXBlU3RyaW5nKENTU1VuaXRUeXBlIHVuaXRUeXBlKQorQVNDSUlMaXRlcmFsIENT U1ByaW1pdGl2ZVZhbHVlOjp1bml0VHlwZVN0cmluZyhDU1NVbml0VHlwZSB1bml0VHlwZSkKIHsK ICAgICBzd2l0Y2ggKHVuaXRUeXBlKSB7CiAgICAgICAgIGNhc2UgQ1NTVW5pdFR5cGU6OkNTU19Q RVJDRU5UQUdFOiByZXR1cm4gIiUiX3M7CkBAIC0xMzI2LDEwICsxMzI1LDEwIEBAIFN0cmluZyBD U1NQcmltaXRpdmVWYWx1ZTo6dW5pdFR5cGVTdHJpbmcoQ1NTVW5pdFR5cGUgdW5pdFR5cGUpCiAg ICAgICAgIGNhc2UgQ1NTVW5pdFR5cGU6OkNTU19QUk9QRVJUWV9JRDoKICAgICAgICAgY2FzZSBD U1NVbml0VHlwZTo6Q1NTX1ZBTFVFX0lEOgogICAgICAgICBjYXNlIENTU1VuaXRUeXBlOjpDU1Nf UVVJUktZX0VNUzoKLSAgICAgICAgICAgIHJldHVybiBlbXB0eVN0cmluZygpOworICAgICAgICAg ICAgcmV0dXJuICIiX3M7CiAgICAgfQogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgIHJl dHVybiBlbXB0eVN0cmluZygpOworICAgIHJldHVybiAiIl9zOwogfQogCiBBTFdBWVNfSU5MSU5F IFN0cmluZyBDU1NQcmltaXRpdmVWYWx1ZTo6Zm9ybWF0TnVtYmVyRm9yQ3VzdG9tQ1NTVGV4dCgp IGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUu aCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5oCmluZGV4IGZiYjY3Njk4 YjU3NDEzZWMyM2I0NDcxNjM1OTg0Y2YwNDM4ZWY5MTQuLmNmZWQyY2ExYzg5ODJiNGUwMjg1YmM5 NjAyNGMwZDM3MWJlMzE4YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmlt aXRpdmVWYWx1ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5o CkBAIC0xOTUsNyArMTk1LDcgQEAgcHVibGljOgogICAgIGJvb2wgZXF1YWxzKGNvbnN0IENTU1By aW1pdGl2ZVZhbHVlJikgY29uc3Q7CiAKICAgICBzdGF0aWMgc3RkOjpvcHRpb25hbDxkb3VibGU+ IGNvbnZlcnNpb25Ub0Nhbm9uaWNhbFVuaXRzU2NhbGVGYWN0b3IoQ1NTVW5pdFR5cGUpOwotICAg IHN0YXRpYyBTdHJpbmcgdW5pdFR5cGVTdHJpbmcoQ1NTVW5pdFR5cGUpOworICAgIHN0YXRpYyBB U0NJSUxpdGVyYWwgdW5pdFR5cGVTdHJpbmcoQ1NTVW5pdFR5cGUpOwogCiAgICAgc3RhdGljIGRv dWJsZSBjb21wdXRlVW56b29tZWROb25DYWxjTGVuZ3RoRG91YmxlKENTU1VuaXRUeXBlLCBkb3Vi bGUgdmFsdWUsIENTU1Byb3BlcnR5SUQsIGNvbnN0IEZvbnRNZXRyaWNzKiA9IG51bGxwdHIsIGNv bnN0IEZvbnRDYXNjYWRlRGVzY3JpcHRpb24qID0gbnVsbHB0ciwgY29uc3QgRm9udENhc2NhZGVE ZXNjcmlwdGlvbiogcm9vdEZvbnREZXNjcmlwdGlvbiA9IG51bGxwdHIsIGNvbnN0IFJlbmRlclZp ZXcqID0gbnVsbHB0cik7CiAgICAgc3RhdGljIGRvdWJsZSBjb21wdXRlTm9uQ2FsY0xlbmd0aERv dWJsZShjb25zdCBDU1NUb0xlbmd0aENvbnZlcnNpb25EYXRhJiwgQ1NTVW5pdFR5cGUsIGRvdWJs ZSB2YWx1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvdHlwZWRvbS9DU1NVbml0 VmFsdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL3R5cGVkb20vQ1NTVW5pdFZhbHVlLmNwcApp bmRleCBmZDMyNDg4ZTY1YTEzM2FmYjRmMmRlZGI0OGNlMmM1Mjc4ZThjNWVhLi4zZTIwMThkZTY2 ZGZmZWUxMWRhMjg1MzA2NzlkODQyY2EwODM4YjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvdHlwZWRvbS9DU1NVbml0VmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy90 eXBlZG9tL0NTU1VuaXRWYWx1ZS5jcHAKQEAgLTkzLDcgKzkzLDcgQEAgc3RhdGljIENTU1VuaXRU eXBlIHBhcnNlVW5pdChjb25zdCBTdHJpbmcmIHVuaXQpCiAgICAgcmV0dXJuIENTU1BhcnNlclRv a2VuOjpzdHJpbmdUb1VuaXRUeXBlKHVuaXQpOwogfQogCi1TdHJpbmcgQ1NTVW5pdFZhbHVlOjp1 bml0KCkgY29uc3QKK0FTQ0lJTGl0ZXJhbCBDU1NVbml0VmFsdWU6OnVuaXQoKSBjb25zdAogewog ICAgIHN3aXRjaCAobV91bml0KSB7CiAgICAgY2FzZSBDU1NVbml0VHlwZTo6Q1NTX05VTUJFUjoK QEAgLTEwNiw3ICsxMDYsNyBAQCBTdHJpbmcgQ1NTVW5pdFZhbHVlOjp1bml0KCkgY29uc3QKICAg ICByZXR1cm4gdW5pdFNlcmlhbGl6YXRpb24oKTsKIH0KIAotU3RyaW5nIENTU1VuaXRWYWx1ZTo6 dW5pdFNlcmlhbGl6YXRpb24oKSBjb25zdAorQVNDSUlMaXRlcmFsIENTU1VuaXRWYWx1ZTo6dW5p dFNlcmlhbGl6YXRpb24oKSBjb25zdAogewogICAgIHJldHVybiBDU1NQcmltaXRpdmVWYWx1ZTo6 dW5pdFR5cGVTdHJpbmcobV91bml0KTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nz cy90eXBlZG9tL0NTU1VuaXRWYWx1ZS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL3R5cGVkb20vQ1NT VW5pdFZhbHVlLmgKaW5kZXggZWQwMjVjYzE4Y2Y1ZmIzZDVkODc3YzBjZmRkNGVhZDc2YzVmNTIw ZS4uYWZjYzhlNDM1MjYyNTE5NzA2YmVhYzAyMGViYTIxN2VmN2VjZTFhOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL3R5cGVkb20vQ1NTVW5pdFZhbHVlLmgKKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL3R5cGVkb20vQ1NTVW5pdFZhbHVlLmgKQEAgLTQ2LDggKzQ2LDggQEAgcHVibGlj OgogCiAgICAgZG91YmxlIHZhbHVlKCkgY29uc3QgeyByZXR1cm4gbV92YWx1ZTsgfQogICAgIHZv aWQgc2V0VmFsdWUoZG91YmxlIHZhbHVlKSB7IG1fdmFsdWUgPSB2YWx1ZTsgfQotICAgIFN0cmlu ZyB1bml0KCkgY29uc3Q7Ci0gICAgU3RyaW5nIHVuaXRTZXJpYWxpemF0aW9uKCkgY29uc3Q7Cisg ICAgQVNDSUlMaXRlcmFsIHVuaXQoKSBjb25zdDsKKyAgICBBU0NJSUxpdGVyYWwgdW5pdFNlcmlh bGl6YXRpb24oKSBjb25zdDsKICAgICBDU1NVbml0VHlwZSB1bml0RW51bSgpIGNvbnN0IHsgcmV0 dXJuIG1fdW5pdDsgfQogCiBwcml2YXRlOgo=