239474 2022-04-18 16:49:22 -0700 [ macOS ] TestWebKitAPI.WebKit2.SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPageE is a flaky crash 2022-06-16 00:20:58 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rackler achristensen achristensen sihui_liu webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1862371 0 rackler 2022-04-18 16:49:22 -0700 Description: This API test is a flaky crash on [ macOS ] bots The first crash that I see on the dashboard for Monterey was 3/18/2022 at r291517, and for BigSur 2/22/2022 at r290314. There was not one commit that I observe causing this issue. This test seems to have been flaky since the start. History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit2.SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPage&limit=50000&platform=mac Crash Log: Bot failed to capture the crash log with: Test suite failed Crashed TestWebKitAPI.WebKit2.SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPage Pulled the crash log off the bot: Thread 4 Crashed:: Dispatch queue: MockAudioSharedUnit Capture Queue 0 WebCore 0x115aac6b4 _cxx_atomic_fetch_add<unsigned int> + 0 (atomic:1061) [inlined] 1 WebCore 0x115aac6b4 fetch_add + 0 (atomic:1748) [inlined] 2 WebCore 0x115aac6b4 operator++ + 0 (atomic:1785) [inlined] 3 WebCore 0x115aac6b4 ref + 0 (ThreadSafeRefCounted.h:60) [inlined] 4 WebCore 0x115aac6b4 Ref + 8 (Ref.h:67) [inlined] 5 WebCore 0x115aac6b4 Ref + 8 (Ref.h:66) [inlined] 6 WebCore 0x115aac6b4 WebCore::AudioSampleDataSource::AudioSampleDataSource(unsigned long, WTF::LoggerHelper&, unsigned long) + 176 (AudioSampleDataSource.mm:57) 1862372 1 webkit-bug-importer 2022-04-18 16:49:44 -0700 <rdar://problem/91927019> 1862389 2 rackler 2022-04-18 17:51:57 -0700 REPRODUCTION STEPS ToT run-api-tests --root --debug 1876103 3 achristensen 2022-06-15 15:47:28 -0700 Thread 6 Crashed:: Dispatch queue: MockAudioSharedInternalUnit Capture Queue 0 WebCore 0x111279360 unsigned int std::__1::__cxx_atomic_fetch_add<unsigned int>(std::__1::__cxx_atomic_base_impl<unsigned int>*, unsigned int, std::__1::memory_order) + 0 (atomic:1050) [inlined] 1 WebCore 0x111279360 std::__1::__atomic_base<unsigned int, true>::fetch_add(unsigned int, std::__1::memory_order) + 0 (atomic:1719) [inlined] 2 WebCore 0x111279360 std::__1::__atomic_base<unsigned int, true>::operator++() + 0 (atomic:1756) [inlined] 3 WebCore 0x111279360 WTF::ThreadSafeRefCountedBase::ref() const + 0 (ThreadSafeRefCounted.h:60) [inlined] 4 WebCore 0x111279360 WTF::Ref<WTF::Logger const, WTF::RawPtrTraits<WTF::Logger const> >::Ref(WTF::Logger const&) + 8 (Ref.h:67) [inlined] 5 WebCore 0x111279360 WTF::Ref<WTF::Logger const, WTF::RawPtrTraits<WTF::Logger const> >::Ref(WTF::Logger const&) + 8 (Ref.h:66) [inlined] 6 WebCore 0x111279360 WebCore::AudioSampleDataSource::AudioSampleDataSource(unsigned long, WTF::LoggerHelper&, unsigned long) + 196 (AudioSampleDataSource.mm:57) 7 WebCore 0x111279358 WebCore::AudioSampleDataSource::AudioSampleDataSource(unsigned long, WTF::LoggerHelper&, unsigned long) + 188 (AudioSampleDataSource.mm:57) 8 WebCore 0x111279270 WebCore::AudioSampleDataSource::AudioSampleDataSource(unsigned long, WTF::LoggerHelper&, unsigned long) + 16 (AudioSampleDataSource.mm:60) [inlined] 9 WebCore 0x111279270 WebCore::AudioSampleDataSource::create(unsigned long, WTF::LoggerHelper&, unsigned long) + 64 (AudioSampleDataSource.mm:49) 10 WebCore 0x11169cc5c WebCore::SpeechRecognitionCaptureSourceImpl::updateDataSource(WebCore::CAAudioStreamDescription const&) + 96 (SpeechRecognitionCaptureSourceImpl.cpp:91) 11 WebCore 0x11169d040 WebCore::SpeechRecognitionCaptureSourceImpl::audioSamplesAvailable(WTF::MediaTime const&, WebCore::PlatformAudioData const&, WebCore::AudioStreamDescription const&, unsigned long) + 128 (SpeechRecognitionCaptureSourceImpl.cpp:135) 12 WebCore 0x1122d6f34 WebCore::RealtimeMediaSource::audioSamplesAvailable(WTF::MediaTime const&, WebCore::PlatformAudioData const&, WebCore::AudioStreamDescription const&, unsigned long) + 392 (RealtimeMediaSource.cpp:224) 13 WebCore 0x1122fe14c WebCore::BaseAudioSharedUnit::audioSamplesAvailable(WTF::MediaTime const&, WebCore::PlatformAudioData const&, WebCore::AudioStreamDescription const&, unsigned long) + 60 (BaseAudioSharedUnit.cpp:277) [inlined] 14 WebCore 0x1122fe14c WebCore::CoreAudioSharedUnit::processMicrophoneSamples(unsigned int&, AudioTimeStamp const&, unsigned int, unsigned int, AudioBufferList*) + 568 (CoreAudioSharedUnit.cpp:452) 15 WebCore 0x1115b0d1c WebCore::MockAudioSharedInternalUnit::emitSampleBuffers(unsigned int) + 156 (MockAudioSharedUnit.mm:296) [inlined] 16 WebCore 0x1115b0d1c WebCore::MockAudioSharedInternalUnit::generateSampleBuffers(WTF::MonotonicTime) + 1128 (MockAudioSharedUnit.mm:334) 17 JavaScriptCore 0x105a893b0 WTF::Function<void ()>::operator()() const + 16 (Function.h:82) [inlined] 18 JavaScriptCore 0x105a893b0 WTF::(anonymous namespace)::DispatchWorkItem::operator()() + 16 (WorkQueueCocoa.cpp:40) [inlined] 19 JavaScriptCore 0x105a893b0 void WTF::dispatchWorkItem<WTF::(anonymous namespace)::DispatchWorkItem>(void*) + 32 (WorkQueueCocoa.cpp:48) 20 libdispatch.dylib 0x189aca1c8 _dispatch_client_callout + 20 21 libdispatch.dylib 0x189ad18a8 _dispatch_lane_serial_drain + 668 22 libdispatch.dylib 0x189ad2404 _dispatch_lane_invoke + 392 23 libdispatch.dylib 0x189adcc98 _dispatch_workloop_worker_thread + 648 24 libsystem_pthread.dylib 0x189c8a360 _pthread_wqthread + 288 25 libsystem_pthread.dylib 0x189c89080 start_wqthread + 8 1876116 4 460263 achristensen 2022-06-15 16:45:49 -0700 Created attachment 460263 Patch 1876122 5 460263 sihui_liu 2022-06-15 17:29:58 -0700 Comment on attachment 460263 Patch r=me, thanks for fixing! 1876202 6 ews-feeder 2022-06-16 00:20:57 -0700 Committed r295588 (251593@main): <https://commits.webkit.org/251593@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460263. 460263 2022-06-15 16:45:49 -0700 2022-06-16 00:20:57 -0700 Patch bug-239474-20220615164548.patch text/plain 2242 achristensen RnJvbSA3ZWY5NDAyYTdlZjA4ZWJiOWYwNWMzNmQ4YTFiODRiMzIzYWNiM2I3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IENocmlzdGVuc2VuIDxhY2hyaXN0ZW5zZW5AYXBwbGUu Y29tPgpEYXRlOiBXZWQsIDE1IEp1biAyMDIyIDE2OjQwOjU4IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gWyBtYWNPUyBdCiBUZXN0V2ViS2l0QVBJLldlYktpdDIuU3BlZWNoUmVjb2duaXRpb25FcnJv cldoZW5TdGFydGluZ0F1ZGlvQ2FwdHVyZU9uRGlmZmVyZW50UGFnZUUKIGlzIGEgZmxha3kgY3Jh c2ggaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTQ3NAoKUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpBdCBsZWFzdCB3aGVuIHVzaW5nIE1vY2tBdWRpb1NoYXJl ZEludGVybmFsVW5pdCB0aGUgY2FsbCB0byBSZWFsdGltZU1lZGlhU291cmNlOjpzdGFydCBjYW4g Y2FsbCBjb2RlIG9uIGFub3RoZXIgdGhyZWFkCnRoYXQgYXNzdW1lcyB0aGF0IFJlYWx0aW1lTWVk aWFTb3VyY2U6OnNldExvZ2dlciBoYXMgYWxyZWFkeSBiZWVuIGNhbGxlZC4gIFRoaXMgY2FuIGJl IG1hZGUgdG8gY3Jhc2ggYWxtb3N0IDEwMCUgb2YgdGhlIHRpbWUKaW4gdGhlIHRlc3QgYnkgYWRk aW5nIFdURlJlcG9ydEJhY2t0cmFjZSBhdCB0aGUgYmVnaW5uaW5nIG9mIFJlYWx0aW1lTWVkaWFT b3VyY2U6OnNldExvZ2dlciB3aGljaCBkZWxheXMgd2hlbiBtX2xvZ2dlciBpcyBzZXQKZW5vdWdo IGZvciB0aGUgIk1vY2tBdWRpb1NoYXJlZEludGVybmFsVW5pdCBDYXB0dXJlIFF1ZXVlIiB0aHJl YWQgdG8gcmVhZCBmcm9tIG1fbG9nZ2VyIGJlZm9yZSBpdCBpcyB3cml0dGVuIHdpdGhvdXQgdGhp cyBjaGFuZ2UuCgoqIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL1NwZWVjaFJlY29nbml0 aW9uQ2FwdHVyZVNvdXJjZUltcGwuY3BwOgooV2ViQ29yZTo6U3BlZWNoUmVjb2duaXRpb25DYXB0 dXJlU291cmNlSW1wbDo6U3BlZWNoUmVjb2duaXRpb25DYXB0dXJlU291cmNlSW1wbCk6Ci0tLQog Li4uL01vZHVsZXMvc3BlZWNoL1NwZWVjaFJlY29nbml0aW9uQ2FwdHVyZVNvdXJjZUltcGwuY3Bw IHwgOCArKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3NwZWVjaC9TcGVlY2hS ZWNvZ25pdGlvbkNhcHR1cmVTb3VyY2VJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv c3BlZWNoL1NwZWVjaFJlY29nbml0aW9uQ2FwdHVyZVNvdXJjZUltcGwuY3BwCmluZGV4IDYwNzUz ZmVjZTM1YS4uYzhmNTM5N2M2MDk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3NwZWVjaC9TcGVlY2hSZWNvZ25pdGlvbkNhcHR1cmVTb3VyY2VJbXBsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3NwZWVjaC9TcGVlY2hSZWNvZ25pdGlvbkNhcHR1cmVTb3VyY2VJ bXBsLmNwcApAQCAtNTcsMTAgKzU3LDYgQEAgU3BlZWNoUmVjb2duaXRpb25DYXB0dXJlU291cmNl SW1wbDo6U3BlZWNoUmVjb2duaXRpb25DYXB0dXJlU291cmNlSW1wbChTcGVlY2hSZWMKICAgICAs IG1fc3RhdGVVcGRhdGVDYWxsYmFjayhXVEZNb3ZlKHN0YXRlVXBkYXRlQ2FsbGJhY2spKQogICAg ICwgbV9zb3VyY2UoV1RGTW92ZShzb3VyY2UpKQogewotICAgIG1fc291cmNlLT5hZGRBdWRpb1Nh bXBsZU9ic2VydmVyKCp0aGlzKTsKLSAgICBtX3NvdXJjZS0+YWRkT2JzZXJ2ZXIoKnRoaXMpOwot ICAgIG1fc291cmNlLT5zdGFydCgpOwotCiAjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECiAgICAg aWYgKCFudWxsTG9nZ2VyKCkuZ2V0KCkpIHsKICAgICAgICAgbnVsbExvZ2dlcigpID0gTG9nZ2Vy OjpjcmVhdGUodGhpcyk7CkBAIC03MCw2ICs2NiwxMCBAQCBTcGVlY2hSZWNvZ25pdGlvbkNhcHR1 cmVTb3VyY2VJbXBsOjpTcGVlY2hSZWNvZ25pdGlvbkNhcHR1cmVTb3VyY2VJbXBsKFNwZWVjaFJl YwogICAgIG1fc291cmNlLT5zZXRMb2dnZXIoKm51bGxMb2dnZXIoKSwgbmV4dExvZ0lkZW50aWZp ZXIoKSk7CiAjZW5kaWYKIAorICAgIG1fc291cmNlLT5hZGRBdWRpb1NhbXBsZU9ic2VydmVyKCp0 aGlzKTsKKyAgICBtX3NvdXJjZS0+YWRkT2JzZXJ2ZXIoKnRoaXMpOworICAgIG1fc291cmNlLT5z dGFydCgpOworCiAgICAgaW5pdGlhbGl6ZVdlYWtQdHJGYWN0b3J5KCk7CiB9CiAKLS0gCjIuMzIu MCAoQXBwbGUgR2l0LTEzMikKCg==