239456 2022-04-18 11:16:26 -0700 Remove the deprecated CaptivePortal enablement key 2022-04-18 14:38:49 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham webkit-bug-importer wenson_hsieh oldest_to_newest 1862269 0 bfulgham 2022-04-18 11:16:26 -0700 Remove the temporary "WebKitCaptivePortalModeEnabled" preference as we now have a real preference to handle this use case. 1862270 1 457812 bfulgham 2022-04-18 11:19:02 -0700 Created attachment 457812 Patch 1862271 2 bfulgham 2022-04-18 11:21:58 -0700 <rdar://88486480> 1862278 3 457812 wenson_hsieh 2022-04-18 11:57:27 -0700 Comment on attachment 457812 Patch rs=me 1862290 4 bfulgham 2022-04-18 12:35:40 -0700 It looks like the gtk-wk2 build failure is unrelated to this patch (some kind of out-of-space issue). 1862320 5 ews-feeder 2022-04-18 14:38:46 -0700 Committed r292972 (249735@main): <https://commits.webkit.org/249735@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457812. 457812 2022-04-18 11:19:02 -0700 2022-04-18 14:38:48 -0700 Patch bug-239456-20220418111901.patch text/plain 3591 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyOTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNmMTNkNjVkOTUwZmQ5OGI3 NTNiODRkNDhhYmM1NzdiNTIxZjkwNWMuLjlkMWY5MzMyYjYxYjQ4ODAwMjgzNzFhYzA0YTNkMDk4 Y2E0NDFmNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjItMDQtMTggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHRoZSBkZXByZWNh dGVkIENhcHRpdmVQb3J0YWwgZW5hYmxlbWVudCBrZXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTQ1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYSBtaW5vciBjb2RlIGNsZWFudXAgdG8g cmVtb3ZlIGFuIG9sZCBkZWZhdWx0IGtleQorICAgICAgICB3ZSB1c2VkIGluIHRoZSBlYXJseSBl eHBlcmltZW50cyB3aXRoIHRoaXMgYmVoYXZpb3IuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL19XS1N5c3RlbVByZWZlcmVuY2VzLm1tOgorICAgICAgICAoK1tfV0tTeXN0ZW1QcmVm ZXJlbmNlcyBpc0NhcHRpdmVQb3J0YWxNb2RlRW5hYmxlZF0pOgorICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvQ29jb2EvX1dLU3lzdGVtUHJlZmVyZW5jZXNJbnRlcm5hbC5oOgorICAgICAgICAqIFVJ UHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpX ZWJQcm9jZXNzUG9vbDo6bm90aWZ5UHJlZmVyZW5jZXNDaGFuZ2VkKToKKwogMjAyMi0wNC0xOCAg RWxsaW90dCBXaWxsaWFtcyAgPGVtd0BhcHBsZS5jb20+CiAKICAgICAgICAgW1hDQnVpbGRdIFVz ZSBYQ0J1aWxkIGZvciBhbGwgY29tbWFuZC1saW5lIGFuZCBwcm9qZWN0IGJ1aWxkcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1N5c3RlbVByZWZlcmVu Y2VzLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1N5c3RlbVByZWZl cmVuY2VzLm1tCmluZGV4IGQ4MGUyNTgxMTQ5YTljZTM4ZTI4NDJkYTEyYjEzMGIxN2YyNjVhM2Iu LjQ5ZTA2MGQ1YjdhNGEzMTMyMmYwZDk0OGVkZGYwMGU3YzIzZGRhZjggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tTeXN0ZW1QcmVmZXJlbmNlcy5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLU3lzdGVtUHJlZmVyZW5j ZXMubW0KQEAgLTQwLDkgKzQwLDYgQEAgY29uc3RleHByIGF1dG8gQ2FwdGl2ZVBvcnRhbENvbmZp Z3VyYXRpb25JZ25vcmVGaWxlTmFtZSA9IEAiY29tLmFwcGxlLldlYktpdC5jcG0KICAgICBpZiAo cHJlZmVyZW5jZVZhbHVlLmdldCgpID09IGtDRkJvb2xlYW5UcnVlKQogICAgICAgICByZXR1cm4g dHJ1ZTsKIAotICAgIGlmIChbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBi b29sRm9yS2V5OltOU1N0cmluZyBzdHJpbmdXaXRoVVRGOFN0cmluZzpXZWJLaXRDYXB0aXZlUG9y dGFsTW9kZUNoYW5nZWROb3RpZmljYXRpb25fTGVnYWN5XV0pCi0gICAgICAgIHJldHVybiB0cnVl OwotCiAgICAga2V5ID0gYWRvcHRDRihDRlN0cmluZ0NyZWF0ZVdpdGhDU3RyaW5nKGtDRkFsbG9j YXRvckRlZmF1bHQsIExETUVuYWJsZWRLZXksIGtDRlN0cmluZ0VuY29kaW5nVVRGOCkpOwogICAg IHByZWZlcmVuY2VWYWx1ZSA9IGFkb3B0Q0YoQ0ZQcmVmZXJlbmNlc0NvcHlWYWx1ZShrZXkuZ2V0 KCksIGtDRlByZWZlcmVuY2VzQW55QXBwbGljYXRpb24sIGtDRlByZWZlcmVuY2VzQ3VycmVudFVz ZXIsIGtDRlByZWZlcmVuY2VzQW55SG9zdCkpOwogICAgIHJldHVybiBwcmVmZXJlbmNlVmFsdWUu Z2V0KCkgPT0ga0NGQm9vbGVhblRydWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQ29jb2EvX1dLU3lzdGVtUHJlZmVyZW5jZXNJbnRlcm5hbC5oIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1N5c3RlbVByZWZlcmVuY2VzSW50ZXJuYWwuaApp bmRleCBjMjM1N2Q5YzRlYzc0MTI4YzI5NzhiNjk2MzllNjNiYzgyNzQxMDcyLi5kZDJkNDYyZmQx ODRlNmE3ZDExYTAwZDgxNDhjY2IxZGEzMGY0ZmM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLU3lzdGVtUHJlZmVyZW5jZXNJbnRlcm5hbC5oCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tTeXN0ZW1QcmVmZXJlbmNlc0lu dGVybmFsLmgKQEAgLTI3LDUgKzI3LDQgQEAKIAogY29uc3RleHByIGF1dG8gTERNRW5hYmxlZEtl eSA9ICJMRE1HbG9iYWxFbmFibGVkIjsKIGNvbnN0ZXhwciBhdXRvIFdLQ2FwdGl2ZVBvcnRhbE1v ZGVFbmFibGVkS2V5ID0gIldLQ2FwdGl2ZVBvcnRhbE1vZGVFbmFibGVkIjsKLWNvbnN0ZXhwciBh dXRvIFdlYktpdENhcHRpdmVQb3J0YWxNb2RlQ2hhbmdlZE5vdGlmaWNhdGlvbl9MZWdhY3kgPSAi V2ViS2l0Q2FwdGl2ZVBvcnRhbE1vZGVFbmFibGVkIjsKIGNvbnN0ZXhwciBhdXRvIFdLQ2FwdGl2 ZVBvcnRhbE1vZGVDb250YWluZXJDb25maWd1cmF0aW9uQ2hhbmdlZE5vdGlmaWNhdGlvbiA9IEAi V0tDYXB0aXZlUG9ydGFsTW9kZUNvbnRhaW5lckNvbmZpZ3VyYXRpb25DaGFuZ2VkIjsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2Eu bW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1t CmluZGV4IGZkZDhlZjY0YTE0N2NiMWExYWZiOTUwYTkzODMyN2I5OTMyZmFiMDEuLjA2ZjY5NzY4 YTg2NWVmMDRhNjZlZmRmYzg4YzA2OWE2YTFjYWIwNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbQpAQCAtMTA4Miw3ICsx MDgyLDcgQEAgdm9pZCBXZWJQcm9jZXNzUG9vbDo6bm90aWZ5UHJlZmVyZW5jZXNDaGFuZ2VkKGNv bnN0IFN0cmluZyYgZG9tYWluLCBjb25zdCBTdHJpbmcKICAgICAgICAgICAgIG5ldHdvcmtQcm9j ZXNzLT5zZW5kKE1lc3NhZ2VzOjpOZXR3b3JrUHJvY2Vzczo6Tm90aWZ5UHJlZmVyZW5jZXNDaGFu Z2VkKGRvbWFpbiwga2V5LCBlbmNvZGVkVmFsdWUpLCAwKTsKICAgICB9KTsKIAotICAgIGlmIChr ZXkgPT0gV0tDYXB0aXZlUG9ydGFsTW9kZUVuYWJsZWRLZXkgfHwga2V5ID09IFdlYktpdENhcHRp dmVQb3J0YWxNb2RlQ2hhbmdlZE5vdGlmaWNhdGlvbl9MZWdhY3kpCisgICAgaWYgKGtleSA9PSBX S0NhcHRpdmVQb3J0YWxNb2RlRW5hYmxlZEtleSkKICAgICAgICAgY2FwdGl2ZVBvcnRhbE1vZGVT dGF0ZUNoYW5nZWQoKTsKIH0KICNlbmRpZiAvLyBFTkFCTEUoQ0ZQUkVGU19ESVJFQ1RfTU9ERSkK