239440 2022-04-17 14:42:53 -0700 Harden setPrototypeOf(). 2022-04-18 10:15:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam saam webkit-bug-importer oldest_to_newest 1862166 0 mark.lam 2022-04-17 14:42:53 -0700 <rdar://problem/91761043> 1862170 1 457778 mark.lam 2022-04-17 14:51:16 -0700 Created attachment 457778 patch for landing. 1862171 2 mark.lam 2022-04-17 14:54:02 -0700 Landed in r292950: <http://trac.webkit.org/r292950>. 1862254 3 457778 saam 2022-04-18 10:15:30 -0700 Comment on attachment 457778 patch for landing. View in context: https://bugs.webkit.org/attachment.cgi?id=457778&action=review > Source/JavaScriptCore/runtime/JSObject.cpp:1881 > + else if (UNLIKELY(!prototype.isNull())) // Conservative hardening. > + return; should the above just be a release assert and we can remove this? 457778 2022-04-17 14:51:16 -0700 2022-04-17 14:51:16 -0700 patch for landing. bug-239440.patch text/plain 5564 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjkyOTQ2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDIyLTA0LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBI YXJkZW4gSlNPYmplY3Q6OnNldFByb3RvdHlwZU9mLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5NDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWXVz dWtlIFN1enVraS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuY3BwOgorICAgICAgICAo SlNDOjpKU09iamVjdDo6c2V0UHJvdG90eXBlRGlyZWN0KToKKyAgICAgICAgKEpTQzo6SlNPYmpl Y3Q6OnNldFByb3RvdHlwZVdpdGhDeWNsZUNoZWNrKToKKyAgICAgICAgKiBydW50aW1lL0pTT2Jq ZWN0Lmg6CisgICAgICAgICogcnVudGltZS9PYmplY3RDb25zdHJ1Y3Rvci5jcHA6CisgICAgICAg IChKU0M6Om9iamVjdENvbnN0cnVjdG9yU2V0UHJvdG90eXBlT2YpOgorCiAyMDIyLTA0LTE2ICBN YXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYSBkZWFkbG9jayBp biBWTVRyYXBzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3Qu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0 LmNwcAkocmV2aXNpb24gMjkyOTQ2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogLyoKICAqICBDb3B5 cmlnaHQgKEMpIDE5OTktMjAwMSBIYXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUub3JnKQogICogIENv cHlyaWdodCAoQykgMjAwMSBQZXRlciBLZWxseSAocG1rQHBvc3QuY29tKQotICogIENvcHlyaWdo dCAoQykgMjAwMy0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5 cmlnaHQgKEMpIDIwMDMtMjAyMiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiAg Q29weXJpZ2h0IChDKSAyMDA3IEVyaWMgU2VpZGVsIChlcmljQHdlYmtpdC5vcmcpCiAgKgogICog IFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh bmQvb3IKQEAgLTY0LDYgKzY0LDcgQEAgY29uc3QgQVNDSUlMaXRlcmFsIFVuY29uZmlndXJhYmxl UHJvcGVydAogY29uc3QgQVNDSUlMaXRlcmFsIFVuY29uZmlndXJhYmxlUHJvcGVydHlDaGFuZ2VD b25maWd1cmFiaWxpdHlFcnJvciB7ICJBdHRlbXB0aW5nIHRvIGNoYW5nZSBjb25maWd1cmFibGUg YXR0cmlidXRlIG9mIHVuY29uZmlndXJhYmxlIHByb3BlcnR5LiJfcyB9OwogY29uc3QgQVNDSUlM aXRlcmFsIFVuY29uZmlndXJhYmxlUHJvcGVydHlDaGFuZ2VFbnVtZXJhYmlsaXR5RXJyb3IgeyAi QXR0ZW1wdGluZyB0byBjaGFuZ2UgZW51bWVyYWJsZSBhdHRyaWJ1dGUgb2YgdW5jb25maWd1cmFi bGUgcHJvcGVydHkuIl9zIH07CiBjb25zdCBBU0NJSUxpdGVyYWwgVW5jb25maWd1cmFibGVQcm9w ZXJ0eUNoYW5nZVdyaXRhYmlsaXR5RXJyb3IgeyAiQXR0ZW1wdGluZyB0byBjaGFuZ2Ugd3JpdGFi bGUgYXR0cmlidXRlIG9mIHVuY29uZmlndXJhYmxlIHByb3BlcnR5LiJfcyB9OworY29uc3QgQVND SUlMaXRlcmFsIFByb3RvdHlwZVZhbHVlQ2FuT25seUJlQW5PYmplY3RPck51bGxUeXBlRXJyb3Ig eyAiUHJvdG90eXBlIHZhbHVlIGNhbiBvbmx5IGJlIGFuIG9iamVjdCBvciBudWxsIl9zIH07CiAK IGNvbnN0IENsYXNzSW5mbyBKU09iamVjdDo6c19pbmZvID0geyAiT2JqZWN0Il9zLCBudWxscHRy LCBudWxscHRyLCBudWxscHRyLCBDUkVBVEVfTUVUSE9EX1RBQkxFKEpTT2JqZWN0KSB9OwogCkBA IC0xODczLDkgKzE4NzQsMTEgQEAgdm9pZCBKU09iamVjdDo6c3dpdGNoVG9TbG93UHV0QXJyYXlT dG9yYQogCiB2b2lkIEpTT2JqZWN0OjpzZXRQcm90b3R5cGVEaXJlY3QoVk0mIHZtLCBKU1ZhbHVl IHByb3RvdHlwZSkKIHsKLSAgICBBU1NFUlQocHJvdG90eXBlKTsKKyAgICBBU1NFUlQocHJvdG90 eXBlLmlzT2JqZWN0KCkgfHwgcHJvdG90eXBlLmlzTnVsbCgpKTsKICAgICBpZiAocHJvdG90eXBl LmlzT2JqZWN0KCkpCiAgICAgICAgIGFzT2JqZWN0KHByb3RvdHlwZSktPmRpZEJlY29tZVByb3Rv dHlwZSgpOworICAgIGVsc2UgaWYgKFVOTElLRUxZKCFwcm90b3R5cGUuaXNOdWxsKCkpKSAvLyBD b25zZXJ2YXRpdmUgaGFyZGVuaW5nLgorICAgICAgICByZXR1cm47CiAgICAgCiAgICAgaWYgKHN0 cnVjdHVyZSgpLT5oYXNNb25vUHJvdG8oKSkgewogICAgICAgICBEZWZlcnJlZFN0cnVjdHVyZVRy YW5zaXRpb25XYXRjaHBvaW50RmlyZSBkZWZlcnJlZCh2bSwgc3RydWN0dXJlKCkpOwpAQCAtMTky Niw2ICsxOTI5LDEyIEBAIGJvb2wgSlNPYmplY3Q6OnNldFByb3RvdHlwZVdpdGhDeWNsZUNoZWMK ICAgICBpZiAoIWlzRXh0ZW5zaWJsZSkKICAgICAgICAgcmV0dXJuIHR5cGVFcnJvcihnbG9iYWxP YmplY3QsIHNjb3BlLCBzaG91bGRUaHJvd0lmQ2FudFNldCwgUmVhZG9ubHlQcm9wZXJ0eVdyaXRl RXJyb3IpOwogCisgICAgLy8gU29tZSBjbGllbnRzIHdvdWxkIGhhdmUgYWxyZWFkeSBkb25lIHRo aXMgY2hlY2sgYmVjYXVzZSBvZiB0aGUgb3JkZXIgb2YgdGhlIGNoZWNrCisgICAgLy8gc3BlY2lm aWVkIGluIHRoZWlyIHJlc3BlY3RpdmUgc3BlY2lmaWNhdGlvbnMuIEhvd2V2ZXIsIHdlIHN0aWxs IGRvIHRoaXMgY2hlY2sgaGVyZQorICAgIC8vIHRvIGRvY3VtZW50IGFuZCBlbmZvcmNlIHRoaXMg aW52YXJpYW50IGFib3V0IHRoZSBuYXR1cmUgb2YgcHJvdG90eXBlLgorICAgIGlmIChVTkxJS0VM WSghcHJvdG90eXBlLmlzT2JqZWN0KCkgJiYgIXByb3RvdHlwZS5pc051bGwoKSkpCisgICAgICAg IHJldHVybiB0eXBlRXJyb3IoZ2xvYmFsT2JqZWN0LCBzY29wZSwgc2hvdWxkVGhyb3dJZkNhbnRT ZXQsIFByb3RvdHlwZVZhbHVlQ2FuT25seUJlQW5PYmplY3RPck51bGxUeXBlRXJyb3IpOworCiAg ICAgSlNWYWx1ZSBuZXh0UHJvdG90eXBlID0gcHJvdG90eXBlOwogICAgIHdoaWxlIChuZXh0UHJv dG90eXBlICYmIG5leHRQcm90b3R5cGUuaXNPYmplY3QoKSkgewogICAgICAgICBpZiAobmV4dFBy b3RvdHlwZSA9PSB0aGlzKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNP YmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09i amVjdC5oCShyZXZpc2lvbiAyOTI5NDYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU09iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogLyoKICAqICBDb3B5 cmlnaHQgKEMpIDE5OTktMjAwMSBIYXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUub3JnKQogICogIENv cHlyaWdodCAoQykgMjAwMSBQZXRlciBLZWxseSAocG1rQHBvc3QuY29tKQotICogIENvcHlyaWdo dCAoQykgMjAwMy0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5 cmlnaHQgKEMpIDIwMDMtMjAyMiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgog ICogIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IKICAqICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFy eSBHZW5lcmFsIFB1YmxpYwpAQCAtODMsNiArODMsNyBAQCBleHRlcm4gSlNfRVhQT1JUX1BSSVZB VEUgY29uc3QgQVNDSUlMaXRlCiBleHRlcm4gSlNfRVhQT1JUX1BSSVZBVEUgY29uc3QgQVNDSUlM aXRlcmFsIFVuY29uZmlndXJhYmxlUHJvcGVydHlDaGFuZ2VDb25maWd1cmFiaWxpdHlFcnJvcjsK IGV4dGVybiBKU19FWFBPUlRfUFJJVkFURSBjb25zdCBBU0NJSUxpdGVyYWwgVW5jb25maWd1cmFi bGVQcm9wZXJ0eUNoYW5nZUVudW1lcmFiaWxpdHlFcnJvcjsKIGV4dGVybiBKU19FWFBPUlRfUFJJ VkFURSBjb25zdCBBU0NJSUxpdGVyYWwgVW5jb25maWd1cmFibGVQcm9wZXJ0eUNoYW5nZVdyaXRh YmlsaXR5RXJyb3I7CitleHRlcm4gSlNfRVhQT1JUX1BSSVZBVEUgY29uc3QgQVNDSUlMaXRlcmFs IFByb3RvdHlwZVZhbHVlQ2FuT25seUJlQW5PYmplY3RPck51bGxUeXBlRXJyb3I7CiAKIGNsYXNz IEpTRmluYWxPYmplY3Q7CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09i amVjdENvbnN0cnVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9PYmplY3RDb25zdHJ1Y3Rvci5jcHAJKHJldmlzaW9uIDI5Mjk0NikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVjdG9yLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMSw2ICsxLDYgQEAKIC8qCiAgKiAgQ29weXJpZ2h0IChDKSAxOTk5LTIwMDAgSGFy cmkgUG9ydGVuIChwb3J0ZW5Aa2RlLm9yZykKLSAqICBDb3B5cmlnaHQgKEMpIDIwMDgtMjAyMSBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiAgQ29weXJpZ2h0IChDKSAyMDA4LTIw MjIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqICBUaGlzIGxpYnJhcnkg aXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiAgbW9k aWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYwpA QCAtMTYwLDcgKzE2MCw3IEBAIEpTQ19ERUZJTkVfSE9TVF9GVU5DVElPTihvYmplY3RDb25zdHJ1 Y3QKIAogICAgIEpTVmFsdWUgcHJvdG9WYWx1ZSA9IGNhbGxGcmFtZS0+YXJndW1lbnQoMSk7CiAg ICAgaWYgKCFwcm90b1ZhbHVlLmlzT2JqZWN0KCkgJiYgIXByb3RvVmFsdWUuaXNOdWxsKCkpCi0g ICAgICAgIHJldHVybiB0aHJvd1ZNVHlwZUVycm9yKGdsb2JhbE9iamVjdCwgc2NvcGUsICJQcm90 b3R5cGUgdmFsdWUgY2FuIG9ubHkgYmUgYW4gb2JqZWN0IG9yIG51bGwiX3MpOworICAgICAgICBy ZXR1cm4gdGhyb3dWTVR5cGVFcnJvcihnbG9iYWxPYmplY3QsIHNjb3BlLCBQcm90b3R5cGVWYWx1 ZUNhbk9ubHlCZUFuT2JqZWN0T3JOdWxsVHlwZUVycm9yKTsKIAogICAgIEpTT2JqZWN0KiBvYmpl Y3QgPSBvYmplY3RWYWx1ZS50b09iamVjdChnbG9iYWxPYmplY3QpOwogICAgIFJFVFVSTl9JRl9F WENFUFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwo=