239393 2022-04-15 11:09:40 -0700 Apply purifyNaN in more places. 2022-04-15 12:55:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1861851 0 mark.lam 2022-04-15 11:09:40 -0700 <rdar://problem/91761362> 1861855 1 457707 mark.lam 2022-04-15 11:15:58 -0700 Created attachment 457707 proposed patch. 1861869 2 457707 saam 2022-04-15 12:03:19 -0700 Comment on attachment 457707 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=457707&action=review > Source/JavaScriptCore/wasm/WasmInstance.h:137 > + double loadF64Global(unsigned i) const { return purifyNaN(bitwise_cast<double>(loadI64Global(i))); } let's just delete this function? 1861874 3 457712 mark.lam 2022-04-15 12:14:59 -0700 Created attachment 457712 patch for landing. 1861880 4 mark.lam 2022-04-15 12:55:33 -0700 Thanks for the review. Landed in r292920: <http://trac.webkit.org/r292920>. 457707 2022-04-15 11:15:58 -0700 2022-04-15 12:03:19 -0700 proposed patch. bug-239393.patch text/plain 2852 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjkyOTE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDIyLTA0LTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB cHBseSBwdXJpZnlOYU4gaW4gbW9yZSBwbGFjZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzkzOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHdhc20vV2FzbUluc3RhbmNlLmg6CisgICAgICAgIChK U0M6Oldhc206Okluc3RhbmNlOjpsb2FkRjY0R2xvYmFsIGNvbnN0KToKKyAgICAgICAgKiB3YXNt L2pzL0pTV2ViQXNzZW1ibHlIZWxwZXJzLmg6CisgICAgICAgIChKU0M6OnRvSlNWYWx1ZSk6CisK IDIwMjItMDQtMTQgIENhaXRsaW4gUG90dGVyICA8Y2FpdHBAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbSlNDXSBTaGFkb3dSZWFsbSBnbG9iYWwgb2JqZWN0IGhhcyBhIG11dGFibGUgcHJvdG90eXBl CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtSW5zdGFuY2UuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtSW5zdGFuY2UuaAkocmV2aXNp b24gMjkyMzcyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUluc3RhbmNlLmgJ KHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE3 LTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAy MDE3LTIwMjIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJp YnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91 dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxv d2luZyBjb25kaXRpb25zCkBAIC0yNyw2ICsyNyw3IEBACiAKICNpZiBFTkFCTEUoV0VCQVNTRU1C TFkpCiAKKyNpbmNsdWRlICJQdXJlTmFOLmgiCiAjaW5jbHVkZSAiV2FzbUZvcm1hdC5oIgogI2lu Y2x1ZGUgIldhc21HbG9iYWwuaCIKICNpbmNsdWRlICJXYXNtTWVtb3J5LmgiCkBAIC0xMzMsNyAr MTM0LDcgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gc2xvdC0+bV9wcmltaXRpdmU7CiAgICAg fQogICAgIGZsb2F0IGxvYWRGMzJHbG9iYWwodW5zaWduZWQgaSkgY29uc3QgeyByZXR1cm4gYml0 d2lzZV9jYXN0PGZsb2F0Pihsb2FkSTMyR2xvYmFsKGkpKTsgfQotICAgIGRvdWJsZSBsb2FkRjY0 R2xvYmFsKHVuc2lnbmVkIGkpIGNvbnN0IHsgcmV0dXJuIGJpdHdpc2VfY2FzdDxkb3VibGU+KGxv YWRJNjRHbG9iYWwoaSkpOyB9CisgICAgZG91YmxlIGxvYWRGNjRHbG9iYWwodW5zaWduZWQgaSkg Y29uc3QgeyByZXR1cm4gcHVyaWZ5TmFOKGJpdHdpc2VfY2FzdDxkb3VibGU+KGxvYWRJNjRHbG9i YWwoaSkpKTsgfQogICAgIHZvaWQgc2V0R2xvYmFsKHVuc2lnbmVkIGksIGludDY0X3QgYml0cykK ICAgICB7CiAgICAgICAgIEdsb2JhbDo6VmFsdWUqIHNsb3QgPSBtX2dsb2JhbHMuZ2V0KCkgKyBp OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vanMvSlNXZWJBc3NlbWJseUhlbHBl cnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9qcy9KU1dlYkFz c2VtYmx5SGVscGVycy5oCShyZXZpc2lvbiAyOTIzNzIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvd2FzbS9qcy9KU1dlYkFzc2VtYmx5SGVscGVycy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUg KzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxNi0yMDE4IEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxNi0yMDIyIEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJj ZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJl IHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMTYy LDcgKzE2Miw3IEBAIEFMV0FZU19JTkxJTkUgSlNWYWx1ZSB0b0pTVmFsdWUoSlNHbG9iYWwKICAg ICBjYXNlIFdhc206OlR5cGVLaW5kOjpGMzI6CiAgICAgICAgIHJldHVybiBqc051bWJlcihiaXR3 aXNlX2Nhc3Q8ZmxvYXQ+KHN0YXRpY19jYXN0PGludDMyX3Q+KGJpdHMpKSk7CiAgICAgY2FzZSBX YXNtOjpUeXBlS2luZDo6RjY0OgotICAgICAgICByZXR1cm4ganNOdW1iZXIoYml0d2lzZV9jYXN0 PGRvdWJsZT4oYml0cykpOworICAgICAgICByZXR1cm4ganNOdW1iZXIocHVyaWZ5TmFOKGJpdHdp c2VfY2FzdDxkb3VibGU+KGJpdHMpKSk7CiAgICAgY2FzZSBXYXNtOjpUeXBlS2luZDo6STY0Ogog ICAgICAgICByZXR1cm4gSlNCaWdJbnQ6OmNyZWF0ZUZyb20oZ2xvYmFsT2JqZWN0LCBzdGF0aWNf Y2FzdDxpbnQ2NF90PihiaXRzKSk7CiAgICAgY2FzZSBXYXNtOjpUeXBlS2luZDo6RXh0ZXJucmVm Ogo= 457712 2022-04-15 12:14:59 -0700 2022-04-15 12:14:59 -0700 patch for landing. bug-239393.patch text/plain 2781 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjkyOTE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDIyLTA0LTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB cHBseSBwdXJpZnlOYU4gaW4gbW9yZSBwbGFjZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzkzOTMKKworICAgICAgICBSZXZpZXdlZCBieSBTYWFt IEJhcmF0aS4KKworICAgICAgICBBbHNvIHJlbW92ZWQgc29tZSB1bnVzZWQgZnVuY3Rpb25zLgor CisgICAgICAgICogd2FzbS9XYXNtSW5zdGFuY2UuaDoKKyAgICAgICAgKEpTQzo6V2FzbTo6SW5z dGFuY2U6OmxvYWRJNjRHbG9iYWwgY29uc3QpOgorICAgICAgICAoSlNDOjpXYXNtOjpJbnN0YW5j ZTo6bG9hZEYzMkdsb2JhbCBjb25zdCk6IERlbGV0ZWQuCisgICAgICAgIChKU0M6Oldhc206Oklu c3RhbmNlOjpsb2FkRjY0R2xvYmFsIGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKiB3YXNtL2pz L0pTV2ViQXNzZW1ibHlIZWxwZXJzLmg6CisgICAgICAgIChKU0M6OnRvSlNWYWx1ZSk6CisKIDIw MjItMDQtMTQgIENhaXRsaW4gUG90dGVyICA8Y2FpdHBAaWdhbGlhLmNvbT4KIAogICAgICAgICBb SlNDXSBTaGFkb3dSZWFsbSBnbG9iYWwgb2JqZWN0IGhhcyBhIG11dGFibGUgcHJvdG90eXBlCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtSW5zdGFuY2UuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtSW5zdGFuY2UuaAkocmV2aXNpb24g MjkyMzcyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUluc3RhbmNlLmgJKHdv cmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE3LTIw MTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE3 LTIwMjIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAog ICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu ZyBjb25kaXRpb25zCkBAIC0xMzIsOCArMTMyLDYgQEAgcHVibGljOgogICAgICAgICB9CiAgICAg ICAgIHJldHVybiBzbG90LT5tX3ByaW1pdGl2ZTsKICAgICB9Ci0gICAgZmxvYXQgbG9hZEYzMkds b2JhbCh1bnNpZ25lZCBpKSBjb25zdCB7IHJldHVybiBiaXR3aXNlX2Nhc3Q8ZmxvYXQ+KGxvYWRJ MzJHbG9iYWwoaSkpOyB9Ci0gICAgZG91YmxlIGxvYWRGNjRHbG9iYWwodW5zaWduZWQgaSkgY29u c3QgeyByZXR1cm4gYml0d2lzZV9jYXN0PGRvdWJsZT4obG9hZEk2NEdsb2JhbChpKSk7IH0KICAg ICB2b2lkIHNldEdsb2JhbCh1bnNpZ25lZCBpLCBpbnQ2NF90IGJpdHMpCiAgICAgewogICAgICAg ICBHbG9iYWw6OlZhbHVlKiBzbG90ID0gbV9nbG9iYWxzLmdldCgpICsgaTsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL0pTV2ViQXNzZW1ibHlIZWxwZXJzLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vanMvSlNXZWJBc3NlbWJseUhlbHBlcnMu aAkocmV2aXNpb24gMjkyMzcyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vanMvSlNX ZWJBc3NlbWJseUhlbHBlcnMuaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0g KiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAxOCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CisgKiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAyMiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm b3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJv dmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTE2Miw3ICsxNjIsNyBAQCBB TFdBWVNfSU5MSU5FIEpTVmFsdWUgdG9KU1ZhbHVlKEpTR2xvYmFsCiAgICAgY2FzZSBXYXNtOjpU eXBlS2luZDo6RjMyOgogICAgICAgICByZXR1cm4ganNOdW1iZXIoYml0d2lzZV9jYXN0PGZsb2F0 PihzdGF0aWNfY2FzdDxpbnQzMl90PihiaXRzKSkpOwogICAgIGNhc2UgV2FzbTo6VHlwZUtpbmQ6 OkY2NDoKLSAgICAgICAgcmV0dXJuIGpzTnVtYmVyKGJpdHdpc2VfY2FzdDxkb3VibGU+KGJpdHMp KTsKKyAgICAgICAgcmV0dXJuIGpzTnVtYmVyKHB1cmlmeU5hTihiaXR3aXNlX2Nhc3Q8ZG91Ymxl PihiaXRzKSkpOwogICAgIGNhc2UgV2FzbTo6VHlwZUtpbmQ6Okk2NDoKICAgICAgICAgcmV0dXJu IEpTQmlnSW50OjpjcmVhdGVGcm9tKGdsb2JhbE9iamVjdCwgc3RhdGljX2Nhc3Q8aW50NjRfdD4o Yml0cykpOwogICAgIGNhc2UgV2FzbTo6VHlwZUtpbmQ6OkV4dGVybnJlZjoK