239391 2022-04-15 10:09:30 -0700 Add a helper function to perform additional setup on VKCImageAnalysis(Interaction|OverlayView) 2022-04-15 19:07:33 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi hi katherine_cheney megan_gardner thorton webkit-bug-importer oldest_to_newest 1861834 0 wenson_hsieh 2022-04-15 10:09:30 -0700 rdar://91466567 1861913 1 457725 wenson_hsieh 2022-04-15 14:23:44 -0700 Created attachment 457725 Patch 1861951 2 457725 wenson_hsieh 2022-04-15 16:02:03 -0700 Comment on attachment 457725 Patch Thanks for the review! 1861997 3 ews-feeder 2022-04-15 18:17:13 -0700 Committed r292935 (249700@main): <https://commits.webkit.org/249700@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457725. 457725 2022-04-15 14:23:44 -0700 2022-04-15 19:07:33 -0700 Patch bug-239391-20220415142343.patch text/plain 6842 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVjMGViMjQzZWEzNDU1NDg1 MDU0ZTU5YzZjYjk4MTE1NmVmNWNkOTYuLjkzMzhhYWYyZDE3NDJhZGNmOWNlNDYwNWZiZjA1YjY5 NWViZjg5MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjItMDQtMTUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgaGVscGVyIGZ1 bmN0aW9uIHRvIHBlcmZvcm0gYWRkaXRpb25hbCBzZXR1cCBvbiBWS0NJbWFnZUFuYWx5c2lzKElu dGVyYWN0aW9ufE92ZXJsYXlWaWV3KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM5MzkxCisgICAgICAgIHJkYXI6Ly85MTQ2NjU2NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGhlbHBlciBmdW5j dGlvbiB0byBJbWFnZUFuYWx5c2lzVXRpbGl0aWVzLCBhbmQgY2FsbCBpdCBvbiBib3RoIGlPUyAo V0tDb250ZW50VmlldykgYW5kIG1hY09TCisgICAgICAgIChXZWJWaWV3SW1wbCkuCisKKyAgICAg ICAgKiBQbGF0Zm9ybS9jb2NvYS9JbWFnZUFuYWx5c2lzVXRpbGl0aWVzLmg6CisgICAgICAgICog VUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3 SW1wbDo6aW5zdGFsbEltYWdlQW5hbHlzaXNPdmVybGF5Vmlldyk6CisgICAgICAgICogVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVu dFZpZXcgX3NpbmdsZVRhcElkZW50aWZpZWQ6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcg aW5zdGFsbEltYWdlQW5hbHlzaXNJbnRlcmFjdGlvbjpdKToKKyAgICAgICAgKC1bV0tDb250ZW50 VmlldyBpbWFnZUFuYWx5c2lzSW50ZXJhY3Rpb246c2hvdWxkQmVnaW5BdFBvaW50OmZvckFuYWx5 c2lzVHlwZTpdKToKKworICAgICAgICBBZGQgc3VwcG9ydCBmb3IgdG9nZ2xpbmcgdGhlIExpdmUg VGV4dCBvdmVybGF5IHdoZW4gdGFwcGluZyBvbiB0aGUgaW1hZ2UgYW5hbHlzaXMgYnV0dG9uIG93 bmVkIGJ5IHRoZQorICAgICAgICBpbnRlcmFjdGlvbi4gVGhpcyBjdXN0b20gaGFuZGxpbmcgaXMg bmVjZXNzYXJ5LCBzaW5jZSB0aGUgc3ludGhldGljIHRhcCBnZXN0dXJlIHJlY29nbml6ZXIgZG9l cyBub3QgcmVjb2duaXplCisgICAgICAgIHNpbXVsdGFuZW91c2x5IGFsb25nc2lkZSB0aGUgdGFw IGdlc3R1cmUgZm9yIFZpc2lvbktpdCdzIFVJQnV0dG9uLCBhbmQgd2UgY2FuJ3QgKGVhc2lseSkg Z3JhYiBWaXNpb25LaXQncworICAgICAgICBidXR0b24ncyB0YXAgZ2VzdHVyZSB0byBhZGQgZmFp bHVyZSByZXF1aXJlbWVudHMgdG8gb3VyIHN5bnRoZXRpYyB0YXAgZ2VzdHVyZS4KKwogMjAyMi0w NC0xNCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBV bmRvIG9wdGlvbiBhZnRlciBpbnZva2luZyAiTWFya3VwIEltYWdlIiBzYXlzICJVbmRvIFBhc3Rl IgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9jb2NvYS9JbWFnZUFuYWx5c2lz VXRpbGl0aWVzLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL2NvY29hL0ltYWdlQW5hbHlzaXNV dGlsaXRpZXMuaAppbmRleCBkZTc0NWI1ZjFhNmI5NzJmNjk2YjMwZmMzZDgyYjhiMzIyYzYxZTll Li43OTVmYzJjYWJmZmE0MGI2NTAyZTRkMTkxNGJhMThmMDlmMWIzM2ZkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1BsYXRmb3JtL2NvY29hL0ltYWdlQW5hbHlzaXNVdGlsaXRpZXMuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL2NvY29hL0ltYWdlQW5hbHlzaXNVdGlsaXRpZXMuaApA QCAtNjAsNyArNjAsMTQgQEAgUmV0YWluUHRyPENvY29hSW1hZ2VBbmFseXplclJlcXVlc3Q+IGNy ZWF0ZUltYWdlQW5hbHl6ZXJSZXF1ZXN0KENHSW1hZ2VSZWYsIFZLQW4KICNpZiBFTkFCTEUoSU1B R0VfQU5BTFlTSVNfRU5IQU5DRU1FTlRTKQogdm9pZCByZXF1ZXN0SW1hZ2VBbmFseXNpc1dpdGhJ ZGVudGlmaWVyKENvY29hSW1hZ2VBbmFseXplciAqLCBjb25zdCBTdHJpbmcmIGlkZW50aWZpZXIs IENHSW1hZ2VSZWYsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoV2ViQ29yZTo6VGV4dFJlY29nbml0 aW9uUmVzdWx0JiYpPiYmKTsKIHZvaWQgcmVxdWVzdEltYWdlQW5hbHlzaXNNYXJrdXAoQ0dJbWFn ZVJlZiwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChDR0ltYWdlUmVmLCBDR1JlY3QpPiYmKTsKKwor I2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCit1c2luZyBQbGF0Zm9ybUltYWdlQW5hbHlzaXNPYmpl Y3QgPSBWS0NJbWFnZUFuYWx5c2lzSW50ZXJhY3Rpb247CisjZWxzZQordXNpbmcgUGxhdGZvcm1J bWFnZUFuYWx5c2lzT2JqZWN0ID0gVktDSW1hZ2VBbmFseXNpc092ZXJsYXlWaWV3OwogI2VuZGlm Cit2b2lkIHNldFVwQWRkaXRpb25hbEltYWdlQW5hbHlzaXNCZWhhdmlvcnMoUGxhdGZvcm1JbWFn ZUFuYWx5c2lzT2JqZWN0ICopOworI2VuZGlmIC8vIEVOQUJMRShJTUFHRV9BTkFMWVNJU19FTkhB TkNFTUVOVFMpCiAKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29j b2EvV2ViVmlld0ltcGwubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3 SW1wbC5tbQppbmRleCAwMTVhNjY4NDBkYmM4Nzg4YmQzNGQ3OWZkN2MzYmJlNTljZWQxNzQyLi43 ZTRlOWQ2MDNmZmUxNzlkZmFkYTFmZTZmZDU4NWYwY2RjMjNlMjQ0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQpAQCAtNTkzOCw2ICs1OTM4LDcgQEAg dm9pZCBXZWJWaWV3SW1wbDo6aW5zdGFsbEltYWdlQW5hbHlzaXNPdmVybGF5VmlldyhWS0NJbWFn ZUFuYWx5c2lzICphbmFseXNpcykKICAgICAgICAgW21faW1hZ2VBbmFseXNpc092ZXJsYXlWaWV3 IHNldERlbGVnYXRlOm1faW1hZ2VBbmFseXNpc092ZXJsYXlWaWV3RGVsZWdhdGUuZ2V0KCldOwog ICAgICAgICBbbV9pbWFnZUFuYWx5c2lzT3ZlcmxheVZpZXcgc2V0QWN0aXZlSW50ZXJhY3Rpb25U eXBlczpWS0ltYWdlQW5hbHlzaXNJbnRlcmFjdGlvblR5cGVUZXh0U2VsZWN0aW9uIHwgVktJbWFn ZUFuYWx5c2lzSW50ZXJhY3Rpb25UeXBlRGF0YURldGVjdG9yc107CiAgICAgICAgIFttX2ltYWdl QW5hbHlzaXNPdmVybGF5VmlldyBzZXRXYW50c0F1dG9tYXRpY0NvbnRlbnRzUmVjdENhbGN1bGF0 aW9uOk5PXTsKKyAgICAgICAgc2V0VXBBZGRpdGlvbmFsSW1hZ2VBbmFseXNpc0JlaGF2aW9ycyht X2ltYWdlQW5hbHlzaXNPdmVybGF5Vmlldy5nZXQoKSk7CiAgICAgfQogCiAgICAgW21faW1hZ2VB bmFseXNpc092ZXJsYXlWaWV3IHNldEFuYWx5c2lzOmFuYWx5c2lzXTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmlu ZGV4IDYxNmQyOTE4ZTlhMmQwOGYzZmIyYTkxZGZlMDBjMDNlNGRhZmFmNmYuLjI4ODM2Y2VmZjVh NzQ3M2ExZGJiMGRhZjk2YTE2NTJkYjZjMDhmYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMzI3Myw2 ICszMjczLDE5IEBAIC0gKHZvaWQpX2VuZFBvdGVudGlhbFRhcEFuZEVuYWJsZURvdWJsZVRhcEdl c3R1cmVzSWZOZWNlc3NhcnkKIAogLSAodm9pZClfc2luZ2xlVGFwSWRlbnRpZmllZDooVUlUYXBH ZXN0dXJlUmVjb2duaXplciAqKWdlc3R1cmVSZWNvZ25pemVyCiB7CisgICAgYXV0byBwb3NpdGlv biA9IFtzZWxmIF9sb2NhdGlvbkZvckdlc3R1cmU6Z2VzdHVyZVJlY29nbml6ZXJdOworI2lmIEVO QUJMRShJTUFHRV9BTkFMWVNJU19FTkhBTkNFTUVOVFMpCisgICAgaWYgKFVJQnV0dG9uICphbmFs eXNpc0J1dHRvbiA9IFtfaW1hZ2VBbmFseXNpc0ludGVyYWN0aW9uIGFuYWx5c2lzQnV0dG9uXSkg eworICAgICAgICBhdXRvIGhpdFRlc3RlZFZpZXcgPSBkeW5hbWljX29iamNfY2FzdDxVSUJ1dHRv bj4oW3NlbGYgaGl0VGVzdDpwb3NpdGlvbiB3aXRoRXZlbnQ6bmlsXSk7CisgICAgICAgIC8vIEZJ WE1FOiBJbnN0ZWFkIG9mIGEgY2xhc3MgY2hlY2ssIHRoaXMgc2hvdWxkIGJlIGEgc3RyYWlnaHRm b3J3YXJkIGVxdWFsaXR5IGNoZWNrLgorICAgICAgICAvLyBIb3dldmVyLCByZGFyOi8vOTE4Mjgz ODQgY3VycmVudGx5IHByZXZlbnRzIHVzIGZyb20gZG9pbmcgc28uIFdlIGNhbiBzaW1wbGlmeSB0 aGlzIGxvZ2ljCisgICAgICAgIC8vIG9uY2UgdGhlIGZpeCBmb3IgdGhhdCBidWcgaGFzIGxhbmRl ZC4KKyAgICAgICAgaWYgKGhpdFRlc3RlZFZpZXcuY2xhc3MgPT0gYW5hbHlzaXNCdXR0b24uY2xh c3MpCisgICAgICAgICAgICBbX2ltYWdlQW5hbHlzaXNJbnRlcmFjdGlvbiBzZXRIaWdobGlnaHRT ZWxlY3RhYmxlSXRlbXM6IVtfaW1hZ2VBbmFseXNpc0ludGVyYWN0aW9uIGhpZ2hsaWdodFNlbGVj dGFibGVJdGVtc11dOworICAgICAgICByZXR1cm47CisgICAgfQorI2VuZGlmIC8vIEVOQUJMRShJ TUFHRV9BTkFMWVNJU19FTkhBTkNFTUVOVFMpCisKICAgICBBU1NFUlQoZ2VzdHVyZVJlY29nbml6 ZXIgPT0gX3NpbmdsZVRhcEdlc3R1cmVSZWNvZ25pemVyKTsKICAgICBBU1NFUlQoIV9wb3RlbnRp YWxUYXBJblByb2dyZXNzKTsKICAgICBbc2VsZiBfcmVzZXRJc0RvdWJsZVRhcFBlbmRpbmddOwpA QCAtMzI4OSw3ICszMzAyLDcgQEAgLSAodm9pZClfc2luZ2xlVGFwSWRlbnRpZmllZDooVUlUYXBH ZXN0dXJlUmVjb2duaXplciAqKWdlc3R1cmVSZWNvZ25pemVyCiAgICAgaWYgKHNob3VsZFJlcXVl c3RNYWduaWZpY2F0aW9uSW5mb3JtYXRpb24pCiAgICAgICAgIFJFTEVBU0VfTE9HKFZpZXdHZXN0 dXJlcywgIlNpbmdsZSB0YXAgaWRlbnRpZmllZC4gUmVxdWVzdCBkZXRhaWxzIG9uIHBvdGVudGlh bCB6b29tLiAoJXAsIHBhZ2VQcm94eUlEPSVsbHUpIiwgc2VsZiwgX3BhZ2UtPmlkZW50aWZpZXIo KS50b1VJbnQ2NCgpKTsKIAotICAgIF9wYWdlLT5wb3RlbnRpYWxUYXBBdFBvc2l0aW9uKFtzZWxm IF9sb2NhdGlvbkZvckdlc3R1cmU6Z2VzdHVyZVJlY29nbml6ZXJdLCBzaG91bGRSZXF1ZXN0TWFn bmlmaWNhdGlvbkluZm9ybWF0aW9uLCBbc2VsZiBuZXh0VGFwSWRlbnRpZmllcl0pOworICAgIF9w YWdlLT5wb3RlbnRpYWxUYXBBdFBvc2l0aW9uKHBvc2l0aW9uLCBzaG91bGRSZXF1ZXN0TWFnbmlm aWNhdGlvbkluZm9ybWF0aW9uLCBbc2VsZiBuZXh0VGFwSWRlbnRpZmllcl0pOwogICAgIF9wb3Rl bnRpYWxUYXBJblByb2dyZXNzID0gWUVTOwogICAgIF9pc1RhcEhpZ2hsaWdodElEVmFsaWQgPSBZ RVM7CiAgICAgX2lzRXhwZWN0aW5nRmFzdFNpbmdsZVRhcENvbW1pdCA9ICFfZG91YmxlVGFwR2Vz dHVyZVJlY29nbml6ZXIuZ2V0KCkuZW5hYmxlZDsKQEAgLTExMDE2LDYgKzExMDI5LDcgQEAgLSAo dm9pZClpbnN0YWxsSW1hZ2VBbmFseXNpc0ludGVyYWN0aW9uOihWS0NJbWFnZUFuYWx5c2lzICop YW5hbHlzaXMKICAgICAgICAgW19pbWFnZUFuYWx5c2lzSW50ZXJhY3Rpb24gc2V0QWN0aXZlSW50 ZXJhY3Rpb25UeXBlczpWS0ltYWdlQW5hbHlzaXNJbnRlcmFjdGlvblR5cGVUZXh0U2VsZWN0aW9u IHwgVktJbWFnZUFuYWx5c2lzSW50ZXJhY3Rpb25UeXBlRGF0YURldGVjdG9yc107CiAgICAgICAg IFtfaW1hZ2VBbmFseXNpc0ludGVyYWN0aW9uIHNldERlbGVnYXRlOnNlbGZdOwogICAgICAgICBb X2ltYWdlQW5hbHlzaXNJbnRlcmFjdGlvbiBzZXRXYW50c0F1dG9tYXRpY0NvbnRlbnRzUmVjdENh bGN1bGF0aW9uOk5PXTsKKyAgICAgICAgV2ViS2l0OjpzZXRVcEFkZGl0aW9uYWxJbWFnZUFuYWx5 c2lzQmVoYXZpb3JzKF9pbWFnZUFuYWx5c2lzSW50ZXJhY3Rpb24uZ2V0KCkpOwogICAgICAgICBb c2VsZiBhZGRJbnRlcmFjdGlvbjpfaW1hZ2VBbmFseXNpc0ludGVyYWN0aW9uLmdldCgpXTsKICAg ICB9CiAgICAgW19pbWFnZUFuYWx5c2lzSW50ZXJhY3Rpb24gc2V0QW5hbHlzaXM6YW5hbHlzaXNd OwpAQCAtMTEwNDcsNyArMTEwNjEsNyBAQCAtIChDR1JlY3QpY29udGVudHNSZWN0Rm9ySW1hZ2VB bmFseXNpc0ludGVyYWN0aW9uOihWS0NJbWFnZUFuYWx5c2lzSW50ZXJhY3Rpb24gKgogCiAtIChC T09MKWltYWdlQW5hbHlzaXNJbnRlcmFjdGlvbjooVktDSW1hZ2VBbmFseXNpc0ludGVyYWN0aW9u ICopaW50ZXJhY3Rpb24gc2hvdWxkQmVnaW5BdFBvaW50OihDR1BvaW50KXBvaW50IGZvckFuYWx5 c2lzVHlwZTooVktJbWFnZUFuYWx5c2lzSW50ZXJhY3Rpb25UeXBlcylhbmFseXNpc1R5cGUKIHsK LSAgICByZXR1cm4gW19pbWFnZUFuYWx5c2lzSW50ZXJhY3Rpb24gaW50ZXJhY3RhYmxlSXRlbUV4 aXN0c0F0UG9pbnQ6cG9pbnRdOworICAgIHJldHVybiBpbnRlcmFjdGlvbi5oYXNBY3RpdmVUZXh0 U2VsZWN0aW9uIHx8IFtpbnRlcmFjdGlvbiBpbnRlcmFjdGFibGVJdGVtRXhpc3RzQXRQb2ludDpw b2ludF07CiB9CiAKICNlbmRpZiAvLyBFTkFCTEUoSU1BR0VfQU5BTFlTSVNfRU5IQU5DRU1FTlRT KQo=