23939 2009-02-12 16:55:37 -0800 Release build being built with debugging symbols 2009-02-17 04:49:03 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 gustavo gustavo calvin.walton oldest_to_newest 109589 0 gustavo 2009-02-12 16:55:37 -0800 The autoconf build system was recently modified to call AC_PROG_CXX. This macro is adding -g and -O2 to CXXFLAGS, which ends up making the build have debug symbols. 109599 1 27634 gustavo 2009-02-12 17:29:37 -0800 Created attachment 27634 proposed fix While searching for a way to protect CXXFLAGS from modification I found webkit.m4 where WEBKIT_INIT (which is called by our configure.ac) is defined. There is already an AC_PROG_CXX call there, which protects CXXFLAGS against changes, and which is expanded as part of WEBKIT_INIT, so adding a second call without the protection is no good. I tested automake1.10 here after removing the second call, and it did not complain about it missing, so I am not sure an issue actually exists. 109611 2 calvin.walton 2009-02-12 20:57:03 -0800 I'm afraid to say this is my fault, due to a computer that had a broken autotools installation. The original code was in fact correct, and this change should be reverted. 109832 3 27634 ap 2009-02-16 02:31:28 -0800 Comment on attachment 27634 proposed fix rs=me 109956 4 gustavo 2009-02-17 04:49:03 -0800 Landed in r41038. 27634 2009-02-12 17:29:37 -0800 2009-02-16 02:31:28 -0800 proposed fix 0001-Revert-2009-02-09-Calvin-Walton-calvin.walton-gm.patch text/plain 1388 gustavo RnJvbSA1OTJjMDdiOTQ3ZDc3ZDk0OTIyMmI5NWI1Mzc4Njc4NGE2MTM2YzUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUaHUsIDEyIEZlYiAyMDA5IDIzOjI1OjMyIC0wMjAwClN1YmplY3Q6IFtQQVRDSF0g UmV2ZXJ0ICIyMDA5LTAyLTA5ICBDYWx2aW4gV2FsdG9uICA8Y2FsdmluLndhbHRvbkBnbWFpbC5j b20+IgoKVGhpcyByZXZlcnRzIGNvbW1pdCAxMDU5MTQ1NTNiMTM4YWQ5MWNmNWI2NjFmZjJmZjlh MTcxNTIwNDBlLgotLS0KIENoYW5nZUxvZyAgICB8ICAgIDcgKysrKysrKwogY29uZmlndXJlLmFj IHwgICAgMyAtLS0KIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiMWU1ZGI4Li4y MGYxYjNhIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs MTIgQEAKIDIwMDktMDItMTIgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+ CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKKworICAgICAgICAqIGNvbmZp Z3VyZS5hYzogUmV2ZXJ0IGNoYW5nZSBkb25lIGluIHJldmlzaW9uIDQwNzkwLCBzaW5jZSB3ZQor CWFscmVhZHkgaGF2ZSBhIEFDX1BST0dfQ1hYIG1hY3JvIGNhbGwgYXMgcGFydCBvZiBXRUJLSVRf SU5JVAorCisyMDA5LTAyLTEyICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3Jn PgorCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgogCiAgICAgICAgICogY29uZmln dXJlLmFjOiBNYWtlIHNvdXAgdGhlIGRlZmF1bHQgSFRUUCBiYWNrZW5kIGZvciB0aGUgR3RrIHBv cnQuCmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggNGU1Zjk4 My4uMjg3NzFkZiAxMDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3VyZS5hYwpA QCAtMjcsOSArMjcsNiBAQCBkbmwgIyBzZWUgaHR0cDovL3d3dy5nbnUub3JnL3NvZnR3YXJlL2xp YnRvb2wvbWFudWFsLmh0bWwjVmVyc2lvbmluZwogTElCV0VCS0lUR1RLX1ZFUlNJT049MTowOjAK IEFDX1NVQlNUKFtMSUJXRUJLSVRHVEtfVkVSU0lPTl0pCiAKLSMgUmVjZW50IGxpYnRvb2wrYXV0 b21ha2UgZG9uJ3QgYXNzdW1lIHlvdSB3YW50IEMrKywgZXhwbGljaXRseSBlbmFibGUgaXQKLUFD X1BST0dfQ1hYCi0KIEFNX0lOSVRfQVVUT01BS0UoW2ZvcmVpZ24gc3ViZGlyLW9iamVjdHMgdGFy LXVzdGFyXSkKIAogIyBob3N0IGNoZWNraW5nIC0gaW5zcGlyZWQgYnkgdGhlIEdUSysgY29uZmln dXJlLmluCi0tIAoxLjUuNi41Cgo=