239346 2022-04-14 10:22:02 -0700 InternalFunction::createSubclassStructure() should use base object's global object 2022-04-14 13:19:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Trivial --- 1 ashvayka ashvayka darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1861555 0 ashvayka 2022-04-14 10:22:02 -0700 InternalFunction::createSubclassStructure() should use base object's global object 1861557 1 457640 ashvayka 2022-04-14 10:24:37 -0700 Created attachment 457640 Patch 1861564 2 457640 darin 2022-04-14 10:37:48 -0700 Comment on attachment 457640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457640&action=review > Source/JavaScriptCore/ChangeLog:9 > + Chrome and Firefox don't agree on interoperable behavior in case of cross-realm > + NewTarget's "prototype", so this patch aligns WebKit with Chrome to fix a web-compat issue. In future: Where should the interoperability test go? WPT? Somewhere else? 1861593 3 ashvayka 2022-04-14 12:30:41 -0700 Committed r292883 (249653@trunk): <https://commits.webkit.org/249653@trunk> 1861594 4 webkit-bug-importer 2022-04-14 12:31:15 -0700 <rdar://problem/91770382> 1861595 5 ashvayka 2022-04-14 12:31:44 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 457640 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457640&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + Chrome and Firefox don't agree on interoperable behavior in case of cross-realm > > + NewTarget's "prototype", so this patch aligns WebKit with Chrome to fix a web-compat issue. > > In future: Where should the interoperability test go? WPT? Somewhere else? Discussed this with Darin offline. 1861596 6 webkit-bug-importer 2022-04-14 12:31:56 -0700 <rdar://problem/91770431> 1861613 7 ashvayka 2022-04-14 13:19:23 -0700 Committed r292886 (249656@trunk): <https://commits.webkit.org/249656@trunk> 457640 2022-04-14 10:24:37 -0700 2022-04-14 10:37:48 -0700 Patch bug-239346-20220414182434.patch text/plain 4792 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyOTI4NzUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDIyLTA0LTE0ICBBbGV4ZXkgU2h2YXlrYSAgPGFzaHZheWthQGFw cGxlLmNvbT4KKworICAgICAgICBJbnRlcm5hbEZ1bmN0aW9uOjpjcmVhdGVTdWJjbGFzc1N0cnVj dHVyZSgpIHNob3VsZCB1c2UgYmFzZSBvYmplY3QncyBnbG9iYWwgb2JqZWN0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzkzNDYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9pbnRlcm5hbC1m dW5jdGlvbi1zdWJjbGFzcy1zdHJ1Y3R1cmUtcmVhbG0uanM6CisKIDIwMjItMDQtMTIgIEFkaXRp IFNpbmdoICA8YXNpbmdoQGlnYWxpYS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IENoYW5nZSBB cnJheSBieSBjb3B5IHByb3Bvc2FsCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9pbnRlcm5hbC1mdW5j dGlvbi1zdWJjbGFzcy1zdHJ1Y3R1cmUtcmVhbG0uanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9z dHJlc3MvaW50ZXJuYWwtZnVuY3Rpb24tc3ViY2xhc3Mtc3RydWN0dXJlLXJlYWxtLmpzCShyZXZp c2lvbiAyOTI4NzEpCisrKyBKU1Rlc3RzL3N0cmVzcy9pbnRlcm5hbC1mdW5jdGlvbi1zdWJjbGFz cy1zdHJ1Y3R1cmUtcmVhbG0uanMJKHdvcmtpbmcgY29weSkKQEAgLTEzLDcgKzEzLDcgQEAgY29u c3QgcjMgPSBjcmVhdGVHbG9iYWxPYmplY3QoKTsKICAgICAgICAgICAgIF0pIHsKICAgICAgICAg ICAgICAgICBPYmplY3QuZGVmaW5lUHJvcGVydHkobmV3VGFyZ2V0LCAicHJvdG90eXBlIiwgeyB2 YWx1ZTogbmV3IHIzLk9iamVjdCB9KTsKICAgICAgICAgICAgICAgICBjb25zdCBpbnN0YW5jZSA9 IFJlZmxlY3QuY29uc3RydWN0KHIxW2tleV0sIFtdLCBuZXdUYXJnZXQpOwotICAgICAgICAgICAg ICAgIGlmICgkdm0uZ2xvYmFsT2JqZWN0Rm9yT2JqZWN0KGluc3RhbmNlKSAhPT0gcjMpCisgICAg ICAgICAgICAgICAgaWYgKCR2bS5nbG9iYWxPYmplY3RGb3JPYmplY3QoaW5zdGFuY2UpICE9PSBy MikKICAgICAgICAgICAgICAgICAgICAgdGhyb3cgbmV3IEVycm9yKGBTdHJ1Y3R1cmUgb2YgJHtr ZXl9IGluc3RhbmNlIGhhcyBpbmNvcnJlY3QgZ2xvYmFsIG9iamVjdCFgKTsKICAgICAgICAgICAg IH0KICAgICAgICAgfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyOTI4 NzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMjItMDQtMTQgIEFsZXhleSBTaHZheWthICA8YXNodmF5a2FAYXBw bGUuY29tPgorCisgICAgICAgIEludGVybmFsRnVuY3Rpb246OmNyZWF0ZVN1YmNsYXNzU3RydWN0 dXJlKCkgc2hvdWxkIHVzZSBiYXNlIG9iamVjdCdzIGdsb2JhbCBvYmplY3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTM0NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9tZSBhbmQgRmlyZWZveCBk b24ndCBhZ3JlZSBvbiBpbnRlcm9wZXJhYmxlIGJlaGF2aW9yIGluIGNhc2Ugb2YgY3Jvc3MtcmVh bG0KKyAgICAgICAgTmV3VGFyZ2V0J3MgInByb3RvdHlwZSIsIHNvIHRoaXMgcGF0Y2ggYWxpZ25z IFdlYktpdCB3aXRoIENocm9tZSB0byBmaXggYSB3ZWItY29tcGF0IGlzc3VlLgorCisgICAgICAg ICogcnVudGltZS9JbnRlcm5hbEZ1bmN0aW9uLmNwcDoKKyAgICAgICAgKEpTQzo6SW50ZXJuYWxG dW5jdGlvbjo6Y3JlYXRlU3ViY2xhc3NTdHJ1Y3R1cmUpOgorCiAyMDIyLTA0LTE0ICBKdXN0aW4g TWljaGF1ZCAgPGp1c3Rpbl9taWNoYXVkQGFwcGxlLmNvbT4KIAogICAgICAgICBbUEdPXSBXZSBz aG91bGQgYmUgYWJsZSB0byBidWlsZCBXZWJLaXQgdG8gY29sbGVjdCBQR08gcHJvZmlsZXMgZWFz aWx5CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRlcm5hbEZ1bmN0aW9u LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRlcm5h bEZ1bmN0aW9uLmNwcAkocmV2aXNpb24gMjkyODcxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSW50ZXJuYWxGdW5jdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNyw2ICsx MzcsNyBAQCBTdHJ1Y3R1cmUqIEludGVybmFsRnVuY3Rpb246OmNyZWF0ZVN1YmNsCiB7CiAgICAg Vk0mIHZtID0gZ2xvYmFsT2JqZWN0LT52bSgpOwogICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RI Uk9XX1NDT1BFKHZtKTsKKyAgICBKU0dsb2JhbE9iamVjdCogYmFzZUdsb2JhbE9iamVjdCA9IGJh c2VDbGFzcy0+Z2xvYmFsT2JqZWN0KCk7CiAKICAgICBBU1NFUlQoYmFzZUNsYXNzLT5oYXNNb25v UHJvdG8oKSk7CiAKQEAgLTE0NiwyMiArMTQ3LDIxIEBAIFN0cnVjdHVyZSogSW50ZXJuYWxGdW5j dGlvbjo6Y3JlYXRlU3ViY2wKICAgICBpZiAoTElLRUxZKHRhcmdldEZ1bmN0aW9uKSkgewogICAg ICAgICBGdW5jdGlvblJhcmVEYXRhKiByYXJlRGF0YSA9IHRhcmdldEZ1bmN0aW9uLT5lbnN1cmVS YXJlRGF0YSh2bSk7CiAgICAgICAgIFN0cnVjdHVyZSogc3RydWN0dXJlID0gcmFyZURhdGEtPmlu dGVybmFsRnVuY3Rpb25BbGxvY2F0aW9uU3RydWN0dXJlKCk7Ci0gICAgICAgIGlmIChMSUtFTFko c3RydWN0dXJlICYmIHN0cnVjdHVyZS0+Y2xhc3NJbmZvKCkgPT0gYmFzZUNsYXNzLT5jbGFzc0lu Zm8oKSAmJiBzdHJ1Y3R1cmUtPmdsb2JhbE9iamVjdCgpID09IGJhc2VDbGFzcy0+Z2xvYmFsT2Jq ZWN0KCkpKQorICAgICAgICBpZiAoTElLRUxZKHN0cnVjdHVyZSAmJiBzdHJ1Y3R1cmUtPmNsYXNz SW5mbygpID09IGJhc2VDbGFzcy0+Y2xhc3NJbmZvKCkgJiYgc3RydWN0dXJlLT5nbG9iYWxPYmpl Y3QoKSA9PSBiYXNlR2xvYmFsT2JqZWN0KSkKICAgICAgICAgICAgIHJldHVybiBzdHJ1Y3R1cmU7 CiAKICAgICAgICAgLy8gTm90ZSwgUmVmbGVjdC5jb25zdHJ1Y3QgbWlnaHQgY2F1c2UgdGhlIHBy b2ZpbGUgdG8gY2h1cm4gYnV0IHdlIGRvbid0IGNhcmUuCiAgICAgICAgIEpTVmFsdWUgcHJvdG90 eXBlVmFsdWUgPSB0YXJnZXRGdW5jdGlvbi0+Z2V0KGdsb2JhbE9iamVjdCwgdm0ucHJvcGVydHlO YW1lcy0+cHJvdG90eXBlKTsKICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgbnVs bHB0cik7CiAgICAgICAgIGlmIChKU09iamVjdCogcHJvdG90eXBlID0ganNEeW5hbWljQ2FzdDxK U09iamVjdCo+KHZtLCBwcm90b3R5cGVWYWx1ZSkpCi0gICAgICAgICAgICByZXR1cm4gcmFyZURh dGEtPmNyZWF0ZUludGVybmFsRnVuY3Rpb25BbGxvY2F0aW9uU3RydWN0dXJlRnJvbUJhc2Uodm0s IHByb3RvdHlwZS0+Z2xvYmFsT2JqZWN0KHZtKSwgcHJvdG90eXBlLCBiYXNlQ2xhc3MpOworICAg ICAgICAgICAgcmV0dXJuIHJhcmVEYXRhLT5jcmVhdGVJbnRlcm5hbEZ1bmN0aW9uQWxsb2NhdGlv blN0cnVjdHVyZUZyb21CYXNlKHZtLCBiYXNlR2xvYmFsT2JqZWN0LCBwcm90b3R5cGUsIGJhc2VD bGFzcyk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgSlNWYWx1ZSBwcm90b3R5cGVWYWx1ZSA9IG5l d1RhcmdldC0+Z2V0KGdsb2JhbE9iamVjdCwgdm0ucHJvcGVydHlOYW1lcy0+cHJvdG90eXBlKTsK ICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgbnVsbHB0cik7CiAgICAgICAgIGlm IChKU09iamVjdCogcHJvdG90eXBlID0ganNEeW5hbWljQ2FzdDxKU09iamVjdCo+KHZtLCBwcm90 b3R5cGVWYWx1ZSkpIHsKICAgICAgICAgICAgIC8vIFRoaXMgb25seSBoYXBwZW5zIGlmIHNvbWVv bmUgUmVmbGVjdC5jb25zdHJ1Y3RzIG91ciBidWlsdGluIGNvbnN0cnVjdG9yIHdpdGggYW5vdGhl ciBidWlsdGluIGNvbnN0cnVjdG9yIGFzIHRoZSBuZXcudGFyZ2V0LgogICAgICAgICAgICAgLy8g VGh1cywgd2UgZG9uJ3QgY2FyZSBhYm91dCB0aGUgY29zdCBvZiBsb29raW5nIHVwIHRoZSBzdHJ1 Y3R1cmUgZnJvbSBvdXIgaGFzaCB0YWJsZSBldmVyeSB0aW1lLgotICAgICAgICAgICAgSlNHbG9i YWxPYmplY3QqIGdsb2JhbE9iamVjdCA9IHByb3RvdHlwZS0+Z2xvYmFsT2JqZWN0KHZtKTsKLSAg ICAgICAgICAgIHJldHVybiBnbG9iYWxPYmplY3QtPnN0cnVjdHVyZUNhY2hlKCkuZW1wdHlTdHJ1 Y3R1cmVGb3JQcm90b3R5cGVGcm9tQmFzZVN0cnVjdHVyZShnbG9iYWxPYmplY3QsIHByb3RvdHlw ZSwgYmFzZUNsYXNzKTsKKyAgICAgICAgICAgIHJldHVybiBiYXNlR2xvYmFsT2JqZWN0LT5zdHJ1 Y3R1cmVDYWNoZSgpLmVtcHR5U3RydWN0dXJlRm9yUHJvdG90eXBlRnJvbUJhc2VTdHJ1Y3R1cmUo Z2xvYmFsT2JqZWN0LCBwcm90b3R5cGUsIGJhc2VDbGFzcyk7CiAgICAgICAgIH0KICAgICB9CiAg ICAgCg==