239340 2022-04-14 09:14:35 -0700 -Wstringop-overflow warning in DocumentWriter.cpp 2022-05-13 10:59:30 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro mcatanzaro webkit-bug-importer oldest_to_newest 1861526 0 mcatanzaro 2022-04-14 09:14:35 -0700 -Wstringop-overflow warnings are *usually* false positives. I will need to look closer at this one: [3703/6690] Building CXX object Source/WebCore/CMakeFiles/...ivedSources/unified-sources/UnifiedSource-c57e08af-2.cpp.o In file included from /usr/include/c++/12/bits/shared_ptr_atomic.h:33, from /usr/include/c++/12/memory:78, from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/StdLibExtras.h:30, from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/FastMalloc.h:26, from /home/mcatanzaro/Projects/WebKit/Source/WebCore/config.h:56, from /home/mcatanzaro/Projects/WebKit/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp:27, from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WebCore/DerivedSources/unified-sources/UnifiedSource-c57e08af-2.cpp:1: In member function ‘std::__atomic_base<_IntTp>::__int_type std::__atomic_base<_IntTp>::operator++() [with _ITp = unsigned int]’, inlined from ‘void WTF::ThreadSafeRefCountedBase::ref() const’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/ThreadSafeRefCounted.h:60:9, inlined from ‘WTF::Ref<T, <template-parameter-1-2> >::Ref(T&) [with T = WebCore::Frame; Traits = WTF::RawPtrTraits<WebCore::Frame>]’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/Ref.h:67:19, inlined from ‘void WebCore::DocumentWriter::end()’ at /home/mcatanzaro/Projects/WebKit/Source/WebCore/loader/DocumentWriter.cpp:299:32: /usr/include/c++/12/bits/atomic_base.h:385:34: warning: ‘unsigned int __atomic_add_fetch_4(volatile void*, unsigned int, int)’ writing 4 bytes into a region of size 0 overflows the destination [-Wstringop-overflow=] 385 | { return __atomic_add_fetch(&_M_i, 1, int(memory_order_seq_cst)); } | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1868756 1 mcatanzaro 2022-05-13 07:40:46 -0700 If there's anything wrong with this code, there is no way to know it from this nonsense. I will suppress it. 1868757 2 webkit-bug-importer 2022-05-13 07:40:55 -0700 <rdar://problem/93243931> 1868760 3 mcatanzaro 2022-05-13 07:47:42 -0700 Pull request: https://github.com/WebKit/WebKit/pull/609 1868802 4 ews-feeder 2022-05-13 10:59:28 -0700 Committed r294164 (250533@main): <https://commits.webkit.org/250533@main> Reviewed commits have been landed. Closing PR #609 and removing active labels.