23934 2009-02-12 15:53:40 -0800 Skia platform doesn't render text decoration shadows 2009-02-13 11:06:17 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 sky webkit-unassigned brettw oldest_to_newest 109571 0 sky 2009-02-12 15:53:40 -0800 This is covered by these layout tests: LayoutTests/fast/repaint/shadow-multiple-horizontal.html LayoutTests/fast/repaint/shadow-multiple-strict-horizontal.html LayoutTests/fast/repaint/shadow-multiple-strict-vertical.html LayoutTests/fast/repaint/shadow-multiple-vertical.html 109572 1 27625 sky 2009-02-12 16:00:05 -0800 Created attachment 27625 Fix for 23934 109579 2 27625 eric 2009-02-12 16:11:03 -0800 Comment on attachment 27625 Fix for 23934 I don't quite understand why the fill/stroke changes are necessary. I'd also rather they were named something like fillColorWithAlpha() if you're going to pre-multiply the alpha? 109581 3 sky 2009-02-12 16:15:49 -0800 The alpha is stored separately in PlatformContextSkia. To get the real color to draw with you need to add the alpha into it. See other places in PlatformContextSkia that do the same song and dance. Brett suggested the name effectiveXXX. 109583 4 27625 eric 2009-02-12 16:28:31 -0800 Comment on attachment 27625 Fix for 23934 144 // Returns the stroke color. The returned color has it's alpha adjusted 145 // by the current alpha. Whoever lands this could change that comment to say "current context alpha" instead of just "current alpha" to be more specific that this is the context-wide alpha which CG supports, thus GraphicsContext supports, and thus we support. I talked this out with brett at length. The patch looks fine. 109705 5 dglazkov 2009-02-13 11:06:17 -0800 Landed as http://trac.webkit.org/changeset/40982. 27625 2009-02-12 16:00:05 -0800 2009-02-12 16:28:31 -0800 Fix for 23934 23934.patch text/plain 4998 sky SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDk0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjcgQEAKKzIwMDktMDItMTIgIFNjb3R0IFZpb2xldCAgPHNreUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzkzNAorICAgICAgICBTa2lhIHBs YXRmb3JtIGRvZXNuJ3QgcmVuZGVyIHRleHQgZGVjb3JhdGlvbiBzaGFkb3dzCisKKyAgICAgICAg TWFrZXMgU2tpYSByZW5kZXIgdGV4dCBkZWNvcmF0aW9uIHNoYWRvd3MgY29ycmVjdGx5LiBXZSB3 ZXJlbid0CisgICAgICAgIHByZXBhcmluZyB0aGUgU2tQYWludCBjb3JyZWN0bHkgYW5kIGRpZG4n dCBoYXZlIGEgY291cGxlIG9mIGNoZWNrcworICAgICAgICBDRyBoYXMuIEFkZGl0aW9uYWxseSBt YWtlcyB0aGUgZmlsbENvbG9yL3N0cm9rZUNvbG9yIG1ldGhvZHMKKyAgICAgICAgY29uc2lzdGVu dC4KKworICAgICAgICBUaGlzIGJlaGF2aW9yIGlzIGNvdmVyZWQgYnkgZXhpc3RpbmcgbGF5b3V0 IHRlc3RzIChzZWUgYnVnIGZvciBsaXN0KS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0ZvbnRDaHJvbWl1bVdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250Ojpk cmF3R2x5cGhzKToKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6OmRyYXdDb21wbGV4VGV4dCk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6ZHJhd0xpbmVGb3JUZXh0KToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwOgor ICAgICAgICAoUGxhdGZvcm1Db250ZXh0U2tpYTo6ZWZmZWN0aXZlRmlsbENvbG9yKToKKyAgICAg ICAgKFBsYXRmb3JtQ29udGV4dFNraWE6OmVmZmVjdGl2ZVN0cm9rZUNvbG9yKToKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuaDoKKwogMjAwOS0w Mi0xMiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIGdl dE92ZXJmbG93Q2xpcFJlY3QgYW5kIGdldENsaXBSZWN0IHRvIG92ZXJmbG93Q2xpcFJlY3QgYW5k IGNsaXBSZWN0LiAgTW92ZSB0aGVtIHRvIFJlbmRlckJveCwgc2luY2UgdGhlc2UgbWV0aG9kcwpJ bmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2hyb21pdW1XaW4u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9u dENocm9taXVtV2luLmNwcAkocmV2aXNpb24gNDA5NDYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL0ZvbnRDaHJvbWl1bVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc1 LDcgKzc1LDcgQEAgdm9pZCBGb250OjpkcmF3R2x5cGhzKEdyYXBoaWNzQ29udGV4dCogZwogICAg IC8vIERlZmF1bHQgc2l6ZSBmb3IgdGhlIGJ1ZmZlci4gSXQgc2hvdWxkIGJlIGVub3VnaCBmb3Ig bW9zdCBvZiBjYXNlcy4KICAgICBjb25zdCBpbnQga0RlZmF1bHRCdWZmZXJMZW5ndGggPSAyNTY7 CiAKLSAgICBTa0NvbG9yIGNvbG9yID0gY29udGV4dC0+ZmlsbENvbG9yKCk7CisgICAgU2tDb2xv ciBjb2xvciA9IGNvbnRleHQtPmVmZmVjdGl2ZUZpbGxDb2xvcigpOwogICAgIHVuc2lnbmVkIGNo YXIgYWxwaGEgPSBTa0NvbG9yR2V0QShjb2xvcik7CiAgICAgLy8gU2tpcCAxMDAlIHRyYW5zcGFy ZW50IHRleHQ7IG5vIG5lZWQgdG8gZHJhdyBhbnl0aGluZy4KICAgICBpZiAoIWFscGhhICYmIGNv bnRleHQtPmdldFN0cm9rZVN0eWxlKCkgPT0gTm9TdHJva2UpCkBAIC0xODMsNyArMTgzLDcgQEAg dm9pZCBGb250OjpkcmF3Q29tcGxleFRleHQoR3JhcGhpY3NDb250ZQogICAgIFBsYXRmb3JtR3Jh cGhpY3NDb250ZXh0KiBjb250ZXh0ID0gZ3JhcGhpY3NDb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQo KTsKICAgICBVbmlzY3JpYmVIZWxwZXJUZXh0UnVuIHN0YXRlKHJ1biwgKnRoaXMpOwogCi0gICAg U2tDb2xvciBjb2xvciA9IGNvbnRleHQtPmZpbGxDb2xvcigpOworICAgIFNrQ29sb3IgY29sb3Ig PSBjb250ZXh0LT5lZmZlY3RpdmVGaWxsQ29sb3IoKTsKICAgICB1bnNpZ25lZCBjaGFyIGFscGhh ID0gU2tDb2xvckdldEEoY29sb3IpOwogICAgIC8vIFNraXAgMTAwJSB0cmFuc3BhcmVudCB0ZXh0 OyBubyBuZWVkIHRvIGRyYXcgYW55dGhpbmcuCiAgICAgaWYgKCFhbHBoYSkKSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tp YS5jcHAJKHJldmlzaW9uIDQwOTQ2KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NDcsNiArNjQ3LDkg QEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmRyYXdMaW5lRm9yVGV4dChjbwogICAgIGlmIChwYWlu dGluZ0Rpc2FibGVkKCkpCiAgICAgICAgIHJldHVybjsKIAorICAgIGlmICh3aWR0aCA8PSAwKQor ICAgICAgICByZXR1cm47CisKICAgICBpbnQgdGhpY2tuZXNzID0gU2tNYXgzMihzdGF0aWNfY2Fz dDxpbnQ+KHN0cm9rZVRoaWNrbmVzcygpKSwgMSk7CiAgICAgU2tSZWN0IHI7CiAgICAgci5mTGVm dCA9IFNrSW50VG9TY2FsYXIocHQueCgpKTsKQEAgLTY1NSw3ICs2NTgsOSBAQCB2b2lkIEdyYXBo aWNzQ29udGV4dDo6ZHJhd0xpbmVGb3JUZXh0KGNvCiAgICAgci5mQm90dG9tID0gci5mVG9wICsg U2tJbnRUb1NjYWxhcih0aGlja25lc3MpOwogCiAgICAgU2tQYWludCBwYWludDsKLSAgICBwYWlu dC5zZXRDb2xvcihzdHJva2VDb2xvcigpLnJnYigpKTsKKyAgICBwbGF0Zm9ybUNvbnRleHQoKS0+ c2V0dXBQYWludEZvckZpbGxpbmcoJnBhaW50KTsKKyAgICAvLyBUZXh0IGxpbmVzIGFyZSBkcmF3 biB1c2luZyB0aGUgc3Ryb2tlIGNvbG9yLgorICAgIHBhaW50LnNldENvbG9yKHBsYXRmb3JtQ29u dGV4dCgpLT5lZmZlY3RpdmVTdHJva2VDb2xvcigpKTsKICAgICBwbGF0Zm9ybUNvbnRleHQoKS0+ Y2FudmFzKCktPmRyYXdSZWN0KHIsIHBhaW50KTsKIH0KIApJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAkocmV2 aXNpb24gNDA5NDYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1D b250ZXh0U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1MSw5ICs0NTEsMTQgQEAgdm9pZCBQ bGF0Zm9ybUNvbnRleHRTa2lhOjpzZXRVc2VBbnRpYWxpYQogICAgIG1fc3RhdGUtPm1fdXNlQW50 aWFsaWFzaW5nID0gZW5hYmxlOwogfQogCi1Ta0NvbG9yIFBsYXRmb3JtQ29udGV4dFNraWE6OmZp bGxDb2xvcigpIGNvbnN0CitTa0NvbG9yIFBsYXRmb3JtQ29udGV4dFNraWE6OmVmZmVjdGl2ZUZp bGxDb2xvcigpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIG1fc3RhdGUtPm1fZmlsbENvbG9yOworICAg IHJldHVybiBtX3N0YXRlLT5hcHBseUFscGhhKG1fc3RhdGUtPm1fZmlsbENvbG9yKTsKK30KKwor U2tDb2xvciBQbGF0Zm9ybUNvbnRleHRTa2lhOjplZmZlY3RpdmVTdHJva2VDb2xvcigpIGNvbnN0 Cit7CisgICAgcmV0dXJuIG1fc3RhdGUtPmFwcGx5QWxwaGEobV9zdGF0ZS0+bV9zdHJva2VDb2xv cik7CiB9CiAKIHZvaWQgUGxhdGZvcm1Db250ZXh0U2tpYTo6YmVnaW5QYXRoKCkKSW5kZXg6IFdl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNr aWEuaAkocmV2aXNpb24gNDA5NDYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEv UGxhdGZvcm1Db250ZXh0U2tpYS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzcsNyArMTM3LDEzIEBA IHB1YmxpYzoKICAgICB2b2lkIGFkZFBhdGgoY29uc3QgU2tQYXRoJik7CiAgICAgY29uc3QgU2tQ YXRoKiBjdXJyZW50UGF0aCgpIGNvbnN0IHsgcmV0dXJuICZtX3BhdGg7IH0KIAotICAgIFNrQ29s b3IgZmlsbENvbG9yKCkgY29uc3Q7CisgICAgLy8gUmV0dXJucyB0aGUgZmlsbCBjb2xvci4gVGhl IHJldHVybmVkIGNvbG9yIGhhcyBpdCdzIGFscGhhIGFkanVzdGVkCisgICAgLy8gYnkgdGhlIGN1 cnJlbnQgYWxwaGEuCisgICAgU2tDb2xvciBlZmZlY3RpdmVGaWxsQ29sb3IoKSBjb25zdDsKKwor ICAgIC8vIFJldHVybnMgdGhlIHN0cm9rZSBjb2xvci4gVGhlIHJldHVybmVkIGNvbG9yIGhhcyBp dCdzIGFscGhhIGFkanVzdGVkCisgICAgLy8gYnkgdGhlIGN1cnJlbnQgYWxwaGEuCisgICAgU2tD b2xvciBlZmZlY3RpdmVTdHJva2VDb2xvcigpIGNvbnN0OwogCiAgICAgc2tpYTo6UGxhdGZvcm1D YW52YXMqIGNhbnZhcygpIHsgcmV0dXJuIG1fY2FudmFzOyB9CiAK