239335 2022-04-14 08:12:23 -0700 Require an existing AtomString for HTMLFormElement's named getter parameter 2022-04-14 13:37:14 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ashvayka cdumez changseok darin esprehn+autocc ews-watchlist gyuyoung.kim kondapallykalyan mifenton sam webkit-bug-importer oldest_to_newest 1861502 0 cdumez 2022-04-14 08:12:23 -0700 Require an existing AtomString for HTMLFormElement's named getter parameter. There is no point in allocating a new AtomString as the AtomString should already exist if there is any element with this name / id. 1861504 1 457630 cdumez 2022-04-14 08:13:47 -0700 Created attachment 457630 Patch 1861605 2 457630 darin 2022-04-14 13:01:09 -0700 Comment on attachment 457630 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457630&action=review > Source/WebCore/html/HTMLFormElement.cpp:936 > + if (name.isEmpty()) > + return { }; This further optimizes the null and empty string cases, but slows down all the non-empty cases. I don’t think it’s needed for correctness, unless I missed something. I suppose it’s a good idea. > Source/WebCore/html/HTMLFormElement.idl:42 > + getter (RadioNodeList or Element)? ([RequiresExistingAtomString] DOMString name); Want to be sure these are good optimizations. I think I made RequiresExistingAtomString, and it’s obviously helpful if people often look for something that doesn’t exist, but it might *slightly* slow down the case of looking for things that do exist. 1861616 3 ews-feeder 2022-04-14 13:36:25 -0700 Committed r292887 (249657@main): <https://commits.webkit.org/249657@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457630. 1861617 4 webkit-bug-importer 2022-04-14 13:37:14 -0700 <rdar://problem/91774265> 457630 2022-04-14 08:13:47 -0700 2022-04-14 13:36:27 -0700 Patch bug-239335-20220414081346.patch text/plain 2534 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyODY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjczMDkxM2E2ZTFiY2Q1 NTE0YTkyMzQ2ZTUzMjViNjczNDk3NDZkNS4uMzYyNjVjMjUxODQxMDQ1OWI4NTgwOWVmMWZhZjI3 ZmNmYjg0YzlmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTA0LTE0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVxdWlyZSBhbiBleGlzdGlu ZyBBdG9tU3RyaW5nIGZvciBIVE1MRm9ybUVsZW1lbnQncyBuYW1lZCBnZXR0ZXIgcGFyYW1ldGVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzkzMzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXF1aXJl IGFuIGV4aXN0aW5nIEF0b21TdHJpbmcgZm9yIEhUTUxGb3JtRWxlbWVudCdzIG5hbWVkIGdldHRl ciBwYXJhbWV0ZXIuIFRoZXJlIGlzIG5vIHBvaW50CisgICAgICAgIGluIGFsbG9jYXRpbmcgYSBu ZXcgQXRvbVN0cmluZyBhcyB0aGUgQXRvbVN0cmluZyBzaG91bGQgYWxyZWFkeSBleGlzdCBpZiB0 aGVyZSBpcyBhbnkgZWxlbWVudAorICAgICAgICB3aXRoIHRoaXMgbmFtZSAvIGlkLgorCisgICAg ICAgICogaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZv cm1FbGVtZW50OjpuYW1lZEVsZW1lbnRzKToKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtRWxlbWVu dC5pZGw6CisKIDIwMjItMDQtMTQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXF1aXJlIGFuIGV4aXN0aW5nIEF0b21TdHJpbmcgZm9yIEhUTUxEb2N1bWVudCdz IG5hbWVkIGdldHRlciBwYXJhbWV0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTEZvcm1FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50 LmNwcAppbmRleCBkNGY1NmFkMTU5ZTQ3M2ZlOTNkMzYxNDE4ODM3NmU3ZWFiY2FjZTkyLi4yYTBh MjRkOTBiMzk3MDFhNDRmZjFlZDExZGNjMWY2YzI3ZTU2ZGYxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRm9ybUVsZW1lbnQuY3BwCkBAIC05MzIsNiArOTMyLDkgQEAgYm9vbCBIVE1MRm9ybUVs ZW1lbnQ6Om1hdGNoZXNJbnZhbGlkUHNldWRvQ2xhc3MoKSBjb25zdAogLy8gRklYTUU6IFVzZSBS ZWY8SFRNTEVsZW1lbnQ+IGZvciB0aGUgZnVuY3Rpb24gcmVzdWx0IHNpbmNlIHRoZXJlIGFyZSBu byBub24tSFRNTCBlbGVtZW50cyByZXR1cm5lZCBoZXJlLgogVmVjdG9yPFJlZjxFbGVtZW50Pj4g SFRNTEZvcm1FbGVtZW50OjpuYW1lZEVsZW1lbnRzKGNvbnN0IEF0b21TdHJpbmcmIG5hbWUpCiB7 CisgICAgaWYgKG5hbWUuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4geyB9OworCiAgICAgLy8g aHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay9tdWx0aXBh Z2UvZm9ybXMuaHRtbCNkb20tZm9ybS1uYW1lZGl0ZW0KICAgICBWZWN0b3I8UmVmPEVsZW1lbnQ+ PiBuYW1lZEl0ZW1zID0gZWxlbWVudHMoKS0+bmFtZWRJdGVtcyhuYW1lKTsKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuaWRsCmluZGV4IDEyMDkwNjYwZmU1ZjkwYzM4NWQ1MWEy NzVkZDZlYjlmNWQ4Y2Q5ZjkuLjgwZDUxMzE3MmZhZjUxZDkyYmMzZDY5MmYxMmI2ZmVjNTI4NDM5 YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5pZGwKQEAgLTM5LDcgKzM5 LDcgQEAKICAgICByZWFkb25seSBhdHRyaWJ1dGUgSFRNTEZvcm1Db250cm9sc0NvbGxlY3Rpb24g ZWxlbWVudHM7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIGxvbmcgbGVuZ3RoOwog ICAgIGdldHRlciBFbGVtZW50PyAodW5zaWduZWQgbG9uZyBpbmRleCk7Ci0gICAgZ2V0dGVyIChS YWRpb05vZGVMaXN0IG9yIEVsZW1lbnQpPyAoW0F0b21TdHJpbmddIERPTVN0cmluZyBuYW1lKTsK KyAgICBnZXR0ZXIgKFJhZGlvTm9kZUxpc3Qgb3IgRWxlbWVudCk/IChbUmVxdWlyZXNFeGlzdGlu Z0F0b21TdHJpbmddIERPTVN0cmluZyBuYW1lKTsKIAogICAgIFtJbXBsZW1lbnRlZEFzPXN1Ym1p dEZyb21KYXZhU2NyaXB0XSB1bmRlZmluZWQgc3VibWl0KCk7CiAgICAgW0VuYWJsZWRCeVNldHRp bmc9UmVxdWVzdFN1Ym1pdEVuYWJsZWRdIHVuZGVmaW5lZCByZXF1ZXN0U3VibWl0KG9wdGlvbmFs IEhUTUxFbGVtZW50PyBzdWJtaXR0ZXIpOwo=