239329 2022-04-14 05:05:57 -0700 [git-webkit] Personal branch is "not a PR branch" 2022-04-14 14:16:22 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 239082 1 graouts jbedard jbedard mcatanzaro webkit-bug-importer oldest_to_newest 1861448 0 graouts 2022-04-14 05:05:57 -0700 I've been working on a bug and created a local branch "macos-preview-cleanup" off main using `git checkout -b macos-preview-cleanup` which I then pushed to my fork. My remotes are listed as such: fork git@github.com:graouts/WebKit.git (fetch) fork git@github.com:graouts/WebKit.git (push) graouts git@github.com:graouts/WebKit.git (fetch) graouts git@github.com:graouts/WebKit.git (push) origin git@github.com:WebKit/WebKit.git (fetch) origin git@github.com:WebKit/WebKit.git (push) So my branch is set to track "graouts/macos-preview-cleanup" I created my ChangeLog prior to starting the PR process using `prepare-ChangeLog -o --merge-base main -b XXXXXX`. Then I ran the following and things didn't work: OpenSource > git-webkit pr 'macos-preview-cleanup' is not a pull request branch, enter name of new branch (or bug URL): ^C User interrupted program I would have expected that my branch which is already pushed to a remote should be able to be used as-is for a pull request. 1861519 1 webkit-bug-importer 2022-04-14 08:58:40 -0700 <rdar://problem/91756286> 1861524 2 jbedard 2022-04-14 09:07:47 -0700 Pull request: https://github.com/WebKit/WebKit/pull/290 1861549 3 mcatanzaro 2022-04-14 10:08:46 -0700 (In reply to Jonathan Bedard from comment #2) > Pull request: https://github.com/WebKit/WebKit/pull/290 This probably/mostly also fixes bug #239126, yes? 1861563 4 jbedard 2022-04-14 10:36:08 -0700 (In reply to Michael Catanzaro from comment #3) > (In reply to Jonathan Bedard from comment #2) > > Pull request: https://github.com/WebKit/WebKit/pull/290 > > This probably/mostly also fixes bug #239126, yes? It won't change what we're encouraging you to do, but yes, it will mean we support most flavors of personally created branches. There is still the matter of EWS's pickiness regarding PRs from main branches, which we should continue to discuss in https://bugs.webkit.org/show_bug.cgi?id=239126. 1861628 5 ews-feeder 2022-04-14 14:16:19 -0700 Committed r292890 (249660@main): <https://commits.webkit.org/249660@main> Reviewed commits have been landed. Closing PR #290 and removing active labels.