23928 2009-02-12 10:30:24 -0800 Fix run-webkit-tests to skip some dirs when new features are turned off 2009-02-12 14:30:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Enhancement --- 23359 1 simon.fraser simon.fraser gsherloc oldest_to_newest 109500 0 simon.fraser 2009-02-12 10:30:24 -0800 It should be possible for run-webkit-tests to run additional tests to test features that are inside of #ifdefs, without the user having to specify additional directories manually. As is done for SVG, this can be done by using 'nm' to detect if the feature is turned on (by looking for a unique symbol), and then looking for specific test directories. 109525 1 27615 simon.fraser 2009-02-12 11:41:59 -0800 Created attachment 27615 Patch, changelog 109546 2 27615 aroben 2009-02-12 13:04:00 -0800 Comment on attachment 27615 Patch, changelog > +if (!checkWebCoreAcceleratedCompositingSupport(0)) { > + $ignoredDirectories{'compositing'} = 1; > +} I guess this is the style already used by SVG/WML, but I think something like this would be clearer: if (!checkWebCoreAcceleratedCompositingSupport({required => 0})) { r=me 109558 3 simon.fraser 2009-02-12 14:30:57 -0800 http://trac.webkit.org/changeset/40927 27615 2009-02-12 11:41:59 -0800 2009-02-12 13:04:00 -0800 Patch, changelog 23928_patch.txt text/plain 3556 simon.fraser ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhMDJhZmJkLi4zZmNlOTkwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDIt MTIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzOTI4CisgICAgICAgIAorICAgICAgICBBZGQgZGV0ZWN0aW9u IG9mIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGFuZCAzZCB0cmFuc2Zvcm1zLAorICAgICAgICBh bmQgYWRkIHZhcmlvdXMgZGlyZWN0b3JpZXMgdG8gJGlnbm9yZWREaXJlY3RvcmllcyB3aGVuIHRo ZXNlCisgICAgICAgIGZlYXR1cmVzIGFyZSBvZmYuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13 ZWJraXQtdGVzdHM6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorCiAyMDA5LTAy LTEyICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggQnVnIDIz OTIyOiBXYXJuaW5nIG1lc3NhZ2UgZnJvbSBydW4td2Via2l0LXRlc3RzIHdoZW4gU2tpcHBlZCBm aWxlCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKaW5kZXggNjY0MjMyZi4uYTk0Zjcx OSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCisrKyBi L1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwpAQCAtMSw2ICsxLDYgQEAKICMh L3Vzci9iaW4vcGVybAogCi0jIENvcHlyaWdodCAoQykgMjAwNSwgMjAwNiwgMjAwNyBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAwNSwgMjAwNiwgMjAw NywgMjAwOCwgMjAwOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAjIENvcHlyaWdo dCAoQykgMjAwNiBBbGV4ZXkgUHJvc2t1cnlha292IChhcEBueXBvcC5jb20pCiAjIENvcHlyaWdo dCAoQykgMjAwNyBNYXR0IExpbGVrIChwZXd0ZXJtb29zZUBnbWFpbC5jb20pCiAjIENvcHlyaWdo dCAoQykgMjAwNyBFcmljIFNlaWRlbCA8ZXJpY0B3ZWJraXQub3JnPgpAQCAtMzcxLDYgKzM3MSwx NSBAQCBpZiAoISR0ZXN0TWVkaWEpIHsKICAgICAkaWdub3JlZERpcmVjdG9yaWVzeydodHRwL3Rl c3RzL21lZGlhJ30gPSAxOwogfQogCitpZiAoIWNoZWNrV2ViQ29yZUFjY2VsZXJhdGVkQ29tcG9z aXRpbmdTdXBwb3J0KDApKSB7CisgICAgJGlnbm9yZWREaXJlY3Rvcmllc3snY29tcG9zaXRpbmcn fSA9IDE7Cit9CisKK2lmICghY2hlY2tXZWJDb3JlM0RUcmFuc2Zvcm1zU3VwcG9ydCgwKSkgewor ICAgICRpZ25vcmVkRGlyZWN0b3JpZXN7J2FuaW1hdGlvbnMvM2QnfSA9IDE7CisgICAgJGlnbm9y ZWREaXJlY3Rvcmllc3sndHJhbnNmb3Jtcy8zZCd9ID0gMTsKK30KKwogaWYgKCRpZ25vcmVUZXN0 cykgewogICAgIHByb2Nlc3NJZ25vcmVUZXN0cygkaWdub3JlVGVzdHMsICJpZ25vcmUtdGVzdHMi KTsKIH0KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBhZjhiZjNmLi44YTg2YzQ5IDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC00NjYsNiArNDY2LDY0IEBAIHN1YiBjaGVj a1dlYkNvcmVTVkdTdXBwb3J0CiAgICAgcmV0dXJuICRoYXNTVkc7CiB9CiAKK3N1YiBoYXNBY2Nl bGVyYXRlZENvbXBvc2l0aW5nU3VwcG9ydAoreworICAgIHJldHVybiAwIGlmIGlzQ3lnd2luKCk7 CisgICAgCisgICAgbXkgJHBhdGggPSBzaGlmdDsKKworICAgIG15ICR1c2VBY2NlbGVyYXRlZENv bXBvc2l0aW5nID0gMDsKKyAgICBpZiAoLWUgJHBhdGgpIHsKKyAgICAgICAgb3BlbiBOTSwgIi18 IiwgIm5tIiwgJHBhdGggb3IgZGllOworICAgICAgICB3aGlsZSAoPE5NPikgeworICAgICAgICAg ICAgJHVzZUFjY2VsZXJhdGVkQ29tcG9zaXRpbmcgPSAxIGlmIC9HcmFwaGljc0xheWVyLzsKKyAg ICAgICAgfQorICAgICAgICBjbG9zZSBOTTsKKyAgICB9CisgICAgcmV0dXJuICR1c2VBY2NlbGVy YXRlZENvbXBvc2l0aW5nOworfQorCitzdWIgY2hlY2tXZWJDb3JlQWNjZWxlcmF0ZWRDb21wb3Np dGluZ1N1cHBvcnQKK3sKKyAgICBteSAkcmVxdWlyZWQgPSBzaGlmdDsKKyAgICBteSAkZnJhbWV3 b3JrID0gIldlYkNvcmUiOworICAgIG15ICRwYXRoID0gYnVpbHREeWxpYlBhdGhGb3JOYW1lKCRm cmFtZXdvcmspOworICAgIG15ICRoYXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nID0gaGFzQWNjZWxl cmF0ZWRDb21wb3NpdGluZ1N1cHBvcnQoJHBhdGgpOworICAgIGlmICgkcmVxdWlyZWQgJiYgISRo YXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nKSB7CisgICAgICAgIGRpZSAiJGZyYW1ld29yayBhdCBc IiRwYXRoXCIgZG9lcyBub3QgdXNlIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nXG4iOworICAgIH0K KyAgICByZXR1cm4gJGhhc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmc7Cit9CisKK3N1YiBoYXMzRFRy YW5zZm9ybXNTdXBwb3J0Cit7CisgICAgcmV0dXJuIDAgaWYgaXNDeWd3aW4oKTsKKyAgICAKKyAg ICBteSAkcGF0aCA9IHNoaWZ0OworCisgICAgbXkgJGhhczNEVHJhbnNmb3Jtc1N1cHBvcnQgPSAw OworICAgIGlmICgtZSAkcGF0aCkgeworICAgICAgICBvcGVuIE5NLCAiLXwiLCAibm0iLCAkcGF0 aCBvciBkaWU7CisgICAgICAgIHdoaWxlICg8Tk0+KSB7CisgICAgICAgICAgICAkaGFzM0RUcmFu c2Zvcm1zU3VwcG9ydCA9IDEgaWYgL1dlYkNvcmVIYXMzRFRyYW5zZm9ybXMvOworICAgICAgICB9 CisgICAgICAgIGNsb3NlIE5NOworICAgIH0KKyAgICByZXR1cm4gJGhhczNEVHJhbnNmb3Jtc1N1 cHBvcnQ7Cit9CisKK3N1YiBjaGVja1dlYkNvcmUzRFRyYW5zZm9ybXNTdXBwb3J0Cit7CisgICAg bXkgJHJlcXVpcmVkID0gc2hpZnQ7CisgICAgbXkgJGZyYW1ld29yayA9ICJXZWJDb3JlIjsKKyAg ICBteSAkcGF0aCA9IGJ1aWx0RHlsaWJQYXRoRm9yTmFtZSgkZnJhbWV3b3JrKTsKKyAgICBteSAk aGFzM0RUcmFuc2Zvcm1zID0gaGFzM0RUcmFuc2Zvcm1zU3VwcG9ydCgkcGF0aCk7CisgICAgaWYg KCRyZXF1aXJlZCAmJiAhJGhhczNEVHJhbnNmb3JtcykgeworICAgICAgICBkaWUgIiRmcmFtZXdv cmsgYXQgXCIkcGF0aFwiIGRvZXMgbm90IGluY2x1ZGUgM0QgVHJhbnNmb3JtcyBTdXBwb3J0LCBw bGVhc2UgcnVuIGJ1aWxkLXdlYmtpdCAtLTNkLXRyYW5zZm9ybXNcbiI7CisgICAgfQorICAgIHJl dHVybiAkaGFzM0RUcmFuc2Zvcm1zOworfQorCiBzdWIgaGFzV01MU3VwcG9ydAogewogICAgIHJl dHVybiAwIGlmIGlzQ3lnd2luKCk7Cg==