<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>239268</bug_id>
          
          <creation_ts>2022-04-12 17:43:52 -0700</creation_ts>
          <short_desc>[WinCairo] WEBKIT_LIBRARIES env var should be customizable</short_desc>
          <delta_ts>2022-04-13 13:07:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>achristensen</cc>
    
    <cc>basuke</cc>
    
    <cc>bfulgham</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>pvollan</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1860981</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2022-04-12 17:43:52 -0700</bug_when>
    <thetext>Even though WEBKIT_LIBRARIES is a env var, it isn&apos;t customizable.
It should set to WebKitLibraries\win directory for WinCairo builds.

&gt; set WEBKIT_LIBRARIES=%~dp0WebKitLibraries\win

This has two problems:

1. It is the same directory with one AppleWin is using. This is error prone. See Bug 238988.
2. WebKitLibraries\win directory is a source directory. It isn&apos;t a good practise to overwrite source directories.

I&apos;d like to set it to a WinCairo specific directory for me. For example,

&gt; set WEBKIT_LIBRARIES=%~dp0WinCairoLibraries

As for now, if I change the env var, the build fails. auto-version.pl is missing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1861014</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2022-04-12 20:38:07 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/280</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1861232</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-04-13 13:06:20 -0700</bug_when>
    <thetext>Committed r292824 (249600@main): &lt;https://commits.webkit.org/249600@main&gt;

Reviewed commits have been landed. Closing PR #280 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1861234</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-04-13 13:07:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/91709965&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>