23922 2009-02-12 08:02:31 -0800 Warning message from run-webkit-tests when Skipped file contains non-existent tests is confusing and is given for disabled tests 2009-02-12 08:48:42 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 aroben aroben oldest_to_newest 109477 0 aroben 2009-02-12 08:02:31 -0800 The Warning message from run-webkit-tests when the Skipped list contains non-existent tests is confusing. It says: ignoring item 'fast/css/computed-style.html' from ignore-tests list There are at least two things wrong with this: 1) it uses a double-negative 2) the test wasn't in the "ignore-tests" list, it was in the "Skipped" list 109478 1 aroben 2009-02-12 08:03:03 -0800 The warning is also emitted for disabled tests, which seems unhelpful. 109479 2 27603 aroben 2009-02-12 08:05:55 -0800 Created attachment 27603 patch + changelog v1 109483 3 aroben 2009-02-12 08:48:42 -0800 Committed in r40906 27603 2009-02-12 08:05:55 -0800 2009-02-12 08:43:46 -0800 patch + changelog v1 0001--Fix-Bug-23922-Warning-message-from-run-webk.patch text/plain 4189 aroben RnJvbSA2YzAzZmNiODMyODU4MDRkYjdmNjA4YWJjODg3ZDE2MWQwZmQyZDU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBU aHUsIDEyIEZlYiAyMDA5IDExOjA1OjI3IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gICAgICAgICBG aXggQnVnIDIzOTIyOiBXYXJuaW5nIG1lc3NhZ2UgZnJvbSBydW4td2Via2l0LXRlc3RzIHdoZW4g U2tpcHBlZCBmaWxlIGNvbnRhaW5zIG5vbi1leGlzdGVudCB0ZXN0cyBpcyBjb25mdXNpbmcgYW5k IGlzIGdpdmVuIGZvciBkaXNhYmxlZCB0ZXN0cwoKICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTIyPgoKICAgICAgICBXZSBub3cgbm8gbG9uZ2VyIHdh cm4gYWJvdXQgZGlzYWJsZWQgdGVzdHMuIFRoZSB3YXJuaW5nIG5vdyByZWFkczoKCiAgICAgICAg U2tpcHBlZCBsaXN0IGNvbnRhaW5lZCAnJGl0ZW0nLCBidXQgbm8gZmlsZSBvZiB0aGF0IG5hbWUg Y291bGQgYmUKICAgICAgICBmb3VuZAoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KCiAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHM6CiAgICAgICAgKHRvcCBsZXZl bCk6IFBhc3MgdGhlIGxpc3QgbmFtZSB0byBwcm9jZXNzSWdub3JlVGVzdHMgc28gaXQgY2FuIHBy aW50CiAgICAgICAgb3V0IGEgcmVhc29uYWJsZSB3YXJuaW5nIG1lc3NhZ2UuCiAgICAgICAgKHBy b2Nlc3NJZ25vcmVUZXN0cyk6IFRha2UgYSBsaXN0IG5hbWUgYXMgYSBzZWNvbmQgcGFyYW1ldGVy IGFuZCB1c2UKICAgICAgICBpdCB0byBkaXNwbGF5IGEgYmV0dGVyIHdhcm5pbmcgbWVzc2FnZS4g QWxzbyBjaGVjayBmb3IgYSAiLWRpc2FibGVkIgogICAgICAgIHZlcnNpb24gb2YgdGhlIHRlc3Qg YmVmb3JlIHdhcm5pbmcgYWJvdXQgaXQgbm90IGV4aXN0aW5nLgotLS0KIFdlYktpdFRvb2xzL0No YW5nZUxvZyAgICAgICAgICAgICAgICB8ICAgMjIgKysrKysrKysrKysrKysrKysrKysrKwogV2Vi S2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzIHwgICAxOSArKysrKysrKysrKystLS0t LS0tCiAyIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9n CmluZGV4IGZmMGU2ZDMuLmNiZmE0ZmQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxv ZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAwOS0wMi0x MiAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IEJ1ZyAyMzky MjogV2FybmluZyBtZXNzYWdlIGZyb20gcnVuLXdlYmtpdC10ZXN0cyB3aGVuIFNraXBwZWQgZmls ZQorICAgICAgICBjb250YWlucyBub24tZXhpc3RlbnQgdGVzdHMgaXMgY29uZnVzaW5nIGFuZCBp cyBnaXZlbiBmb3IgZGlzYWJsZWQKKyAgICAgICAgdGVzdHMKKworICAgICAgICA8aHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTIyPgorCisgICAgICAgIFdlIG5vdyBu byBsb25nZXIgd2FybiBhYm91dCBkaXNhYmxlZCB0ZXN0cy4gVGhlIHdhcm5pbmcgbm93IHJlYWRz OgorCisgICAgICAgIFNraXBwZWQgbGlzdCBjb250YWluZWQgJyRpdGVtJywgYnV0IG5vIGZpbGUg b2YgdGhhdCBuYW1lIGNvdWxkIGJlCisgICAgICAgIGZvdW5kCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHM6 CisgICAgICAgICh0b3AgbGV2ZWwpOiBQYXNzIHRoZSBsaXN0IG5hbWUgdG8gcHJvY2Vzc0lnbm9y ZVRlc3RzIHNvIGl0IGNhbiBwcmludAorICAgICAgICBvdXQgYSByZWFzb25hYmxlIHdhcm5pbmcg bWVzc2FnZS4KKyAgICAgICAgKHByb2Nlc3NJZ25vcmVUZXN0cyk6IFRha2UgYSBsaXN0IG5hbWUg YXMgYSBzZWNvbmQgcGFyYW1ldGVyIGFuZCB1c2UKKyAgICAgICAgaXQgdG8gZGlzcGxheSBhIGJl dHRlciB3YXJuaW5nIG1lc3NhZ2UuIEFsc28gY2hlY2sgZm9yIGEgIi1kaXNhYmxlZCIKKyAgICAg ICAgdmVyc2lvbiBvZiB0aGUgdGVzdCBiZWZvcmUgd2FybmluZyBhYm91dCBpdCBub3QgZXhpc3Rp bmcuCisKIDIwMDktMDItMTEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFdpbmRvd3MgZml4IGZvciBCdWcgMjIyMzk6IEltcGxlbWVudCBtaXNzaW5nIGFuaW1hdGlv biAmIHRyYW5zaXRpb24KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtp dC10ZXN0cyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwppbmRleCA0ZjM1 MzAyLi42NjQyMzJmIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQt dGVzdHMKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCkBAIC03Niw3 ICs3Niw3IEBAIHN1YiBmaWxlTmFtZVdpdGhOdW1iZXIoJCQpOwogc3ViIG51bWVyaWNjbXAoJCQp Owogc3ViIG9wZW5IVFRQRElmTmVlZGVkKCk7CiBzdWIgcGF0aGNtcCgkJCk7Ci1zdWIgcHJvY2Vz c0lnbm9yZVRlc3RzKCQpOworc3ViIHByb2Nlc3NJZ25vcmVUZXN0cygkJCk7CiBzdWIgc2xvd2Vz dGNtcCgkJCk7CiBzdWIgc3BsaXRwYXRoKCQpOwogc3ViIHN0cmlwRXh0ZW5zaW9uKCQpOwpAQCAt MzcyLDcgKzM3Miw3IEBAIGlmICghJHRlc3RNZWRpYSkgewogfQogCiBpZiAoJGlnbm9yZVRlc3Rz KSB7Ci0gICAgcHJvY2Vzc0lnbm9yZVRlc3RzKCRpZ25vcmVUZXN0cyk7CisgICAgcHJvY2Vzc0ln bm9yZVRlc3RzKCRpZ25vcmVUZXN0cywgImlnbm9yZS10ZXN0cyIpOwogfQogCiBpZiAoISRpZ25v cmVTa2lwcGVkKSB7CkBAIC0zOTUsNyArMzk1LDcgQEAgaWYgKCEkaWdub3JlU2tpcHBlZCkgewog ICAgICAgICAgICAgICAgICAgICAgICAgaWYgKCR2ZXJib3NlKSB7CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcHJpbnQgIiAgICAkc2tpcHBlZFxuIjsKICAgICAgICAgICAgICAgICAgICAg ICAgIH0KLSAgICAgICAgICAgICAgICAgICAgICAgIHByb2Nlc3NJZ25vcmVUZXN0cygkc2tpcHBl ZCk7CisgICAgICAgICAgICAgICAgICAgICAgICBwcm9jZXNzSWdub3JlVGVzdHMoJHNraXBwZWQs ICJTa2lwcGVkIik7CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9CiAg ICAgICAgICAgICB9CkBAIC0xMzg2LDggKzEzODYsMTIgQEAgc3ViIGZpbGVOYW1lV2l0aE51bWJl cigkJCkKICAgICByZXR1cm4gJGJhc2U7CiB9CiAKLXN1YiBwcm9jZXNzSWdub3JlVGVzdHMoJCkg eworc3ViIHByb2Nlc3NJZ25vcmVUZXN0cygkJCkgewogICAgIG15IEBpZ25vcmVMaXN0ID0gc3Bs aXQoL1xzKixccyovLCBzaGlmdCk7CisgICAgbXkgJGxpc3ROYW1lID0gc2hpZnQ7CisKKyAgICBt eSAkZGlzYWJsZWRTdWZmaXggPSAiLWRpc2FibGVkIjsKKwogICAgIG15ICRhZGRJZ25vcmVkRGly ZWN0b3JpZXMgPSBzdWIgewogICAgICAgICByZXR1cm4gKCkgaWYgZXhpc3RzICRpZ25vcmVkTG9j YWxEaXJlY3Rvcmllc3tiYXNlbmFtZSgkRmlsZTo6RmluZDo6ZGlyKX07CiAgICAgICAgICRpZ25v cmVkRGlyZWN0b3JpZXN7RmlsZTo6U3BlYy0+YWJzMnJlbCgkRmlsZTo6RmluZDo6ZGlyLCAkdGVz dERpcmVjdG9yeSl9ID0gMTsKQEAgLTE0MDEsOSArMTQwNSwxMCBAQCBzdWIgcHJvY2Vzc0lnbm9y ZVRlc3RzKCQpIHsKICAgICAgICAgfQogICAgICAgICBlbHNpZiAoLWYgJHBhdGgpIHsKICAgICAg ICAgICAgICRpZ25vcmVkRmlsZXN7JGl0ZW19ID0gMTsKLSAgICAgICAgfQotICAgICAgICBlbHNl IHsKLSAgICAgICAgICAgIHByaW50ICJpZ25vcmluZyAnJGl0ZW0nIG9uIGlnbm9yZS10ZXN0cyBs aXN0XG4iOworICAgICAgICB9IGVsc2lmICgtZiAkcGF0aCAuICRkaXNhYmxlZFN1ZmZpeCkgewor ICAgICAgICAgICAgIyBUaGUgdGVzdCBpcyBkaXNhYmxlZCwgc28gZG8gbm90aGluZy4KKyAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHByaW50ICIkbGlzdE5hbWUgbGlzdCBjb250YWluZWQg JyRpdGVtJywgYnV0IG5vIGZpbGUgb2YgdGhhdCBuYW1lIGNvdWxkIGJlIGZvdW5kXG4iOwogICAg ICAgICB9CiAgICAgfQogfQotLSAKMS42LjEKCg==