23920 2009-02-12 07:34:29 -0800 build script doesn't respect setting installation prefix 2009-02-16 19:15:30 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Normal --- 1 gustavo gustavo oldest_to_newest 109472 0 gustavo 2009-02-12 07:34:29 -0800 The script used to build WebKit expects a WebKitInstallationPrefix environment variable to exist, which should be used to set the installation prefix for autotools builds. The setting is currently being ignored, though. 109473 1 27602 gustavo 2009-02-12 07:36:29 -0800 Created attachment 27602 proposed fix 109474 2 27602 aroben 2009-02-12 07:38:33 -0800 Comment on attachment 27602 proposed fix > + push @buildArgs, "--prefix=" . $prefix if(defined($prefix)); We normally leave out the parentheses around the condition in these postfix ifs: push @buildArgs, "--prefix=" . $prefix if defined($prefix); r=me 109911 3 gustavo 2009-02-16 19:15:30 -0800 Landed in r41033. 27602 2009-02-12 07:36:29 -0800 2009-02-12 07:38:33 -0800 proposed fix 0001-Actually-use-the-installation-prefix-defined-in-WebK.patch text/plain 1504 gustavo RnJvbSA1OTlkNWVjMmQ3YjFmN2QwNDY2MDI1MzMwZTE2NmZjNTI1MjlmN2QwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUaHUsIDEyIEZlYiAyMDA5IDEzOjI4OjA1IC0wMjAwClN1YmplY3Q6IFtQQVRDSF0g QWN0dWFsbHkgdXNlIHRoZSBpbnN0YWxsYXRpb24gcHJlZml4IGRlZmluZWQgaW4gV2ViS2l0SW5z dGFsbGF0aW9uUHJlZml4LAogaW4gYXV0b3Rvb2xzIGJ1aWxkcy4KCi0tLQogV2ViS2l0VG9vbHMv Q2hhbmdlTG9nICAgICAgICAgICAgIHwgICAgOSArKysrKysrKysKIFdlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbSB8ICAgIDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9u cygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cg Yi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggZmYwZTZkMy4uMmExMjNlNiAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEyIEBACisyMDA5LTAyLTEyICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25v bWUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFjdHVhbGx5IHVzZSB0aGUgaW5zdGFsbGF0aW9uIHByZWZpeCBkZWZpbmVkIGluIFdlYktpdElu c3RhbGxhdGlvblByZWZpeCwKKyAgICAgICAgaW4gYXV0b3Rvb2xzIGJ1aWxkcy4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKwogMjAwOS0wMi0xMSAgQWRhbSBSb2JlbiAgPGFy b2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2luZG93cyBmaXggZm9yIEJ1ZyAyMjIzOTogSW1w bGVtZW50IG1pc3NpbmcgYW5pbWF0aW9uICYgdHJhbnNpdGlvbgpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRk aXJzLnBtCmluZGV4IGFmOGJmM2YuLjY1ZThhNzkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMu cG0KQEAgLTkxOCw2ICs5MTgsOCBAQCBzdWIgYnVpbGRBdXRvdG9vbHNQcm9qZWN0KCRAKQogICAg IG15ICRjb25maWcgPSBwYXNzZWRDb25maWd1cmF0aW9uKCkgfHwgY29uZmlndXJhdGlvbigpOwog ICAgIG15ICRwcmVmaXggPSAkRU5WeyJXZWJLaXRJbnN0YWxsYXRpb25QcmVmaXgifTsKIAorICAg IHB1c2ggQGJ1aWxkQXJncywgIi0tcHJlZml4PSIgLiAkcHJlZml4IGlmKGRlZmluZWQoJHByZWZp eCkpOworCiAgICAgIyBjaGVjayBpZiBjb25maWd1cmF0aW9uIGlzIERlYnVnCiAgICAgaWYgKCRj b25maWcgPX4gbS9kZWJ1Zy9pKSB7CiAgICAgICAgIHB1c2ggQGJ1aWxkQXJncywgIi0tZW5hYmxl LWRlYnVnIjsKLS0gCjEuNS42LjUKCg==