239131 2022-04-12 09:56:32 -0700 Add logging for persistent notification event handler failure 2022-04-14 09:26:14 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf beidson cdumez nham webkit-bug-importer oldest_to_newest 1860705 0 youennf 2022-04-12 09:56:32 -0700 Add logging for persistent notification event handler failure 1860728 1 457347 youennf 2022-04-12 10:54:22 -0700 Created attachment 457347 Patch 1861482 2 457347 cdumez 2022-04-14 07:20:39 -0700 Comment on attachment 457347 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457347&action=review > Source/WebCore/workers/service/server/SWServer.cpp:1376 > + RELEASE_LOG_ERROR_IF(succeeded, ServiceWorker, "Service Worker notification event handler did not succeed"); Shouldn't that be !succeeded ? 1861506 3 youennf 2022-04-14 08:20:03 -0700 (In reply to Chris Dumez from comment #2) > Comment on attachment 457347 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457347&action=review > > > Source/WebCore/workers/service/server/SWServer.cpp:1376 > > + RELEASE_LOG_ERROR_IF(succeeded, ServiceWorker, "Service Worker notification event handler did not succeed"); > > Shouldn't that be !succeeded ? Indeed, fixed! 1861507 4 457632 youennf 2022-04-14 08:20:16 -0700 Created attachment 457632 Patch 1861531 5 ews-feeder 2022-04-14 09:25:13 -0700 Committed r292872 (249643@main): <https://commits.webkit.org/249643@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457632. 1861533 6 webkit-bug-importer 2022-04-14 09:26:14 -0700 <rdar://problem/91758050> 457347 2022-04-12 10:54:22 -0700 2022-04-14 08:20:12 -0700 Patch bug-239131-20220412195421.patch text/plain 2200 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDI1NGRlNWZiNDlhNjcz NDFjZjBiYWVlOTRhZDJkNjc0ZDVlZmEwNC4uOTMyZGZjYzk5OTc2Nzc5OTdhYmM4YjNmNDgzMmRj ZDQ0OTYxMjQ3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIyLTA0LTEyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbG9nZ2luZyBmb3Ig cGVyc2lzdGVudCBub3RpZmljYXRpb24gZXZlbnQgaGFuZGxlciBmYWlsdXJlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzkxMzEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9z ZXJ2ZXIvU1dTZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1dTZXJ2ZXI6OnByb2Nlc3NO b3RpZmljYXRpb25FdmVudCk6CisKIDIwMjItMDQtMTIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5A YXBwbGUuY29tPgogCiAgICAgICAgIEV4cG9zZSB3b3JrZXJzIGFzIHNlcnZpY2Ugd29ya2VyIGNs aWVudHMgYW5kIGltcGxlbWVudCByZWdpc3RyYXRpb24gbWF0Y2hpbmcgZm9yIGRlZGljYXRlZCB3 b3JrZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVy L1NXU2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dT ZXJ2ZXIuY3BwCmluZGV4IDdjMzY0MmZlMzM4MWM5NmE5NGQxNTVjYzQ3YWFiZTljZTg1NmI3ZDcu LmY3NzA4MzcxZTAzN2I1NzgxMjQ1NTVlZWFmNjg3ZGE2MTI2ZjdlOTggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCkBAIC0xMzcy LDcgKzEzNzIsOCBAQCB2b2lkIFNXU2VydmVyOjpwcm9jZXNzTm90aWZpY2F0aW9uRXZlbnQoTm90 aWZpY2F0aW9uRGF0YSYmIGRhdGEsIE5vdGlmaWNhdGlvbkV2ZQogICAgICAgICAgICAgICAgIHdv cmtlci0+ZGVjcmVtZW50RnVuY3Rpb25hbEV2ZW50Q291bnRlcigpOwogICAgICAgICAgICAgfSk7 CiAgICAgICAgICAgICB0ZXJtaW5hdGVXb3JrZXJUaW1lci0+c3RhcnRPbmVTaG90KHdlYWtUaGlz ICYmIHdlYWtUaGlzLT5tX2lzUHJvY2Vzc1Rlcm1pbmF0aW9uRGVsYXlFbmFibGVkID8gZGVmYXVs dFRlcm1pbmF0aW9uRGVsYXkgOiBkZWZhdWx0RnVuY3Rpb25hbEV2ZW50RHVyYXRpb24pOwotICAg ICAgICAgICAgY29ubmVjdGlvbk9yU3RhdHVzLnZhbHVlKCktPmZpcmVOb3RpZmljYXRpb25FdmVu dChzZXJ2aWNlV29ya2VySWRlbnRpZmllciwgZGF0YSwgdHlwZSwgW3Rlcm1pbmF0ZVdvcmtlclRp bWVyID0gV1RGTW92ZSh0ZXJtaW5hdGVXb3JrZXJUaW1lciksIHdvcmtlciA9IFdURk1vdmUod29y a2VyKV0oYm9vbCAvKiBzdWNjZWVkZWQgKi8pIG11dGFibGUgeworICAgICAgICAgICAgY29ubmVj dGlvbk9yU3RhdHVzLnZhbHVlKCktPmZpcmVOb3RpZmljYXRpb25FdmVudChzZXJ2aWNlV29ya2Vy SWRlbnRpZmllciwgZGF0YSwgdHlwZSwgW3Rlcm1pbmF0ZVdvcmtlclRpbWVyID0gV1RGTW92ZSh0 ZXJtaW5hdGVXb3JrZXJUaW1lciksIHdvcmtlciA9IFdURk1vdmUod29ya2VyKV0oYm9vbCBzdWNj ZWVkZWQpIG11dGFibGUgeworICAgICAgICAgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SX0lGKHN1 Y2NlZWRlZCwgU2VydmljZVdvcmtlciwgIlNlcnZpY2UgV29ya2VyIG5vdGlmaWNhdGlvbiBldmVu dCBoYW5kbGVyIGRpZCBub3Qgc3VjY2VlZCIpOwogICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBp ZiBzdWNjZWVkZWQgaXMgZmFsc2UsIHNob3VsZCB3ZSBpbXBsZW1lbnQgYSBkZWZhdWx0IGFjdGlv biBsaWtlIG9wZW5pbmcgYSBuZXcgcGFnZT8KICAgICAgICAgICAgICAgICBpZiAodGVybWluYXRl V29ya2VyVGltZXItPmlzQWN0aXZlKCkpIHsKICAgICAgICAgICAgICAgICAgICAgd29ya2VyLT5k ZWNyZW1lbnRGdW5jdGlvbmFsRXZlbnRDb3VudGVyKCk7Cg== 457632 2022-04-14 08:20:16 -0700 2022-04-14 09:25:15 -0700 Patch bug-239131-20220414172014.patch text/plain 2156 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjJmOWQ1ZThhY2VkMGIx ZWU0ZGVmOTcxYWM2OGQ2OWI1OThmY2VjMS4uNjFhOTliZDBjMTY3NmJmNDRkMTk3YmRiMTIyZGFm ODA5OTQ3NTI5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIyLTA0LTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbG9nZ2luZyBmb3Ig cGVyc2lzdGVudCBub3RpZmljYXRpb24gZXZlbnQgaGFuZGxlciBmYWlsdXJlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzkxMzEKKworICAgICAgICBS ZXZpZXdlZCBieSBDaHJpcyBEdW1lei4KKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9zZXJ2 ZXIvU1dTZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1dTZXJ2ZXI6OnByb2Nlc3NOb3Rp ZmljYXRpb25FdmVudCk6CisKIDIwMjItMDQtMTQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgogCiAgICAgICAgIFNoYXJlZCB3b3JrZXJzIHNob3VsZCBtYXRjaCBzZXJ2aWNlIHdv cmtlciByZWdpc3RyYXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3Nl cnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vydmlj ZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCmluZGV4IDhkZjEzOTE0MDM3N2EzYTliYmUxNTIxNTA5M2Nj ZDZkYTQ3ODhmODEuLjlmNzdlOGY0NWM0N2NhMTgyMTAyMTlkZjVjYWU1YjJmYzc4YzkwZGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIu Y3BwCkBAIC0xMzcyLDcgKzEzNzIsOCBAQCB2b2lkIFNXU2VydmVyOjpwcm9jZXNzTm90aWZpY2F0 aW9uRXZlbnQoTm90aWZpY2F0aW9uRGF0YSYmIGRhdGEsIE5vdGlmaWNhdGlvbkV2ZQogICAgICAg ICAgICAgICAgIHdvcmtlci0+ZGVjcmVtZW50RnVuY3Rpb25hbEV2ZW50Q291bnRlcigpOwogICAg ICAgICAgICAgfSk7CiAgICAgICAgICAgICB0ZXJtaW5hdGVXb3JrZXJUaW1lci0+c3RhcnRPbmVT aG90KHdlYWtUaGlzICYmIHdlYWtUaGlzLT5tX2lzUHJvY2Vzc1Rlcm1pbmF0aW9uRGVsYXlFbmFi bGVkID8gZGVmYXVsdFRlcm1pbmF0aW9uRGVsYXkgOiBkZWZhdWx0RnVuY3Rpb25hbEV2ZW50RHVy YXRpb24pOwotICAgICAgICAgICAgY29ubmVjdGlvbk9yU3RhdHVzLnZhbHVlKCktPmZpcmVOb3Rp ZmljYXRpb25FdmVudChzZXJ2aWNlV29ya2VySWRlbnRpZmllciwgZGF0YSwgdHlwZSwgW3Rlcm1p bmF0ZVdvcmtlclRpbWVyID0gV1RGTW92ZSh0ZXJtaW5hdGVXb3JrZXJUaW1lciksIHdvcmtlciA9 IFdURk1vdmUod29ya2VyKV0oYm9vbCAvKiBzdWNjZWVkZWQgKi8pIG11dGFibGUgeworICAgICAg ICAgICAgY29ubmVjdGlvbk9yU3RhdHVzLnZhbHVlKCktPmZpcmVOb3RpZmljYXRpb25FdmVudChz ZXJ2aWNlV29ya2VySWRlbnRpZmllciwgZGF0YSwgdHlwZSwgW3Rlcm1pbmF0ZVdvcmtlclRpbWVy ID0gV1RGTW92ZSh0ZXJtaW5hdGVXb3JrZXJUaW1lciksIHdvcmtlciA9IFdURk1vdmUod29ya2Vy KV0oYm9vbCBzdWNjZWVkZWQpIG11dGFibGUgeworICAgICAgICAgICAgICAgIFJFTEVBU0VfTE9H X0VSUk9SX0lGKCFzdWNjZWVkZWQsIFNlcnZpY2VXb3JrZXIsICJTZXJ2aWNlIFdvcmtlciBub3Rp ZmljYXRpb24gZXZlbnQgaGFuZGxlciBkaWQgbm90IHN1Y2NlZWQiKTsKICAgICAgICAgICAgICAg ICAvLyBGSVhNRTogaWYgc3VjY2VlZGVkIGlzIGZhbHNlLCBzaG91bGQgd2UgaW1wbGVtZW50IGEg ZGVmYXVsdCBhY3Rpb24gbGlrZSBvcGVuaW5nIGEgbmV3IHBhZ2U/CiAgICAgICAgICAgICAgICAg aWYgKHRlcm1pbmF0ZVdvcmtlclRpbWVyLT5pc0FjdGl2ZSgpKSB7CiAgICAgICAgICAgICAgICAg ICAgIHdvcmtlci0+ZGVjcmVtZW50RnVuY3Rpb25hbEV2ZW50Q291bnRlcigpOwo=