23912 2009-02-11 20:54:41 -0800 REGRESSION: Select elements don't scroll in response to the mouse wheel 2009-02-12 12:19:11 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED https://bugs.webkit.org/enter_bug.cgi?product=WebKit InRadar, Regression P1 Normal --- 1 oliver hyatt adele hyatt simon.fraser oldest_to_newest 109420 0 oliver 2009-02-11 20:54:41 -0800 When attempting to scroll the Component select element on bugzilla i found that the entire page scrolled, rather than just the select contents. Steps to reproduce: 1. Go to https://bugs.webkit.org/enter_bug.cgi?product=WebKit 2. move mouse over Component select element 3. try to scroll select element with scroll wheel 109421 1 mrowe 2009-02-11 20:55:46 -0800 <rdar://problem/6579560> 109422 2 adele 2009-02-11 20:57:22 -0800 I think this used to work. I wonder when it regressed. 109423 3 oliver 2009-02-11 21:00:26 -0800 (In reply to comment #2) > I think this used to work. I wonder when it regressed. > It worked relatively recently, i'm blaming hyatt's many recent changes, although i have no real basis for this other than my fear of large changes, and, well, it's hyatt ;D 109424 4 adele 2009-02-11 21:00:42 -0800 Yup, works in 3.1.1 109528 5 27616 hyatt 2009-02-12 12:13:47 -0800 Created attachment 27616 Patch 109530 6 27616 simon.fraser 2009-02-12 12:15:41 -0800 Comment on attachment 27616 Patch > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 40918) > +++ ChangeLog (working copy) > @@ -1,3 +1,16 @@ > +2009-02-12 David Hyatt <hyatt@apple.com> > + > + Fix for https://bugs.webkit.org/show_bug.cgi?id=23912 > + > + I have no idea why this broke. As far as I can tell the old code never should have worked in > + the first place. Add code to handleWheelEvent that will find an enclosing renderer for a node > + in order to attempt a wheel scroll. > + > + Reviewed by NOBODY (OOPS!). "Reviewed by" should go at the top. r-me. 109531 7 hyatt 2009-02-12 12:19:11 -0800 Fixed in r40919. It bugs me that I have no idea what change broke this or why it ever worked in the first place. 27616 2009-02-12 12:13:47 -0800 2009-02-12 12:15:41 -0800 Patch patch.txt text/plain 1874 hyatt SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQwOTE4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDIt MTIgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBmb3IgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTEyCisKKyAgICAgICAgSSBo YXZlIG5vIGlkZWEgd2h5IHRoaXMgYnJva2UuICBBcyBmYXIgYXMgSSBjYW4gdGVsbCB0aGUgb2xk IGNvZGUgbmV2ZXIgc2hvdWxkIGhhdmUgd29ya2VkIGluCisgICAgICAgIHRoZSBmaXJzdCBwbGFj ZS4gIEFkZCBjb2RlIHRvIGhhbmRsZVdoZWVsRXZlbnQgdGhhdCB3aWxsIGZpbmQgYW4gZW5jbG9z aW5nIHJlbmRlcmVyIGZvciBhIG5vZGUKKyAgICAgICAgaW4gb3JkZXIgdG8gYXR0ZW1wdCBhIHdo ZWVsIHNjcm9sbC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFu ZGxlcjo6aGFuZGxlV2hlZWxFdmVudCk6CisKIDIwMDktMDItMTIgIERhdmlkIEh5YXR0ICA8aHlh dHRAYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgdGhlIGZ1bmN0aW9ucyB0aGF0IHBhaW50IGJv cmRlcnMsIGJveCBzaGFkb3dzIGFuZCBib3JkZXIgaW1hZ2VzIGludG8gUmVuZGVyQm94TW9kZWxP YmplY3QuICBkcmF3Qm9yZGVyIGFuZCBkcmF3Qm9yZGVyQXJjLCBiZWNhdXNlIHRoZXkgYXJlIHVz ZWQKSW5kZXg6IHBhZ2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwYWdlL0V2ZW50 SGFuZGxlci5jcHAJKHJldmlzaW9uIDQwODcxKQorKysgcGFnZS9FdmVudEhhbmRsZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xNjIzLDggKzE2MjMsMTMgQEAgYm9vbCBFdmVudEhhbmRsZXI6Omhh bmRsZVdoZWVsRXZlbnQoUGxhdAogICAgICAgICBub2RlLT5kaXNwYXRjaFdoZWVsRXZlbnQoZSk7 CiAgICAgICAgIGlmIChlLmlzQWNjZXB0ZWQoKSkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwot ICAgICAgICAgICAgCi0gICAgICAgIGlmIChub2RlLT5yZW5kZXJlcigpKSB7CisgICAgICAgIAor ICAgICAgICAvLyBJZiB3ZSBkb24ndCBoYXZlIGEgcmVuZGVyZXIsIHNlbmQgdGhlIHdoZWVsIHRv IHRoZSBmaXJzdCBub2RlIHdlIGZpbmQgd2l0aCBhIHJlbmRlcmVyLgorICAgICAgICAvLyBUaGlz IGlzIG5lZWRlZCBmb3IgPG9wdGlvbj4gYW5kIDxvcHRncm91cD4gZWxlbWVudHMgc28gdGhhdCA8 c2VsZWN0PnMgZ2V0IGEgd2hlZWwgc2Nyb2xsLgorICAgICAgICB3aGlsZSAobm9kZSAmJiAhbm9k ZS0+cmVuZGVyZXIoKSkKKyAgICAgICAgICAgIG5vZGUgPSBub2RlLT5wYXJlbnQoKTsKKyAgICAg ICAgCisgICAgICAgIGlmIChub2RlICYmIG5vZGUtPnJlbmRlcmVyKCkpIHsKICAgICAgICAgICAg IC8vIEp1c3QgYnJlYWsgdXAgaW50byB0d28gc2Nyb2xscyBpZiB3ZSBuZWVkIHRvLiAgRGlhZ29u YWwgbW92ZW1lbnQgb24gCiAgICAgICAgICAgICAvLyBhIE1hY0Jvb2sgcHJvIGlzIGFuIGV4YW1w bGUgb2YgYSAyLWRpbWVuc2lvbmFsIG1vdXNlIHdoZWVsIGV2ZW50ICh3aGVyZSBib3RoIGRlbHRh WCBhbmQgZGVsdGFZIGNhbiBiZSBzZXQpLgogICAgICAgICAgICAgc2Nyb2xsQW5kQWNjZXB0RXZl bnQoZS5kZWx0YVgoKSwgU2Nyb2xsTGVmdCwgU2Nyb2xsUmlnaHQsIGUsIG5vZGUpOwo=