239108 2022-04-11 23:02:26 -0700 Add Contributing.md mentioning to how to create PR to WebKit (instead of doing it through GitHub UI) 2022-04-18 23:03:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=239082 https://bugs.webkit.org/show_bug.cgi?id=239347 InRadar P2 Normal --- 239082 1 ysuzuki webkit-unassigned jbedard tetsuharu.ohzeki webkit-bug-importer oldest_to_newest 1860569 0 ysuzuki 2022-04-11 23:02:26 -0700 Contributing.md can be shown when opening PR via GitHub UI. While we are using tools (git-webkit) to create PR with specific format, it is not easily obvious to new contributors. Let's add Contributing.md mentioning to 1. The way to create PR through git-webkit (and introducing https://github.com/WebKit/WebKit/wiki/Contributing link) 2. Not creating a PR though GitHub UI in a normal way (just creating a branch and PR) 1860578 1 ysuzuki 2022-04-11 23:21:50 -0700 Some examples. LLVM https://github.com/llvm/llvm-project/blob/main/CONTRIBUTING.md FoundationDB https://github.com/apple/foundationdb/blob/main/CONTRIBUTING.md Swift https://github.com/apple/swift/blob/main/CONTRIBUTING.md Go https://github.com/golang/go/blob/master/CONTRIBUTING.md 1860608 2 tetsuharu.ohzeki 2022-04-12 00:27:47 -0700 Additionally, I think it’s better to add a PR template like https://github.com/llvm/llvm-project/blob/main/.github/PULL_REQUEST_TEMPLATE.md I guess strongly some people will not read CONTRIBUTING.md because it’s shown as a link. But PR template fills the form to create PR. 1860631 3 ysuzuki 2022-04-12 02:37:56 -0700 PULL_REQUEST_TEMPLATE sounds good. We should offer the best way for contributors to access to the expected procedure so that we will not waste contributors' time and their patches! 1861571 4 jbedard 2022-04-14 10:49:29 -0700 (In reply to Yusuke Suzuki from comment #3) > PULL_REQUEST_TEMPLATE sounds good. > We should offer the best way for contributors to access to the expected > procedure so that we will not waste contributors' time and their patches! Adding the PR template in https://bugs.webkit.org/show_bug.cgi?id=239347 1862429 5 webkit-bug-importer 2022-04-18 23:03:13 -0700 <rdar://problem/91940821>