239098 2022-04-11 17:44:11 -0700 Fix PlayStation build after r292696 2022-04-12 11:53:12 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1860503 0 don.olmstead 2022-04-11 17:44:11 -0700 ... 1860508 1 457304 don.olmstead 2022-04-11 17:55:56 -0700 Created attachment 457304 [fast-cq] Patch 1860517 2 ews-feeder 2022-04-11 18:33:55 -0700 Committed r292753 (249537@main): <https://commits.webkit.org/249537@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457304. 1860518 3 webkit-bug-importer 2022-04-11 18:34:15 -0700 <rdar://problem/91601084> 1860747 4 457304 darin 2022-04-12 11:37:03 -0700 Comment on attachment 457304 [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457304&action=review > Source/WebDriver/playstation/WebDriverServicePlayStation.cpp:48 > + capabilities.platformName = String::fromLatin1("playstation"); The preferred idiom here would be: capabilities.platformName = "playstation"_s; Unless that doesn’t compile for some reason? 1860752 5 457304 cdumez 2022-04-12 11:53:12 -0700 Comment on attachment 457304 [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457304&action=review >> Source/WebDriver/playstation/WebDriverServicePlayStation.cpp:48 >> + capabilities.platformName = String::fromLatin1("playstation"); > > The preferred idiom here would be: > > capabilities.platformName = "playstation"_s; > > Unless that doesn’t compile for some reason? Agreed, that's a clear use case for ASCIILiteral / ""_s. 457304 2022-04-11 17:55:56 -0700 2022-04-11 18:33:58 -0700 [fast-cq] Patch bug-239098.diff text/plain 2441 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNmVkMzlkODIzNWExLi5iZTdkYWM3NGEzN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MjItMDQtMTEgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KKworICAgICAg ICBGaXggUGxheVN0YXRpb24gYnVpbGQgYWZ0ZXIgcjI5MjY5NgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5MDk4CisKKyAgICAgICAgVW5yZXZpZXdl ZCBidWlsZCBmaXguCisKKyAgICAgICAgKiB3dGYvcGxheXN0YXRpb24vTGFuZ3VhZ2VQbGF5U3Rh dGlvbi5jcHA6CisgICAgICAgIChXVEY6OnBsYXRmb3JtVXNlclByZWZlcnJlZExhbmd1YWdlcyk6 CisKIDIwMjItMDQtMTEgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAg ICAgICBbSlNDXSBSZWR1Y2UgdXNlIG9mIHVubmVjZXNzYXJ5IGNyeXB0b2dyYXBoaWNhbGx5UmFu ZG9tIG51bWJlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3BsYXlzdGF0aW9uL0xhbmd1 YWdlUGxheVN0YXRpb24uY3BwIGIvU291cmNlL1dURi93dGYvcGxheXN0YXRpb24vTGFuZ3VhZ2VQ bGF5U3RhdGlvbi5jcHAKaW5kZXggY2FmMTU0OWY4MDAyLi5lODY5NDUxYWEzNWQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvd3RmL3BsYXlzdGF0aW9uL0xhbmd1YWdlUGxheVN0YXRpb24uY3BwCisr KyBiL1NvdXJjZS9XVEYvd3RmL3BsYXlzdGF0aW9uL0xhbmd1YWdlUGxheVN0YXRpb24uY3BwCkBA IC0zNiw3ICszNiw3IEBAIFZlY3RvcjxTdHJpbmc+IHBsYXRmb3JtVXNlclByZWZlcnJlZExhbmd1 YWdlcyhTaG91bGRNaW5pbWl6ZUxhbmd1YWdlcykKIAogICAgIGNoYXIgYnVmZmVyWzE2XTsKICAg ICBpZiAoIWdldGVudl9ucCgiU1lTVEVNX0xBTkdVQUdFIiwgYnVmZmVyLCBzaXplb2YoYnVmZmVy KSkpCi0gICAgICAgIGxhbmd1YWdlcy5hcHBlbmQoYnVmZmVyKTsKKyAgICAgICAgbGFuZ3VhZ2Vz LmFwcGVuZChTdHJpbmc6OmZyb21MYXRpbjEoYnVmZmVyKSk7CiAKICAgICByZXR1cm4gbGFuZ3Vh Z2VzOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRyaXZlci9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViRHJpdmVyL0NoYW5nZUxvZwppbmRleCBmYWUwM2MxNTU5ZWEuLjc0ODJhZTIzNDM0ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMi0wNC0xMSAgRG9uIE9sbXN0ZWFkICA8 ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIEZpeCBQbGF5U3RhdGlvbiBidWlsZCBh ZnRlciByMjkyNjk2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzkwOTgKKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KKworICAgICAgICAq IHBsYXlzdGF0aW9uL1dlYkRyaXZlclNlcnZpY2VQbGF5U3RhdGlvbi5jcHA6CisgICAgICAgIChX ZWJEcml2ZXI6OldlYkRyaXZlclNlcnZpY2U6OnBsYXRmb3JtQ2FwYWJpbGl0aWVzKToKKwogMjAy Mi0wNC0xMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEZpbmlz aCBwb3J0aW5nIGNvZGUgYmFzZSB0byBTdHJpbmc6OmZyb21MYXRpbjEoKSBhbmQgbWFrZSBTdHJp bmcoY29uc3QgY2hhciopIHByaXZhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvcGxh eXN0YXRpb24vV2ViRHJpdmVyU2VydmljZVBsYXlTdGF0aW9uLmNwcCBiL1NvdXJjZS9XZWJEcml2 ZXIvcGxheXN0YXRpb24vV2ViRHJpdmVyU2VydmljZVBsYXlTdGF0aW9uLmNwcAppbmRleCAyNTNi YWY0MGVjNjAuLmY5NDhlYmM4ZmQ4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9wbGF5 c3RhdGlvbi9XZWJEcml2ZXJTZXJ2aWNlUGxheVN0YXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJE cml2ZXIvcGxheXN0YXRpb24vV2ViRHJpdmVyU2VydmljZVBsYXlTdGF0aW9uLmNwcApAQCAtNDUs NyArNDUsNyBAQCB2b2lkIFdlYkRyaXZlclNlcnZpY2U6OnBsYXRmb3JtSW5pdCgpCiBDYXBhYmls aXRpZXMgV2ViRHJpdmVyU2VydmljZTo6cGxhdGZvcm1DYXBhYmlsaXRpZXMoKQogewogICAgIENh cGFiaWxpdGllcyBjYXBhYmlsaXRpZXM7Ci0gICAgY2FwYWJpbGl0aWVzLnBsYXRmb3JtTmFtZSA9 IFN0cmluZygicGxheXN0YXRpb24iKTsKKyAgICBjYXBhYmlsaXRpZXMucGxhdGZvcm1OYW1lID0g U3RyaW5nOjpmcm9tTGF0aW4xKCJwbGF5c3RhdGlvbiIpOwogICAgIGNhcGFiaWxpdGllcy5zZXRX aW5kb3dSZWN0ID0gdHJ1ZTsKICAgICByZXR1cm4gY2FwYWJpbGl0aWVzOwogfQo=