<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>239087</bug_id>
          
          <creation_ts>2022-04-11 14:21:40 -0700</creation_ts>
          <short_desc>REGRESSION (r292696): lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string is a constant failure</short_desc>
          <delta_ts>2022-04-12 15:03:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Karl Rackler">rackler</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>cdumez</cc>
    
    <cc>darin</cc>
    
    <cc>ggaren</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1860403</commentid>
    <comment_count>0</comment_count>
    <who name="Karl Rackler">rackler</who>
    <bug_when>2022-04-11 14:21:40 -0700</bug_when>
    <thetext>lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string

The first build that the failure is seen on: 
https://build.webkit.org/#/builders/370/builds/2637

Diff: 
  Traceback (most recent call last):
    File &quot;/Volumes/Data/worker/monterey-release-applesilicon-tests-wk2/build/Tools/lldb/lldb_webkit_unittest.py&quot;, line 110, in serial_test_WTFStringImpl_SummaryProvider_null_string
      self.assertEqual(summary, &quot;{ length = 0, is8bit = 1, contents = &apos;&apos; }&quot;)
  AssertionError: &apos;&apos; != &quot;{ length = 0, is8bit = 1, contents = &apos;&apos; }&quot;
  + { length = 0, is8bit = 1, contents = &apos;&apos; }</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1860411</commentid>
    <comment_count>1</comment_count>
      <attachid>457287</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-04-11 14:34:28 -0700</bug_when>
    <thetext>Created attachment 457287
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1860412</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-04-11 14:34:39 -0700</bug_when>
    <thetext>&lt;rdar://problem/91589463&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1860513</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-04-11 18:17:00 -0700</bug_when>
    <thetext>Committed r292750 (249534@main): &lt;https://commits.webkit.org/249534@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457287.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1860732</commentid>
    <comment_count>4</comment_count>
      <attachid>457287</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2022-04-12 11:02:40 -0700</bug_when>
    <thetext>Comment on attachment 457287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457287&amp;action=review

&gt; Tools/ChangeLog:9
&gt; +        Revert change to aNullString made in r292696 as the the following test relies on this String being empty:
&gt; +        lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string

Someone named an empty string &quot;aNullString&quot;! Great way to set a trap for Chris.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1860908</commentid>
    <comment_count>5</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-04-12 14:53:19 -0700</bug_when>
    <thetext>We also have &quot;anEmptyString&quot; right below. Which is now identical to aNullString.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1860917</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-04-12 15:03:40 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #5)
&gt; We also have &quot;anEmptyString&quot; right below. Which is now identical to
&gt; aNullString.

Yes, aNullString and anEmptyString are identical now and historically (before I tried to fix this non-sense recently and failed because I didn&apos;t realize this python test somehow relies on these).</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>457287</attachid>
            <date>2022-04-11 14:34:28 -0700</date>
            <delta_ts>2022-04-11 18:17:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-239087-20220411143428.patch</filename>
            <type>text/plain</type>
            <size>1437</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNzIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmMxYTMwM2E0NWY0YWJmYjJlNjk1YTEzOGJjNzdjZTg2
OTNlYWUzZS4uZTZhNTAxNTQ1YmVhZDQxMTUyNGY2ZmY0YzY1Njg2NmY2ZTkwMDUyZCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDIyLTA0LTExICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg
ICAgUkVHUkVTU0lPTjoocjI5MjY5NikgbGxkYl93ZWJraXRfdW5pdHRlc3QuVGVzdFN1bW1hcnlQ
cm92aWRlcnMuc2VyaWFsX3Rlc3RfV1RGU3RyaW5nSW1wbF9TdW1tYXJ5UHJvdmlkZXJfbnVsbF9z
dHJpbmcgaXMgYSBjb25zdGFudCBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzkwODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBSZXZlcnQgY2hhbmdlIHRvIGFOdWxsU3RyaW5nIG1hZGUgaW4g
cjI5MjY5NiBhcyB0aGUgdGhlIGZvbGxvd2luZyB0ZXN0IHJlbGllcyBvbiB0aGlzIFN0cmluZyBi
ZWluZyBlbXB0eToKKyAgICAgICAgbGxkYl93ZWJraXRfdW5pdHRlc3QuVGVzdFN1bW1hcnlQcm92
aWRlcnMuc2VyaWFsX3Rlc3RfV1RGU3RyaW5nSW1wbF9TdW1tYXJ5UHJvdmlkZXJfbnVsbF9zdHJp
bmcKKworICAgICAgICAqIGxsZGIvbGxkYldlYktpdFRlc3Rlci9tYWluLmNwcDoKKyAgICAgICAg
KHRlc3RTdW1tYXJ5UHJvdmlkZXJzKToKKwogMjAyMi0wNC0xMSAgU2lodWkgTGl1ICA8c2lodWlf
bGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggc2l6ZSBjb21wdXRhdGlvbiBpbiBXZWJDb3Jl
OjpTdG9yYWdlTWFwCmRpZmYgLS1naXQgYS9Ub29scy9sbGRiL2xsZGJXZWJLaXRUZXN0ZXIvbWFp
bi5jcHAgYi9Ub29scy9sbGRiL2xsZGJXZWJLaXRUZXN0ZXIvbWFpbi5jcHAKaW5kZXggYzNmMGQz
OTcyMjM3ZWJkMzYzNTgxNjMyYzhjY2U0ODNmZWE1YzJiZC4uNjgyNDhlNDNlYmNjZGM3MzQ1ZjQw
NjZiODA5YmU5NGMwMzc3ZDNhNCAxMDA2NDQKLS0tIGEvVG9vbHMvbGxkYi9sbGRiV2ViS2l0VGVz
dGVyL21haW4uY3BwCisrKyBiL1Rvb2xzL2xsZGIvbGxkYldlYktpdFRlc3Rlci9tYWluLmNwcApA
QCAtNTcsNyArNTcsNyBAQCBlbnVtIGNsYXNzIEV4YW1wbGVGbGFncyB7CiAKIHN0YXRpYyB2b2lk
IHRlc3RTdW1tYXJ5UHJvdmlkZXJzKCkKIHsKLSAgICBTdHJpbmcgYU51bGxTdHJpbmcgeyB9Owor
ICAgIFN0cmluZyBhTnVsbFN0cmluZyB7ICIiX3MgfTsKICAgICBTdHJpbmdJbXBsKiBhTnVsbFN0
cmluZ0ltcGwgPSBhTnVsbFN0cmluZy5pbXBsKCk7CiAKICAgICBTdHJpbmcgYW5FbXB0eVN0cmlu
ZyB7ICIiX3MgfTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>