239086 2022-04-11 14:07:58 -0700 Web Inspector: Add engineering-build-only ability to dump the current known bound nodes tree in Inspector^2 or layout tests 2022-04-12 12:28:13 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pangle pangle ews-watchlist hi inspector-bugzilla-changes joepeck pangle webkit-bug-importer oldest_to_newest 1860397 0 pangle 2022-04-11 14:07:58 -0700 Split from the patch for bug 189687. 1860398 1 webkit-bug-importer 2022-04-11 14:08:21 -0700 <rdar://problem/91588036> 1860399 2 457284 pangle 2022-04-11 14:11:56 -0700 Created attachment 457284 Patch v1.0 1860427 3 457284 hi 2022-04-11 14:57:43 -0700 Comment on attachment 457284 Patch v1.0 rs=me 1860749 4 pangle 2022-04-12 11:44:14 -0700 Test failure is being addressed in bug 239134, it is unrelated to this patch. 1860764 5 457284 joepeck 2022-04-12 12:19:24 -0700 Comment on attachment 457284 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=457284&action=review Neat! > Source/WebInspectorUI/ChangeLog:11 > + (get let): Ooof prepare-ChangeLog doesn't handle this well. 1860766 6 ews-feeder 2022-04-12 12:28:09 -0700 Committed r292781 (249565@main): <https://commits.webkit.org/249565@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457284. 457284 2022-04-11 14:11:56 -0700 2022-04-12 12:28:11 -0700 Patch v1.0 bug-239086-20220411141156.patch text/plain 5274 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 NWMwMDkzYjhlZDEwOTJiNWNiNDQwNDliOWU4NDBmOTcwMmU5YTczLi40YTZmODljODcxMTA2YmNh YjJlYjYwMmRiZDkyNDBlM2I0MWMxMGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMi0wNC0xMSAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIGVuZ2luZWVyaW5nLWJ1aWxkLW9ubHkgYWJp bGl0eSB0byBkdW1wIHRoZSBjdXJyZW50IGtub3duIGJvdW5kIG5vZGVzIHRyZWUgaW4gSW5zcGVj dG9yXjIgb3IgbGF5b3V0IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzkwODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvRGVidWcvRE9NTWFuYWdlci5qczogQWRkZWQu CisgICAgICAgIChhcHBlbmRMaW5lKToKKyAgICAgICAgKGFwcGVuZENoaWxkcmVuKToKKyAgICAg ICAgKGdldCBsZXQpOgorICAgICAgICAtIFRvIGFzc2lzdCB3aXRoIGRlYnVnZ2luZyBsYXlvdXQg dGVzdHMgYW5kIHBhdGNoZXMgdG8gdGhlIERPTU1hbmFnZXIsIGFkZCBhIHV0aWxpdHkgZ2V0dGVy IHRvIGR1bXAgdGhlIGN1cnJlbnQKKyAgICAgICAgbm9kZSB0cmVlLgorICAgICAgICAKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL01haW4uaHRtbDoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Rl c3QuaHRtbDoKKwogMjAyMi0wNC0wOCAgRWxsaW90dCBXaWxsaWFtcyAgPGVtd0BhcHBsZS5jb20+ CiAKICAgICAgICAgW1hjb2RlXSBBdm9pZCB0YXJnZXRpbmcgMzItYml0IGlPUyBhbmQgTWFjIGFy Y2hpdGVjdHVyZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0RlYnVnL0RPTU1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9EZWJ1Zy9ET01NYW5hZ2VyLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc0Mjg0MzYzY2Y5NTFlNjAzYmQ1 ODUwNGVhM2EwNDdmYzgzYTBiOTAKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9EZWJ1Zy9ET01NYW5hZ2VyLmpzCkBAIC0wLDAgKzEsNTcgQEAK Ky8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMjIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVk aXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmln aHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lci4KKyAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0 IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBv ZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBk b2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlz dHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5D LiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycKKyAqIEFORCBBTlkgRVhQUkVTUyBPUiBJ TVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogVEhF IElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEg UEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwg QVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTCisgKiBCRSBMSUFCTEUgRk9SIEFOWSBESVJF Q1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SCisgKiBDT05T RVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJF TUVOVCBPRgorICogU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERB VEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTCisgKiBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FV U0VEIEFORCBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTgorICogQ09OVFJB Q1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9U SEVSV0lTRSkKKyAqIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YKKyAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERB TUFHRS4KKyAqLworCitPYmplY3QuZGVmaW5lUHJvcGVydHkoV0kuRE9NTWFuYWdlci5wcm90b3R5 cGUsICJib3VuZE5vZGVzRGVidWdEZXNjcmlwdGlvbiIsIHsKKyAgICBnZXQoKSB7CisgICAgICAg IGxldCBkZWJ1Z0Rlc2NyaXB0aW9uID0gIiI7CisgICAgICAgIGZ1bmN0aW9uIGFwcGVuZExpbmUo bGluZSkgeworICAgICAgICAgICAgZGVidWdEZXNjcmlwdGlvbiArPSBsaW5lICsgIlxuIjsKKyAg ICAgICAgfQorCisgICAgICAgIGNvbnN0IHNpbmdsZUxldmVsU3BhY2VQcmVmaXggPSAiICAgICI7 CisgICAgICAgIGZ1bmN0aW9uIGFwcGVuZENoaWxkcmVuKHBhcmVudCwgbGV2ZWwpIHsKKyAgICAg ICAgICAgIGxldCBzcGFjZVByZWZpeCA9IHNpbmdsZUxldmVsU3BhY2VQcmVmaXgucmVwZWF0KGxl dmVsICsgMSk7CisKKyAgICAgICAgICAgIGZvciAobGV0IGNoaWxkIG9mIHBhcmVudC5jaGlsZHJl bikgeworICAgICAgICAgICAgICAgIGFwcGVuZExpbmUoYCR7c3BhY2VQcmVmaXh9aWQoJHtjaGls ZC5pZH0pIGRpc3BsYXlOYW1lKCR7Y2hpbGQuZGlzcGxheU5hbWV9KWApOworCisgICAgICAgICAg ICAgICAgZm9yIChsZXQgcHNldWRvRWxlbWVudCBvZiBjaGlsZC5wc2V1ZG9FbGVtZW50cygpLnZh bHVlcygpKQorICAgICAgICAgICAgICAgICAgICBhcHBlbmRMaW5lKGAke3NwYWNlUHJlZml4fSR7 c2luZ2xlTGV2ZWxTcGFjZVByZWZpeH1pZCgke3BzZXVkb0VsZW1lbnQuaWR9KSBkaXNwbGF5TmFt ZSgke3BzZXVkb0VsZW1lbnQuZGlzcGxheU5hbWV9KWApOworCisgICAgICAgICAgICAgICAgaWYg KGNoaWxkLmNoaWxkcmVuKQorICAgICAgICAgICAgICAgICAgICBhcHBlbmRDaGlsZHJlbihjaGls ZCwgbGV2ZWwgKyAxKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCisgICAgICAgIGxldCBy b290Tm9kZXMgPSBPYmplY3QudmFsdWVzKHRoaXMuX2lkVG9ET01Ob2RlKS5maWx0ZXIoKHZhbHVl KSA9PiAhdmFsdWUucGFyZW50Tm9kZSk7CisgICAgICAgIGZvciAobGV0IHJvb3ROb2RlIG9mIHJv b3ROb2RlcykgeworICAgICAgICAgICAgYXBwZW5kTGluZShgPCR7cm9vdE5vZGUgPT09IHRoaXMu X2RvY3VtZW50ID8gIkRvY3VtZW50IiA6ICJEZXRhY2hlZCJ9IFJvb3Q+IGlkKCR7cm9vdE5vZGUu aWR9KSBkaXNwbGF5TmFtZSgke3Jvb3ROb2RlLmRpc3BsYXlOYW1lfSlgKTsKKyAgICAgICAgICAg IGlmIChyb290Tm9kZS5jaGlsZHJlbikKKyAgICAgICAgICAgICAgICBhcHBlbmRDaGlsZHJlbihy b290Tm9kZSwgMCk7CisgICAgICAgIH0KKworICAgICAgICByZXR1cm4gZGVidWdEZXNjcmlwdGlv bjsKKyAgICB9Cit9KTsKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9NYWluLmh0bWwgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9NYWluLmh0bWwKaW5kZXggY2RlOGI1NzBiYmI3YTRi MGNhNDQ0NWQwOTdjOWE2ZDNlZmM5ZDMwZC4uMTljNzhiYTVmNWZmY2IwMzI1MTRlYTNmZWFkZGU0 MTVlNWJkYTEyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvTWFpbi5odG1sCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01h aW4uaHRtbApAQCAtOTYzLDYgKzk2Myw3IEBACiAgICAgPHNjcmlwdCBzcmM9IkRlYnVnL0NhcHR1 cmluZ1Byb3RvY29sVHJhY2VyLmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iRGVidWcv UHJvdG9jb2xUcmFjZS5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9IkRlYnVnL0RlYnVn Q29udGVudFZpZXcuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSJEZWJ1Zy9ET01NYW5h Z2VyLmpzIj48L3NjcmlwdD4KIAogICAgIDxzY3JpcHQgc3JjPSJOb25NaW5pZmllZC9EZWZhdWx0 QXVkaXRzLmpzIj48L3NjcmlwdD4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVGVzdC5odG1sIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVGVzdC5odG1sCmluZGV4IDVmMWVkMjU0YTM3ZTI0ODlmNjUxY2I5MjZlNWJhMjNjMGE4 MDYyMjIuLmY3M2M4NDMxMzdkYTg3OThhZGI5MTFhODA4NTRhOTM5M2U0M2FlZjYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QuaHRtbAorKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UZXN0Lmh0bWwKQEAgLTI5Myw2ICsy OTMsOCBAQAogICAgIDxzY3JpcHQgc3JjPSJWaWV3cy9UcmVlRWxlbWVudC5qcyI+PC9zY3JpcHQ+ CiAgICAgPHNjcmlwdCBzcmM9IlZpZXdzL1RyZWVPdXRsaW5lLmpzIj48L3NjcmlwdD4KIAorICAg IDxzY3JpcHQgc3JjPSJEZWJ1Zy9ET01NYW5hZ2VyLmpzIj48L3NjcmlwdD4KKwogICAgIDxzY3Jp cHQgc3JjPSJOb25NaW5pZmllZC9EZWZhdWx0QXVkaXRzLmpzIj48L3NjcmlwdD4KIAogICAgIDxz Y3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4K