239057 2022-04-10 18:33:34 -0700 [WebGPU] WebGPU strings are UTF-8, not Latin-1 2022-04-12 15:40:49 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 239056 1 mmaxfield mmaxfield darin dino djg kkinnunen webkit-bug-importer oldest_to_newest 1860178 0 mmaxfield 2022-04-10 18:33:34 -0700 . 1860179 1 457219 mmaxfield 2022-04-10 18:36:42 -0700 Created attachment 457219 Patch 1860226 2 457219 kkinnunen 2022-04-11 01:23:44 -0700 Comment on attachment 457219 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457219&action=review > Source/WebGPU/WebGPU/Adapter.mm:137 > + auto label = String::fromUTF8(descriptor.label); Aren't these coming from the API? E.g. would fromAPI() be more appropriate? 1860499 3 457219 mmaxfield 2022-04-11 17:34:23 -0700 Comment on attachment 457219 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457219&action=review >> Source/WebGPU/WebGPU/Adapter.mm:137 >> + auto label = String::fromUTF8(descriptor.label); > > Aren't these coming from the API? E.g. would fromAPI() be more appropriate? Good point. 1860500 4 mmaxfield 2022-04-11 17:40:39 -0700 Committed r292748 (?): <https://commits.webkit.org/r292748> 1860501 5 webkit-bug-importer 2022-04-11 17:41:16 -0700 <rdar://problem/91598857> 1860768 6 457219 darin 2022-04-12 12:30:03 -0700 Comment on attachment 457219 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457219&action=review > Source/WebGPU/ChangeLog:8 > + Replace String::fromLatin1() with String::fromUTF8(). Great to fix this if it was going to mishandle non-ASCII characters. But note that now there is a failure case for all of these, if it’s invalid UTF-8. This is a major difference between String::fromUTF8 and String::fromLatin1, and might eventually lead to us renaming it to String::tryFromUTF8. As long as each caller either has a guarantee it will be valid UTF-8, or can withstand a null string result when it’s not, we are OK. 1860944 7 457219 mmaxfield 2022-04-12 15:40:49 -0700 Comment on attachment 457219 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457219&action=review >> Source/WebGPU/ChangeLog:8 >> + Replace String::fromLatin1() with String::fromUTF8(). > > Great to fix this if it was going to mishandle non-ASCII characters. But note that now there is a failure case for all of these, if it’s invalid UTF-8. This is a major difference between String::fromUTF8 and String::fromLatin1, and might eventually lead to us renaming it to String::tryFromUTF8. > > As long as each caller either has a guarantee it will be valid UTF-8, or can withstand a null string result when it’s not, we are OK. Right. For this situation, it's the latter. 457219 2022-04-10 18:36:42 -0700 2022-04-11 01:23:44 -0700 Patch patch.diff text/plain 5239 mmaxfield Y29tbWl0IGZhM2NmZmFlNWIwODIzOGQ2ODRhOTMzYTAwMGM1YTY1YmM0YTkyYTQKQXV0aG9yOiBN eWxlcyBDLiBNYXhmaWVsZCA8bW1heGZpZWxkQGFwcGxlLmNvbT4KRGF0ZTogICBTdW4gQXByIDEw IDE4OjM1OjA0IDIwMjIgLTA3MDAKCiAgICBVVEY4CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkdQ VS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViR1BVL0NoYW5nZUxvZwppbmRleCA4N2I5MjgxZDQ3YTEu Ljg1MjI2MjEyMTM2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkdQVS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkdQVS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAyMi0wNC0xMCAgTXls ZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgorCisgICAgICAgIFtXZWJHUFVd IFdlYkdQVSBzdHJpbmdzIGFyZSBVVEYtOCwgbm90IExhdGluLTEKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTA1NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2UgU3RyaW5nOjpmcm9tTGF0aW4x KCkgd2l0aCBTdHJpbmc6OmZyb21VVEY4KCkuCisKKyAgICAgICAgKiBXZWJHUFUvQVBJQ29udmVy c2lvbnMuaDoKKyAgICAgICAgKFdlYkdQVTo6ZnJvbUFQSSk6CisgICAgICAgICogV2ViR1BVL0Fk YXB0ZXIubW06CisgICAgICAgIChXZWJHUFU6OkFkYXB0ZXI6OnJlcXVlc3REZXZpY2UpOgorICAg ICAgICAqIFdlYkdQVS9Db21wdXRlUGlwZWxpbmUubW06CisgICAgICAgIChXZWJHUFU6OmNyZWF0 ZUNvbnN0YW50VmFsdWVzKToKKyAgICAgICAgKFdlYkdQVTo6RGV2aWNlOjpjcmVhdGVDb21wdXRl UGlwZWxpbmUpOgorICAgICAgICAqIFdlYkdQVS9TaGFkZXJNb2R1bGUubW06CisgICAgICAgIChX ZWJHUFU6OmVhcmx5Q29tcGlsZVNoYWRlck1vZHVsZSk6CisgICAgICAgIChXZWJHUFU6OkRldmlj ZTo6Y3JlYXRlU2hhZGVyTW9kdWxlKToKKwogMjAyMi0wNC0xMCAgTXlsZXMgQy4gTWF4ZmllbGQg IDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJHUFVdIE1ha2Ugc3VyZSBhc3lu Y2hyb25vdXMgdGhpbmdzIGFyZSBhc3luY2hyb25vdXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJH UFUvV2ViR1BVL0FQSUNvbnZlcnNpb25zLmggYi9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9BUElDb252 ZXJzaW9ucy5oCmluZGV4IDVlYmE3MDQ1MjAxYy4uNjdiYjNkNmUwYWE4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViR1BVL1dlYkdQVS9BUElDb252ZXJzaW9ucy5oCisrKyBiL1NvdXJjZS9XZWJHUFUv V2ViR1BVL0FQSUNvbnZlcnNpb25zLmgKQEAgLTE3MSw3ICsxNzEsNyBAQCBpbmxpbmUgVGV4dHVy ZVZpZXcmIGZyb21BUEkoV0dQVVRleHR1cmVWaWV3IHRleHR1cmVWaWV3KQogCiBpbmxpbmUgU3Ry aW5nIGZyb21BUEkoY29uc3QgY2hhciogc3RyaW5nKQogewotICAgIHJldHVybiBTdHJpbmc6OmZy b21MYXRpbjEoc3RyaW5nKTsKKyAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOChzdHJpbmcpOwog fQogCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJHUFUvV2Vi R1BVL0FkYXB0ZXIubW0gYi9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9BZGFwdGVyLm1tCmluZGV4IDE2 YmRiNmYxMmYwMS4uOGM2ZTRlMzk0NTNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViR1BVL1dlYkdQ VS9BZGFwdGVyLm1tCisrKyBiL1NvdXJjZS9XZWJHUFUvV2ViR1BVL0FkYXB0ZXIubW0KQEAgLTEz NCw3ICsxMzQsNyBAQCB2b2lkIEFkYXB0ZXI6OnJlcXVlc3REZXZpY2UoY29uc3QgV0dQVURldmlj ZURlc2NyaXB0b3ImIGRlc2NyaXB0b3IsIENvbXBsZXRpb25IYQogICAgICAgICByZXR1cm47CiAg ICAgfQogCi0gICAgYXV0byBsYWJlbCA9IFN0cmluZzo6ZnJvbUxhdGluMShkZXNjcmlwdG9yLmxh YmVsKTsKKyAgICBhdXRvIGxhYmVsID0gU3RyaW5nOjpmcm9tVVRGOChkZXNjcmlwdG9yLmxhYmVs KTsKICAgICBpbnN0YW5jZSgpLnNjaGVkdWxlV29yayhbc3Ryb25nVGhpcyA9IFJlZiB7ICp0aGlz IH0sIGxhYmVsID0gV1RGTW92ZShsYWJlbCksIGNhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayld KCkgbXV0YWJsZSB7CiAgICAgICAgIGNhbGxiYWNrKFdHUFVSZXF1ZXN0RGV2aWNlU3RhdHVzX1N1 Y2Nlc3MsIERldmljZTo6Y3JlYXRlKHN0cm9uZ1RoaXMtPm1fZGV2aWNlLCBXVEZNb3ZlKGxhYmVs KSwgc3Ryb25nVGhpcyksIHsgfSk7CiAgICAgfSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViR1BV L1dlYkdQVS9Db21wdXRlUGlwZWxpbmUubW0gYi9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9Db21wdXRl UGlwZWxpbmUubW0KaW5kZXggMmEyMDlkZjM2ZWE5Li45YjUwZjM0ZDVlNDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJHUFUvV2ViR1BVL0NvbXB1dGVQaXBlbGluZS5tbQorKysgYi9Tb3VyY2UvV2Vi R1BVL1dlYkdQVS9Db21wdXRlUGlwZWxpbmUubW0KQEAgLTcxLDcgKzcxLDcgQEAgc3RhdGljIE1U TEZ1bmN0aW9uQ29uc3RhbnRWYWx1ZXMgKmNyZWF0ZUNvbnN0YW50VmFsdWVzKHVpbnQzMl90IGNv bnN0YW50Q291bnQsIGMKICAgICBhdXRvIGNvbnN0YW50VmFsdWVzID0gW01UTEZ1bmN0aW9uQ29u c3RhbnRWYWx1ZXMgbmV3XTsKICAgICBmb3IgKHVpbnQzMl90IGkgPSAwOyBpIDwgY29uc3RhbnRD b3VudDsgKytpKSB7CiAgICAgICAgIGNvbnN0IGF1dG8mIGVudHJ5ID0gY29uc3RhbnRzW2ldOwot ICAgICAgICBhdXRvIG5hbWVJdGVyYXRvciA9IGVudHJ5UG9pbnRJbmZvcm1hdGlvbi5zcGVjaWFs aXphdGlvbkNvbnN0YW50SW5kaWNlcy5maW5kKFN0cmluZzo6ZnJvbUxhdGluMShlbnRyeS5rZXkp KTsKKyAgICAgICAgYXV0byBuYW1lSXRlcmF0b3IgPSBlbnRyeVBvaW50SW5mb3JtYXRpb24uc3Bl Y2lhbGl6YXRpb25Db25zdGFudEluZGljZXMuZmluZChTdHJpbmc6OmZyb21VVEY4KGVudHJ5Lmtl eSkpOwogICAgICAgICBpZiAobmFtZUl0ZXJhdG9yID09IGVudHJ5UG9pbnRJbmZvcm1hdGlvbi5z cGVjaWFsaXphdGlvbkNvbnN0YW50SW5kaWNlcy5lbmQoKSkKICAgICAgICAgICAgIHJldHVybiBu dWxscHRyOwogICAgICAgICBhdXRvIHNwZWNpYWxpemF0aW9uQ29uc3RhbnRJbmRleCA9IG5hbWVJ dGVyYXRvci0+dmFsdWU7CkBAIC0xNTAsNyArMTUwLDcgQEAgUmVmPENvbXB1dGVQaXBlbGluZT4g RGV2aWNlOjpjcmVhdGVDb21wdXRlUGlwZWxpbmUoY29uc3QgV0dQVUNvbXB1dGVQaXBlbGluZURl c2MKICAgICBjb25zdCBQaXBlbGluZUxheW91dCYgcGlwZWxpbmVMYXlvdXQgPSBXZWJHUFU6OmZy b21BUEkoZGVzY3JpcHRvci5sYXlvdXQpOwogICAgIGF1dG8gbGFiZWwgPSBmcm9tQVBJKGRlc2Ny aXB0b3IubGFiZWwpOwogCi0gICAgYXV0byBsaWJyYXJ5Q3JlYXRpb25SZXN1bHQgPSBjcmVhdGVM aWJyYXJ5KG1fZGV2aWNlLCBzaGFkZXJNb2R1bGUsIHBpcGVsaW5lTGF5b3V0LCBTdHJpbmc6OmZy b21MYXRpbjEoZGVzY3JpcHRvci5jb21wdXRlLmVudHJ5UG9pbnQpLCBsYWJlbCk7CisgICAgYXV0 byBsaWJyYXJ5Q3JlYXRpb25SZXN1bHQgPSBjcmVhdGVMaWJyYXJ5KG1fZGV2aWNlLCBzaGFkZXJN b2R1bGUsIHBpcGVsaW5lTGF5b3V0LCBTdHJpbmc6OmZyb21VVEY4KGRlc2NyaXB0b3IuY29tcHV0 ZS5lbnRyeVBvaW50KSwgbGFiZWwpOwogICAgIGlmICghbGlicmFyeUNyZWF0aW9uUmVzdWx0KQog ICAgICAgICByZXR1cm4gQ29tcHV0ZVBpcGVsaW5lOjpjcmVhdGVJbnZhbGlkKCp0aGlzKTsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkdQVS9XZWJHUFUvU2hhZGVyTW9kdWxlLm1tIGIvU291cmNl L1dlYkdQVS9XZWJHUFUvU2hhZGVyTW9kdWxlLm1tCmluZGV4IDEwZDA2ZDA4M2VmZi4uYTAzZjhi MzMzYTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9TaGFkZXJNb2R1bGUubW0K KysrIGIvU291cmNlL1dlYkdQVS9XZWJHUFUvU2hhZGVyTW9kdWxlLm1tCkBAIC04OCw3ICs4OCw3 IEBAIHN0YXRpYyBSZWZQdHI8U2hhZGVyTW9kdWxlPiBlYXJseUNvbXBpbGVTaGFkZXJNb2R1bGUo RGV2aWNlJiBkZXZpY2UsIHN0ZDo6dmFyaWFuCiAgICAgICAgIGNvbnN0IGF1dG8mIGhpbnQgPSBz dXBwbGllZEhpbnRzLmhpbnRzW2ldOwogICAgICAgICBpZiAoaGludC5uZXh0SW5DaGFpbikKICAg ICAgICAgICAgIHJldHVybiBudWxscHRyOwotICAgICAgICBhdXRvIGhpbnRLZXkgPSBTdHJpbmc6 OmZyb21MYXRpbjEoaGludC5rZXkpOworICAgICAgICBhdXRvIGhpbnRLZXkgPSBTdHJpbmc6OmZy b21VVEY4KGhpbnQua2V5KTsKICAgICAgICAgaGludHMuYWRkKGhpbnRLZXksIFdlYkdQVTo6ZnJv bUFQSShoaW50LmhpbnQubGF5b3V0KSk7CiAgICAgICAgIGF1dG8gY29udmVydGVkUGlwZWxpbmVM YXlvdXQgPSBTaGFkZXJNb2R1bGU6OmNvbnZlcnRQaXBlbGluZUxheW91dChXZWJHUFU6OmZyb21B UEkoaGludC5oaW50LmxheW91dCkpOwogICAgICAgICB3Z3NsSGludHMuYWRkKGhpbnRLZXksIFdU Rk1vdmUoY29udmVydGVkUGlwZWxpbmVMYXlvdXQpKTsKQEAgLTEwOSw3ICsxMDksNyBAQCBSZWY8 U2hhZGVyTW9kdWxlPiBEZXZpY2U6OmNyZWF0ZVNoYWRlck1vZHVsZShjb25zdCBXR1BVU2hhZGVy TW9kdWxlRGVzY3JpcHRvciYgZAogICAgIGlmICghc2hhZGVyTW9kdWxlUGFyYW1ldGVycykKICAg ICAgICAgcmV0dXJuIFNoYWRlck1vZHVsZTo6Y3JlYXRlSW52YWxpZCgqdGhpcyk7CiAKLSAgICBh dXRvIGNoZWNrUmVzdWx0ID0gV0dTTDo6c3RhdGljQ2hlY2soU3RyaW5nOjpmcm9tTGF0aW4xKHNo YWRlck1vZHVsZVBhcmFtZXRlcnMtPndnc2wuY29kZSksIHN0ZDo6bnVsbG9wdCk7CisgICAgYXV0 byBjaGVja1Jlc3VsdCA9IFdHU0w6OnN0YXRpY0NoZWNrKFN0cmluZzo6ZnJvbVVURjgoc2hhZGVy TW9kdWxlUGFyYW1ldGVycy0+d2dzbC5jb2RlKSwgc3RkOjpudWxsb3B0KTsKIAogICAgIGlmIChz dGQ6OmhvbGRzX2FsdGVybmF0aXZlPFdHU0w6OlN1Y2Nlc3NmdWxDaGVjaz4oY2hlY2tSZXN1bHQp ICYmIHNoYWRlck1vZHVsZVBhcmFtZXRlcnMtPmhpbnRzICYmIHNoYWRlck1vZHVsZVBhcmFtZXRl cnMtPmhpbnRzLT5oaW50c0NvdW50KSB7CiAgICAgICAgIGlmIChhdXRvIHJlc3VsdCA9IGVhcmx5 Q29tcGlsZVNoYWRlck1vZHVsZSgqdGhpcywgV1RGTW92ZShjaGVja1Jlc3VsdCksICpzaGFkZXJN b2R1bGVQYXJhbWV0ZXJzLT5oaW50cywgZnJvbUFQSShkZXNjcmlwdG9yLmxhYmVsKSkpCg==