239055 2022-04-10 14:59:04 -0700 REGRESSION (r289785): [iOS] Unable to double-click to select a word in a received email 2022-04-11 13:38:54 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi hi katherine_cheney megan_gardner thorton webkit-bug-importer oldest_to_newest 1860150 0 wenson_hsieh 2022-04-10 14:59:04 -0700 rdar://90736710 1860153 1 457213 wenson_hsieh 2022-04-10 15:35:16 -0700 Created attachment 457213 For EWS 1860180 2 457213 thorton 2022-04-10 18:37:42 -0700 Comment on attachment 457213 For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=457213&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-1857 > - if (gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch && touch.type == UITouchTypeIndirectPointer) I think this isn't the only use of `UITouchTypeIndirectPointer` in our code? Are the others wrong too? 1860280 3 457213 wenson_hsieh 2022-04-11 07:40:15 -0700 Comment on attachment 457213 For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=457213&action=review Thanks for the review! >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-1857 >> - if (gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch && touch.type == UITouchTypeIndirectPointer) > > I think this isn't the only use of `UITouchTypeIndirectPointer` in our code? Are the others wrong too? That's a good point — the two other checks in `-_shouldReceiveTouch:forEvent:recognizerView:` and in this same function (below) also look a bit suspicious. I'll double check to see if they should be changed as well.... 1860305 4 wenson_hsieh 2022-04-11 09:35:19 -0700 (In reply to Wenson Hsieh from comment #3) > Comment on attachment 457213 [details] > For EWS > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457213&action=review > > Thanks for the review! > > >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-1857 > >> - if (gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch && touch.type == UITouchTypeIndirectPointer) > > > > I think this isn't the only use of `UITouchTypeIndirectPointer` in our code? Are the others wrong too? > > That's a good point — the two other checks in > `-_shouldReceiveTouch:forEvent:recognizerView:` and in this same function > (below) also look a bit suspicious. > > I'll double check to see if they should be changed as well.... So for this check: ``` if (gestureRecognizer == _doubleTapGestureRecognizer || gestureRecognizer == _nonBlockingDoubleTapGestureRecognizer) return touch.type != UITouchTypeIndirectPointer; ``` I'm actually not sure how to exercise that codepath using touches produced by a trackpad on iOS, since we would normally already have bailed in the `gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch` check above. It's also interesting to note that this was changed in trac.webkit.org/r261978 as well, from `-_isPointerTouch` to `UITouchTypeIndirectPointer`, though maybe that was just about moving off of UIKit SPI (rather than about changing behavior). For the other check: ``` - (BOOL)_shouldReceiveTouch:(UITouch *)touch forEvent:(UIEvent *)event recognizerView:(id)gestureOwner { return touch == _currentTouch && touch.type == UITouchTypeIndirectPointer; } ``` I confirmed that this causes `mousedown` and `mouseup` events to *not* be dispatched in non-"UIApplicationSupportsIndirectInputEvents" apps when clicking with a trackpad! This is fixed if we use `-_isPointerTouch` instead. Since this also appears to be a recent regression (from r290009), I'll fix it in this patch as well. 1860309 5 457259 wenson_hsieh 2022-04-11 09:40:25 -0700 Created attachment 457259 For landing 1860382 6 ews-feeder 2022-04-11 13:19:58 -0700 Committed r292715 (249505@main): <https://commits.webkit.org/249505@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457259. 457213 2022-04-10 15:35:16 -0700 2022-04-11 09:40:23 -0700 For EWS bug-239055-20220410153515.patch text/plain 4033 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM5ODlhNDkwYzFjZjQ4ZGE1 MmFhOGIwODU2ZDcyMTg3MDg2ZmY0NWQuLjkxZWU1YWZiYTMzZjRkZjQ2MjljZDA1NDYyMDc2ZGYz OTAxZjIwOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMjItMDQtMTAgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI4 OTc4NSk6IFtpT1NdIFVuYWJsZSB0byBkb3VibGUtY2xpY2sgdG8gc2VsZWN0IGEgd29yZCBpbiBh IHJlY2VpdmVkIGVtYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzkwNTUKKyAgICAgICAgcmRhcjovLzkwNzM2NzEwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9sbG93aW5nIHIyODk3ODUsIGRvdWJs ZS1jbGlja2luZyB0ZXh0IGluIE1haWwgbWVzc2FnZSB2aWV3ZXIgb24gaU9TIChvciBtb3JlIGdl bmVyYWxseSwgYW55IHdlYiB2aWV3IGluIGFuIGFwcAorICAgICAgICB0aGF0IGRvZXMgbm90IGhh dmUgdGhlICJVSUFwcGxpY2F0aW9uU3VwcG9ydHNJbmRpcmVjdElucHV0RXZlbnRzIiBhcHBsaWNh dGlvbiBwbGlzdCBrZXkgc2V0IHRvIGBZRVNgKSBwcm9kdWNlcyBhCisgICAgICAgIHNlbGVjdGlv biB0aGF0IGlzIGltbWVkaWF0ZWx5IHJlbW92ZWQuIFRoaXMgaXMgYmVjYXVzZSBhZnRlciBkb3Vi bGUgY2xpY2tpbmcsIHRoZSBzeW50aGV0aWMgY2xpY2sgZ2VzdHVyZSBmaXJlcworICAgICAgICBh bmQgaW1tZWRpYXRlbHkgY2xlYXJzIHRoZSBzZWxlY3Rpb24uCisKKyAgICAgICAgSW4gU2FmYXJp IChhbiBhcHBsaWNhdGlvbiB0aGF0IHNldHMgVUlBcHBsaWNhdGlvblN1cHBvcnRzSW5kaXJlY3RJ bnB1dEV2ZW50cyksIHRoZSBub24tcG9pbnRlciBnZXN0dXJlCisgICAgICAgIHJlY29nbml6ZXJz IChlLmcuIHN5bnRoZXRpYyB0YXBzKSBkb24ndCBmaXJlIGJlY2F1c2UgdGhlIHR5cGUgb2YgdGhl IGBVSVRvdWNoYCBpcyBgVUlUb3VjaFR5cGVJbmRpcmVjdFBvaW50ZXJgLAorICAgICAgICB3aGlj aCBhbGxvd3MgdXMgdG8gcmV0dXJuIGBOT2AgZnJvbSBgLWdlc3R1cmVSZWNvZ25pemVyOnNob3Vs ZFJlY2VpdmVUb3VjaDpgIGZvciBhbnl0aGluZyB0aGF0IGlzIG5vdCB0aGUgbW91c2UKKyAgICAg ICAgZ2VzdHVyZSByZWNvZ25pemVyJ3MgY3VycmVudCBtb3VzZSB0b3VjaC4KKworICAgICAgICBG b3IgYXBwcyB0aGF0IGxhY2sgdGhpcyBwbGlzdCBrZXksIHRoZSB0b3VjaCB0eXBlIHJlbWFpbnMg YFVJVG91Y2hUeXBlRGlyZWN0YCB0byBhdm9pZCBicmVha2luZyBjb21wYXRpYmlsaXR5LAorICAg ICAgICBldmVuIGZvciBldmVudHMgdGhhdCBhcmUgZ2VuZXJhdGVkIHZpYSBhIHBvaW50aW5nIGRl dmljZSAoaS5lLiB0cmFja3BhZCkuIFRoaXMgbWVhbnMgdGhhdCB3ZSBubyBsb25nZXIgcm91dGUK KyAgICAgICAgdGhlc2UgZXZlbnRzIHNvbGVseSB0byB0aGUgbW91c2UgZ2VzdHVyZSByZWNvZ25p emVyLiBUbyBmaXggdGhpcywgdXNlIGAtX2lzUG9pbnRlclRvdWNoYCBpbnN0ZWFkIG9mCisgICAg ICAgIGAtW1VJVG91Y2ggdHlwZV1gIGhlcmUuIFVubGlrZSB0aGUgbGF0dGVyLCB0aGUgZm9ybWVy IGlzbid0IGFmZmVjdGVkIGJ5IHRoZSAic3VwcG9ydHMgaW5kaXJlY3QgaW5wdXQiIHBsaXN0IGtl eS4KKworICAgICAgICAqIFBsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaDoKKyAgICAgICAgKiBV SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tD b250ZW50VmlldyBnZXN0dXJlUmVjb2duaXplcjpzaG91bGRSZWNlaXZlVG91Y2g6XSk6CisKIDIw MjItMDQtMDkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUHV0IGxheWVyIGJhY2tpbmcgc3RvcmUgYnVmZmVycyBpbnRvIHRoZSBwZXItUmVtb3RlUmVu ZGVyaW5nQmFja2VuZCBJT1N1cmZhY2VQb29sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Bs YXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lv cy9VSUtpdFNQSS5oCmluZGV4IDk3NDdlNDViNWI1NWUwZTdhY2Y1YzQ0MjcxY2U4NTBiZGYzYTEx MGUuLjA2ZGI5NWU3YzI5Y2VmYTkyM2JhNjI5NTdjN2Q5MmIxOWNmMzgxZTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCkBAIC03NSw2ICs3NSw3IEBACiAjaW1w b3J0IDxVSUtpdC9VSVRleHRJbnB1dF9Qcml2YXRlLmg+CiAjaW1wb3J0IDxVSUtpdC9VSVRleHRJ bnRlcmFjdGlvbkFzc2lzdGFudF9Qcml2YXRlLmg+CiAjaW1wb3J0IDxVSUtpdC9VSVRleHRJbnRl cmFjdGlvbl9Qcml2YXRlLmg+CisjaW1wb3J0IDxVSUtpdC9VSVRvdWNoX1ByaXZhdGUuaD4KICNp bXBvcnQgPFVJS2l0L1VJVmlld0NvbnRyb2xsZXJUcmFuc2l0aW9uaW5nX1ByaXZhdGUuaD4KICNp bXBvcnQgPFVJS2l0L1VJVmlld0NvbnRyb2xsZXJfUHJpdmF0ZS5oPgogI2ltcG9ydCA8VUlLaXQv VUlWaWV3Q29udHJvbGxlcl9WaWV3U2VydmljZS5oPgpAQCAtMTM2Myw2ICsxMzY0LDEyIEBAIHR5 cGVkZWYgTlNfRU5VTShOU1VJbnRlZ2VyLCBfVUlDb250ZXh0TWVudUxheW91dCkgewogQHByb3Bl cnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBOU1N0cmluZyAqX3NjZW5lSWRlbnRpZmllcjsKIEBl bmQKIAorI2lmIEhBVkUoVUlLSVRfV0lUSF9NT1VTRV9TVVBQT1JUKQorQGludGVyZmFjZSBVSVRv dWNoICgpCitAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIEJPT0wgX2lzUG9pbnRlclRv dWNoOworQGVuZAorI2VuZGlmCisKICNlbmRpZiAvLyBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQog CiAjaWYgSEFWRShQQVNURUJPQVJEX0RBVEFfT1dORVIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCA3ZGIz MWI3NWFiM2VlODY1YjNkYTU2OGFiZjI5OGNiZDZiOTVhMDFhLi4zZjExZmQxMjMyZTJiYzkwZjVl MGRlNjEyYWFhZTM1NTMyNGFjNWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTE4NTQsNyArMTg1NCw3 IEBAIC0gKEJPT0wpZ2VzdHVyZVJlY29nbml6ZXI6KFVJR2VzdHVyZVJlY29nbml6ZXIgKilnZXN0 dXJlUmVjb2duaXplciBzaG91bGRSZWNlaXZlCiAjZW5kaWYKIAogI2lmIEhBVkUoVUlLSVRfV0lU SF9NT1VTRV9TVVBQT1JUKQotICAgIGlmIChnZXN0dXJlUmVjb2duaXplciAhPSBfbW91c2VHZXN0 dXJlUmVjb2duaXplciAmJiBbX21vdXNlR2VzdHVyZVJlY29nbml6ZXIgbW91c2VUb3VjaF0gPT0g dG91Y2ggJiYgdG91Y2gudHlwZSA9PSBVSVRvdWNoVHlwZUluZGlyZWN0UG9pbnRlcikKKyAgICBp ZiAoZ2VzdHVyZVJlY29nbml6ZXIgIT0gX21vdXNlR2VzdHVyZVJlY29nbml6ZXIgJiYgW19tb3Vz ZUdlc3R1cmVSZWNvZ25pemVyIG1vdXNlVG91Y2hdID09IHRvdWNoICYmIHRvdWNoLl9pc1BvaW50 ZXJUb3VjaCkKICAgICAgICAgcmV0dXJuIE5POwogICAgIAogICAgIGlmIChnZXN0dXJlUmVjb2du aXplciAhPSBfYWx0ZXJuYXRlTW91c2VHZXN0dXJlUmVjb2duaXplciAmJiBbX2FsdGVybmF0ZU1v dXNlR2VzdHVyZVJlY29nbml6ZXIgbW91c2VUb3VjaF0gPT0gdG91Y2gpCg== 457259 2022-04-11 09:40:25 -0700 2022-04-11 13:38:54 -0700 For landing bug-239055-20220411094024.patch text/plain 5340 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM5ODlhNDkwYzFjZjQ4ZGE1 MmFhOGIwODU2ZDcyMTg3MDg2ZmY0NWQuLjYwNDE3NjdkZDNkZjIzMWNmYzlmZDRkZWE2MzFiMmUz ZmU2YzZiMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzYgQEAKKzIwMjItMDQtMTEgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI4 OTc4NSk6IFtpT1NdIFVuYWJsZSB0byBkb3VibGUtY2xpY2sgdG8gc2VsZWN0IGEgd29yZCBpbiBh IHJlY2VpdmVkIGVtYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzkwNTUKKyAgICAgICAgcmRhcjovLzkwNzM2NzEwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBGb2xsb3dpbmcgcjI4OTc4NSwgZG91YmxlLWNs aWNraW5nIHRleHQgaW4gTWFpbCBtZXNzYWdlIHZpZXdlciBvbiBpT1MgKG9yIG1vcmUgZ2VuZXJh bGx5LCBhbnkgd2ViIHZpZXcgaW4gYW4gYXBwCisgICAgICAgIHRoYXQgZG9lcyBub3QgaGF2ZSB0 aGUgIlVJQXBwbGljYXRpb25TdXBwb3J0c0luZGlyZWN0SW5wdXRFdmVudHMiIGFwcGxpY2F0aW9u IHBsaXN0IGtleSBzZXQgdG8gYFlFU2ApIHByb2R1Y2VzIGEKKyAgICAgICAgc2VsZWN0aW9uIHRo YXQgaXMgaW1tZWRpYXRlbHkgcmVtb3ZlZC4gVGhpcyBpcyBiZWNhdXNlIGFmdGVyIGRvdWJsZSBj bGlja2luZywgdGhlIHN5bnRoZXRpYyBjbGljayBnZXN0dXJlIGZpcmVzCisgICAgICAgIGFuZCBp bW1lZGlhdGVseSBjbGVhcnMgdGhlIHNlbGVjdGlvbi4KKworICAgICAgICBJbiBTYWZhcmkgKGFu IGFwcGxpY2F0aW9uIHRoYXQgc2V0cyBVSUFwcGxpY2F0aW9uU3VwcG9ydHNJbmRpcmVjdElucHV0 RXZlbnRzKSwgdGhlIG5vbi1wb2ludGVyIGdlc3R1cmUKKyAgICAgICAgcmVjb2duaXplcnMgKGUu Zy4gc3ludGhldGljIHRhcHMpIGRvbid0IGZpcmUgYmVjYXVzZSB0aGUgdHlwZSBvZiB0aGUgYFVJ VG91Y2hgIGlzIGBVSVRvdWNoVHlwZUluZGlyZWN0UG9pbnRlcmAsCisgICAgICAgIHdoaWNoIGFs bG93cyB1cyB0byByZXR1cm4gYE5PYCBmcm9tIGAtZ2VzdHVyZVJlY29nbml6ZXI6c2hvdWxkUmVj ZWl2ZVRvdWNoOmAgZm9yIGFueXRoaW5nIHRoYXQgaXMgbm90IHRoZSBtb3VzZQorICAgICAgICBn ZXN0dXJlIHJlY29nbml6ZXIncyBjdXJyZW50IG1vdXNlIHRvdWNoLgorCisgICAgICAgIEZvciBh cHBzIHRoYXQgbGFjayB0aGlzIHBsaXN0IGtleSwgdGhlIHRvdWNoIHR5cGUgcmVtYWlucyBgVUlU b3VjaFR5cGVEaXJlY3RgIHRvIGF2b2lkIGJyZWFraW5nIGNvbXBhdGliaWxpdHksCisgICAgICAg IGV2ZW4gZm9yIGV2ZW50cyB0aGF0IGFyZSBnZW5lcmF0ZWQgdmlhIGEgcG9pbnRpbmcgZGV2aWNl IChpLmUuIHRyYWNrcGFkKS4gVGhpcyBtZWFucyB0aGF0IHdlIG5vIGxvbmdlciByb3V0ZQorICAg ICAgICB0aGVzZSBldmVudHMgc29sZWx5IHRvIHRoZSBtb3VzZSBnZXN0dXJlIHJlY29nbml6ZXIu IFRvIGZpeCB0aGlzLCB1c2UgYC1faXNQb2ludGVyVG91Y2hgIGluc3RlYWQgb2YKKyAgICAgICAg YC1bVUlUb3VjaCB0eXBlXWAgaGVyZS4gVW5saWtlIHRoZSBsYXR0ZXIsIHRoZSBmb3JtZXIgaXNu J3QgYWZmZWN0ZWQgYnkgdGhlICJzdXBwb3J0cyBpbmRpcmVjdCBpbnB1dCIgcGxpc3Qga2V5Lgor CisgICAgICAgICogUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oOgorICAgICAgICAqIFVJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRl bnRWaWV3IGdlc3R1cmVSZWNvZ25pemVyOnNob3VsZFJlY2VpdmVUb3VjaDpdKToKKyAgICAgICAg KiBVSVByb2Nlc3MvaW9zL1dLTW91c2VHZXN0dXJlUmVjb2duaXplci5tbToKKyAgICAgICAgKC1b V0tNb3VzZUdlc3R1cmVSZWNvZ25pemVyIF9zaG91bGRSZWNlaXZlVG91Y2g6Zm9yRXZlbnQ6cmVj b2duaXplclZpZXc6XSk6CisKKyAgICAgICAgQWxzbyBmaXggYSBzaW1pbGFyIGJ1ZyBoZXJlLCB3 aGVyZSB0aGUgY2hlY2sgYWdhaW5zdCBgVUlUb3VjaFR5cGVJbmRpcmVjdFBvaW50ZXJgIGluc3Rl YWQgb2YgYC1faXNQb2ludGVyRXZlbnRgCisgICAgICAgIGNhdXNlcyBhcHBzIHdpdGhvdXQgdGhl IFVJQXBwbGljYXRpb25TdXBwb3J0c0luZGlyZWN0SW5wdXRFdmVudHMga2V5IHRvIGxvc2UgdGhl IGFiaWxpdHkgdG8gbGlzdGVuIGZvciBtb3VzZWRvd24KKyAgICAgICAgYW5kIG1vdXNldXAgZXZl bnRzIHdoZW4gdGhlIHVzZXIgY2xpY2tzIHZpYSB0cmFja3BhZCBvbiBpUGFkLgorCiAyMDIyLTA0 LTA5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFB1 dCBsYXllciBiYWNraW5nIHN0b3JlIGJ1ZmZlcnMgaW50byB0aGUgcGVyLVJlbW90ZVJlbmRlcmlu Z0JhY2tlbmQgSU9TdXJmYWNlUG9vbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9y bS9zcGkvaW9zL1VJS2l0U1BJLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlL aXRTUEkuaAppbmRleCA5NzQ3ZTQ1YjViNTVlMGU3YWNmNWM0NDI3MWNlODUwYmRmM2ExMTBlLi4w NmRiOTVlN2MyOWNlZmE5MjNiYTYyOTU3YzdkOTJiMTljZjM4MWU1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaApAQCAtNzUsNiArNzUsNyBAQAogI2ltcG9ydCA8 VUlLaXQvVUlUZXh0SW5wdXRfUHJpdmF0ZS5oPgogI2ltcG9ydCA8VUlLaXQvVUlUZXh0SW50ZXJh Y3Rpb25Bc3Npc3RhbnRfUHJpdmF0ZS5oPgogI2ltcG9ydCA8VUlLaXQvVUlUZXh0SW50ZXJhY3Rp b25fUHJpdmF0ZS5oPgorI2ltcG9ydCA8VUlLaXQvVUlUb3VjaF9Qcml2YXRlLmg+CiAjaW1wb3J0 IDxVSUtpdC9VSVZpZXdDb250cm9sbGVyVHJhbnNpdGlvbmluZ19Qcml2YXRlLmg+CiAjaW1wb3J0 IDxVSUtpdC9VSVZpZXdDb250cm9sbGVyX1ByaXZhdGUuaD4KICNpbXBvcnQgPFVJS2l0L1VJVmll d0NvbnRyb2xsZXJfVmlld1NlcnZpY2UuaD4KQEAgLTEzNjMsNiArMTM2NCwxMiBAQCB0eXBlZGVm IE5TX0VOVU0oTlNVSW50ZWdlciwgX1VJQ29udGV4dE1lbnVMYXlvdXQpIHsKIEBwcm9wZXJ0eSAo bm9uYXRvbWljLCByZWFkb25seSkgTlNTdHJpbmcgKl9zY2VuZUlkZW50aWZpZXI7CiBAZW5kCiAK KyNpZiBIQVZFKFVJS0lUX1dJVEhfTU9VU0VfU1VQUE9SVCkKK0BpbnRlcmZhY2UgVUlUb3VjaCAo KQorQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBCT09MIF9pc1BvaW50ZXJUb3VjaDsK K0BlbmQKKyNlbmRpZgorCiAjZW5kaWYgLy8gVVNFKEFQUExFX0lOVEVSTkFMX1NESykKIAogI2lm IEhBVkUoUEFTVEVCT0FSRF9EQVRBX09XTkVSKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggN2RiMzFiNzVh YjNlZTg2NWIzZGE1NjhhYmYyOThjYmQ2Yjk1YTAxYS4uM2YxMWZkMTIzMmUyYmM5MGY1ZTBkZTYx MmFhYWUzNTUzMjRhYzVkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0xODU0LDcgKzE4NTQsNyBAQCAt IChCT09MKWdlc3R1cmVSZWNvZ25pemVyOihVSUdlc3R1cmVSZWNvZ25pemVyICopZ2VzdHVyZVJl Y29nbml6ZXIgc2hvdWxkUmVjZWl2ZQogI2VuZGlmCiAKICNpZiBIQVZFKFVJS0lUX1dJVEhfTU9V U0VfU1VQUE9SVCkKLSAgICBpZiAoZ2VzdHVyZVJlY29nbml6ZXIgIT0gX21vdXNlR2VzdHVyZVJl Y29nbml6ZXIgJiYgW19tb3VzZUdlc3R1cmVSZWNvZ25pemVyIG1vdXNlVG91Y2hdID09IHRvdWNo ICYmIHRvdWNoLnR5cGUgPT0gVUlUb3VjaFR5cGVJbmRpcmVjdFBvaW50ZXIpCisgICAgaWYgKGdl c3R1cmVSZWNvZ25pemVyICE9IF9tb3VzZUdlc3R1cmVSZWNvZ25pemVyICYmIFtfbW91c2VHZXN0 dXJlUmVjb2duaXplciBtb3VzZVRvdWNoXSA9PSB0b3VjaCAmJiB0b3VjaC5faXNQb2ludGVyVG91 Y2gpCiAgICAgICAgIHJldHVybiBOTzsKICAgICAKICAgICBpZiAoZ2VzdHVyZVJlY29nbml6ZXIg IT0gX2FsdGVybmF0ZU1vdXNlR2VzdHVyZVJlY29nbml6ZXIgJiYgW19hbHRlcm5hdGVNb3VzZUdl c3R1cmVSZWNvZ25pemVyIG1vdXNlVG91Y2hdID09IHRvdWNoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLTW91c2VHZXN0dXJlUmVjb2duaXplci5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS01vdXNlR2VzdHVyZVJlY29nbml6ZXIubW0KaW5kZXgg Zjk2ZTc1MzBjN2IwYWJiY2FhNDc2MmZjYTM5MjgxZTg2NmZjMTQwNS4uOTAwNDQ4NDcxODhlNjM1 NjkyOTY3ZjE5ZGQ2NmRlODNjZjI5YmRlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLTW91c2VHZXN0dXJlUmVjb2duaXplci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9pb3MvV0tNb3VzZUdlc3R1cmVSZWNvZ25pemVyLm1tCkBAIC04Nyw3ICs4Nyw3 IEBAIC0gKEJPT0wpX3Nob3VsZFJlY2VpdmVUb3VjaDooVUlUb3VjaCAqKXRvdWNoIGZvckV2ZW50 OihVSUV2ZW50ICopZXZlbnQgcmVjb2duaXplCiB7CiAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBt b3ZlIG9mZiBvZiB0aGlzIFVJS2l0IElQSSBtZXRob2Qgb25jZSB3ZSBoYXZlIGEgdmlhYmxlIFNQ SSBvciBBUEkgYWx0ZXJuYXRpdmUKICAgICAvLyBmb3Igb3B0aW5nIGEgVUlIb3Zlckdlc3R1cmVS ZWNvZ25pemVyIHN1YmNsYXNzIGludG8gcmVjZWl2aW5nIFVJVG91Y2hlcy4gU2VlIGFsc286IHJk YXI6Ly84MDcwMDIyNy4KLSAgICByZXR1cm4gdG91Y2ggPT0gX2N1cnJlbnRUb3VjaCAmJiB0b3Vj aC50eXBlID09IFVJVG91Y2hUeXBlSW5kaXJlY3RQb2ludGVyOworICAgIHJldHVybiB0b3VjaCA9 PSBfY3VycmVudFRvdWNoICYmIHRvdWNoLl9pc1BvaW50ZXJUb3VjaDsKIH0KIAogLSAoV2ViS2l0 OjpOYXRpdmVXZWJNb3VzZUV2ZW50ICopbGFzdE1vdXNlRXZlbnQK