239040 2022-04-09 15:53:51 -0700 [Mail Compose] Preserve attachment identifiers when cloning attachment-backed images 2022-04-11 12:03:34 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi cdumez changseok esprehn+autocc ews-watchlist gyuyoung.kim hi megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1860069 0 wenson_hsieh 2022-04-09 15:53:51 -0700 . 1860070 1 webkit-bug-importer 2022-04-09 15:54:06 -0700 <rdar://problem/91527065> 1860071 2 457184 wenson_hsieh 2022-04-09 16:07:03 -0700 Created attachment 457184 Patch 1860317 3 457184 wenson_hsieh 2022-04-11 09:57:48 -0700 Comment on attachment 457184 Patch Thanks for the review! 1860369 4 ews-feeder 2022-04-11 12:03:31 -0700 Committed r292712 (249502@main): <https://commits.webkit.org/249502@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457184. 457184 2022-04-09 16:07:03 -0700 2022-04-11 12:03:33 -0700 Patch bug-239040-20220409160703.patch text/plain 5329 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzY1NzQ1ZTc3NDIzMGVj ZmIzOGZiYTA3YjlhMjY3MGYyYWYyZjU5MS4uNDQ2MDA2MzQ2ZTZjMjg4YjFmMGYxNmM5YjhlNTRh YTZmY2EwMTAzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIyLTA0LTA5ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWlsIENvbXBv c2VdIFByZXNlcnZlIGF0dGFjaG1lbnQgaWRlbnRpZmllcnMgd2hlbiBjbG9uaW5nIGF0dGFjaG1l bnQtYmFja2VkIGltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjM5MDQwCisgICAgICAgIHJkYXI6Ly85MTUyNzA2NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE92ZXJyaWRlIEhUTUxJbWFnZUVsZW1l bnQncyBgY2xvbmVFbGVtZW50V2l0aG91dEF0dHJpYnV0ZXNBbmRDaGlsZHJlbmAgbWV0aG9kIHNv IHRoYXQgaXQgYWRkaXRpb25hbGx5IGNsb25lcyB0aGUKKyAgICAgICAgYXR0YWNobWVudCBlbGVt ZW50IHVuZGVybmVhdGggdGhlIG9yaWdpbmFsIGltYWdlIGVsZW1lbnQsIGlmIGl0IGV4aXN0cy4g VGhpcyBlbnN1cmVzIHRoYXQgYW4gaW1hZ2UgZWxlbWVudCB0aGF0CisgICAgICAgIGlzIGNvcGll ZCBmcm9tIGV4aXN0aW5nIGF0dGFjaG1lbnQtYmFja2VkIGltYWdlcyB1c2luZyBgY2xvbmVOb2Rl YCB3aWxsIGNvbnRhaW4gYW4gYGF0dGFjaG1lbnRgIGluIGl0cyBzaGFkb3cKKyAgICAgICAgcm9v dCB0aGF0IHBvaW50cyB0byB0aGUgc2FtZSBgX1dLQXR0YWNobWVudGAgaW4gdGhlIGVtYmVkZGlu ZyBjbGllbnQuCisKKyAgICAgICAgVGVzdDogV0tBdHRhY2htZW50VGVzdHMuQ2xvbmVJbWFnZVdp dGhBdHRhY2htZW50CisKKyAgICAgICAgKiBodG1sL0hUTUxJbWFnZUVsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTEltYWdlRWxlbWVudDo6Y2xvbmVFbGVtZW50V2l0aG91dEF0dHJp YnV0ZXNBbmRDaGlsZHJlbik6CisgICAgICAgICogaHRtbC9IVE1MSW1hZ2VFbGVtZW50Lmg6CisK IDIwMjItMDQtMDcgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRqdXN0IGFuZCByZWZhY3RvciBzb21lIFVBIHN0eWxlcyBhbmQgbG9naWMgZm9yIGlu amVjdGluZyBMaXZlIFRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElt YWdlRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbWFnZUVsZW1lbnQuY3Bw CmluZGV4IDQwMTcyOGI5NDhmNDJmODJjMTM3OWY5ZmVhZmFkOTQxZDA5NWI3N2UuLjgwNzBhZjAz YjJhMmJhYmExOTljNjNjMDdhZDM4YzZjNDcwZjM1M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTEltYWdlRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MSW1hZ2VFbGVtZW50LmNwcApAQCAtOTQ4LDQgKzk0OCwxNyBAQCB2b2lkIEhUTUxJbWFnZUVs ZW1lbnQ6OmludmFsaWRhdGVBdHRyaWJ1dGVNYXBwaW5nKCkKICAgICBpbnZhbGlkYXRlU3R5bGUo KTsKIH0KIAorUmVmPEVsZW1lbnQ+IEhUTUxJbWFnZUVsZW1lbnQ6OmNsb25lRWxlbWVudFdpdGhv dXRBdHRyaWJ1dGVzQW5kQ2hpbGRyZW4oRG9jdW1lbnQmIHRhcmdldERvY3VtZW50KQoreworICAg IGF1dG8gY2xvbmUgPSBjcmVhdGUodGFyZ2V0RG9jdW1lbnQpOworI2lmIEVOQUJMRShBVFRBQ0hN RU5UX0VMRU1FTlQpCisgICAgaWYgKGF1dG8gYXR0YWNobWVudCA9IGF0dGFjaG1lbnRFbGVtZW50 KCkpIHsKKyAgICAgICAgYXV0byBhdHRhY2htZW50Q2xvbmUgPSBhdHRhY2htZW50LT5jbG9uZUVs ZW1lbnRXaXRob3V0Q2hpbGRyZW4odGFyZ2V0RG9jdW1lbnQpOworICAgICAgICBSRUxFQVNFX0FT U0VSVChpczxIVE1MQXR0YWNobWVudEVsZW1lbnQ+KGF0dGFjaG1lbnRDbG9uZSkpOworICAgICAg ICBjbG9uZS0+c2V0QXR0YWNobWVudEVsZW1lbnQoZG93bmNhc3Q8SFRNTEF0dGFjaG1lbnRFbGVt ZW50PihhdHRhY2htZW50Q2xvbmUuZ2V0KCkpKTsKKyAgICB9CisjZW5kaWYKKyAgICByZXR1cm4g Y2xvbmU7Cit9CisKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEltYWdl RWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW1hZ2VFbGVtZW50LmgKaW5kZXgg ZTA2MTVjZGU2YTAwM2JjOTgxZWI0NDUxNzM3Njk2NTcxOThkNTZiNy4uYjE3OWMwYTlhNWI3ZGMx Y2I1ZmY2OGUxYmMyYTMwNzM4OGZhZTUzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MSW1hZ2VFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW1hZ2VF bGVtZW50LmgKQEAgLTE2NSw2ICsxNjUsOCBAQCBwcml2YXRlOgogICAgIHZvaWQgY29sbGVjdEV4 dHJhU3R5bGVGb3JQcmVzZW50YXRpb25hbEhpbnRzKE11dGFibGVTdHlsZVByb3BlcnRpZXMmKSBv dmVycmlkZTsKICAgICB2b2lkIGludmFsaWRhdGVBdHRyaWJ1dGVNYXBwaW5nKCk7CiAKKyAgICBS ZWY8RWxlbWVudD4gY2xvbmVFbGVtZW50V2l0aG91dEF0dHJpYnV0ZXNBbmRDaGlsZHJlbihEb2N1 bWVudCYgdGFyZ2V0RG9jdW1lbnQpIGZpbmFsOworCiAgICAgLy8gQWN0aXZlRE9NT2JqZWN0Lgog ICAgIGNvbnN0IGNoYXIqIGFjdGl2ZURPTU9iamVjdE5hbWUoKSBjb25zdCBmaW5hbDsKICAgICBi b29sIHZpcnR1YWxIYXNQZW5kaW5nQWN0aXZpdHkoKSBjb25zdCBmaW5hbDsKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MThmMWJmOTRmMTc3YjJl OWRiNWI5YmI1MzIzODgxMjYxOWQ5ZmI4Li44ZjdhYTAyMjYxOGQ2YWRkZGY1ODYzNjg5OGZjODZh ZDlkYmEyMmY0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDQtMDkgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9o c2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW01haWwgQ29tcG9zZV0gUHJlc2VydmUgYXR0YWNo bWVudCBpZGVudGlmaWVycyB3aGVuIGNsb25pbmcgYXR0YWNobWVudC1iYWNrZWQgaW1hZ2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzkwNDAKKyAg ICAgICAgcmRhcjovLzkxNTI3MDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGFuIEFQSSB0ZXN0IHRvIGV4ZXJjaXNlIHRoZSBjaGFuZ2UuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLQXR0YWNobWVudFRl c3RzLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMjItMDQtMDcgIEpv bmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFtNZXJnZS1RdWV1 ZV0gRXh0cmFjdCBidWdfaWQgd2hlbiB1cGRhdGluZyBwdWxsLXJlcXVlc3QgKEZvbGxvdy11cCBm aXgpCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dL QXR0YWNobWVudFRlc3RzLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2Nv YS9XS0F0dGFjaG1lbnRUZXN0cy5tbQppbmRleCAzYzZmMjJkOGI0YjJkZGEwOTUzMTQwY2YwZDA5 NmFjMGNkMzA3MzRhLi5kMTNmOWMzNzQ1N2E4Nzc3MWQxMDJlNzU5NWVkNGUyYzU1ZWU0ZjRkIDEw MDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLQXR0YWNo bWVudFRlc3RzLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2Ev V0tBdHRhY2htZW50VGVzdHMubW0KQEAgLTE2MzIsNiArMTYzMiwzMCBAQCBURVNUKFdLQXR0YWNo bWVudFRlc3RzLCBBdHRhY2htZW50SWRlbnRpZmllck9mQ2xvbmVkQXR0YWNobWVudCkKICAgICBF WFBFQ1RfV0tfU1RSRVEoW2F0dGFjaG1lbnQgdW5pcXVlSWRlbnRpZmllcl0sIFt3ZWJWaWV3IHN0 cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJkb2N1bWVudC5ib2R5LmNsb25lTm9kZSh0cnVl KS5xdWVyeVNlbGVjdG9yKCdhdHRhY2htZW50JykudW5pcXVlSWRlbnRpZmllciJdKTsKIH0KIAor VEVTVChXS0F0dGFjaG1lbnRUZXN0cywgQ2xvbmVJbWFnZVdpdGhBdHRhY2htZW50KQoreworICAg IGF1dG8gd2ViVmlldyA9IHdlYlZpZXdGb3JUZXN0aW5nQXR0YWNobWVudHMoKTsKKyAgICBwbGF0 Zm9ybUNvcHlQTkcoKTsKKworICAgIFJldGFpblB0cjxfV0tBdHRhY2htZW50PiBhdHRhY2htZW50 OworICAgIHsKKyAgICAgICAgT2JzZXJ2ZUF0dGFjaG1lbnRVcGRhdGVzRm9yU2NvcGUgb2JzZXJ2 ZXIod2ViVmlldy5nZXQoKSk7CisgICAgICAgIFt3ZWJWaWV3IF9zeW5jaHJvbm91c2x5RXhlY3V0 ZUVkaXRDb21tYW5kOkAiUGFzdGUiIGFyZ3VtZW50Om5pbF07CisgICAgICAgIEVYUEVDVF9FUSgx VSwgb2JzZXJ2ZXIub2JzZXJ2ZXIoKS5pbnNlcnRlZC5jb3VudCk7CisKKyAgICAgICAgYXR0YWNo bWVudCA9IG9ic2VydmVyLm9ic2VydmVyKCkuaW5zZXJ0ZWQuZmlyc3RPYmplY3Q7CisgICAgICAg IEVYUEVDVF9XS19TVFJFUSgiaW1hZ2UvcG5nIiwgW2F0dGFjaG1lbnQgaW5mb10uY29udGVudFR5 cGUpOworICAgIH0KKworICAgIE5TU3RyaW5nICpjbG9uZWRBdHRhY2htZW50SWRlbnRpZmllciA9 IFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJjb25zdCBvcmlnaW5hbCA9 IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2ltZycpOyIKKyAgICAgICAgImNvbnN0IGNsb25lID0g b3JpZ2luYWwuY2xvbmVOb2RlKCk7IgorICAgICAgICAib3JpZ2luYWwucmVtb3ZlKCk7IgorICAg ICAgICAiZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChjbG9uZSk7IgorICAgICAgICAiSFRNTEF0 dGFjaG1lbnRFbGVtZW50LmdldEF0dGFjaG1lbnRJZGVudGlmaWVyKGNsb25lKTsiXTsKKworICAg IEVYUEVDVF9XS19TVFJFUShbYXR0YWNobWVudCB1bmlxdWVJZGVudGlmaWVyXSwgY2xvbmVkQXR0 YWNobWVudElkZW50aWZpZXIpOworfQorCiBURVNUKFdLQXR0YWNobWVudFRlc3RzLCBTZXRGaWxl V3JhcHBlckZvclBERkltYWdlQXR0YWNobWVudCkKIHsKICAgICBhdXRvIHdlYlZpZXcgPSB3ZWJW aWV3Rm9yVGVzdGluZ0F0dGFjaG1lbnRzKCk7Cg==