239032 2022-04-09 09:00:31 -0700 [Flatpak] clangd wrapper improvements 2022-04-10 09:52:28 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand aperez bugs-noreply mrobinson webkit-bug-importer oldest_to_newest 1860021 0 pnormand 2022-04-09 09:00:31 -0700 . 1860022 1 457166 pnormand 2022-04-09 09:06:14 -0700 Created attachment 457166 Patch 1860026 2 pnormand 2022-04-09 09:52:46 -0700 I wonder also, why not pass --enable-config directly to clangd from the wrapper? 1860059 3 aperez 2022-04-09 14:00:28 -0700 (In reply to Philippe Normand from comment #2) > I wonder also, why not pass --enable-config directly to clangd from the > wrapper? Maybe to avoid arbitrary user configurations breaking how clangd works? Imagine an user's ~/.clangd file adding -std=c++11 and breaking things. 1860063 4 pnormand 2022-04-09 14:22:43 -0700 (In reply to Adrian Perez from comment #3) > (In reply to Philippe Normand from comment #2) > > I wonder also, why not pass --enable-config directly to clangd from the > > wrapper? > > Maybe to avoid arbitrary user configurations breaking how clangd works? > Imagine an user's ~/.clangd file adding -std=c++11 and breaking things. The doc explicitly mentions this option, that's why i'm asking. https://trac.webkit.org/wiki/WebKitEnablingFlatpakClangd 1860116 5 ews-feeder 2022-04-10 09:48:27 -0700 Committed r292687 (249479@main): <https://commits.webkit.org/249479@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457166. 1860119 6 webkit-bug-importer 2022-04-10 09:52:28 -0700 <rdar://problem/91536540> 457166 2022-04-09 09:06:14 -0700 2022-04-10 09:48:30 -0700 Patch bug-239032-20220409090612.patch text/plain 3293 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNjc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTgzNmU2NjYxMGU0YmIyOTJmMGU3NmU2ZDY3NWQ1NjZl NTk1ZWU0Ny4uM2Q3ZjA3ZTMwYTJjZmQ5YmI3YmE3ODJjZWUzMTU2ZjQxYTYyZWU5NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIyLTA0LTA5ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbRmxhdHBha10gY2xhbmdkIHdyYXBwZXIgaW1wcm92ZW1lbnRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzkwMzIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcGF0aCBvZiB0aGUg Y29tcGlsZV9jb21tYW5kcy5qc29uIGlzIG5vdyBpbXBsaWVkIGZyb20gdGhlIHdlYmtpdC1jbGFu Z2QgY29tbWFuZC1saW5lCisgICAgICAgIGFyZ3VtZW50cywgZGVmYXVsdGluZyB0byB0aGUgR1RL L1JlbGVhc2UgY29uZmlndXJhdGlvbi4KKworICAgICAgICBUaGUgcGF0aCBtYXBwaW5ncyB3ZXJl IGluY29ycmVjdCwgdGhlIHNyYyBwYXJ0IGJlaW5nIC9hcHAvd2Via2l0L3tEZWJ1ZyxSZWxlYXNl fSwgd2hpY2ggYXJlCisgICAgICAgIGludmFsaWQgcGF0aHMgaW4gdGhlIHNhbmRib3guIFRoZXkg c2hvdWxkIGluc3RlYWQgcG9pbnQgdG8KKyAgICAgICAgL2FwcC93ZWJraXQvV2ViS2l0QnVpbGQv e0RlYnVnLFJlbGVhc2V9LgorCisgICAgICAgIEZpbmFsbHksIHRoZXJlIHNob3VsZCBiZSBubyBu ZWVkIHRvIGFkZCBhIHBhdGggbWFwcGluZyBmb3IgL3Vzci9pbmNsdWRlIGJlY2F1c2UgY2xhbmdk IGlzCisgICAgICAgIGxhdW5jaGVkIGluIHRoZSBzYW5kYm94IHJ1bnRpbWUsIHdoZXJlIC91c3Iv aW5jbHVkZS8gaXMgYWxyZWFkeSBiaW5kLW1vdW5kZWQgYnkKKyAgICAgICAgZmxhdHBhay9id3Jh cC4KKworICAgICAgICAqIGZsYXRwYWsvd2Via2l0LWNsYW5nZDoKKwogMjAyMi0wNC0wOCAgRWxs aW90dCBXaWxsaWFtcyAgPGVtd0BhcHBsZS5jb20+CiAKICAgICAgICAgW1hjb2RlXSBBdm9pZCB0 YXJnZXRpbmcgMzItYml0IGlPUyBhbmQgTWFjIGFyY2hpdGVjdHVyZXMKZGlmZiAtLWdpdCBhL1Rv b2xzL2ZsYXRwYWsvd2Via2l0LWNsYW5nZCBiL1Rvb2xzL2ZsYXRwYWsvd2Via2l0LWNsYW5nZApp bmRleCA5NTc0MjYzNGQ0MmRmZDEwNDYzMTJkZDQ5NGFmYzE5ZjU0YzM1ODBiLi5hMzJlZjJlZTE4 ZTZjNTZjNjg0ZjRmYTMyN2FmMDg1N2YzOThmMmQwIDEwMDc1NQotLS0gYS9Ub29scy9mbGF0cGFr L3dlYmtpdC1jbGFuZ2QKKysrIGIvVG9vbHMvZmxhdHBhay93ZWJraXQtY2xhbmdkCkBAIC0yMiwy OCArMjIsMzYgQEAgaW1wb3J0IG9zCiBpbXBvcnQgc3lzCiAKIHBsYXRmb3JtID0gIkdUSyIKK2J1 aWxkX3R5cGUgPSAiUmVsZWFzZSIKIGlmICItLXdwZSIgaW4gc3lzLmFyZ3Y6CiAgICAgcGxhdGZv cm0gPSAiV1BFIgogICAgIHN5cy5hcmd2LnJlbW92ZSgiLS13cGUiKQogaWYgIi0tZ3RrIiBpbiBz eXMuYXJndjoKICAgICBzeXMuYXJndi5yZW1vdmUoIi0tZ3RrIikKIAoraWYgIi0tZGVidWciIGlu IHN5cy5hcmd2OgorICAgIGJ1aWxkX3R5cGUgPSAiRGVidWciCisgICAgc3lzLmFyZ3YucmVtb3Zl KCItLWRlYnVnIikKK2lmICItLXJlbGVhc2UiIGluIHN5cy5hcmd2OgorICAgIHN5cy5hcmd2LnJl bW92ZSgiLS1yZWxlYXNlIikKKwogYnVpbGRfcGF0aCA9IG9zLmVudmlyb25bJ1dFQktJVF9PVVRQ VVRESVInXSBpZiAnV0VCS0lUX09VVFBVVERJUicgaW4gb3MuZW52aXJvbiBcCiAgICAgZWxzZSBm bGF0cGFrdXRpbHMuREVGQVVMVF9CVUlMRF9ST09UCiBtYXBwaW5ncyA9ICItLXBhdGgtbWFwcGlu Z3M9IiArICIsIi5qb2luKFsKICAgICAie309e30iLmZvcm1hdCgKLSAgICAgICAgb3MucGF0aC5q b2luKGZsYXRwYWt1dGlscy5TQU5EQk9YX1NPVVJDRV9ST09ULCAiRGVidWciKSwKKyAgICAgICAg b3MucGF0aC5qb2luKGZsYXRwYWt1dGlscy5TQU5EQk9YX1NPVVJDRV9ST09ULCBmbGF0cGFrdXRp bHMuQlVJTERfUk9PVF9ESVJfTkFNRSwgIkRlYnVnIiksCiAgICAgICAgIG9zLnBhdGguam9pbihi dWlsZF9wYXRoLCBwbGF0Zm9ybSwgIkRlYnVnIikpLAogICAgICJ7fT17fSIuZm9ybWF0KAotICAg ICAgICBvcy5wYXRoLmpvaW4oZmxhdHBha3V0aWxzLlNBTkRCT1hfU09VUkNFX1JPT1QsICJSZWxl YXNlIiksCisgICAgICAgIG9zLnBhdGguam9pbihmbGF0cGFrdXRpbHMuU0FOREJPWF9TT1VSQ0Vf Uk9PVCwgZmxhdHBha3V0aWxzLkJVSUxEX1JPT1RfRElSX05BTUUsICJSZWxlYXNlIiksCiAgICAg ICAgIG9zLnBhdGguam9pbihidWlsZF9wYXRoLCBwbGF0Zm9ybSwgIlJlbGVhc2UiKSksCiAgICAg Int9PXt9Ii5mb3JtYXQoCiAgICAgICAgIG9zLnBhdGguam9pbihmbGF0cGFrdXRpbHMuV0VCS0lU X1NPVVJDRV9ESVIsICJTb3VyY2UiKSwKICAgICAgICAgb3MucGF0aC5qb2luKGZsYXRwYWt1dGls cy5TQU5EQk9YX1NPVVJDRV9ST09ULCAiU291cmNlIikpLAotICAgICIvdXNyL2luY2x1ZGU9e30i LmZvcm1hdCgKLSAgICAgICAgb3MucGF0aC5qb2luKGZsYXRwYWt1dGlscy5GTEFUUEFLX1VTRVJf RElSX1BBVEgsICJydW50aW1lIiwgIm9yZy53ZWJraXQuU2RrIiwKLSAgICAgICAgICAgICAgICAg ICAgICJ4ODZfNjQiLCBmbGF0cGFrdXRpbHMuU0RLX0JSQU5DSCwgImFjdGl2ZSIsICJmaWxlcyIs ICJpbmNsdWRlIikpLAogXSkKIAotcHJpbnQoZiJSdW5uaW5nIGNsYW5nZCB3aXRoIGFyZ3VtZW50 czoge1ttYXBwaW5nc10gKyBzeXMuYXJndlsxOl19IikKLWZsYXRwYWt1dGlscy5ydW5faW5fc2Fu ZGJveF9pZl9hdmFpbGFibGUoWyJjbGFuZ2QiLCBtYXBwaW5nc10gKyBzeXMuYXJndlsxOl0pCiti dWlsZF9kaXIgPSBvcy5wYXRoLmpvaW4oZmxhdHBha3V0aWxzLlNBTkRCT1hfU09VUkNFX1JPT1Qs IGZsYXRwYWt1dGlscy5CVUlMRF9ST09UX0RJUl9OQU1FLCBidWlsZF90eXBlKQorZXh0cmFfb3B0 aW9ucyA9IFtmIi0tY29tcGlsZS1jb21tYW5kcy1kaXI9e2J1aWxkX2Rpcn0iXQorCitjb21tYW5k ID0gWyJjbGFuZ2QiLCBtYXBwaW5nc10gKyBleHRyYV9vcHRpb25zICsgc3lzLmFyZ3ZbMTpdCitw cmludChmIlJ1bm5pbmcgY2xhbmdkIHdpdGggYXJndW1lbnRzOiB7Y29tbWFuZH0iKQorZmxhdHBh a3V0aWxzLnJ1bl9pbl9zYW5kYm94X2lmX2F2YWlsYWJsZShjb21tYW5kKQo=