239004 2022-04-08 08:46:58 -0700 [WPE][2.36] Build with a11y disabled fails 2022-04-08 12:55:52 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand bugs-noreply mcatanzaro oldest_to_newest 1859744 0 pnormand 2022-04-08 08:46:58 -0700 ../Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp:52:67: error: no member named 'accessibilityBusAddress' in 'WebCore::PlatformDisplay' m_dbusAddress = WebCore::PlatformDisplay::sharedDisplay().accessibilityBusAddress().utf8(); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated. 1859745 1 457076 pnormand 2022-04-08 08:48:48 -0700 Created attachment 457076 Patch 1859757 2 457076 mcatanzaro 2022-04-08 09:15:14 -0700 Comment on attachment 457076 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457076&action=review > Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp:50 > XDGDBusProxy::XDGDBusProxy(Type type, bool allowPortals) > : m_type(type) > { > +#if ENABLE(ACCESSIBILITY) > switch (m_type) { > case Type::SessionBus: > m_dbusAddress = g_getenv("DBUS_SESSION_BUS_ADDRESS"); I think you're removing too much here, right? This will break the non-a11y proxy too? 1859768 3 457084 pnormand 2022-04-08 09:25:40 -0700 Created attachment 457084 Patch 1859848 4 ews-feeder 2022-04-08 12:55:49 -0700 Committed r292628 (249448@main): <https://commits.webkit.org/249448@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457084. 457076 2022-04-08 08:48:48 -0700 2022-04-08 09:25:35 -0700 Patch bug-239004-20220408084846.patch text/plain 2902 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU0MzBlMWI2MTY1NGE0YzIw YjEzMDUxY2VhNjg0ODI0OGI2ZGY0OWEuLjRhZDRjMjkxZTlhODkwNGVjYmJjYTJlMGU3M2ZlZWZl YjI1NzdkYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDQtMDggIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdWzIuMzZdIEJ1 aWxkIHdpdGggYTExeSBkaXNhYmxlZCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5MDA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIGFjY2Vzc2liaWxpdHkgYnVpbGQgZ3VhcmRzLgorCisg ICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6WERHREJ1c1Byb3h5OjpYREdEQnVzUHJveHkpOgorICAgICAgICAoV2ViS2l0 OjpYREdEQnVzUHJveHk6OmxhdW5jaCBjb25zdCk6CisKIDIwMjItMDQtMDggIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFJlbW90ZUlu c3BlY3RvcjogdXBkYXRlIHRhcmdldCBsaXN0IHBhZ2UgY29udGVudHMgb24gY2hhbmdlIGluc3Rl YWQgb2YgcmVsb2FkaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVu Y2hlci9nbGliL1hER0RCdXNQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVu Y2hlci9nbGliL1hER0RCdXNQcm94eS5jcHAKaW5kZXggMDQ0YTE1YmZjMDQyNTNjODk2MTc4ZDU3 MTNmZmE4NjllY2M0NGMwYy4uNGM4M2I4YTFlZjYxM2UxZDc1ZTM0MGQ3NWU4MzgwYjBmNWM2OTBi OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9YREdE QnVzUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIv WERHREJ1c1Byb3h5LmNwcApAQCAtNDQsNiArNDQsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIFhE R0RCdXNQcm94eTo6WERHREJ1c1Byb3h5KFR5cGUgdHlwZSwgYm9vbCBhbGxvd1BvcnRhbHMpCiAg ICAgOiBtX3R5cGUodHlwZSkKIHsKKyNpZiBFTkFCTEUoQUNDRVNTSUJJTElUWSkKICAgICBzd2l0 Y2ggKG1fdHlwZSkgewogICAgIGNhc2UgVHlwZTo6U2Vzc2lvbkJ1czoKICAgICAgICAgbV9kYnVz QWRkcmVzcyA9IGdfZ2V0ZW52KCJEQlVTX1NFU1NJT05fQlVTX0FERFJFU1MiKTsKQEAgLTczLDcg Kzc0LDcgQEAgWERHREJ1c1Byb3h5OjpYREdEQnVzUHJveHkoVHlwZSB0eXBlLCBib29sIGFsbG93 UG9ydGFscykKIAogICAgICAgICBtX3BhdGggPSBDU3RyaW5nKHBhdGgsIHBhdGhFbmQgLSBwYXRo KTsKICAgICB9Ci0KKyNlbmRpZgogICAgIG1fc3luY0ZEID0gbGF1bmNoKGFsbG93UG9ydGFscyk7 CiB9CiAKQEAgLTE1Niw2ICsxNTcsNyBAQCBpbnQgWERHREJ1c1Byb3h5OjpsYXVuY2goYm9vbCBh bGxvd1BvcnRhbHMpIGNvbnN0CiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNlIFR5cGU6 OkFjY2Vzc2liaWxpdHlCdXM6CisjaWYgRU5BQkxFKEFDQ0VTU0lCSUxJVFkpCiAgICAgICAgIHBy b3h5QXJncy5hcHBlbmRWZWN0b3IoVmVjdG9yPENTdHJpbmc+IHsKICAgICAgICAgICAgICItLXNs b3BweS1uYW1lcyIsCiAgICAgICAgICAgICAiLS1jYWxsPW9yZy5hMTF5LmF0c3BpLlJlZ2lzdHJ5 PW9yZy5hMTF5LmF0c3BpLlNvY2tldC5FbWJlZEAvb3JnL2ExMXkvYXRzcGkvYWNjZXNzaWJsZS9y b290IiwKQEAgLTE2Niw2ICsxNjgsNyBAQCBpbnQgWERHREJ1c1Byb3h5OjpsYXVuY2goYm9vbCBh bGxvd1BvcnRhbHMpIGNvbnN0CiAgICAgICAgICAgICAiLS1jYWxsPW9yZy5hMTF5LmF0c3BpLlJl Z2lzdHJ5PW9yZy5hMTF5LmF0c3BpLkRldmljZUV2ZW50Q29udHJvbGxlci5Ob3RpZnlMaXN0ZW5l cnNTeW5jQC9vcmcvYTExeS9hdHNwaS9yZWdpc3RyeS9kZXZpY2VldmVudGNvbnRyb2xsZXIiLAog ICAgICAgICAgICAgIi0tY2FsbD1vcmcuYTExeS5hdHNwaS5SZWdpc3RyeT1vcmcuYTExeS5hdHNw aS5EZXZpY2VFdmVudENvbnRyb2xsZXIuTm90aWZ5TGlzdGVuZXJzQXN5bmNAL29yZy9hMTF5L2F0 c3BpL3JlZ2lzdHJ5L2RldmljZWV2ZW50Y29udHJvbGxlciIsCiAgICAgICAgIH0pOworI2VuZGlm CiAgICAgICAgIGJyZWFrOwogICAgIH0KIApAQCAtMTk3LDggKzIwMCwxMCBAQCBpbnQgWERHREJ1 c1Byb3h5OjpsYXVuY2goYm9vbCBhbGxvd1BvcnRhbHMpIGNvbnN0CiAKICAgICBQcm9jZXNzTGF1 bmNoZXI6OkxhdW5jaE9wdGlvbnMgbGF1bmNoT3B0aW9uczsKICAgICBsYXVuY2hPcHRpb25zLnBy b2Nlc3NUeXBlID0gUHJvY2Vzc0xhdW5jaGVyOjpQcm9jZXNzVHlwZTo6REJ1c1Byb3h5OworI2lm IEVOQUJMRShBQ0NFU1NJQklMSVRZKQogICAgIGlmIChtX3R5cGUgPT0gVHlwZTo6QWNjZXNzaWJp bGl0eUJ1cyAmJiAhbV9wYXRoLmlzTnVsbCgpKQogICAgICAgICBsYXVuY2hPcHRpb25zLmV4dHJh U2FuZGJveFBhdGhzLmFkZChtX3BhdGgsIFNhbmRib3hQZXJtaXNzaW9uOjpSZWFkT25seSk7Cisj ZW5kaWYKICAgICBHVW5pcXVlT3V0UHRyPEdFcnJvcj4gZXJyb3I7CiAgICAgR1JlZlB0cjxHU3Vi cHJvY2Vzcz4gcHJvY2VzcyA9IGJ1YmJsZXdyYXBTcGF3bihsYXVuY2hlci5nZXQoKSwgbGF1bmNo T3B0aW9ucywgYXJndiwgJmVycm9yLm91dFB0cigpKTsKICAgICBpZiAoIXByb2Nlc3MpCg== 457084 2022-04-08 09:25:40 -0700 2022-04-08 12:55:51 -0700 Patch bug-239004-20220408092539.patch text/plain 2806 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU0MzBlMWI2MTY1NGE0YzIw YjEzMDUxY2VhNjg0ODI0OGI2ZGY0OWEuLjRhZDRjMjkxZTlhODkwNGVjYmJjYTJlMGU3M2ZlZWZl YjI1NzdkYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDQtMDggIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdWzIuMzZdIEJ1 aWxkIHdpdGggYTExeSBkaXNhYmxlZCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5MDA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIGFjY2Vzc2liaWxpdHkgYnVpbGQgZ3VhcmRzLgorCisg ICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvWERHREJ1c1Byb3h5LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6WERHREJ1c1Byb3h5OjpYREdEQnVzUHJveHkpOgorICAgICAgICAoV2ViS2l0 OjpYREdEQnVzUHJveHk6OmxhdW5jaCBjb25zdCk6CisKIDIwMjItMDQtMDggIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFJlbW90ZUlu c3BlY3RvcjogdXBkYXRlIHRhcmdldCBsaXN0IHBhZ2UgY29udGVudHMgb24gY2hhbmdlIGluc3Rl YWQgb2YgcmVsb2FkaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVu Y2hlci9nbGliL1hER0RCdXNQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVu Y2hlci9nbGliL1hER0RCdXNQcm94eS5jcHAKaW5kZXggMDQ0YTE1YmZjMDQyNTNjODk2MTc4ZDU3 MTNmZmE4NjllY2M0NGMwYy4uYmUwOTZmOGZjOTUyNDFlYzBjZTUzODkwNWU2YmI5MzY2N2QyMmI5 ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9YREdE QnVzUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIv WERHREJ1c1Byb3h5LmNwcApAQCAtNDksNyArNDksOSBAQCBYREdEQnVzUHJveHk6OlhER0RCdXNQ cm94eShUeXBlIHR5cGUsIGJvb2wgYWxsb3dQb3J0YWxzKQogICAgICAgICBtX2RidXNBZGRyZXNz ID0gZ19nZXRlbnYoIkRCVVNfU0VTU0lPTl9CVVNfQUREUkVTUyIpOwogICAgICAgICBicmVhazsK ICAgICBjYXNlIFR5cGU6OkFjY2Vzc2liaWxpdHlCdXM6CisjaWYgRU5BQkxFKEFDQ0VTU0lCSUxJ VFkpCiAgICAgICAgIG1fZGJ1c0FkZHJlc3MgPSBXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6OnNo YXJlZERpc3BsYXkoKS5hY2Nlc3NpYmlsaXR5QnVzQWRkcmVzcygpLnV0ZjgoKTsKKyNlbmRpZgog ICAgICAgICBicmVhazsKICAgICB9CiAKQEAgLTE1Niw2ICsxNTgsNyBAQCBpbnQgWERHREJ1c1By b3h5OjpsYXVuY2goYm9vbCBhbGxvd1BvcnRhbHMpIGNvbnN0CiAgICAgICAgIGJyZWFrOwogICAg IH0KICAgICBjYXNlIFR5cGU6OkFjY2Vzc2liaWxpdHlCdXM6CisjaWYgRU5BQkxFKEFDQ0VTU0lC SUxJVFkpCiAgICAgICAgIHByb3h5QXJncy5hcHBlbmRWZWN0b3IoVmVjdG9yPENTdHJpbmc+IHsK ICAgICAgICAgICAgICItLXNsb3BweS1uYW1lcyIsCiAgICAgICAgICAgICAiLS1jYWxsPW9yZy5h MTF5LmF0c3BpLlJlZ2lzdHJ5PW9yZy5hMTF5LmF0c3BpLlNvY2tldC5FbWJlZEAvb3JnL2ExMXkv YXRzcGkvYWNjZXNzaWJsZS9yb290IiwKQEAgLTE2Niw2ICsxNjksNyBAQCBpbnQgWERHREJ1c1By b3h5OjpsYXVuY2goYm9vbCBhbGxvd1BvcnRhbHMpIGNvbnN0CiAgICAgICAgICAgICAiLS1jYWxs PW9yZy5hMTF5LmF0c3BpLlJlZ2lzdHJ5PW9yZy5hMTF5LmF0c3BpLkRldmljZUV2ZW50Q29udHJv bGxlci5Ob3RpZnlMaXN0ZW5lcnNTeW5jQC9vcmcvYTExeS9hdHNwaS9yZWdpc3RyeS9kZXZpY2Vl dmVudGNvbnRyb2xsZXIiLAogICAgICAgICAgICAgIi0tY2FsbD1vcmcuYTExeS5hdHNwaS5SZWdp c3RyeT1vcmcuYTExeS5hdHNwaS5EZXZpY2VFdmVudENvbnRyb2xsZXIuTm90aWZ5TGlzdGVuZXJz QXN5bmNAL29yZy9hMTF5L2F0c3BpL3JlZ2lzdHJ5L2RldmljZWV2ZW50Y29udHJvbGxlciIsCiAg ICAgICAgIH0pOworI2VuZGlmCiAgICAgICAgIGJyZWFrOwogICAgIH0KIApAQCAtMTk3LDggKzIw MSwxMCBAQCBpbnQgWERHREJ1c1Byb3h5OjpsYXVuY2goYm9vbCBhbGxvd1BvcnRhbHMpIGNvbnN0 CiAKICAgICBQcm9jZXNzTGF1bmNoZXI6OkxhdW5jaE9wdGlvbnMgbGF1bmNoT3B0aW9uczsKICAg ICBsYXVuY2hPcHRpb25zLnByb2Nlc3NUeXBlID0gUHJvY2Vzc0xhdW5jaGVyOjpQcm9jZXNzVHlw ZTo6REJ1c1Byb3h5OworI2lmIEVOQUJMRShBQ0NFU1NJQklMSVRZKQogICAgIGlmIChtX3R5cGUg PT0gVHlwZTo6QWNjZXNzaWJpbGl0eUJ1cyAmJiAhbV9wYXRoLmlzTnVsbCgpKQogICAgICAgICBs YXVuY2hPcHRpb25zLmV4dHJhU2FuZGJveFBhdGhzLmFkZChtX3BhdGgsIFNhbmRib3hQZXJtaXNz aW9uOjpSZWFkT25seSk7CisjZW5kaWYKICAgICBHVW5pcXVlT3V0UHRyPEdFcnJvcj4gZXJyb3I7 CiAgICAgR1JlZlB0cjxHU3VicHJvY2Vzcz4gcHJvY2VzcyA9IGJ1YmJsZXdyYXBTcGF3bihsYXVu Y2hlci5nZXQoKSwgbGF1bmNoT3B0aW9ucywgYXJndiwgJmVycm9yLm91dFB0cigpKTsKICAgICBp ZiAoIXByb2Nlc3MpCg==