238964 2022-04-07 15:20:35 -0700 REGRESSION(247678@main) [WPE] API test TestUIClient /webkit/WebKitWebView/allow-modal-dialogs is making run-wpe-tests to timeout 2022-05-31 20:49:59 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=217655 P2 Normal --- 1 lmoura lmoura bugs-noreply oldest_to_newest 1859466 0 lmoura 2022-04-07 15:20:35 -0700 /TestWebKitAPI/WPE/TestUIClient /webkit/WebKitWebView/allow-modal-dialogs The test passes but `run-wpe-tests` has been timing out consistently in WPE bots waiting for the TestUIClient executable to return. Reverting this commit or commenting out this test makes the test to exit correctly, as does adding a small timeout to give the loop a few more spins before exiting. 1859470 1 456975 lmoura 2022-04-07 15:35:31 -0700 Created attachment 456975 Tentative patch Tentative patch by adding the wait time. Not sure if the original patch actually uncovered some limitation in the modal dialog implementation (although the test uses showModalDialog which is deprecated in HTML). 1873216 2 lmoura 2022-05-31 20:49:45 -0700 Looks like something between 249870@main and 250658@main fixed the issue and the tests are working now. Closing. 456975 2022-04-07 15:35:31 -0700 2022-05-31 20:49:59 -0700 Tentative patch bug-238964-20220407193530.patch text/plain 1613 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNTI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGQ3NDhkYmYxNTA2YjA4Y2JlMmJjMDkyZDNiNWQ0M2Vi ODdiNjI0NC4uOWUyNGU5YWRiYzQ0YmFkZTJlZjY0Y2NmNWJiOTMyMzZiYmRhNWNmZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIyLTA0LTA3ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04oMjQ3Njc4QG1haW4pIFtXUEVdIEFQSSB0ZXN0IFRlc3RVSUNsaWVudCAv d2Via2l0L1dlYktpdFdlYlZpZXcvYWxsb3ctbW9kYWwtZGlhbG9ncyBpcyBtYWtpbmcgcnVuLXdw ZS10ZXN0cyB0byB0aW1lb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMzg5NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0VUlDbGllbnQu Y3BwOgorICAgICAgICAodGVzdFdlYlZpZXdBbGxvd01vZGFsRGlhbG9ncyk6IFdhaXQgYSBiaXQg YmVmb3JlIGV4aXRpbmcgdGhlIGxvb3AuCisKIDIwMjItMDQtMDYgIERld2VpIFpodSAgPGRld2Vp X3podUBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlICdvcGVuJyBjb21tYW5kIG9uIG1hY09TIHRv IGxhdW5jaCBVUkwgc2hvdWxkIHBhc3MgU2FmYXJpIGFwcCBidW5kbGUgaW5zdGVhZCBvZiBiaW5h cnkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0 VUlDbGllbnQuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RV SUNsaWVudC5jcHAKaW5kZXggYjdjMWNjMWM1YzUzYjk3MDZlZGQ0YmM0Zjc3MmNhMjk2M2QxMzQy Zi4uZGE2MGI5MjdlNTczY2Q5MjI1ZmU5ZTJkYTg4MzZhMDBmOTA0YjY4NSAxMDA2NDQKLS0tIGEv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RVSUNsaWVudC5jcHAKKysr IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RVSUNsaWVudC5jcHAK QEAgLTYzNyw2ICs2MzcsNyBAQCBzdGF0aWMgdm9pZCB0ZXN0V2ViVmlld0FsbG93TW9kYWxEaWFs b2dzKE1vZGFsRGlhbG9nc1Rlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAgICAgd2Via2l0X3Nl dHRpbmdzX3NldF9hbGxvd190b3BfbmF2aWdhdGlvbl90b19kYXRhX3VybHMoc2V0dGluZ3MsIFRS VUUpOwogCiAgICAgdGVzdC0+bG9hZEh0bWwoIjxodG1sPjxib2R5IG9ubG9hZD1cIndpbmRvdy5z aG93TW9kYWxEaWFsb2coJ2RhdGE6dGV4dC9odG1sLDxodG1sPjxib2R5Lz48c2NyaXB0PndpbmRv dy5jbG9zZSgpOzwvc2NyaXB0PjwvaHRtbD4nKVwiPjwvYm9keT48L2h0bWw+IiwgMCk7CisgICAg dGVzdC0+d2FpdCgxKTsKICAgICB0ZXN0LT53YWl0VW50aWxNYWluTG9vcEZpbmlzaGVzKCk7CiAK ICAgICBWZWN0b3I8VUlDbGllbnRUZXN0OjpXZWJWaWV3RXZlbnRzPiYgZXZlbnRzID0gdGVzdC0+ bV93ZWJWaWV3RXZlbnRzOwo=