238931 2022-04-07 06:42:23 -0700 [web-animations] REGRESSION (r287881): loading performance for diply.com regressed 2022-04-07 13:33:46 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts dino graouts nham simon.fraser webkit-bug-importer oldest_to_newest 1859229 0 graouts 2022-04-07 06:42:23 -0700 [web-animations] REGRESSION (r287881): loading performance for diply.com regressed 1859230 1 456918 graouts 2022-04-07 06:43:47 -0700 Created attachment 456918 Patch 1859231 2 graouts 2022-04-07 06:43:53 -0700 <rdar://problem/91190007> 1859290 3 456918 simon.fraser 2022-04-07 09:42:16 -0700 Comment on attachment 456918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456918&action=review > Source/WebCore/style/Styleable.cpp:451 > + auto effectTargetsProperty = [&](KeyframeEffect& effect) { > + if (effect.animatedProperties().contains(property)) > + return true; > + if (auto* transition = dynamicDowncast<CSSTransition>(effect.animation())) > + return transition->property() == property; > + return false; > + }; Might be cleaner to pass `property` in and remove default capture. 1859317 4 graouts 2022-04-07 10:45:45 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 456918 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456918&action=review > > > Source/WebCore/style/Styleable.cpp:451 > > + auto effectTargetsProperty = [&](KeyframeEffect& effect) { > > + if (effect.animatedProperties().contains(property)) > > + return true; > > + if (auto* transition = dynamicDowncast<CSSTransition>(effect.animation())) > > + return transition->property() == property; > > + return false; > > + }; > > Might be cleaner to pass `property` in and remove default capture. Had the same thought as I was writing but was too lazy! Will fix in the commit. 1859328 5 456943 graouts 2022-04-07 10:54:43 -0700 Created attachment 456943 Patch for landing 1859419 6 ews-feeder 2022-04-07 13:33:43 -0700 Committed r292561 (249399@main): <https://commits.webkit.org/249399@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456943. 456918 2022-04-07 06:43:47 -0700 2022-04-07 10:54:39 -0700 Patch bug-238931-20220407154346.patch text/plain 2924 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVmZjI5ZTdlMmY0YTM0 MWY4ZjU2ZjdjNDI5NTkwMDMyNzRhZDU4ZS4uMjhjZWM5MTBjZGMzOGNhOWJkMzc0MzljMDhjNDYz YWMxYTVlZmU3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTA0LTA3ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFt3ZWItYW5pbWF0aW9u c10gUkVHUkVTU0lPTiAocjI4Nzg4MSk6IGxvYWRpbmcgcGVyZm9ybWFuY2UgZm9yIGRpcGx5LmNv bSByZWdyZXNzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzODkzMQorICAgICAgICByZGFyOi8vOTExOTAwMDcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBvbmx5IG5lZWQgdG8gcmVzb2x2ZSBlZmZl Y3RzIGluIHRoZSBzdGFjayBpZiB0aGV5IGFyZSB0YXJnZXRpbmcgdGhlIHByb3BlcnR5IHdlIGFy ZQorICAgICAgICBjb25zaWRlcmluZyBmb3IgdGhlIGNyZWF0aW9uLCB1cGRhdGUgb3IgcmVtb3Zh bCBvZiBhIENTUyBUcmFuc2l0aW9uLgorCisgICAgICAgICogc3R5bGUvU3R5bGVhYmxlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OnVwZGF0ZUNTU1RyYW5zaXRpb25zRm9yU3R5bGVhYmxlQW5kUHJv cGVydHkpOgorCiAyMDIyLTAzLTI4ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3Jn PgogCiAgICAgICAgIE1ha2UgaXQgaGFyZCB0byBhZGQgYSBuZXcgQ1NTIHByb3BlcnR5IHRvIFdl YktpdCB3aWh0b3V0IGFkZGluZyBhbmltYXRpb24gc3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvc3R5bGUvU3R5bGVhYmxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxl YWJsZS5jcHAKaW5kZXggODllNzM2ODkxNTJmYzUzYWIwNDA3ODcxZDlmOGUxMWYyNGNjODc1Ni4u NzBiMzQ0Y2UxZDg3MGM0NjFjMGFlOGZlNTVjMzg0NWZkZTUxMDZjZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVhYmxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdHls ZS9TdHlsZWFibGUuY3BwCkBAIC00NDIsNiArNDQyLDE0IEBAIHN0YXRpYyB2b2lkIHVwZGF0ZUNT U1RyYW5zaXRpb25zRm9yU3R5bGVhYmxlQW5kUHJvcGVydHkoY29uc3QgU3R5bGVhYmxlJiBzdHls ZWFiCiAgICAgICAgIH0KICAgICB9CiAKKyAgICBhdXRvIGVmZmVjdFRhcmdldHNQcm9wZXJ0eSA9 IFsmXShLZXlmcmFtZUVmZmVjdCYgZWZmZWN0KSB7CisgICAgICAgIGlmIChlZmZlY3QuYW5pbWF0 ZWRQcm9wZXJ0aWVzKCkuY29udGFpbnMocHJvcGVydHkpKQorICAgICAgICAgICAgcmV0dXJuIHRy dWU7CisgICAgICAgIGlmIChhdXRvKiB0cmFuc2l0aW9uID0gZHluYW1pY0Rvd25jYXN0PENTU1Ry YW5zaXRpb24+KGVmZmVjdC5hbmltYXRpb24oKSkpCisgICAgICAgICAgICByZXR1cm4gdHJhbnNp dGlvbi0+cHJvcGVydHkoKSA9PSBwcm9wZXJ0eTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAg IH07CisKICAgICAvLyBodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLXRyYW5zaXRpb25zLTEv I2JlZm9yZS1jaGFuZ2Utc3R5bGUKICAgICAvLyBEZWZpbmUgdGhlIGJlZm9yZS1jaGFuZ2Ugc3R5 bGUgYXMgdGhlIGNvbXB1dGVkIHZhbHVlcyBvZiBhbGwgcHJvcGVydGllcyBvbiB0aGUgZWxlbWVu dCBhcyBvZiB0aGUgcHJldmlvdXMgc3R5bGUgY2hhbmdlIGV2ZW50LCBleGNlcHQgd2l0aAogICAg IC8vIGFueSBzdHlsZXMgZGVyaXZlZCBmcm9tIGRlY2xhcmF0aXZlIGFuaW1hdGlvbnMgc3VjaCBh cyBDU1MgVHJhbnNpdGlvbnMsIENTUyBBbmltYXRpb25zLCBhbmQgU01JTCBBbmltYXRpb25zIHVw ZGF0ZWQgdG8gdGhlIGN1cnJlbnQgdGltZS4KQEAgLTQ1MCw2ICs0NTgsOCBAQCBzdGF0aWMgdm9p ZCB1cGRhdGVDU1NUcmFuc2l0aW9uc0ZvclN0eWxlYWJsZUFuZFByb3BlcnR5KGNvbnN0IFN0eWxl YWJsZSYgc3R5bGVhYgogICAgICAgICAgICAgYXV0byBzdHlsZSA9IFJlbmRlclN0eWxlOjpjbG9u ZSgqbGFzdFN0eWxlQ2hhbmdlRXZlbnRTdHlsZSk7CiAgICAgICAgICAgICBpZiAoYXV0byoga2V5 ZnJhbWVFZmZlY3RTdGFjayA9IHN0eWxlYWJsZS5rZXlmcmFtZUVmZmVjdFN0YWNrKCkpIHsKICAg ICAgICAgICAgICAgICBmb3IgKGNvbnN0IGF1dG8mIGVmZmVjdCA6IGtleWZyYW1lRWZmZWN0U3Rh Y2stPnNvcnRlZEVmZmVjdHMoKSkgeworICAgICAgICAgICAgICAgICAgICBpZiAoIWVmZmVjdFRh cmdldHNQcm9wZXJ0eSgqZWZmZWN0KSkKKyAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVl OwogICAgICAgICAgICAgICAgICAgICBhdXRvKiBlZmZlY3RBbmltYXRpb24gPSBlZmZlY3QtPmFu aW1hdGlvbigpOwogICAgICAgICAgICAgICAgICAgICBib29sIHNob3VsZFVzZVRpbWVsaW5lVGlt ZUF0Q3JlYXRpb24gPSBpczxDU1NUcmFuc2l0aW9uPihlZmZlY3RBbmltYXRpb24pICYmICghZWZm ZWN0QW5pbWF0aW9uLT5zdGFydFRpbWUoKSB8fCAqZWZmZWN0QW5pbWF0aW9uLT5zdGFydFRpbWUo KSA9PSBzdHlsZWFibGUuZWxlbWVudC5kb2N1bWVudCgpLnRpbWVsaW5lKCkuY3VycmVudFRpbWUo KSk7CiAgICAgICAgICAgICAgICAgICAgIGVmZmVjdEFuaW1hdGlvbi0+cmVzb2x2ZShzdHlsZSwg eyBudWxscHRyIH0sIHNob3VsZFVzZVRpbWVsaW5lVGltZUF0Q3JlYXRpb24gPyBkb3duY2FzdDxD U1NUcmFuc2l0aW9uPigqZWZmZWN0QW5pbWF0aW9uKS50aW1lbGluZVRpbWVBdENyZWF0aW9uKCkg OiBzdGQ6Om51bGxvcHQpOwo= 456943 2022-04-07 10:54:43 -0700 2022-04-07 13:33:44 -0700 Patch for landing bug-238931-20220407195442.patch text/plain 2929 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVmZjI5ZTdlMmY0YTM0 MWY4ZjU2ZjdjNDI5NTkwMDMyNzRhZDU4ZS4uMjY3NDJiZmEyMjE1MzVhZWJhMDUzNWFmYjE2YWVm MmRmMDc1NGY4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTA0LTA3ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFt3ZWItYW5pbWF0aW9u c10gUkVHUkVTU0lPTiAocjI4Nzg4MSk6IGxvYWRpbmcgcGVyZm9ybWFuY2UgZm9yIGRpcGx5LmNv bSByZWdyZXNzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzODkzMQorICAgICAgICByZGFyOi8vOTExOTAwMDcKKworICAgICAgICBSZXZpZXdlZCBi eSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgV2Ugb25seSBuZWVkIHRvIHJlc29sdmUgZWZmZWN0 cyBpbiB0aGUgc3RhY2sgaWYgdGhleSBhcmUgdGFyZ2V0aW5nIHRoZSBwcm9wZXJ0eSB3ZSBhcmUK KyAgICAgICAgY29uc2lkZXJpbmcgZm9yIHRoZSBjcmVhdGlvbiwgdXBkYXRlIG9yIHJlbW92YWwg b2YgYSBDU1MgVHJhbnNpdGlvbi4KKworICAgICAgICAqIHN0eWxlL1N0eWxlYWJsZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjp1cGRhdGVDU1NUcmFuc2l0aW9uc0ZvclN0eWxlYWJsZUFuZFByb3Bl cnR5KToKKwogMjAyMi0wMy0yOCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4K IAogICAgICAgICBNYWtlIGl0IGhhcmQgdG8gYWRkIGEgbmV3IENTUyBwcm9wZXJ0eSB0byBXZWJL aXQgd2lodG91dCBhZGRpbmcgYW5pbWF0aW9uIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3N0eWxlL1N0eWxlYWJsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZWFi bGUuY3BwCmluZGV4IDg5ZTczNjg5MTUyZmM1M2FiMDQwNzg3MWQ5ZjhlMTFmMjRjYzg3NTYuLmM4 NGQ0OTBjMzJkOGNjYzdiNzRmNDQ3YmZiMDk3NjUwMjdiYTc3ZDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3N0eWxlL1N0eWxlYWJsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3R5bGUv U3R5bGVhYmxlLmNwcApAQCAtNDQyLDYgKzQ0MiwxNCBAQCBzdGF0aWMgdm9pZCB1cGRhdGVDU1NU cmFuc2l0aW9uc0ZvclN0eWxlYWJsZUFuZFByb3BlcnR5KGNvbnN0IFN0eWxlYWJsZSYgc3R5bGVh YgogICAgICAgICB9CiAgICAgfQogCisgICAgYXV0byBlZmZlY3RUYXJnZXRzUHJvcGVydHkgPSBb cHJvcGVydHldKEtleWZyYW1lRWZmZWN0JiBlZmZlY3QpIHsKKyAgICAgICAgaWYgKGVmZmVjdC5h bmltYXRlZFByb3BlcnRpZXMoKS5jb250YWlucyhwcm9wZXJ0eSkpCisgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKKyAgICAgICAgaWYgKGF1dG8qIHRyYW5zaXRpb24gPSBkeW5hbWljRG93bmNhc3Q8 Q1NTVHJhbnNpdGlvbj4oZWZmZWN0LmFuaW1hdGlvbigpKSkKKyAgICAgICAgICAgIHJldHVybiB0 cmFuc2l0aW9uLT5wcm9wZXJ0eSgpID09IHByb3BlcnR5OworICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgfTsKKwogICAgIC8vIGh0dHBzOi8vZHJhZnRzLmNzc3dnLm9yZy9jc3MtdHJhbnNpdGlv bnMtMS8jYmVmb3JlLWNoYW5nZS1zdHlsZQogICAgIC8vIERlZmluZSB0aGUgYmVmb3JlLWNoYW5n ZSBzdHlsZSBhcyB0aGUgY29tcHV0ZWQgdmFsdWVzIG9mIGFsbCBwcm9wZXJ0aWVzIG9uIHRoZSBl bGVtZW50IGFzIG9mIHRoZSBwcmV2aW91cyBzdHlsZSBjaGFuZ2UgZXZlbnQsIGV4Y2VwdCB3aXRo CiAgICAgLy8gYW55IHN0eWxlcyBkZXJpdmVkIGZyb20gZGVjbGFyYXRpdmUgYW5pbWF0aW9ucyBz dWNoIGFzIENTUyBUcmFuc2l0aW9ucywgQ1NTIEFuaW1hdGlvbnMsIGFuZCBTTUlMIEFuaW1hdGlv bnMgdXBkYXRlZCB0byB0aGUgY3VycmVudCB0aW1lLgpAQCAtNDUwLDYgKzQ1OCw4IEBAIHN0YXRp YyB2b2lkIHVwZGF0ZUNTU1RyYW5zaXRpb25zRm9yU3R5bGVhYmxlQW5kUHJvcGVydHkoY29uc3Qg U3R5bGVhYmxlJiBzdHlsZWFiCiAgICAgICAgICAgICBhdXRvIHN0eWxlID0gUmVuZGVyU3R5bGU6 OmNsb25lKCpsYXN0U3R5bGVDaGFuZ2VFdmVudFN0eWxlKTsKICAgICAgICAgICAgIGlmIChhdXRv KiBrZXlmcmFtZUVmZmVjdFN0YWNrID0gc3R5bGVhYmxlLmtleWZyYW1lRWZmZWN0U3RhY2soKSkg ewogICAgICAgICAgICAgICAgIGZvciAoY29uc3QgYXV0byYgZWZmZWN0IDoga2V5ZnJhbWVFZmZl Y3RTdGFjay0+c29ydGVkRWZmZWN0cygpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmICghZWZm ZWN0VGFyZ2V0c1Byb3BlcnR5KCplZmZlY3QpKQorICAgICAgICAgICAgICAgICAgICAgICAgY29u dGludWU7CiAgICAgICAgICAgICAgICAgICAgIGF1dG8qIGVmZmVjdEFuaW1hdGlvbiA9IGVmZmVj dC0+YW5pbWF0aW9uKCk7CiAgICAgICAgICAgICAgICAgICAgIGJvb2wgc2hvdWxkVXNlVGltZWxp bmVUaW1lQXRDcmVhdGlvbiA9IGlzPENTU1RyYW5zaXRpb24+KGVmZmVjdEFuaW1hdGlvbikgJiYg KCFlZmZlY3RBbmltYXRpb24tPnN0YXJ0VGltZSgpIHx8ICplZmZlY3RBbmltYXRpb24tPnN0YXJ0 VGltZSgpID09IHN0eWxlYWJsZS5lbGVtZW50LmRvY3VtZW50KCkudGltZWxpbmUoKS5jdXJyZW50 VGltZSgpKTsKICAgICAgICAgICAgICAgICAgICAgZWZmZWN0QW5pbWF0aW9uLT5yZXNvbHZlKHN0 eWxlLCB7IG51bGxwdHIgfSwgc2hvdWxkVXNlVGltZWxpbmVUaW1lQXRDcmVhdGlvbiA/IGRvd25j YXN0PENTU1RyYW5zaXRpb24+KCplZmZlY3RBbmltYXRpb24pLnRpbWVsaW5lVGltZUF0Q3JlYXRp b24oKSA6IHN0ZDo6bnVsbG9wdCk7Cg==