23891 2009-02-10 22:14:07 -0800 [WebHistoryItem _setVisitCount:] is unused and should be removed 2009-02-10 22:28:53 -0800 1 1 1 Unclassified WebKit History 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sullivan sullivan oldest_to_newest 109249 0 sullivan 2009-02-10 22:14:07 -0800 The method -[WebHistoryItem _setVisitCount:] is a synonym for the longstanding public API -[WebHistoryItem setVisitCount:]. It was added recently as a WebKit-internal method, but soon thereafter abandoned. It's just clogging up the series of tubes, and should be deleted. 109251 1 27553 sullivan 2009-02-10 22:18:45 -0800 Created attachment 27553 Patch to remove unused method. 109255 2 sullivan 2009-02-10 22:28:53 -0800 Committed revision 40850. 27553 2009-02-10 22:18:45 -0800 2009-02-10 22:20:49 -0800 Patch to remove unused method. 23891_patch.txt text/plain 1750 sullivan SW5kZXg6IG1hYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbWFjL0NoYW5nZUxvZwkocmV2aXNp b24gNDA4NDgpCisrKyBtYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTgg QEAKKzIwMDktMDItMTAgIEpvaG4gU3VsbGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICA8aHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODkxPgorICAgICAgICBbV2Vi SGlzdG9yeUl0ZW0gX3NldFZpc2l0Q291bnQ6XSBpcyB1bnVzZWQgYW5kIHNob3VsZCBiZSByZW1v dmVkCisKKyAgICAgICAgKiBIaXN0b3J5L1dlYkhpc3RvcnlJdGVtLm1tOgorICAgICAgICAoLVtX ZWJIaXN0b3J5SXRlbSBfc2V0VmlzaXRDb3VudDpdKToKKyAgICAgICAgcmVtb3ZlZCB0aGlzIHVu dXNlZCBtZXRob2QsIHdoaWNoIGlzIGEgc3lub255bSBmb3Igc2V0VmlzaXRDb3VudDogdGhhdCB3 YXMgaW50cm9kdWNlZAorICAgICAgICByZWNlbnRseSBhbmQgYWJhbmRvbmVkIGV2ZW4gbW9yZSBy ZWNlbnRseQorCisgICAgICAgICogSGlzdG9yeS9XZWJIaXN0b3J5SXRlbUludGVybmFsLmg6Cisg ICAgICAgIHJlbW92ZWQgZGVjbGFyYXRpb24gb2YgX3NldFZpc2l0Q291bnQ6CisKIDIwMDktMDIt MTAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBtYWMvSGlzdG9yeS9XZWJIaXN0b3J5SXRlbUludGVy bmFsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gbWFjL0hpc3RvcnkvV2ViSGlzdG9yeUl0ZW1JbnRlcm5hbC5o CShyZXZpc2lvbiA0MDgyOSkKKysrIG1hYy9IaXN0b3J5L1dlYkhpc3RvcnlJdGVtSW50ZXJuYWwu aAkod29ya2luZyBjb3B5KQpAQCAtNTIsNyArNTIsNiBAQAogLSAodm9pZClfbWVyZ2VBdXRvQ29t cGxldGVIaW50czooV2ViSGlzdG9yeUl0ZW0gKilvdGhlckl0ZW07CiAtICh2b2lkKXNldFRpdGxl OihOU1N0cmluZyAqKXRpdGxlOwogLSAodm9pZClfdmlzaXRlZFdpdGhUaXRsZTooTlNTdHJpbmcg Kil0aXRsZTsKLS0gKHZvaWQpX3NldFZpc2l0Q291bnQ6KGludCljb3VudDsKIC0gKHZvaWQpX3Jl Y29yZEluaXRpYWxWaXNpdDsKIAogQGVuZApJbmRleDogbWFjL0hpc3RvcnkvV2ViSGlzdG9yeUl0 ZW0ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gbWFjL0hpc3RvcnkvV2ViSGlzdG9yeUl0ZW0ubW0JKHJldmlz aW9uIDQwODI5KQorKysgbWFjL0hpc3RvcnkvV2ViSGlzdG9yeUl0ZW0ubW0JKHdvcmtpbmcgY29w eSkKQEAgLTQxMywxMSArNDIyLDYgQEAKICAgICBjb3JlKF9wcml2YXRlKS0+dmlzaXRlZCh0aXRs ZSwgW05TRGF0ZSB0aW1lSW50ZXJ2YWxTaW5jZVJlZmVyZW5jZURhdGVdKTsKIH0KIAotLSAodm9p ZClfc2V0VmlzaXRDb3VudDooaW50KWNvdW50Ci17Ci0gICAgY29yZShfcHJpdmF0ZSktPnNldFZp c2l0Q291bnQoY291bnQpOwotfQotCiAtICh2b2lkKV9yZWNvcmRJbml0aWFsVmlzaXQKIHsKICAg ICBjb3JlKF9wcml2YXRlKS0+cmVjb3JkSW5pdGlhbFZpc2l0KCk7Cg==