238869 2022-04-06 08:49:14 -0700 Fix the address sanitizer build when building with gcc 2022-04-19 01:49:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Linux RESOLVED FIXED InRadar P2 Normal --- 1 mrobinson mrobinson ews-watchlist keith_miller mark.lam msaboff pnormand saam tzagallo webkit-bug-importer oldest_to_newest 1858845 0 mrobinson 2022-04-06 08:49:14 -0700 The build currently fails when trying to turn on the address sanitizer using the gcc compiler. 1858846 1 456823 mrobinson 2022-04-06 08:52:03 -0700 Created attachment 456823 Patch 1861132 2 webkit-bug-importer 2022-04-13 08:50:15 -0700 <rdar://problem/91692190> 1862219 3 456823 pnormand 2022-04-18 02:58:43 -0700 Comment on attachment 456823 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456823&action=review > Source/JavaScriptCore/runtime/ConfigFile.cpp:248 > m_filename[s_maxPathLength] = '\0'; Missing _END before leaving scope? 1862220 4 457803 mrobinson 2022-04-18 03:03:46 -0700 Created attachment 457803 Patch 1862221 5 mrobinson 2022-04-18 03:04:22 -0700 (In reply to Philippe Normand from comment #3) > Comment on attachment 456823 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456823&action=review > > > Source/JavaScriptCore/runtime/ConfigFile.cpp:248 > > m_filename[s_maxPathLength] = '\0'; > > Missing _END before leaving scope? Oof. Yes. Thanks for spotting that. I've uploaded a new version of the change. 1862229 6 ews-feeder 2022-04-18 05:44:37 -0700 Found 1 new test failure: http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html 1862464 7 ews-feeder 2022-04-19 01:49:25 -0700 Committed r293010 (249749@main): <https://commits.webkit.org/249749@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457803. 456823 2022-04-06 08:52:03 -0700 2022-04-18 03:03:41 -0700 Patch bug-238869-20220406175201.patch text/plain 1283 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx NWIxYWJhYjQ3OTk1NWExYzIzM2FiMTJlMjMxNjRjODMwNTg3NmM1Li5mNmU3NGQ5ZGRhN2IwYzRi ZDY3NDdiODI2MjgzMjJiNmM4YzQ1MDFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAyMi0wNC0wNiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQHdlYmtp dC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBhZGRyZXNzIHNhbml0aXplciBidWlsZCB3aGVuIGJ1 aWxkaW5nIHdpdGggZ2NjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzg4NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHJ1bnRpbWUvQ29uZmlnRmlsZS5jcHA6CisgICAgICAgIChKU0M6OkNvbmZpZ0Zp bGU6OkNvbmZpZ0ZpbGUpOgorCiAyMDIyLTA0LTAyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIGRlZmF1bHQgY29uc3RydWN0b3IgdG8gQVNDSUlMaXRlcmFs CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25maWdGaWxlLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbmZpZ0ZpbGUuY3BwCmluZGV4IDE3 YjA2MjM4YWI4YTUyNDc0ODgxMjk2MWUzOTViMGQ2NWFmZTg5OGIuLmVlZTcxMzAwZWVhNmRhOGRi MjFiZWYxNWUwMTQ5ZDA3ODQ2Yzc1MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0NvbmZpZ0ZpbGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvbmZpZ0ZpbGUuY3BwCkBAIC0yNDMsNiArMjQzLDcgQEAgQ29uZmlnRmlsZTo6Q29uZmln RmlsZShjb25zdCBjaGFyKiBmaWxlbmFtZSkKICAgICBpZiAoIWZpbGVuYW1lKQogICAgICAgICBt X2ZpbGVuYW1lWzBdID0gJ1wwJzsKICAgICBlbHNlIHsKKyAgICAgICAgSUdOT1JFX0dDQ19XQVJO SU5HU19CRUdJTigic3RyaW5nb3AtdHJ1bmNhdGlvbiIpCiAgICAgICAgIHN0cm5jcHkobV9maWxl bmFtZSwgZmlsZW5hbWUsIHNfbWF4UGF0aExlbmd0aCk7CiAgICAgICAgIG1fZmlsZW5hbWVbc19t YXhQYXRoTGVuZ3RoXSA9ICdcMCc7CiAgICAgfQo= 457803 2022-04-18 03:03:46 -0700 2022-04-19 01:49:27 -0700 Patch bug-238869-20220418120345.patch text/plain 1318 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx NWIxYWJhYjQ3OTk1NWExYzIzM2FiMTJlMjMxNjRjODMwNTg3NmM1Li5mNmU3NGQ5ZGRhN2IwYzRi ZDY3NDdiODI2MjgzMjJiNmM4YzQ1MDFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAyMi0wNC0wNiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQHdlYmtp dC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBhZGRyZXNzIHNhbml0aXplciBidWlsZCB3aGVuIGJ1 aWxkaW5nIHdpdGggZ2NjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzg4NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHJ1bnRpbWUvQ29uZmlnRmlsZS5jcHA6CisgICAgICAgIChKU0M6OkNvbmZpZ0Zp bGU6OkNvbmZpZ0ZpbGUpOgorCiAyMDIyLTA0LTAyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIGRlZmF1bHQgY29uc3RydWN0b3IgdG8gQVNDSUlMaXRlcmFs CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25maWdGaWxlLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbmZpZ0ZpbGUuY3BwCmluZGV4IDE3 YjA2MjM4YWI4YTUyNDc0ODgxMjk2MWUzOTViMGQ2NWFmZTg5OGIuLjk5Mjc3NmNiNzg1MjRkNTQ4 YTlhOGM4NGRkZmUxNDdiMTU3ZWU3MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0NvbmZpZ0ZpbGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvbmZpZ0ZpbGUuY3BwCkBAIC0yNDMsNyArMjQzLDkgQEAgQ29uZmlnRmlsZTo6Q29uZmln RmlsZShjb25zdCBjaGFyKiBmaWxlbmFtZSkKICAgICBpZiAoIWZpbGVuYW1lKQogICAgICAgICBt X2ZpbGVuYW1lWzBdID0gJ1wwJzsKICAgICBlbHNlIHsKKyAgICAgICAgSUdOT1JFX0dDQ19XQVJO SU5HU19CRUdJTigic3RyaW5nb3AtdHJ1bmNhdGlvbiIpCiAgICAgICAgIHN0cm5jcHkobV9maWxl bmFtZSwgZmlsZW5hbWUsIHNfbWF4UGF0aExlbmd0aCk7CisgICAgICAgIElHTk9SRV9HQ0NfV0FS TklOR1NfRU5ECiAgICAgICAgIG1fZmlsZW5hbWVbc19tYXhQYXRoTGVuZ3RoXSA9ICdcMCc7CiAg ICAgfQogCg==