238868 2022-04-06 08:10:37 -0700 [GTK] Turning on the address sanitizer should disable GIR and documentation 2022-04-07 03:59:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mrobinson mrobinson annulen aperez cgarcia ews-watchlist gyuyoung.kim ryuan.choi sergio webkit-bug-importer oldest_to_newest 1858831 0 mrobinson 2022-04-06 08:10:37 -0700 GIR isn't compatible with the flags passed for address sanitation and documentation depends on GIR. 1858843 1 456822 mrobinson 2022-04-06 08:42:42 -0700 Created attachment 456822 Patch 1858880 2 456822 aperez 2022-04-06 10:04:13 -0700 Comment on attachment 456822 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456822&action=review > Source/cmake/OptionsGTK.cmake:286 > +# FIXME: Does the new documentation toolchain work on Mac now? Do we have any evidence that it does not work in MacOS? TBH, I think the if(APPLE) conditional is unnecessary. It's not like MacOS is particularly well supported, and people packaging for such an environment (e.g. MacPorts) sure can decide themselves if they want to disable documentation or not. FWIW, there is nothing particularly special about gi-docgen: it's a pure Python program, so as long as g-ir-scanner can create a .gir file, it will work fine. Also, this is unrelated to sanitizers, so one more reason to leave this part out od this patch. 1858881 3 mrobinson 2022-04-06 10:05:49 -0700 (In reply to Adrian Perez from comment #2) ork fine. > > Also, this is unrelated to sanitizers, so one more reason to leave this > part out od this patch. I'm just maintaining this existing behavior. I think someone should double-check that the new documentation tool works on Mac before turning it back on. 1859162 4 mrobinson 2022-04-07 00:47:27 -0700 (In reply to Martin Robinson from comment #3) > (In reply to Adrian Perez from comment #2) > ork fine. > > > > Also, this is unrelated to sanitizers, so one more reason to leave this > > part out od this patch. > > I'm just maintaining this existing behavior. I think someone should > double-check that the new documentation tool works on Mac before turning it > back on. That said, I don't want to block this patch. I have uploaded a new version that maintains the broken line which tries to disable documentation when building on Mac. 1859163 5 456898 mrobinson 2022-04-07 00:48:29 -0700 Created attachment 456898 Patch 1859166 6 456898 mrobinson 2022-04-07 01:41:58 -0700 Comment on attachment 456898 Patch Thanks for the review! 1859188 7 ews-feeder 2022-04-07 03:58:44 -0700 Committed r292528 (249366@main): <https://commits.webkit.org/249366@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456898. 1859190 8 webkit-bug-importer 2022-04-07 03:59:16 -0700 <rdar://problem/91406165> 456822 2022-04-06 08:42:42 -0700 2022-04-07 00:48:18 -0700 Patch bug-238868-20220406174237.patch text/plain 2398 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGQ1MjNi ZWE0NWU3ZGEyMjNkMjcwMzI0OWFhNGEwN2RiNzBjMzY1NmIuLjQxMGE4ZDJjNmFkMjM1ZTBiYjZk NGVjMTIzNzNjZjI5NDgwMGQzZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yNzYsNiArMjc2 LDE4IEBAIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9BVFNQSSAke0VOQUJMRV9BQ0NFU1NJ QklMSVRZfSkKIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEhBVkVfR1RLX1VOSVhfUFJJTlRJTkcg JHtHVEtfVU5JWF9QUklOVF9GT1VORH0pCiBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChIQVZFX09T X0RBUktfTU9ERV9TVVBQT1JUIDEpCiAKKyMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4MjI0NworaWYgKEVOQUJMRURfQ09NUElMRVJfU0FOSVRJWkVSUykKKyAgICBz ZXQoRU5BQkxFX0lOVFJPU1BFQ1RJT04gT0ZGKQorICAgIHNldChFTkFCTEVfRE9DVU1FTlRBVElP TiBPRkYpCitlbmRpZiAoKQorCisjIGd0ay1kb2MgZGlkbid0IHJlYWxseSB3b3JrIHdoZW4gYnVp bGRpbmcgb24gTWFjLgorIyBGSVhNRTogRG9lcyB0aGUgbmV3IGRvY3VtZW50YXRpb24gdG9vbGNo YWluIHdvcmsgb24gTWFjIG5vdz8KK2lmIChBUFBMRSkKKyAgICBzZXQoRU5BQkxFX0RPQ1VNRU5U QVRJT04gT0ZGKQorZW5kaWYgKCkKKwogIyBHVXJpIGlzIGF2YWlsYWJsZSBpbiBHTGliIHNpbmNl IHZlcnNpb24gMi42NiwgYnV0IHdlIG9ubHkgd2FudCB0byB1c2UgaXQgaWYgdmVyc2lvbiBpcyA+ PSAyLjY3LjEuCiBpZiAoUENfR0xJQl9WRVJTSU9OIFZFUlNJT05fR1JFQVRFUiAiMi42Ny4xIiBP UiBQQ19HTElCX1ZFUlNJT04gU1RSRVFVQUwgIjIuNjcuMSIpCiAgICAgU0VUX0FORF9FWFBPU0Vf VE9fQlVJTEQoSEFWRV9HVVJJIDEpCkBAIC00OTQsMTYgKzUwNiw2IEBAIGlmIChVU0VfTENNUykK ICAgICBlbmRpZiAoKQogZW5kaWYgKCkKIAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgyMjQ3Ci1pZiAoRU5BQkxFRF9DT01QSUxFUl9TQU5JVElaRVJTKQotICAg IHNldChFTkFCTEVfSU5UUk9TUEVDVElPTiBPRkYpCi1lbmRpZiAoKQotCi0jIE92ZXJyaWRlIHRo ZSBjYWNoZWQgdmFyaWFibGUsIGd0ay1kb2MgZG9lcyBub3QgcmVhbGx5IHdvcmsgd2hlbiBidWls ZGluZyBvbiBNYWMuCi1pZiAoQVBQTEUpCi0gICAgc2V0KEVOQUJMRV9HVEtET0MgT0ZGKQotZW5k aWYgKCkKLQogIyBVc2luZyBERVJJVkVEX1NPVVJDRVNfRElSIGlzIGRlcHJlY2F0ZWQKIHNldChE RVJJVkVEX1NPVVJDRVNfRElSICIke0NNQUtFX0JJTkFSWV9ESVJ9L0Rlcml2ZWRTb3VyY2VzIikK IHNldChERVJJVkVEX1NPVVJDRVNfV1BFVE9PTElOR0JBQ0tFTkRTX0RJUiAiJHtDTUFLRV9CSU5B UllfRElSfS9EZXJpdmVkU291cmNlcy9XUEVUb29saW5nQmFja2VuZHMiKQpkaWZmIC0tZ2l0IGEv Q2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGI4ODEwYzJmNThlZGI2Zjg0ODQxNzk5ZTUxMTlm NzYxN2ViZDEzYzEuLjU2N2JkYTljYjdiYjMzZjZjNzk4MDBiOWUyOTg5NmE0NzA0ZWNkZmQgMTAw NjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAy Mi0wNC0wNiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0dUS10gVHVybmluZyBvbiB0aGUgYWRkcmVzcyBzYW5pdGl6ZXIgc2hvdWxkIGRpc2FibGUg R0lSIGFuZCBkb2N1bWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzg4NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOiBEaXNhYmxlIGRv Y3VtZW50YXRpb24gd2hlbiB0aGUgYWRkcmVzcworICAgICAgICBzYW5pdGl6ZXIgaXMgb24uIERv Y3VtZW50YXRpb24gZGVwZW5kcyBvbiBHSVIuIEFsc28gZml4IHRoZSBhZGp1c3RtZW50CisgICAg ICAgIG9mIHRoZSBkb2N1bWVudGF0aW9uIHNldHRpbmcgd2hlbiBidWlsZGluZyBvbiBNYWMuIFRo aXMgYWxzbyBoYXMgdG8KKyAgICAgICAgaGFwcGVuIGJlZm9yZSB0aGUgY2FsbCB0byBmaW5kX3Bh Y2thZ2UoR0kpLgorCiAyMDIyLTA0LTAyICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVwbGFjZSBndGstZG9jIHdpdGggZ2ktZG9j Z2VuCg== 456898 2022-04-07 00:48:29 -0700 2022-04-07 03:58:46 -0700 Patch bug-238868-20220407094826.patch text/plain 2004 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGQ1MjNi ZWE0NWU3ZGEyMjNkMjcwMzI0OWFhNGEwN2RiNzBjMzY1NmIuLjNiNWE5NDdmOThlMmQ0OGY5OGRj MzAyN2VhMThkMjE3ODg4NjJiYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yNzYsNiArMjc2 LDEyIEBAIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9BVFNQSSAke0VOQUJMRV9BQ0NFU1NJ QklMSVRZfSkKIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEhBVkVfR1RLX1VOSVhfUFJJTlRJTkcg JHtHVEtfVU5JWF9QUklOVF9GT1VORH0pCiBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChIQVZFX09T X0RBUktfTU9ERV9TVVBQT1JUIDEpCiAKKyMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4MjI0NworaWYgKEVOQUJMRURfQ09NUElMRVJfU0FOSVRJWkVSUykKKyAgICBz ZXQoRU5BQkxFX0lOVFJPU1BFQ1RJT04gT0ZGKQorICAgIHNldChFTkFCTEVfRE9DVU1FTlRBVElP TiBPRkYpCitlbmRpZiAoKQorCiAjIEdVcmkgaXMgYXZhaWxhYmxlIGluIEdMaWIgc2luY2UgdmVy c2lvbiAyLjY2LCBidXQgd2Ugb25seSB3YW50IHRvIHVzZSBpdCBpZiB2ZXJzaW9uIGlzID49IDIu NjcuMS4KIGlmIChQQ19HTElCX1ZFUlNJT04gVkVSU0lPTl9HUkVBVEVSICIyLjY3LjEiIE9SIFBD X0dMSUJfVkVSU0lPTiBTVFJFUVVBTCAiMi42Ny4xIikKICAgICBTRVRfQU5EX0VYUE9TRV9UT19C VUlMRChIQVZFX0dVUkkgMSkKQEAgLTQ5NCwxMSArNTAwLDYgQEAgaWYgKFVTRV9MQ01TKQogICAg IGVuZGlmICgpCiBlbmRpZiAoKQogCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODIyNDcKLWlmIChFTkFCTEVEX0NPTVBJTEVSX1NBTklUSVpFUlMpCi0gICAgc2V0 KEVOQUJMRV9JTlRST1NQRUNUSU9OIE9GRikKLWVuZGlmICgpCi0KICMgT3ZlcnJpZGUgdGhlIGNh Y2hlZCB2YXJpYWJsZSwgZ3RrLWRvYyBkb2VzIG5vdCByZWFsbHkgd29yayB3aGVuIGJ1aWxkaW5n IG9uIE1hYy4KIGlmIChBUFBMRSkKICAgICBzZXQoRU5BQkxFX0dUS0RPQyBPRkYpCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYjg4MTBjMmY1OGVkYjZmODQ4NDE3OTll NTExOWY3NjE3ZWJkMTNjMS4uNTY3YmRhOWNiN2JiMzNmNmM3OTgwMGI5ZTI5ODk2YTQ3MDRlY2Rm ZCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDIyLTA0LTA2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25Ad2Via2l0Lm9yZz4KKwor ICAgICAgICBbR1RLXSBUdXJuaW5nIG9uIHRoZSBhZGRyZXNzIHNhbml0aXplciBzaG91bGQgZGlz YWJsZSBHSVIgYW5kIGRvY3VtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzODg2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6IERpc2Fi bGUgZG9jdW1lbnRhdGlvbiB3aGVuIHRoZSBhZGRyZXNzCisgICAgICAgIHNhbml0aXplciBpcyBv bi4gRG9jdW1lbnRhdGlvbiBkZXBlbmRzIG9uIEdJUi4gQWxzbyBmaXggdGhlIGFkanVzdG1lbnQK KyAgICAgICAgb2YgdGhlIGRvY3VtZW50YXRpb24gc2V0dGluZyB3aGVuIGJ1aWxkaW5nIG9uIE1h Yy4gVGhpcyBhbHNvIGhhcyB0bworICAgICAgICBoYXBwZW4gYmVmb3JlIHRoZSBjYWxsIHRvIGZp bmRfcGFja2FnZShHSSkuCisKIDIwMjItMDQtMDIgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxh cGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZXBsYWNlIGd0ay1kb2Mgd2l0aCBn aS1kb2NnZW4K