238819 2022-04-05 10:30:47 -0700 Avoid unnecessary String constructions in IdentifiersFactory.cpp 2022-04-05 14:51:13 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez darin ews-watchlist ggaren hi inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff pangle saam tzagallo webkit-bug-importer oldest_to_newest 1858440 0 cdumez 2022-04-05 10:30:47 -0700 Avoid unnecessary String constructions in IdentifiersFactory.cpp. 1858441 1 456718 cdumez 2022-04-05 10:31:42 -0700 Created attachment 456718 Patch 1858577 2 456718 ggaren 2022-04-05 14:29:29 -0700 Comment on attachment 456718 Patch r=me 1858591 3 ews-feeder 2022-04-05 14:50:00 -0700 Committed r292428 (249287@main): <https://commits.webkit.org/249287@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456718. 1858593 4 webkit-bug-importer 2022-04-05 14:51:13 -0700 <rdar://problem/91317060> 456718 2022-04-05 10:31:42 -0700 2022-04-05 14:50:02 -0700 Patch bug-238819-20220405103142.patch text/plain 2087 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj M2E2MDYwN2UwYzM2ZDYyZWYzYjU5ZDZkNzhlNzhkZmYxOWI0ZjE4Li4wMDFlMjQyZjIyNjI0ZjFk NWY4NmFkNDllM2Y3MzNjODQyNTIxNThkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMi0wNC0wNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CisgICAgICAgIEF2b2lkIHVubmVjZXNzYXJ5IFN0cmluZyBjb25zdHJ1Y3Rpb25zIGluIElkZW50 aWZpZXJzRmFjdG9yeS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzODgxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogaW5zcGVjdG9yL0lkZW50aWZpZXJzRmFjdG9yeS5jcHA6CisgICAgICAgIChJ bnNwZWN0b3I6OmFkZFByZWZpeFRvSWRlbnRpZmllcik6CisgICAgICAgIChJbnNwZWN0b3I6Oklk ZW50aWZpZXJzRmFjdG9yeTo6Y3JlYXRlSWRlbnRpZmllcik6CisgICAgICAgIChJbnNwZWN0b3I6 OklkZW50aWZpZXJzRmFjdG9yeTo6cmVxdWVzdElkKToKKwogMjAyMi0wNC0wNCAgWXVzdWtlIFN1 enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIFJlZHVjZSBzaXplb2Yo QmFzZWxpbmVDYWxsTGlua0luZm8pIHRvIG1ha2UgYnVnIDIzODUzNSBnb29kCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0lkZW50aWZpZXJzRmFjdG9yeS5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0lkZW50aWZpZXJzRmFjdG9yeS5jcHAK aW5kZXggOTVjZDg3YjAxYjE1Y2I4NjY3ZTU3YmM1YmI1MWE3MWYwNmJjMzc2MC4uMThiNmRhYjNi OWRmMzhkNzgxYzVjNzY3Zjc2YTI5ZDhkMThkYmUwMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2luc3BlY3Rvci9JZGVudGlmaWVyc0ZhY3RvcnkuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSWRlbnRpZmllcnNGYWN0b3J5LmNwcApAQCAtMjcsMjcg KzI3LDI3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiSWRlbnRpZmllcnNGYWN0 b3J5LmgiCiAKKyNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZU51bWJlcnMuaD4K KwogbmFtZXNwYWNlIEluc3BlY3RvciB7CiAKIG5hbWVzcGFjZSB7Ci1zdGF0aWMgbG9uZyBzX2xh c3RVc2VkSWRlbnRpZmllciA9IDA7CitzdGF0aWMgdW5zaWduZWQgbG9uZyBzX2xhc3RVc2VkSWRl bnRpZmllciA9IDA7CiB9CiAKLXN0YXRpYyBTdHJpbmcgYWRkUHJlZml4VG9JZGVudGlmaWVyKGNv bnN0IFN0cmluZyYgaWRlbnRpZmllcikKK3N0YXRpYyBTdHJpbmcgYWRkUHJlZml4VG9JZGVudGlm aWVyKHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllcikKIHsKICAgICByZXR1cm4gbWFrZVN0cmluZygi MC4iLCBpZGVudGlmaWVyKTsKIH0KIAogU3RyaW5nIElkZW50aWZpZXJzRmFjdG9yeTo6Y3JlYXRl SWRlbnRpZmllcigpCiB7Ci0gICAgcmV0dXJuIGFkZFByZWZpeFRvSWRlbnRpZmllcihTdHJpbmc6 Om51bWJlcigrK3NfbGFzdFVzZWRJZGVudGlmaWVyKSk7CisgICAgcmV0dXJuIGFkZFByZWZpeFRv SWRlbnRpZmllcigrK3NfbGFzdFVzZWRJZGVudGlmaWVyKTsKIH0KIAogU3RyaW5nIElkZW50aWZp ZXJzRmFjdG9yeTo6cmVxdWVzdElkKHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllcikKIHsKLSAgICBp ZiAoaWRlbnRpZmllcikKLSAgICAgICAgcmV0dXJuIGFkZFByZWZpeFRvSWRlbnRpZmllcihTdHJp bmc6Om51bWJlcihpZGVudGlmaWVyKSk7Ci0gICAgcmV0dXJuIFN0cmluZygpOworICAgIHJldHVy biBpZGVudGlmaWVyID8gYWRkUHJlZml4VG9JZGVudGlmaWVyKGlkZW50aWZpZXIpIDogU3RyaW5n KCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIEluc3BlY3Rvcgo=