238813 2022-04-05 09:54:10 -0700 [GTK][WPE] Regression after r292025, in GraphicsContextGLANGLE if the dmabuf backed is not created we need to bail out 2022-07-12 12:19:49 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 242108 P2 Normal --- 1 alex alex clord cmarcelo dino ews-watchlist extinstall.mstoolsai.jupyter kbr kkinnunen kondapallykalyan luiz zan zdobersek oldest_to_newest 1858417 0 alex 2022-04-05 09:54:10 -0700 We are causing issues to the tests since r292025, there are still the situation we have with xvfb support but we will address that in a different patch. 1858426 1 456713 alex 2022-04-05 10:07:24 -0700 Created attachment 456713 Patch 1858793 2 456713 zan 2022-04-06 05:51:54 -0700 Comment on attachment 456713 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456713&action=review > Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:139 > + if (!result.iterator->value) > + return madeCurrent; > + And how are the actual contents of the WebGL-backing framebuffer composited in this case? Cause you're not rendering anything in the bo, and that's what's to be displayed. 1858809 3 alex 2022-04-06 06:44:01 -0700 (In reply to Zan Dobersek from comment #2) > Comment on attachment 456713 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456713&action=review > > > Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:139 > > + if (!result.iterator->value) > > + return madeCurrent; > > + > > And how are the actual contents of the WebGL-backing framebuffer composited > in this case? Cause you're not rendering anything in the bo, and that's > what's to be displayed. The idea here is to avoid calling GL functions using a null image to avoid errors when we do not have the backing buffer, I don't think we need to create a solution for this situation better than this. The fallback is to use the texture that is later send to the compositor copying an ImageBuffer. We could add a log here if that feels that can help to make sure people know they are in this situation, because it is true sometimes you can end up here and not know about it. Thanks for the comment! 1882454 5 alex 2022-07-12 12:19:49 -0700 That commit broke the previous implementation of the fallback mode that was the reason it failed. We have added a new implementation in the bug 242108. *** This bug has been marked as a duplicate of bug 242108 *** 456713 2022-04-05 10:07:24 -0700 2022-07-12 12:18:12 -0700 Patch bug-238813-20220405190723.patch text/plain 2138 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmUyNDVhM2YxMDY3Njhh ZmJmY2IzZGJlYjM2NzQ4ZTRlNWJlNjk3MS4uMzhkNzIzM2E0YThiM2RlNmRkOTY2Yjg2OTQ5NzQ4 MGY4OTdlZGZjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIyLTA0LTA1ICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0g UmVncmVzc2lvbiBhZnRlciByMjkyMDI1LCBpbiBHcmFwaGljc0NvbnRleHRHTEFOR0xFIGlmIHRo ZSBkbWFidWYgYmFja2VkIGlzIG5vdCBjcmVhdGVkIHdlIG5lZWQgdG8gYmFpbCBvdXQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzODgxMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gYmFp bCBvdXQgd2hlbiB0aGUgaW1hZ2UgaXMgbm90IGNyZWF0ZWQgaWYgdGhlIGRtYWJ1ZgorICAgICAg ICBzdXBwb3J0IGlzIG5vdCBhdmFpbGFibGUsIGxpa2Ugd2Ugd2VyZSBkb2luZyBiZWZvcmUuIFRo YXQgd2F5IHdlCisgICAgICAgIGZhbGxiYWNrLCB3aGljaCBpcyB3aGF0IGlzIGhhcHBlbmluZyBp biBjYXNlIG9mIHRoZSBzb2Z0d2FyZQorICAgICAgICByYXN0ZXJpemVyIHdlIHVzZSBmb3IgdGhl IHRlc3RzLiBXZSB3aWxsIGNoZWNrIHRoYXQgbGltaXRhdGlvbiBvZgorICAgICAgICB0aGUgY3Vy cmVudCB0ZXN0aW5nIGVudmlyb25tZW50IGluIGZvbGxvd2luZyBwYXRjaGVzLgorCisgICAgICAg IFdlIGFyZSBwYXNzaW5nIGFnYWluIHRoZSBmYWlsaW5nIHRlc3RzLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzQ29udGV4dEdMVGV4dHVyZU1hcHBlckFOR0xF LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dEdMQU5HTEU6Om1ha2VDb250 ZXh0Q3VycmVudCk6CisKIDIwMjItMDMtMjkgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gVXNlIEdCTUJ1ZmZlclN3YXBjaGFpbiBpbiBH cmFwaGljc0NvbnRleHRHTFRleHR1cmVNYXBwZXJBTkdMRQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzQ29udGV4dEdMVGV4dHVyZU1h cHBlckFOR0xFLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9H cmFwaGljc0NvbnRleHRHTFRleHR1cmVNYXBwZXJBTkdMRS5jcHAKaW5kZXggMzMwMTA4YzY2ZGFh N2YyMGM2YzMyM2JkNTQwYzkzN2EwYzI4YjdmNi4uYzExNjViYmU3YWE3ZDk2OGFiMWUyNmU1OTdi MjE2NTI2NGUzMDZlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL0dyYXBoaWNzQ29udGV4dEdMVGV4dHVyZU1hcHBlckFOR0xFLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NDb250ZXh0R0xU ZXh0dXJlTWFwcGVyQU5HTEUuY3BwCkBAIC0xMzQsNiArMTM0LDkgQEAgYm9vbCBHcmFwaGljc0Nv bnRleHRHTEFOR0xFOjptYWtlQ29udGV4dEN1cnJlbnQoKQogICAgICAgICAgICAgICAgIHJldHVy biBFR0xfQ3JlYXRlSW1hZ2VLSFIoY29udGV4dC5tX3N3YXBjaGFpbi5wbGF0Zm9ybURpc3BsYXks IEVHTF9OT19DT05URVhULCBFR0xfTElOVVhfRE1BX0JVRl9FWFQsIChFR0xDbGllbnRCdWZmZXIp bnVsbHB0ciwgc3RkOjpkYXRhKGF0dHJpYnV0ZXMpKTsKICAgICAgICAgICAgIH0pOwogCisgICAg ICAgIGlmICghcmVzdWx0Lml0ZXJhdG9yLT52YWx1ZSkKKyAgICAgICAgICAgIHJldHVybiBtYWRl Q3VycmVudDsKKwogICAgICAgICBHTF9CaW5kVGV4dHVyZSh0ZXh0dXJlVGFyZ2V0LCBtX3RleHR1 cmUpOwogICAgICAgICBHTF9FR0xJbWFnZVRhcmdldFRleHR1cmUyRE9FUyh0ZXh0dXJlVGFyZ2V0 LCByZXN1bHQuaXRlcmF0b3ItPnZhbHVlKTsKIAo=