238807 2022-04-05 09:06:50 -0700 [resultsdb] Change termination condition to allow hashes in test results 2022-04-15 10:23:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 angelos angelos jbedard oldest_to_newest 1858396 0 angelos 2022-04-05 09:06:50 -0700 [resultsdb] Change termination condition to allow hashes in test results 1858398 1 456706 angelos 2022-04-05 09:10:09 -0700 Created attachment 456706 Patch 1858500 2 456706 jbedard 2022-04-05 12:32:10 -0700 Comment on attachment 456706 Patch I want to deploy this to our staging instance before landing. 1858579 3 jbedard 2022-04-05 14:32:17 -0700 (In reply to Jonathan Bedard from comment #2) > Comment on attachment 456706 [details] > Patch > > I want to deploy this to our staging instance before landing. This would be why we deploy things to the staging instance: Looking at https://results.webkit.org/api/upload?suite=layout-tests&limit=1, looks like we don't always specify the "actual" result if a test passes. So our check needs to be a bit more sophisticated, I think. Probably the old check, plus an extra check that recognizes that a set of keys that can be nested? 1859616 4 angelos 2022-04-08 01:12:13 -0700 (In reply to Jonathan Bedard from comment #3) > (In reply to Jonathan Bedard from comment #2) > > Comment on attachment 456706 [details] > > Patch > > > > I want to deploy this to our staging instance before landing. > > This would be why we deploy things to the staging instance: > > Looking at https://results.webkit.org/api/upload?suite=layout-tests&limit=1, > looks like we don't always specify the "actual" result if a test passes. So > our check needs to be a bit more sophisticated, I think. Probably the old > check, plus an extra check that recognizes that a set of keys that can be > nested? Thanks for the extra testing! I've looked at the layout tests code and I think it's probably safer in the long run to keep the current termination check. I've modified https://bugs.webkit.org/show_bug.cgi?id=238806 to use two new fields in the existing test result instead of a nested dict. 456706 2022-04-05 09:10:09 -0700 2022-04-15 10:23:17 -0700 Patch bug-238807-20220405181008.patch text/plain 2748 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMzkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjYxMTY5ZjEyNTQzZTJkMjBkNDRjYWMxYWJiNTBkMDY2 YzZjOGUyNy4uY2JmOTZjZjBlOTBlZTc1Yzg3ZGFmMDQxY2U5ZmEzYWY0YTc1ZTM3YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIyLTA0LTA1ICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFtyZXN1bHRzZGJdIENoYW5nZSB0ZXJtaW5hdGlvbiBjb25kaXRpb24g dG8gYWxsb3cgaGFzaGVzIGluIHRlc3QgcmVzdWx0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4ODA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVhZCBvZiB0ZXN0aW5nIGZvciBoYXNoZXMgaW4g YW55IG9mIHRoZSB2YWx1ZXMsIGNoZWNrIGZvciB0aGUKKyAgICAgICAgcHJlc2VuY2Ugb2YgdGhl ICdhY3R1YWwnIGtleSB0byBzdG9wIHJlY3Vyc2lvbiBvdmVyIHRoZSB0ZXN0IHJlc3VsdHMuCisK KyAgICAgICAgVGhpcyBhbGxvd3MgaGF2aW5nIGEgZGljdCBpbiB0aGUgb25lIG9mIHRoZSBmaWVs ZHMgb2YgdGhlIHRlc3QgcmVzdWx0CisgICAgICAgICh0byBiZSB1c2VkIGZvciB0ZXN0LXNwZWNp ZmljIGZsYWtpbmVzcyBpbmZvcm1hdGlvbikuCisKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmll cy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC90ZXN0X2NvbnRleHQucHk6CisgICAgICAg IChFeHBlY3RhdGlvbnMuaXRlcmF0ZV90aHJvdWdoX25lc3RlZF9yZXN1bHRzLnJlY3Vyc2UpOgor CiAyMDIyLTA0LTA1ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAg ICAgICAgQU5HTEUgY2hhbmdlcy5kaWZmIGNvbnRhaW5zIGRpZmZlcmVuY2VzIHRoYXQgYXJlIGZy b20gc3RhbGUgZmlsZXMgb3IgdW5uZWVkZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGli cmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL3Rlc3RfY29udGV4dC5weSBiL1Rv b2xzL1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL3Rlc3Rf Y29udGV4dC5weQppbmRleCBjNzRlODRhNjM2YzA0ZTJlYWZhZWI1ZmFlODhhN2FhYzExMjczMGI3 Li4yZTdhOGMxMDFiMThjNDBmZDQ0NGIxNjc0ZTRmODYwZmVkOTNmMjZlIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL2xpYnJhcmllcy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC90ZXN0 X2NvbnRleHQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvcmVzdWx0c2RicHkvcmVz dWx0c2RicHkvbW9kZWwvdGVzdF9jb250ZXh0LnB5CkBAIC02OSwxNiArNjksMTUgQEAgY2xhc3Mg RXhwZWN0YXRpb25zOgogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBpdGVyYXRlX3Rocm91Z2hf bmVzdGVkX3Jlc3VsdHMoY2xzLCByZXN1bHRzLCBjYWxsYmFjaz1sYW1iZGEgdGVzdCwgcmVzdWx0 czogTm9uZSk6CiAgICAgICAgIGRlZiByZWN1cnNlKHBhcnRpYWxfdGVzdCwgcmVzdWx0cyk6Ci0g ICAgICAgICAgICBwb3RlbnRpYWxfYmFzZV9jYXNlID0gVHJ1ZQotICAgICAgICAgICAgZm9yIGtl eSwgdmFsdWUgaW4gcmVzdWx0cy5pdGVtcygpOgotICAgICAgICAgICAgICAgIGlmIGlzaW5zdGFu Y2UodmFsdWUsIGRpY3QpOgotICAgICAgICAgICAgICAgICAgICBwb3RlbnRpYWxfYmFzZV9jYXNl ID0gRmFsc2UKLSAgICAgICAgICAgICAgICAgICAgcmVjdXJzZShwYXJ0aWFsX3Rlc3QgKyAnLycg KyBrZXksIHZhbHVlKQotICAgICAgICAgICAgICAgIGVsaWYgbm90IHBvdGVudGlhbF9iYXNlX2Nh c2U6Ci0gICAgICAgICAgICAgICAgICAgIHJhaXNlIFZhbHVlRXJyb3IoJ0luY29ycmVjdGx5IGZv cm1hdHRlZCBuZXN0ZWQgcmVzdWx0cyBkaWN0aW9uYXJ5JykKLQotICAgICAgICAgICAgaWYgcG90 ZW50aWFsX2Jhc2VfY2FzZToKLSAgICAgICAgICAgICAgICAjIElmIHdlIGRvbid0IGhhdmUgYSBk aWN0aW9uYXJ5IG9mIGRpY3Rpb25hcmllcywgdGhhdCBtZWFucyB0aGlzIGlzIGEgbGVhZiBub2Rl CisgICAgICAgICAgICBpZiAnYWN0dWFsJyBub3QgaW4gcmVzdWx0czoKKyAgICAgICAgICAgICAg ICBmb3Iga2V5LCB2YWx1ZSBpbiByZXN1bHRzLml0ZW1zKCk6CisgICAgICAgICAgICAgICAgICAg ICMgSWYgdGhlcmUncyBubyAnYWN0dWFsJyBrZXksIHRoaXMgaGFzIHRvIGJlIGEgY29udGFpbmVy CisgICAgICAgICAgICAgICAgICAgICMgaXRlbSwgc28gYWxsIHZhbHVlcyBuZWVkIHRvIGJlIGRp Y3RzLgorICAgICAgICAgICAgICAgICAgICBpZiBpc2luc3RhbmNlKHZhbHVlLCBkaWN0KToKKyAg ICAgICAgICAgICAgICAgICAgICAgIHJlY3Vyc2UocGFydGlhbF90ZXN0ICsgJy8nICsga2V5LCB2 YWx1ZSkKKyAgICAgICAgICAgICAgICAgICAgZWxzZToKKyAgICAgICAgICAgICAgICAgICAgICAg IHJhaXNlIFZhbHVlRXJyb3IoJ0luY29ycmVjdGx5IGZvcm1hdHRlZCBuZXN0ZWQgcmVzdWx0cyBk aWN0aW9uYXJ5JykKKyAgICAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICAgICAgY2FsbGJhY2so cGFydGlhbF90ZXN0LCByZXN1bHRzKQogCiAgICAgICAgIGZvciBrZXksIHZhbHVlIGluIHJlc3Vs dHMuaXRlbXMoKToK