238790 2022-04-04 21:52:43 -0700 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering.html 2022-04-14 07:45:46 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jonlee cdumez cdumez clopez eric.carlson ews-watchlist glenn jer.noble philipj ryanhaddad sergio webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1858234 0 jonlee 2022-04-04 21:52:43 -0700 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering.html https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebaudio%2Fthe-audio-api%2Fthe-biquadfilternode-interface%2Fno-dezippering.html This always fails on iOS simulator arm64 bot. It's not clear whether this is a regression from GPUP work because we have no other arm64 bots. It appears skipped on Mac arm64 bots. 1858453 1 ap 2022-04-05 10:47:48 -0700 --- /Volumes/Data/worker/ios-simulator-15-release-gpuprocess-arm64-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt +++ /Volumes/Data/worker/ios-simulator-15-release-gpuprocess-arm64-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-actual.txt @@ -36,9 +36,20 @@ PASS Output from gain setter matches setValueAtTime output is true. PASS < [Test 3] All assertions passed. (total 5 assertions) PASS > [Test 4] No dezippering of frequency vs JS filter -PASS Output from lowpass filter equals [expected array] with an element-wise tolerance of {"absoluteThreshold":5.9607e-7,"relativeThreshold":0}. -PASS Output matches JS filter results is true. -PASS < [Test 4] All assertions passed. (total 2 assertions) +FAIL X Output from lowpass filter does not equal [expected array] with an element-wise tolerance of {"absoluteThreshold":5.9607e-7,"relativeThreshold":0}. + Index Actual Expected AbsError RelError Test threshold + [82] -5.640129e-1 -5.640122e-1 6.556511e-7 1.162477e-6 5.960700e-7 + [83] -4.615946e-1 -4.615939e-1 6.854534e-7 1.484971e-6 5.960700e-7 + [84] -3.461582e-1 -3.461576e-1 6.854534e-7 1.980178e-6 5.960700e-7 + [85] -2.209939e-1 -2.209932e-1 6.705523e-7 3.034267e-6 5.960700e-7 + [86] -8.966466e-2 -8.966400e-2 6.556511e-7 7.312311e-6 5.960700e-7 + ...and 1 more errors. + Max AbsError of 6.854534e-7 at index of 83. + Max RelError of 1.419336e-5 at index of 87. + [87] 4.409384e-2 4.409447e-2 6.258488e-7 1.419336e-5 5.960700e-7 + assert_true: expected true got false +FAIL X Output matches JS filter results is not true. Got false. assert_true: expected true got false +FAIL < [Test 4] 2 out of 2 assertions were failed. assert_true: expected true got false PASS > [Test 5] Test with modulation PASS Modulation: At time 0, frequency is equal to 350. PASS Modulation: At time 0.015625, frequency is equal to 10. @@ -46,5 +57,5 @@ PASS Modulation: Output from frequency setter equals [expected array] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}. PASS Modulation: Output from frequency setter matches setValueAtTime output is true. PASS < [Test 5] All assertions passed. (total 5 assertions) -PASS # AUDIT TASK RUNNER FINISHED: 6 tasks ran successfully. +FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 6 tasks were failed. assert_true: expected true got false 1858455 2 cdumez 2022-04-05 10:50:32 -0700 (In reply to Alexey Proskuryakov from comment #1) > --- > /Volumes/Data/worker/ios-simulator-15-release-gpuprocess-arm64-tests-wk2/ > build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio- > api/the-biquadfilternode-interface/no-dezippering-expected.txt > +++ > /Volumes/Data/worker/ios-simulator-15-release-gpuprocess-arm64-tests-wk2/ > build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio- > api/the-biquadfilternode-interface/no-dezippering-actual.txt > @@ -36,9 +36,20 @@ > PASS Output from gain setter matches setValueAtTime output is true. > PASS < [Test 3] All assertions passed. (total 5 assertions) > PASS > [Test 4] No dezippering of frequency vs JS filter > -PASS Output from lowpass filter equals [expected array] with an > element-wise tolerance of > {"absoluteThreshold":5.9607e-7,"relativeThreshold":0}. > -PASS Output matches JS filter results is true. > -PASS < [Test 4] All assertions passed. (total 2 assertions) > +FAIL X Output from lowpass filter does not equal [expected array] with an > element-wise tolerance of > {"absoluteThreshold":5.9607e-7,"relativeThreshold":0}. > + Index Actual Expected AbsError RelError Test threshold > + [82] -5.640129e-1 -5.640122e-1 6.556511e-7 1.162477e-6 5.960700e-7 > + [83] -4.615946e-1 -4.615939e-1 6.854534e-7 1.484971e-6 5.960700e-7 > + [84] -3.461582e-1 -3.461576e-1 6.854534e-7 1.980178e-6 5.960700e-7 > + [85] -2.209939e-1 -2.209932e-1 6.705523e-7 3.034267e-6 5.960700e-7 > + [86] -8.966466e-2 -8.966400e-2 6.556511e-7 7.312311e-6 5.960700e-7 > + ...and 1 more errors. > + Max AbsError of 6.854534e-7 at index of 83. > + Max RelError of 1.419336e-5 at index of 87. > + [87] 4.409384e-2 4.409447e-2 6.258488e-7 1.419336e-5 5.960700e-7 > + assert_true: expected true got false > +FAIL X Output matches JS filter results is not true. Got false. > assert_true: expected true got false > +FAIL < [Test 4] 2 out of 2 assertions were failed. assert_true: expected > true got false > PASS > [Test 5] Test with modulation > PASS Modulation: At time 0, frequency is equal to 350. > PASS Modulation: At time 0.015625, frequency is equal to 10. > @@ -46,5 +57,5 @@ > PASS Modulation: Output from frequency setter equals [expected array] > with an element-wise tolerance of > {"absoluteThreshold":0,"relativeThreshold":0}. > PASS Modulation: Output from frequency setter matches setValueAtTime > output is true. > PASS < [Test 5] All assertions passed. (total 5 assertions) > -PASS # AUDIT TASK RUNNER FINISHED: 6 tasks ran successfully. > +FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 6 tasks were failed. > assert_true: expected true got false The actual and expected values are very close. This just looks like a precision issue because we're dealing with floating point values and vectorization (and different CPU architectures). I believe we'll just need to update the test to use a slightly error tolerance. In the mean time, a platform-specific baseline is the right thing to do IMO. 1860556 3 webkit-bug-importer 2022-04-11 21:53:14 -0700 <rdar://problem/91607355> 1861205 4 cdumez 2022-04-13 12:08:19 -0700 Doesn't reproduce on my machine with either: Tools/Scripts/run-webkit-tests --release --no-build --ios-simulator --force imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering.html or Tools/Scripts/run-webkit-tests --release --no-build --ios-simulator --force imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering.html --use-gpu-process 1861206 5 cdumez 2022-04-13 12:10:12 -0700 (In reply to Chris Dumez from comment #4) > Doesn't reproduce on my machine with either: > Tools/Scripts/run-webkit-tests --release --no-build --ios-simulator --force > imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode- > interface/no-dezippering.html > or > Tools/Scripts/run-webkit-tests --release --no-build --ios-simulator --force > imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode- > interface/no-dezippering.html --use-gpu-process I guess because my host is Intel. This probably need arm64 to repro. 1861210 6 457555 cdumez 2022-04-13 12:17:07 -0700 Created attachment 457555 Patch 1861256 7 ews-watchlist 2022-04-13 14:28:47 -0700 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1861265 8 ews-feeder 2022-04-13 14:42:51 -0700 Committed r292832 (249605@main): <https://commits.webkit.org/249605@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457555. 1861493 9 cdumez 2022-04-14 07:45:46 -0700 The test has recovered on the bot and I have submitted the PR upstream: https://github.com/web-platform-tests/wpt/pull/33642. 457555 2022-04-13 12:17:07 -0700 2022-04-13 14:42:53 -0700 Patch bug-238790-20220413121707.patch text/plain 3845 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyODEwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpp bmRleCA3ZjQ4YjdkMmE1N2U3ZTBkZDRlN2MxYjU4Mzc0NTEwYjQ3OTVhMDQ5Li5hNDA2MGFmNDNi NTYyOGI2ZmMzYjUwNjhhZTNmOTMwNWZlNDExNzFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAyMi0wNC0xMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgorCisgICAgICAgIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2Vi YXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYmlxdWFkZmlsdGVybm9kZS1pbnRlcmZhY2Uvbm8tZGV6 aXBwZXJpbmcuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM4NzkwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85MTYwNzM1NT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYXVkaW8gdmFsdWVz IG1heSBkaWZmZXIgc2xpZ2h0bHkgZnJvbSBoYXJkd2FyZSB0byBoYXJkd2FyZSBkdWUgdG8gZmxv YXRpbmcgcG9pbnQgcHJlY2lzaW9uIGFuZCB2ZWN0b3JpemF0aW9uLgorICAgICAgICBPbiBvbmUg b2Ygb3VyIEFSTSBwbGF0Zm9ybXMsIHdlIHdlcmUgZ2V0dGluZyB2YWx1ZXMgc2xpZ2h0bHkgb3V0 c2lkZSB0aGUgYWxsb3dlZCByYW5nZSBidXQgc3RpbGwgY2xvc2UgZW5vdWdoCisgICAgICAgIHRo YXQgd2UgY29uc2lkZXIgdGhlIGJlaGF2aW9yIHRvIGJlIGNvcnJlY3QuIEFzIGEgcmVzdWx0LCBJ IGFtIGluY3JlYXNpbmcgdGhlIHRvbGVyYW5jZSBhIGJpdCBpbiB0aGUgdGVzdC4KKworICAgICAg ICBJZiB0aGlzIHJlc29sdmVzIHRoZSBpc3N1ZSBvbiBvdXIgYm90IChJIGNhbm5vdCByZXByb2R1 Y2UgbG9jYWxseSksIEknbGwgc3VibWl0IGEgUFIgdXBzdHJlYW0uCisKKyAgICAgICAgKiB3ZWIt cGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYmlxdWFkZmlsdGVybm9k ZS1pbnRlcmZhY2Uvbm8tZGV6aXBwZXJpbmctZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHdlYi1w bGF0Zm9ybS10ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1iaXF1YWRmaWx0ZXJub2Rl LWludGVyZmFjZS9uby1kZXppcHBlcmluZy5odG1sOgorCiAyMDIyLTA0LTEzICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBDb21wbGVtZW50IGltcGxlbWVudGF0 aW9uIG9mIHN0ZXAgNS41IG9mIGh0dHBzOi8vZmV0Y2guc3BlYy53aGF0d2cub3JnLyNodHRwLWZl dGNoCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL3dlYmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLWJpcXVhZGZpbHRlcm5vZGUtaW50ZXJmYWNl L25vLWRlemlwcGVyaW5nLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYmlxdWFkZmlsdGVy bm9kZS1pbnRlcmZhY2Uvbm8tZGV6aXBwZXJpbmctZXhwZWN0ZWQudHh0CmluZGV4IGQ4MTkzY2Qw ZmNkMmM0ODhiMzcyZTFhYWZmNDBjZWJiMjI0MjIzNGUuLmNhYWY4YjU3MTAxZjI1OTAyYzBmODEx MjYwYzhmM2UxYTIxNWQyNmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYmlxdWFkZmlsdGVy bm9kZS1pbnRlcmZhY2Uvbm8tZGV6aXBwZXJpbmctZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1ZGlvLWFw aS90aGUtYmlxdWFkZmlsdGVybm9kZS1pbnRlcmZhY2Uvbm8tZGV6aXBwZXJpbmctZXhwZWN0ZWQu dHh0CkBAIC0zNiw3ICszNiw3IEBAIFBBU1MgICBPdXRwdXQgZnJvbSBnYWluIHNldHRlciBlcXVh bHMgW2V4cGVjdGVkIGFycmF5XSB3aXRoIGFuIGVsZW1lbnQtd2lzZSB0b2xlCiBQQVNTICAgT3V0 cHV0IGZyb20gZ2FpbiBzZXR0ZXIgbWF0Y2hlcyBzZXRWYWx1ZUF0VGltZSBvdXRwdXQgaXMgdHJ1 ZS4KIFBBU1MgPCBbVGVzdCAzXSBBbGwgYXNzZXJ0aW9ucyBwYXNzZWQuICh0b3RhbCA1IGFzc2Vy dGlvbnMpCiBQQVNTID4gW1Rlc3QgNF0gTm8gZGV6aXBwZXJpbmcgb2YgZnJlcXVlbmN5IHZzIEpT IGZpbHRlcgotUEFTUyAgIE91dHB1dCBmcm9tIGxvd3Bhc3MgZmlsdGVyIGVxdWFscyBbZXhwZWN0 ZWQgYXJyYXldIHdpdGggYW4gZWxlbWVudC13aXNlIHRvbGVyYW5jZSBvZiB7ImFic29sdXRlVGhy ZXNob2xkIjo1Ljk2MDdlLTcsInJlbGF0aXZlVGhyZXNob2xkIjowfS4KK1BBU1MgICBPdXRwdXQg ZnJvbSBsb3dwYXNzIGZpbHRlciBlcXVhbHMgW2V4cGVjdGVkIGFycmF5XSB3aXRoIGFuIGVsZW1l bnQtd2lzZSB0b2xlcmFuY2Ugb2YgeyJhYnNvbHV0ZVRocmVzaG9sZCI6Ni44NTQ2ZS03LCJyZWxh dGl2ZVRocmVzaG9sZCI6MH0uCiBQQVNTICAgT3V0cHV0IG1hdGNoZXMgSlMgZmlsdGVyIHJlc3Vs dHMgaXMgdHJ1ZS4KIFBBU1MgPCBbVGVzdCA0XSBBbGwgYXNzZXJ0aW9ucyBwYXNzZWQuICh0b3Rh bCAyIGFzc2VydGlvbnMpCiBQQVNTID4gW1Rlc3QgNV0gVGVzdCB3aXRoIG1vZHVsYXRpb24KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2Vi YXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYmlxdWFkZmlsdGVybm9kZS1pbnRlcmZhY2Uvbm8tZGV6 aXBwZXJpbmcuaHRtbCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvd2ViYXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYmlxdWFkZmlsdGVybm9kZS1pbnRlcmZhY2Uv bm8tZGV6aXBwZXJpbmcuaHRtbAppbmRleCA2M2Q0YmUzYmI0MjEwMTI1M2FlZjIxNzFhZTcwZjk3 N2YwYTdmYjBkLi43OWRjMjcwMzVjN2RiZDgxNzZmOTgwMjc4YmRkZGFiNTVhNzZjNzMxIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1 ZGlvL3RoZS1hdWRpby1hcGkvdGhlLWJpcXVhZGZpbHRlcm5vZGUtaW50ZXJmYWNlL25vLWRlemlw cGVyaW5nLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1iaXF1YWRmaWx0ZXJub2RlLWludGVyZmFj ZS9uby1kZXppcHBlcmluZy5odG1sCkBAIC0xNTUsNyArMTU1LDcgQEAKICAgICAgICAgICAgICAg ICAgIGxldCBtYXRjaCA9CiAgICAgICAgICAgICAgICAgICAgICAgc2hvdWxkKGFjdHVhbCwgJ091 dHB1dCBmcm9tICcgKyBmLnR5cGUgKyAnIGZpbHRlcicpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgIC5iZUNsb3NlVG9BcnJheSgKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGV4cGVj dGVkLCB7YWJzb2x1dGVUaHJlc2hvbGQ6IDUuOTYwN2UtN30pOworICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZXhwZWN0ZWQsIHthYnNvbHV0ZVRocmVzaG9sZDogNi44NTQ2ZS03fSk7CiAg ICAgICAgICAgICAgICAgICBzaG91bGQobWF0Y2gsICdPdXRwdXQgbWF0Y2hlcyBKUyBmaWx0ZXIg cmVzdWx0cycpLmJlVHJ1ZSgpOwogICAgICAgICAgICAgICAgIH0pCiAgICAgICAgICAgICAgICAg LnRoZW4oKCkgPT4gdGFzay5kb25lKCkpOwo=