<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>23879</bug_id>
          
          <creation_ts>2009-02-10 14:47:09 -0800</creation_ts>
          <short_desc>Add missing PLATFORM(SKIA) changes to TransformationMatrix.h</short_desc>
          <delta_ts>2009-02-10 16:17:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Darin Fisher (:fishd, Google)">fishd</reporter>
          <assigned_to name="Darin Fisher (:fishd, Google)">fishd</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>109197</commentid>
    <comment_count>0</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2009-02-10 14:47:09 -0800</bug_when>
    <thetext>Add missing PLATFORM(SKIA) changes to TransformationMatrix.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>109198</commentid>
    <comment_count>1</comment_count>
      <attachid>27543</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2009-02-10 14:48:13 -0800</bug_when>
    <thetext>Created attachment 27543
v1 patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>109201</commentid>
    <comment_count>2</comment_count>
      <attachid>27543</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-02-10 14:58:05 -0800</bug_when>
    <thetext>Comment on attachment 27543
v1 patch

LGTM, assume we&apos;re not planning to have skia/ or something in the Skia header path.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>109212</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2009-02-10 16:16:41 -0800</bug_when>
    <thetext>That&apos;s right.  The skia headers expect for skia/include/corecg to be on the include path, so it doesn&apos;t serve us to put a path prefix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>109213</commentid>
    <comment_count>4</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2009-02-10 16:17:46 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/40838</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>27543</attachid>
            <date>2009-02-10 14:48:13 -0800</date>
            <delta_ts>2009-02-10 14:58:05 -0800</delta_ts>
            <desc>v1 patch</desc>
            <filename>skia_1.txt</filename>
            <type>text/plain</type>
            <size>1161</size>
            <attacher name="Darin Fisher (:fishd, Google)">fishd</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQwODM0
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDIt
MTAgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MjM4NzkKKyAgICAgICAgQWRkIG1pc3NpbmcgUExBVEZPUk0oU0tJQSkg
Y2hhbmdlcyB0byBUcmFuc2Zvcm1hdGlvbk1hdHJpeC5oCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n
cmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4Lmg6CisKIDIwMDktMDItMTAg
IERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp
ZXdlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBwbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1Ry
YW5zZm9ybWF0aW9uTWF0cml4LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0vZ3JhcGhpY3MvdHJh
bnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5oCShyZXZpc2lvbiA0MDgzNCkKKysrIHBsYXRm
b3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguaAkod29ya2luZyBj
b3B5KQpAQCAtMzIsNiArMzIsOCBAQAogI2luY2x1ZGUgPGNhaXJvLmg+CiAjZWxpZiBQTEFURk9S
TShRVCkKICNpbmNsdWRlIDxRTWF0cml4PgorI2VsaWYgUExBVEZPUk0oU0tJQSkKKyNpbmNsdWRl
IDxTa01hdHJpeC5oPgogI2VuZGlmCiAKICNpbmNsdWRlIDxzdHJpbmcuaD4gLy9mb3IgbWVtY3B5
CkBAIC0yODEsNiArMjgzLDggQEAgcHVibGljOgogICAgIG9wZXJhdG9yIGNhaXJvX21hdHJpeF90
KCkgY29uc3Q7CiAjZWxpZiBQTEFURk9STShRVCkKICAgICBvcGVyYXRvciBRTWF0cml4KCkgY29u
c3Q7CisjZWxpZiBQTEFURk9STShTS0lBKQorICAgIG9wZXJhdG9yIFNrTWF0cml4KCkgY29uc3Q7
CiAjZW5kaWYKIAogcHJpdmF0ZToK
</data>
<flag name="review"
          id="13338"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>